GNU bug report logs - #71353
[PATCH] eglot--format-markup doesn't support MarkedString code-blocks

Previous Next

Full log

Message #11 received at 71353 <at> debbugs.gnu.org (full text, mbox):

From: Troy Brown <brownts <at> troybrown.dev>
To: Felician Nemeth <felician.nemeth <at> gmail.com>
Cc: 71353 <at> debbugs.gnu.org
Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support
 MarkedString code-blocks
Date: Tue, 4 Jun 2024 06:01:05 -0400

On Tue, Jun 4, 2024 at 1:42 AM Felician Nemeth
<felician.nemeth <at> gmail.com> wrote:
>
> According to the LSP specification, if MarkedString is "{ language:
> string; value: string }", then it should be interpreted as this markdown
> formatted string:
>
> ```${language}
> ${value}
> ```
>
> The patch does not implement this behavior.  And as a sidenote,
> MarkedString is deprecated.
>
> https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_hover
>

Unless I'm mistaken, I believe it does implement that behavior if the
language is markdown, plaintext or the same as the major mode.  This
seemed to be the intent of the existing implementation which doesn't
support any other options (and falls back to the major mode) and the
reason why I didn't expand on it with this patch.  I agree that the
patch does not support anything outside that behavior.  Additionally,
I don't think that because MarkedString is deprecated is a reason to
implement partial support for it (MarkedString for string literals)
when there are obviously existing LSP servers that utilize it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.