From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 22:51:42 2024 Received: (at submit) by debbugs.gnu.org; 4 Jun 2024 02:51:43 +0000 Received: from localhost ([127.0.0.1]:56091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEKH0-0007dX-Bq for submit@debbugs.gnu.org; Mon, 03 Jun 2024 22:51:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:39728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEKGv-0007dL-VQ for submit@debbugs.gnu.org; Mon, 03 Jun 2024 22:51:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEKGi-000351-Fc for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 22:51:24 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEKGg-00075c-6D for bug-gnu-emacs@gnu.org; Mon, 03 Jun 2024 22:51:23 -0400 Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2e72b8931caso55400551fa.0 for ; Mon, 03 Jun 2024 19:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717469480; x=1718074280; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=H1AGeND7AcOMvhQzn6RnxAWMClYm+GWkkjyBKURcw+M=; b=xFm1ZGSCm7+2EsktHAuo4p6coUv8+w66hAIXr3bACFWjHv8dmJ7D6W80H5SLcMQX7u zbOTIlj6ZiBUvUwHbZT09PZ4qF8Fdd7Q8h/4aG+aJxlUq0UkSzY1YW6ZYyvuS7YPrk6M r0zn/u/P3SP8emt2npGkFX9QcqHInA8UVadngZf2sgTS2cO3TT7IV1kwYyNbBL2rqRlU 2ODC/iDbSBCB2YXFbb9En0+H7/UlKpngel2qnNI3mKrdnPNlL2sUrbINaeemAwLgCNO8 SfCgomZmU43wiV79LlTb6vDfUyXcFVxTvSppnMBPrH7jYLvPfXmq0CcrY9jCBp2aDZbx a93g== X-Gm-Message-State: AOJu0YxNeGMMOoJpNJXasxnQX4MVzKAQQ6qJFhApfdBGBGIwixc+vmhO RAVbm8h697//wkf4Ei52B28I7OPh1cMEnN+qDxtgen9rkAe/mwukmiNbIWhz X-Google-Smtp-Source: AGHT+IEArJyCob7RAZ+6IRkXpRRGwbrtxlV5UQaX8PsbbZYGdJ0+TC8uCgcNGLhRVrprwAjDwji7Lw== X-Received: by 2002:a05:651c:1991:b0:2d8:930c:bbfa with SMTP id 38308e7fff4ca-2ea950c5fafmr83065631fa.5.1717469479591; Mon, 03 Jun 2024 19:51:19 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ea91cf1100sm13687971fa.125.2024.06.03.19.51.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 19:51:19 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-52b82d57963so5146790e87.2 for ; Mon, 03 Jun 2024 19:51:19 -0700 (PDT) X-Received: by 2002:a19:6455:0:b0:51f:1bf8:610c with SMTP id 2adb3069b0e04-52b8957ee09mr6557892e87.11.1717469478919; Mon, 03 Jun 2024 19:51:18 -0700 (PDT) MIME-Version: 1.0 From: Troy Brown Date: Mon, 3 Jun 2024 22:51:07 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000034e110061a078649" Received-SPF: pass client-ip=209.85.208.178; envelope-from=troy.s.brown@gmail.com; helo=mail-lj1-f178.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --00000000000034e110061a078649 Content-Type: text/plain; charset="UTF-8" It appears that eglot--format-markup only supports MarkedString for string literals and MarkupContent. This causes markup provided by the server as a MarkedString code-block to be formatted using the major mode. This happens because the MarkedString code-block uses the "language" field to designate the type of markup. eglot--format-markup is only looking for the "kind" field found in MarkupContent. The following is an example of a hover response from an LSP server using a MarkedString code-block to provide a description in "plaintext". [jsonrpc] e[13:34:28.888] --> textDocument/hover[25] {"jsonrpc":"2.0","id":25,"method":"textDocument/hover","params":{"textDocument":{"uri":"file:///home/troy/repos/crates/gtkada_24.0.0_80c56171/src/gtkada.gpr"},"position":{"line":70,"character":12}}} [jsonrpc] e[13:34:29.033] <-- textDocument/hover[25] {"jsonrpc":"2.0","id":25,"result":{"contents":[{"language":"plaintext","value":"This package specifies the compilation options used when building an executable or a library for a project. Most of the options should be set in one of Compiler, Binder or Linker packages, but there are some general options that should be defined in this package."}]}} The following patch will format MarkedString code-blocks for markdown and plaintext while using the major mode to format any other language. --00000000000034e110061a078649 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Disposition: attachment; filename="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwzsopai0 RnJvbSA0YTk0MTI0Nzg4MTljNmNiNDQ0NmQyMTY5OTAxY2RiOTE1MmEyMDNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEJyb3duIDxicm93bnRzQHRyb3licm93bi5kZXY+CkRh dGU6IE1vbiwgMyBKdW4gMjAyNCAyMjoxOToyNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEVnbG90 OiBTdXBwb3J0IGZvcm1hdHRpbmcgTWFya2VkU3RyaW5nIGNvZGUtYmxvY2sKCiogbGlzcC9wcm9n bW9kZXMvZWdsb3QuZWwgKGVnbG90LS1mb3JtYXQtbWFya3VwKTogQWRkIHN1cHBvcnQKZm9yIE1h cmtlZFN0cmluZyBjb2RlLWJsb2NrLgoKQ29weXJpZ2h0LXBhcGVyd29yay1leGVtcHQ6IHllcwot LS0KIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9l Z2xvdC5lbCBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCmluZGV4IDVjY2FlNTIxMGZlLi4zYTQ0 YWNkYjc1YiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvZWdsb3QuZWwKQEAgLTE4NjIsNyArMTg2Miw4IEBAIGVnbG90LS1mb3JtYXQtbWFy a3VwCiAgIChwY2FzZS1sZXQgKChgKCxzdHJpbmcgLG1vZGUpCiAgICAgICAgICAgICAgICAoaWYg KHN0cmluZ3AgbWFya3VwKSAobGlzdCBtYXJrdXAgJ2dmbS12aWV3LW1vZGUpCiAgICAgICAgICAg ICAgICAgIChsaXN0IChwbGlzdC1nZXQgbWFya3VwIDp2YWx1ZSkKLSAgICAgICAgICAgICAgICAg ICAgICAgKHBjYXNlIChwbGlzdC1nZXQgbWFya3VwIDpraW5kKQorICAgICAgICAgICAgICAgICAg ICAgICAocGNhc2UgKG9yIChwbGlzdC1nZXQgbWFya3VwIDpraW5kKQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChwbGlzdC1nZXQgbWFya3VwIDpsYW5ndWFnZSkpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgKCJtYXJrZG93biIgJ2dmbS12aWV3LW1vZGUpCiAgICAgICAgICAg ICAgICAgICAgICAgICAgKCJwbGFpbnRleHQiICd0ZXh0LW1vZGUpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgKF8gbWFqb3ItbW9kZSkpKSkpKQotLSAKMi4zNy4xCgo= --00000000000034e110061a078649-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 01:43:24 2024 Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 05:43:24 +0000 Received: from localhost ([127.0.0.1]:56163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEMx9-0003m0-PT for submit@debbugs.gnu.org; Tue, 04 Jun 2024 01:43:24 -0400 Received: from mail-ej1-f46.google.com ([209.85.218.46]:49448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEMx4-0003lk-6V for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 01:43:21 -0400 Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a62ef52e837so62815266b.3 for <71353@debbugs.gnu.org>; Mon, 03 Jun 2024 22:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717479719; x=1718084519; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aVNaWjMPsAFyPZ3ibNLxP/bKB344JqzkYE6KiTuzwRI=; b=EoIbKohW/hqH55DE7GsKtmLH4We6QSXOF2/td0S5GUqyUzNuJi7eyBq7p72ScbIFhY jxzClVtrSCxpkN0VYyuomjfLvTDakyaPm9NHiNc6S0QufKEMnMtOmiS4+ZFLzQkSm1rb eE3FDzv7t+L8MpuYU1ado8/XcDqIXjOoV95AJwAW0p5nRZMeT/N1QxDf9IX/7bPkxoPe dqOi31SWffOUPYlitzAmE1jZs4iZqIcZhYpGVLsFIQpG2mWwPnP1Of/mut8fUZHm3hyo 7g52FPr8bYcn4fDbswsVE1yxJ8pBdAEkpNvAiB2hOKuvc8xb70lk+JvF3+NB/QWgG0YA OJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717479719; x=1718084519; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aVNaWjMPsAFyPZ3ibNLxP/bKB344JqzkYE6KiTuzwRI=; b=pHvfhBR/DotTIPDcOC05pS8zkmfCdYeFzT88HpXQnPqAJP/U37OgauAFu0a3yjJmBv 64eKx1BiC4XU0nI3gA5kbRbWS/iid4qAfCX6QVyjvBxre7cjOl14Fd2dMdDGj8OqBBSt oIG7LYMohRKFZfNPYr9uw3VE/a03C/lhB6umXj0BjLBN5qar+iUQ7BpN9lmuVnaTyQn7 7TH/bSKZgeeAGRepmeMVqfH9nYhEx+ifhmgFyta70rSYQuAjOE3TQIcAuOKg4w5UY5jS TFibfOVypnSYfIeAAUTDS2qlG6ZbyhwWxq3XB844z9Uwa0qjhZLRf+xn/adYc42zP1Pf wanw== X-Gm-Message-State: AOJu0YxELNCK2/WYP/cfgQqOn0WL0c8LK9jYORqBvQJSkcc0itkmMYeG uwuvwZ7wOBqawNcF9s0sXfzvKIK4SDBRZp18/o4HiLRBUsE+wVNH+uR6rQ== X-Google-Smtp-Source: AGHT+IFp1io8DfDfK8zxng3bCpkGL0z70d/TgBPBd0KUOIG4I5yC6Ks66DTYWHatgXnA0BsgQ8vVrA== X-Received: by 2002:a17:906:e091:b0:a5a:81b1:6cab with SMTP id a640c23a62f3a-a6821f4dfa3mr625383366b.51.1717479718614; Mon, 03 Jun 2024 22:41:58 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a683209927csm551326566b.23.2024.06.03.22.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 22:41:58 -0700 (PDT) From: Felician Nemeth To: Troy Brown Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: Date: Tue, 04 Jun 2024 07:41:57 +0200 In-Reply-To: (Troy Brown's message of "Mon, 3 Jun 2024 22:51:07 -0400") Message-ID: <87ed9dl0wq.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Troy Brown writes: > The following patch will format MarkedString code-blocks for markdown > and plaintext while using the major mode to format any other language. According to the LSP specification, if MarkedString is "{ language: string; value: string }", then it should be interpreted as this markdown formatted string: ```${language} ${value} ``` The patch does not implement this behavior. And as a sidenote, MarkedString is deprecated. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_hover From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 06:01:41 2024 Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 10:01:41 +0000 Received: from localhost ([127.0.0.1]:34791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEQz6-0006XV-R0 for submit@debbugs.gnu.org; Tue, 04 Jun 2024 06:01:41 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:47541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEQz4-0006X3-I0 for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 06:01:39 -0400 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a68c5524086so78357866b.3 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 03:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717495278; x=1718100078; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FH8ldtAceVgHKmrWBeE0Gf0ObAF8mCjpt8Ts1fvMJLo=; b=mtG4l5aJgRdj9WQgVg0UgMLvD61Whw64GVX2aHrs4D4BTIZ/LGSVui3NauXLY35no3 bZqh8x/Zmwg+TESSyO9KpMew4/hnWuwjzCnDUzL+cMVosrOQFDhPLJy2A7c0V9OCstwh 6yLszZPcEt/JKtxAu751piloPJ6W4B+F4eBBMW+padX5bu4TayKF18HVWY8nbVBZKwsF 7HZ9AQTRPgoXxe2FiT7FWdPRvCM3E8T2F0SciWdpYtOCgHnPrTduQqrcNhElGbIgdfky XJ8Zv59meXSCqSyM48rkzzf1mEqL0HwXTygdivZ2MWXSlWHZQjApl0O5vTv03T5NhFcs XTHQ== X-Gm-Message-State: AOJu0YyxSCNzKpZ/KEu9VTQvHcL6ifkFgp7GusTqIRismvT3git+spWg GksObGagqzlewedbY5a7Vvg5+cy6p2XhXln0OJh67Jp4t/fYADGQu74LLWqWTpvqYA== X-Google-Smtp-Source: AGHT+IGJgkxcBazRdD3cL4wdfCMTUBFI+s/VnVLuyQckCoj2jh1Tbaui7XjnHCmo6SouAIscwy5VBQ== X-Received: by 2002:a17:906:fd55:b0:a68:5f08:2e2a with SMTP id a640c23a62f3a-a685f082eefmr560607366b.28.1717495278008; Tue, 04 Jun 2024 03:01:18 -0700 (PDT) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com. [209.85.218.42]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a49deff15sm5674408a12.94.2024.06.04.03.01.17 for <71353@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 03:01:17 -0700 (PDT) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a68b41ef3f6so86087066b.1 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 03:01:17 -0700 (PDT) X-Received: by 2002:a17:907:b010:b0:a5c:fc25:2730 with SMTP id a640c23a62f3a-a681fc5bab6mr549786366b.4.1717495277615; Tue, 04 Jun 2024 03:01:17 -0700 (PDT) MIME-Version: 1.0 References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> In-Reply-To: <87ed9dl0wq.fsf@betli.tmit.bme.hu> From: Troy Brown Date: Tue, 4 Jun 2024 06:01:05 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, Jun 4, 2024 at 1:42=E2=80=AFAM Felician Nemeth wrote: > > According to the LSP specification, if MarkedString is "{ language: > string; value: string }", then it should be interpreted as this markdown > formatted string: > > ```${language} > ${value} > ``` > > The patch does not implement this behavior. And as a sidenote, > MarkedString is deprecated. > > https://microsoft.github.io/language-server-protocol/specifications/lsp/3= .17/specification/#textDocument_hover > Unless I'm mistaken, I believe it does implement that behavior if the language is markdown, plaintext or the same as the major mode. This seemed to be the intent of the existing implementation which doesn't support any other options (and falls back to the major mode) and the reason why I didn't expand on it with this patch. I agree that the patch does not support anything outside that behavior. Additionally, I don't think that because MarkedString is deprecated is a reason to implement partial support for it (MarkedString for string literals) when there are obviously existing LSP servers that utilize it. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 07:23:19 2024 Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 11:23:19 +0000 Received: from localhost ([127.0.0.1]:40754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sESG6-0001rY-No for submit@debbugs.gnu.org; Tue, 04 Jun 2024 07:23:19 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:52619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sESG4-0001qy-6v for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 07:23:17 -0400 Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57a033c2ed4so3141259a12.1 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 04:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717500116; x=1718104916; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=xwd22YgXgT/h5pwo68EJnzdAqmhIP4FWg69hfmyD/E8=; b=alv9tgBjLhzjUPt8536tL337MFzYjDLEnlkiztTgAtJq+SpgwIgpjSU8fPe9kkeNOm HZvOSQDTB5IhVBgxKK+i+YFAxcV6iuXNJnL+ybGtEE19dXJtslUo4O2tJ9Devk3EJh1q sLWx4xchvMcrg7UlmaQE42TU9uO9PHg83jVufNaehmbJru5oJTIe6TfgbItUppD4wUuu 2y/Q9yXp20ff6rRMyoHkarF0Mjf2bDzvU6Tk0cxpo7VgrFOqlCBcceiOGwoB9fgUc5ui /6/8EOO1INfiHVlC1OhA66npj8BR/gpEJKVlyEqX7APNe5DuYHCi/sTjxOtgFhAXjUQm 86nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717500116; x=1718104916; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xwd22YgXgT/h5pwo68EJnzdAqmhIP4FWg69hfmyD/E8=; b=vs6vC6WelFwzmcVAD1tMgG8Fxp2UHbOnv3FkqS605Ur2dmwN7FV7GDcXCMjZ9gDGDN MXJ9vfEQhA2nDib48ZF8OQCP/g+QEWsakLdq0/0U8skSVBDxRHymhqHV+PJBKQsaTKpu rcVF29f6OKt934sshwuSzOWdRDAwxt9peoLGLNO/Q3qwo0IKCoHXxifCm9ePB5lsXS4y mEYX+guAbO7OXu/QvPtxYZZtlwBB3vmdHlSmbCbU/gATFPZdkQfK57KTH+Elu0qhtjfm TE9tN3TbLo5j8c70KGMfmEUPSjVQClnc+fETM7aanrmkMwB5Ri+k4U3KiHhIjJf4Ckm7 3sLA== X-Gm-Message-State: AOJu0YxGkm0OBRaU+XgQuedumL+cprAdQV2a1rmnCxovf+XiF7zQW1NR fUUyDJj+Zl1EmEiBM056+8HGGyNsCSVGZge12PDg6CW3PcJXSSNNiG/65A== X-Google-Smtp-Source: AGHT+IGrMSu4p8ZisBLTXsDrbPmcELSa9YCIH3TpaXrxdLylp22T6EfDRXj/X2B9i1HtRiLM2tr4mA== X-Received: by 2002:a50:f61c:0:b0:578:5f34:b08f with SMTP id 4fb4d7f45d1cf-57a363aabdfmr10383947a12.25.1717500116104; Tue, 04 Jun 2024 04:21:56 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a8134e238sm1118292a12.95.2024.06.04.04.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 04:21:55 -0700 (PDT) From: Felician Nemeth To: Troy Brown Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> Date: Tue, 04 Jun 2024 13:21:55 +0200 In-Reply-To: (Troy Brown's message of "Tue, 4 Jun 2024 06:01:05 -0400") Message-ID: <87zfs1j6lo.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Troy Brown writes: > On Tue, Jun 4, 2024 at 1:42=E2=80=AFAM Felician Nemeth > wrote: >> >> According to the LSP specification, if MarkedString is "{ language: >> string; value: string }", then it should be interpreted as this markdown >> formatted string: >> >> ```${language} >> ${value} >> ``` > Unless I'm mistaken, I believe it does implement that behavior if the > language is markdown, plaintext or the same as the major mode.=20=20 I don't think "markdown" is a valid markdown language. For example, if a MarkedString is { "language": "c", "value": "printf(42);"} then the LSP client should interpret it as this markdown-formatted text: ```c printf(42); ``` Whereas I think you argue that this MarkedString: { "language": "markdown", "value": "```c\nprintf(42);\n```"} should be interpreted as this markdown-formatted text: ```c printf(42); ``` I beleive the second example is not in line with the LSP specification. The patch, however, will format "printf(42);" according to the major-mode of the current buffer, which is probably c-mode or something similar. So this part will usually work. In any case, why not just turn a MarkedString into a markdown-formatted text and give it gfm-view-mode? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 08:40:22 2024 Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 12:40:22 +0000 Received: from localhost ([127.0.0.1]:46461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sETSf-0008DT-Pp for submit@debbugs.gnu.org; Tue, 04 Jun 2024 08:40:22 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:48558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sETQu-00088P-2o for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 08:38:33 -0400 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a6266ffdba8so107152666b.1 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 05:38:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717504692; x=1718109492; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VWtN4Wjz2peMQH9lDj41NNSa5v4foNBXigEOFwSRy04=; b=QOgEhkD3A3GW8Hgs2UKMH/dngPvhLU+kZ1BN64XJIcZN5+L2Y0oJzchgDSrjL315HY ln+gjNPCZrDQoSQ4Iw5bB1cMZhytib7+kLyPcWAAA3t3vcxN16YlQB7GMCe8RqhttLqQ wG+onfLttFzgzprrVp4vEXHbiShyH+9hlW7IQOxJKqw0+vNyvREiH4oHJTKpLWFjYjep 7JIZb61AuL6P6patR/B0DStro0HNtadJRWUb5k4WEczxm1meqsd4H912AvIfSLwys065 TWkIWwVhzc/FbuIslyyOAchGCl2ww8VIN3uogVx6THS3hqqxi6OlJra5mGBcvJuUwPs7 qTlg== X-Gm-Message-State: AOJu0Yyfe6G6xpF5GkxmSpNpb0ww3aCIDKoT8pSVupZAllfdLrIGmYef 85SPN+W1BWhmqw0NU4Qnz87YrN0IIpVUGNRSgT86+VDLDLB1oIrivmILFg5vPfw= X-Google-Smtp-Source: AGHT+IGBRv9t33a7PuemiU4ZoTrgF1TOZMq9OtC67lpmcbFJEftoJagrgTgWERL6jEm4Hk8hWeDPyg== X-Received: by 2002:a17:907:971f:b0:a68:362a:bfdb with SMTP id a640c23a62f3a-a68362acb0bmr943348266b.9.1717504691956; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68ff7836f0sm338080866b.33.2024.06.04.05.38.11 for <71353@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 05:38:11 -0700 (PDT) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-57a31d63b6bso1296435a12.0 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) X-Received: by 2002:a17:906:fb06:b0:a68:c2f4:eac with SMTP id a640c23a62f3a-a68c30351f7mr530134966b.59.1717504691394; Tue, 04 Jun 2024 05:38:11 -0700 (PDT) MIME-Version: 1.0 References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> In-Reply-To: <87zfs1j6lo.fsf@betli.tmit.bme.hu> From: Troy Brown Date: Tue, 4 Jun 2024 08:37:59 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: Felician Nemeth Content-Type: multipart/mixed; boundary="0000000000000806e1061a0fb909" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000000806e1061a0fb909 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 4, 2024 at 7:22=E2=80=AFAM Felician Nemeth wrote: > > In any case, why not just turn a MarkedString into a markdown-formatted > text and give it gfm-view-mode? Thanks for the detailed explanation. I've created a new patch which creates a fenced code block and uses gfm-view-mode, as you suggest. --0000000000000806e1061a0fb909 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Disposition: attachment; filename="0001-Eglot-Support-formatting-MarkedString-code-block.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lx0dtcwf0 RnJvbSBlOWM2Mzg3ZWIxMjNhYWMxZmU0NzQxYTg3MWJlMmI2ODEyOGRlNDFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUcm95IEJyb3duIDxicm93bnRzQHRyb3licm93bi5kZXY+CkRh dGU6IFR1ZSwgNCBKdW4gMjAyNCAwODozMDo1MyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEVnbG90 OiBTdXBwb3J0IGZvcm1hdHRpbmcgTWFya2VkU3RyaW5nIGNvZGUtYmxvY2sKCiogbGlzcC9wcm9n bW9kZXMvZWdsb3QuZWwgKGVnbG90LS1mb3JtYXQtbWFya3VwKTogQWRkIHN1cHBvcnQKZm9yIE1h cmtlZFN0cmluZyBjb2RlLWJsb2NrLgoKQ29weXJpZ2h0LXBhcGVyd29yay1leGVtcHQ6IHllcwot LS0KIGxpc3AvcHJvZ21vZGVzL2VnbG90LmVsIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmlsZSBj aGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9wcm9nbW9kZXMvZWdsb3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAppbmRleCA1Y2Nh ZTUyMTBmZS4uNzAyMjRkMGRjZDYgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVs CisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0xODYxLDExICsxODYxLDE1IEBAIGVn bG90LS1mb3JtYXQtbWFya3VwCiAgICJGb3JtYXQgTUFSS1VQIGFjY29yZGluZyB0byBMU1AncyBz cGVjLiIKICAgKHBjYXNlLWxldCAoKGAoLHN0cmluZyAsbW9kZSkKICAgICAgICAgICAgICAgIChp ZiAoc3RyaW5ncCBtYXJrdXApIChsaXN0IG1hcmt1cCAnZ2ZtLXZpZXctbW9kZSkKLSAgICAgICAg ICAgICAgICAgKGxpc3QgKHBsaXN0LWdldCBtYXJrdXAgOnZhbHVlKQotICAgICAgICAgICAgICAg ICAgICAgICAocGNhc2UgKHBsaXN0LWdldCBtYXJrdXAgOmtpbmQpCi0gICAgICAgICAgICAgICAg ICAgICAgICAgKCJtYXJrZG93biIgJ2dmbS12aWV3LW1vZGUpCi0gICAgICAgICAgICAgICAgICAg ICAgICAgKCJwbGFpbnRleHQiICd0ZXh0LW1vZGUpCi0gICAgICAgICAgICAgICAgICAgICAgICAg KF8gbWFqb3ItbW9kZSkpKSkpKQorICAgICAgICAgICAgICAgICAoaWYtbGV0ICgobGFuZ3VhZ2Ug KHBsaXN0LWdldCBtYXJrdXAgOmxhbmd1YWdlKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAg KHZhbHVlIChwbGlzdC1nZXQgbWFya3VwIDp2YWx1ZSkpKQorICAgICAgICAgICAgICAgICAgICAg KGxpc3QgKGNvbmNhdCAiYGBgIiBsYW5ndWFnZSAiXG4iIHZhbHVlICJcbmBgYCIpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAnZ2ZtLXZpZXctbW9kZSkKKyAgICAgICAgICAgICAgICAgICAo bGlzdCAocGxpc3QtZ2V0IG1hcmt1cCA6dmFsdWUpCisgICAgICAgICAgICAgICAgICAgICAgICAg KHBjYXNlIChwbGlzdC1nZXQgbWFya3VwIDpraW5kKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgKCJtYXJrZG93biIgJ2dmbS12aWV3LW1vZGUpCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAoInBsYWludGV4dCIgJ3RleHQtbW9kZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChf IG1ham9yLW1vZGUpKSkpKSkpCiAgICAgKHdpdGgtdGVtcC1idWZmZXIKICAgICAgIChzZXRxLWxv Y2FsIG1hcmtkb3duLWZvbnRpZnktY29kZS1ibG9ja3MtbmF0aXZlbHkgdCkKICAgICAgIChpbnNl cnQgc3RyaW5nKQotLSAKMi4zNy4xCgo= --0000000000000806e1061a0fb909-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 15:37:28 2024 Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 19:37:28 +0000 Received: from localhost ([127.0.0.1]:47638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEZyK-0008Eq-8F for submit@debbugs.gnu.org; Tue, 04 Jun 2024 15:37:28 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:47190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEZyF-0008ER-Ee for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 15:37:27 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-57a32b0211aso1761169a12.2 for <71353@debbugs.gnu.org>; Tue, 04 Jun 2024 12:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717529764; x=1718134564; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QK4LHWklWrFUZf40ImmfJQev5PwLD5CZ9YULpJGCNo0=; b=OBacfyf+f52Q47iiUoWA8Z7IZS/touv93paB4uGML79IjwPR6K4udOwMZOjGvMeAkI DmUKIp0oSuoUc9vyhGA07kF59/5TUrsfb9/2pleWBdRZ+Zs3G/vjJWEgV/Xq2pHzLShl 7Ykyd8s5101kKFZSJHz4Hpkb9sc3n4oRqNl83TPapN/ucQXgPNpve6tCS1J48q1KUQfb vsnVO86M5vZyKMaETaKNK6wqdPZhJKDPnkXCFIbGVSCVa+aC5WCC2bmi4vxTTHwPse7+ lnl6G5y+Vi6O+LDewD5QsCsck5teZLVIaqrafGoD9EZi/1xu+9RSLeMqq3SgOeucvw3w maoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717529764; x=1718134564; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QK4LHWklWrFUZf40ImmfJQev5PwLD5CZ9YULpJGCNo0=; b=vCK8vTPGAd0PPww3kt+rBf2faDSfDIKvblYD4gF39Bm6ezw9aPNwwcJ2o8l5hDciRk 4PK2d6JijcTBI55xRH+EkM8ilmzPSWCWReZyypYpBth0RPQ/mPDX35FMEyFHIuFnM9Pd P0nnG9BBCX3JqGDnQXhcXUrflDVpx9yymriJ7mfJUETXSGDHwZItMDrN1JO/soEBpeJk IlVz4KR1jaBdcwaXydWLEoPscrnlL493n1CAo/le0IxCqt8V0WFnpkNZVdrMsg0DIqdN 63MKP2o2Iiurip8rGSMZQmzRPrpx/EYubUMAUEtoU4X17Q5Me+I7SpruojHDKqPaxsK3 Izww== X-Gm-Message-State: AOJu0YxO9XnuX6CpFw9Mo77VpWoCG8vE81h25d7jw4gYXo7YUUl7/Fz9 AwoXm7DdO+sF6gQ6FU2FEk5IWSDiL1HdrcbaeDQVBkn+a5oDjq5cy94tdQ== X-Google-Smtp-Source: AGHT+IFqR1FFxpaAFmxOr/dzkheFF388EkaR20EOCKE3d1JAeZXTMmej80dVRWKSxXpjhIuye8Q5hQ== X-Received: by 2002:a50:9f21:0:b0:578:c161:525d with SMTP id 4fb4d7f45d1cf-57a8b6ca8d8mr354079a12.25.1717529763718; Tue, 04 Jun 2024 12:36:03 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57a795833d1sm2642279a12.42.2024.06.04.12.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 12:36:03 -0700 (PDT) From: Felician Nemeth To: Troy Brown Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> Date: Tue, 04 Jun 2024 21:36:02 +0200 In-Reply-To: (Troy Brown's message of "Tue, 4 Jun 2024 08:37:59 -0400") Message-ID: <878qzk8pr1.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Troy Brown writes: > I've created a new patch which creates a fenced code block and uses > gfm-view-mode, I have not tried it, but it looks good. Maybe a comment would help to understand that the new part handles the case when the MarkedString is a code-block. At any rate, I CC'd the maintainer of Eglot. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 04:12:28 2024 Received: (at 71353) by debbugs.gnu.org; 15 Jun 2024 08:12:28 +0000 Received: from localhost ([127.0.0.1]:52753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIOWR-0003oc-RS for submit@debbugs.gnu.org; Sat, 15 Jun 2024 04:12:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIOWQ-0003oH-RE for 71353@debbugs.gnu.org; Sat, 15 Jun 2024 04:12:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIOWK-0002WD-2s; Sat, 15 Jun 2024 04:12:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=n59NxclA0jivikvFHMaxNEo+OLqyyeUtVlFFmjACOng=; b=hpBgIOC3s86DpBlt0s10 1XHPN7T6o7trdpM+L2n2QtyPBVY+4XbHT92jbRkBx9d0zyu23GfP+fQRqcrU5jE9E+vRmDAuNudMD HHmj4EFDu2HfZXLlpBLzzkJNTAv6CwzBhVXhCoREQ+WnnqlDk3YSGOBRxA5KlIzIhISa47pdGCqjl Sw880KUgzrLyq2lXX/0kh9MWxLwD/WWsOLWEgbYcVTtRQyeTTak+PPYhy3S6JrdzOGKeea4IqoUDO z4O5ZQRyx8nbP4/Xez2FTE6GN9bYbRbca6FPULlajNOvRbsJFFQwmHBre080lKhTlRR0bV7kaPqFM ZvzTsr8VW9xdsw==; Date: Sat, 15 Jun 2024 11:12:16 +0300 Message-Id: <86tthuvd3z.fsf@gnu.org> From: Eli Zaretskii To: Felician Nemeth In-Reply-To: <878qzk8pr1.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Tue, 04 Jun 2024 21:36:02 +0200) Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71353 Cc: brownts@troybrown.dev, 71353@debbugs.gnu.org, joaotavora@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 71353@debbugs.gnu.org, > João Távora > From: Felician Nemeth > Date: Tue, 04 Jun 2024 21:36:02 +0200 > > Troy Brown writes: > > > I've created a new patch which creates a fenced code block and uses > > gfm-view-mode, > > I have not tried it, but it looks good. Maybe a comment would help to > understand that the new part handles the case when the MarkedString is a > code-block. > > At any rate, I CC'd the maintainer of Eglot. João, any comments or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 05:39:11 2024 Received: (at 71353) by debbugs.gnu.org; 15 Jun 2024 09:39:11 +0000 Received: from localhost ([127.0.0.1]:58298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIPsM-0007lp-La for submit@debbugs.gnu.org; Sat, 15 Jun 2024 05:39:10 -0400 Received: from mail-lj1-f181.google.com ([209.85.208.181]:42330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIPsJ-0007kh-9P for 71353@debbugs.gnu.org; Sat, 15 Jun 2024 05:39:08 -0400 Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ebe3bac675so26968581fa.1 for <71353@debbugs.gnu.org>; Sat, 15 Jun 2024 02:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718444281; x=1719049081; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YUCoaz0v+4MXRWNv+7gpwQXPI4Zkgr/HkzNR0jSlSsc=; b=CZwtm+ijTl0ZLLV70CfJZnUQsZ+aBia1c8dDxOxqVuDu6ci+NBbpw+wN5/oIkrvBfS AkfXnhIKAcEDbf4PIdQQfBQDrH6w4aw69Nc1QwXzKhO8Lez40kwEa7RWKxc9iJ+gzVOW ZGp9GTdj2OGnua5BmjdQo9ktlobuvMM2ti/AR68z8WjbMv8wLH2NXSFdQuZG8KIwFi45 OqjSVekRZOfJqxKOoVoVn6lutmUW0TaYwn1xfmdUsYZkn43IUtkWpkr2Sk9Zwr2YybHF 4RTEKyna2qX/p6ItN1Br14aJ7dNedgbKhcaTMO3i1joSGoDVHCqfm/dfXffjfzPQxRXI OxkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718444281; x=1719049081; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YUCoaz0v+4MXRWNv+7gpwQXPI4Zkgr/HkzNR0jSlSsc=; b=dUesDK+2rGlzjDFpxm7lzEL1iCWVpS/AoQzVMVvi4XWEhAfSDX5ZDPDbk+qCtl+aPd qFbrdwbKc9FUSJpcMMA9rpAeC35LopxvzzNfdWMl9u/zaevNZJfMIuXC1MP5WDwAVneh cuAxygBlaHc7j89t4cJqgmtQO5pq/1OYMrOoV2HuD+kA3bV1bnOXXQILbms1JtRA9nFM GMMsGZXz/ef6jnLWY4WTXKJfkrA98IGvQKoLTUaO+KWlndchts+igvtkzgbKgmcRnVTr kP1N6pe3x9F3exnfCgTwA/tyapvxF6hTxdANzU/AW5+sRYdZdWvWS7ijRcORiWLa62Ey Wuww== X-Forwarded-Encrypted: i=1; AJvYcCXvj83mO/CuIOkCIDdETLKDoVTncLe7CYgDFKmLgqPP/1Rp/Fosav6BvcsygoafXAdK9QwJW+5YkSey5TSIb4deSMCnRGQ= X-Gm-Message-State: AOJu0Yz9x7IKKHgZPoGkciY5yZUaMppZrtFp/536exZdwv8U2yYIlR9c SGNjHu90HsNjYniuuzvblihJ4RMB37glj8uNKDfnDy5sE68/LwV21kfORxmSS/ZIpC6Xdxf+4gl IcLAr9ZhNXKUzhvQyym+Kw6P7d2BdeA== X-Google-Smtp-Source: AGHT+IHinwGZO8ym0jEABCraeoyOgIl7ls5ZnNsliOdzEPixRt+mIYBH/S0uf+v4ABkcRe3JBTVysClwKojap5yfXEM= X-Received: by 2002:a2e:2e0f:0:b0:2eb:f1a2:5803 with SMTP id 38308e7fff4ca-2ec0e46d205mr16505471fa.4.1718444280476; Sat, 15 Jun 2024 02:38:00 -0700 (PDT) MIME-Version: 1.0 References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> In-Reply-To: <86tthuvd3z.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 15 Jun 2024 10:37:48 +0100 Message-ID: Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000e77e49061aea7cec" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, Troy Brown , Felician Nemeth X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e77e49061aea7cec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Can you please resend the patch for inspection? On Sat, Jun 15, 2024, 09:12 Eli Zaretskii wrote: > > Cc: 71353@debbugs.gnu.org, > > Jo=C3=A3o T=C3=A1vora > > From: Felician Nemeth > > Date: Tue, 04 Jun 2024 21:36:02 +0200 > > > > Troy Brown writes: > > > > > I've created a new patch which creates a fenced code block and uses > > > gfm-view-mode, > > > > I have not tried it, but it looks good. Maybe a comment would help to > > understand that the new part handles the case when the MarkedString is = a > > code-block. > > > > At any rate, I CC'd the maintainer of Eglot. > > Jo=C3=A3o, any comments or suggestions? > --000000000000e77e49061aea7cec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Can you please resend the patch for inspection?

=
On Sat, Ju= n 15, 2024, 09:12 Eli Zaretskii <eliz@gn= u.org> wrote:
> Cc: 71= 353@debbugs.gnu.org,
>=C2=A0 Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
> From: Felician Nemeth <felician.nemeth@gmail.com>
> Date: Tue, 04 Jun 2024 21:36:02 +0200
>
> Troy Brown <brownts@troybrown.dev> writes:
>
> > I've created a new patch which creates a fenced code block an= d uses
> > gfm-view-mode,
>
> I have not tried it, but it looks good.=C2=A0 Maybe a comment would he= lp to
> understand that the new part handles the case when the MarkedString is= a
> code-block.
>
> At any rate, I CC'd the maintainer of Eglot.

Jo=C3=A3o, any comments or suggestions?
--000000000000e77e49061aea7cec-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 08:38:52 2024 Received: (at 71353) by debbugs.gnu.org; 15 Jun 2024 12:38:52 +0000 Received: from localhost ([127.0.0.1]:41248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sISgF-0004LT-Ec for submit@debbugs.gnu.org; Sat, 15 Jun 2024 08:38:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sISgD-0004L2-CV for 71353@debbugs.gnu.org; Sat, 15 Jun 2024 08:38:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sISdz-0002Ap-NF; Sat, 15 Jun 2024 08:36:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:Subject:In-Reply-To:To:From: Date; bh=/ZpYaftARGExhiokHwmAJQ8J2jWFC8hRtxAca1C4GZg=; b=b6nF6t022htVqKUR337O rgWtcchX1TtrcUrk3I8v5ZiyWsOE/purEDxs0+EU67S74wZHrQovBMtUBhL0HPQVAT/4Pm2brRAt1 ySu0LnwYcnZLecPLangUghRRRA1bFsS7AeF7CtiYd7H4wJnT0OC7HZB3a0bLgy73hg+Oho5gH+Lpj Cm6j5LxvaE3lcC2HDlPZYxRYzEI/BaaUB7wd5RFnSL7DXcIPSmjIyRnN88wXh8mlatNfdTGOgUuH8 ZKjlEhN1Zq9tjMUJ9BcGfCnF3IXATob4CraWEf5nfjuU+B5vWWpcQgWOz5Ryv65hmMWYTwNH2AVHg Mgs/0KY+mXuyIQ==; Date: Sat, 15 Jun 2024 15:36:27 +0300 Message-Id: <86v82atmb8.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= In-Reply-To: (message from =?iso-8859-1?Q?Jo=E3o_T=E1vora?= on Sat, 15 Jun 2024 10:37:48 +0100) Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, brownts@troybrown.dev, felician.nemeth@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable > From: Jo=E3o T=E1vora > Date: Sat, 15 Jun 2024 10:37:48 +0100 > Cc: Felician Nemeth , Troy Brown ,=20 > 71353@debbugs.gnu.org >=20 > Can you please resend the patch for inspection? Attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Eglot-Support-formatting-MarkedString-code-block.patch >From e9c6387eb123aac1fe4741a871be2b68128de41a Mon Sep 17 00:00:00 2001 From: Troy Brown Date: Tue, 4 Jun 2024 08:30:53 -0400 Subject: [PATCH] Eglot: Support formatting MarkedString code-block * lisp/progmodes/eglot.el (eglot--format-markup): Add support for MarkedString code-block. Copyright-paperwork-exempt: yes --- lisp/progmodes/eglot.el | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 5ccae5210fe..70224d0dcd6 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1861,11 +1861,15 @@ eglot--format-markup "Format MARKUP according to LSP's spec." (pcase-let ((`(,string ,mode) (if (stringp markup) (list markup 'gfm-view-mode) - (list (plist-get markup :value) - (pcase (plist-get markup :kind) - ("markdown" 'gfm-view-mode) - ("plaintext" 'text-mode) - (_ major-mode)))))) + (if-let ((language (plist-get markup :language)) + (value (plist-get markup :value))) + (list (concat "```" language "\n" value "\n```") + 'gfm-view-mode) + (list (plist-get markup :value) + (pcase (plist-get markup :kind) + ("markdown" 'gfm-view-mode) + ("plaintext" 'text-mode) + (_ major-mode))))))) (with-temp-buffer (setq-local markdown-fontify-code-blocks-natively t) (insert string) -- 2.37.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 18 09:40:43 2024 Received: (at 71353) by debbugs.gnu.org; 18 Jun 2024 13:40:43 +0000 Received: from localhost ([127.0.0.1]:42275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJZ4l-0003QZ-3g for submit@debbugs.gnu.org; Tue, 18 Jun 2024 09:40:43 -0400 Received: from mail-lj1-f169.google.com ([209.85.208.169]:56545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJZ4i-0003QL-Ip for 71353@debbugs.gnu.org; Tue, 18 Jun 2024 09:40:41 -0400 Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ebd95f136bso62011971fa.0 for <71353@debbugs.gnu.org>; Tue, 18 Jun 2024 06:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718717972; x=1719322772; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+m3Ts4YDNWoPshiD7DHrjbj3pW6vgDGoydD4X1Y0qbo=; b=QL6VKjuNg95JMHqsQfyuDVZJqbfr6S/gbpxTxSlJCKD58p7Xlu5GX4IL9te+M8jAJM HWWv6IHwqTfkLKBcKhNKIHryo9lkq89qnyKBi1dUGW3yEctnh48vi099T+GMKujFGqwV ivCoUxdmmLZUTwY8zxXGJ2/AG2pBlMx9yWaC85+skucuyn6RzBUt/iz4th+5UfUOQL54 D4DbQHgKkZnKcLG1qADqOelcj28RJDsnKjqZ2BbOQVSeUKk4EN9GlBEqguwnyOz4h2sa cVh7L1HtpzoaZ8Xcp+yYgLMZ2F3U7eZlmo5iIKJKjWvG8y+NBfnPgtRxJe9MKmCoErHn lbmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717972; x=1719322772; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+m3Ts4YDNWoPshiD7DHrjbj3pW6vgDGoydD4X1Y0qbo=; b=D1etmVs0Cr6BB/eFiNKl0AKx1g/621uBOpF+fISVYqzQ41z5x9nAp8sfBCji0rSggg 1d/xfqjpNvvkgBeI/2Fk72H+7u3dImxfwrRK5GigwxNDeifvPhM4D1TJbhe3RfMGald9 0Pr0hob52BG1NWv0K+1Wn0YTu40ElrBc6DWLIIlfYq1vn5KuzEKL74nrP/DM8Xqn2G4k DpGvGg2Hu08GmNc7XH5McHxG7VO0uA3GIhR1PoqiHdL/jf0sutEaH82MODpqTJj9JM33 3kVr/fyDW6DM2Q2v39BG10y4KTRQoqZPT7CkDovpahAGfdZcO5i+ZKtKvepCpCKRFzWU 4CwA== X-Forwarded-Encrypted: i=1; AJvYcCUzfcLyQrcY2hRPEk+NYWU0hOE7hNsld2/Bhb1JNdfSR0zshfi53rJabCwWyKV66ew4v8gXq3rWoEw/Fz26temjUl2FyQQ= X-Gm-Message-State: AOJu0YxdJxyZ8iY83qDbHY3lCZ5HjYWbUDiyxP1L7QRx/FcQyts7vPvr wVbBQobBAjggXwJSJyX9234itKUJkO8fAV/6bX9S4xzT4ozVt5UJAezWiYRjcdiwabKaRGfcnlm z8AfhGqtM+nrbnDg2BUXevMepODU= X-Google-Smtp-Source: AGHT+IHMcLQxwwU5qyUMU6mqi2ksetf7nRbzYpPkjgPrHimz0aPZ7S6dtPHk/FW2NYLkvk537FmQb+ozc5guafaUtK4= X-Received: by 2002:a2e:2c0c:0:b0:2eb:e67f:3c65 with SMTP id 38308e7fff4ca-2ec0e5c6c0dmr70333881fa.21.1718717971560; Tue, 18 Jun 2024 06:39:31 -0700 (PDT) MIME-Version: 1.0 References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> <86v82atmb8.fsf@gnu.org> In-Reply-To: <86v82atmb8.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 18 Jun 2024 14:39:20 +0100 Message-ID: Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, brownts@troybrown.dev, felician.nemeth@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 15, 2024 at 1:36=E2=80=AFPM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sat, 15 Jun 2024 10:37:48 +0100 > > Cc: Felician Nemeth , Troy Brown , > > 71353@debbugs.gnu.org > > > > Can you please resend the patch for inspection? > > Attached. The gist of the patch is correct, but please consider replacing by this alternative, I don't like if-let inside pcase-let, it's too complex: the following patch should be "flatter". diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 6896baf30ce..eabe01a1676 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1863,14 +1863,22 @@ eglot--snippet-expansion-fn (apply #'yas-expand-snippet args))))) (defun eglot--format-markup (markup) - "Format MARKUP according to LSP's spec." - (pcase-let ((`(,string ,mode) - (if (stringp markup) (list markup 'gfm-view-mode) - (list (plist-get markup :value) - (pcase (plist-get markup :kind) - ("markdown" 'gfm-view-mode) - ("plaintext" 'text-mode) - (_ major-mode)))))) + "Format MARKUP according to LSP's spec. +MARKUP is either an LSP MarkedString or MarkupContent object." + (let (string mode language) + (cond ((stringp markup) + (setq string markup + mode 'gfm-view-mode)) + ((setq language (plist-get markup :language)) + (setq string (concat "```" language "\n" + (plist-get markup :value) "\n```") + mode 'gfm-view-mode)) + (t + (setq string (plist-get markup :value) + mode (pcase (plist-get markup :kind) + ("markdown" 'gfm-view-mode) + ("plaintext" 'text-mode) + (_ major-mode))))) (with-temp-buffer (setq-local markdown-fontify-code-blocks-natively t) (insert string) From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 23:28:58 2024 Received: (at 71353) by debbugs.gnu.org; 1 Jul 2024 03:28:58 +0000 Received: from localhost ([127.0.0.1]:59599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO7ir-0001HO-Qq for submit@debbugs.gnu.org; Sun, 30 Jun 2024 23:28:58 -0400 Received: from mail-ed1-f44.google.com ([209.85.208.44]:55613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sO7ip-0001HB-C3 for 71353@debbugs.gnu.org; Sun, 30 Jun 2024 23:28:55 -0400 Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-57d1d45ba34so2961254a12.3 for <71353@debbugs.gnu.org>; Sun, 30 Jun 2024 20:28:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719804529; x=1720409329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X60WjL1PddqxkNVRG7ZRC2sSkebYG6PmFE2WfZIDAAk=; b=TlH9rkSWj//wrdnDRsQ6ZaGmc9M9gsjYmnq5GKhS8pGMYfn8HbKmQTps4adTCbY7Lu x9SAwz8o0Mlqbmr3bxRPw+GNC0ccsyYpZAMvmdskyUoOMUVn83ko/5HpDxlo4xUPUlSd BsiCRUqQkeXw/2QYG+Fox5WK9J09rFcR3U/sHL0L7CMVgN5i43a0zO6FFJpTNmTTE9f7 ZcEfqNyZiefMcxJXykNrpEeG3i2i3FdDX6OUadYEwdPg0aikR2q3pNhf0oCxEUI8bERn d2ZHK27MHSSMjHObjNLiW7mBGYMtbHJtWbdcdoKYTxULcDcL3WKBsuy5zpCA+Dj891Ca +mWw== X-Forwarded-Encrypted: i=1; AJvYcCWkV1jK2DW+VNfKFI/ciHYv0ZMCq4V/Jbz5dNzUS0zDpSaVq1Sj2vO7FsqyGusEHEV7A/VoOe8f9PUplyg5cokSfb0GrHA= X-Gm-Message-State: AOJu0YzIGpR+VuL/VDIgRX2njWCp6u+4Y75ubQqkQ3VxDt3jT91p37vC s1vWtypjuGo6JMIdvRX6TNy7aAp4o9DSu1QTPDkDJLTezefGBRtjHnub5uUoivs= X-Google-Smtp-Source: AGHT+IGOJLISBMai3lT4g0A/dcln120cqqT9E13i+I/VbiOSX9fosYptBV2hXlM8GCKh3ZXdFiCrDA== X-Received: by 2002:a05:6402:34cd:b0:57c:5fca:ab25 with SMTP id 4fb4d7f45d1cf-5879fa7b459mr3350089a12.25.1719804528526; Sun, 30 Jun 2024 20:28:48 -0700 (PDT) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com. [209.85.218.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58614f3d551sm3872514a12.96.2024.06.30.20.28.47 for <71353@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jun 2024 20:28:48 -0700 (PDT) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a72af03ebdfso329654966b.3 for <71353@debbugs.gnu.org>; Sun, 30 Jun 2024 20:28:47 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU4WvuKqVRGWpwqHgKJty3vPkqF4iYiN6CntqZtNkOmQi3VoklMCMHOuG8ShuE/Cc1SOebt4pUxaT3IyErIm0Z1lKII+/c= X-Received: by 2002:a17:907:7842:b0:a72:b802:15ba with SMTP id a640c23a62f3a-a751445f85fmr291287666b.72.1719804527769; Sun, 30 Jun 2024 20:28:47 -0700 (PDT) MIME-Version: 1.0 References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> <86v82atmb8.fsf@gnu.org> In-Reply-To: From: Troy Brown Date: Sun, 30 Jun 2024 23:28:36 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, Eli Zaretskii , felician.nemeth@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Tue, Jun 18, 2024 at 9:39=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > > The gist of the patch is correct, but please consider replacing by > this alternative, I don't like if-let inside pcase-let, it's too > complex: the following patch should be "flatter". > Thanks Jo=C3=A3o, I've tested your patch and verified it addresses my issue. Since I'm at my limit for patches without copyright assignment, can you apply your correction for this? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 04:41:16 2024 Received: (at 71353) by debbugs.gnu.org; 6 Jul 2024 08:41:16 +0000 Received: from localhost ([127.0.0.1]:45571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0yp-00079F-LY for submit@debbugs.gnu.org; Sat, 06 Jul 2024 04:41:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0yn-000790-Mf for 71353@debbugs.gnu.org; Sat, 06 Jul 2024 04:41:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ0ye-00047p-EM; Sat, 06 Jul 2024 04:41:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/EID0vcopQq+hSZAwLPhyN3U+R5UH4plVGtq2OMCs0g=; b=Sz+I4Qx/3mrDT5GxOZy7 UIJap3XseKYqgrMkV5KJxeoduEgc1wVI3lI25jc5xAoosQ+kXfwK4jBIoUEj/X+r0p2V8j/CiNXWL +MwUWTYXCV4b8QDCGE2ZSoLAZGMoolMNaiRGdyp8i3QxKbHMqu3OXdej4oKXQn0nLjE1SOpqR9CFd fTzu+eQ87+kR+YNxk+YYgJSitfxxks8+nu5wt99aruz9wrVuKL0iykf3ijJNBJqtkf0dybtIZ8r43 BYG5jbTGAWtwGLBaYadUMXrzg711uv5lhg1GM6xeXqiwcM0OVmAoTlU4HUw4oTjCt9jky4myzb3YD 8apfd9TId7jXjw==; Date: Sat, 06 Jul 2024 11:41:03 +0300 Message-Id: <86wmly52w0.fsf@gnu.org> From: Eli Zaretskii To: joaotavora@gmail.com, Troy Brown In-Reply-To: (message from Troy Brown on Sun, 30 Jun 2024 23:28:36 -0400) Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> <86v82atmb8.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71353 Cc: 71353@debbugs.gnu.org, felician.nemeth@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Troy Brown > Date: Sun, 30 Jun 2024 23:28:36 -0400 > Cc: Eli Zaretskii , felician.nemeth@gmail.com, 71353@debbugs.gnu.org > > On Tue, Jun 18, 2024 at 9:39 AM João Távora wrote: > > > > The gist of the patch is correct, but please consider replacing by > > this alternative, I don't like if-let inside pcase-let, it's too > > complex: the following patch should be "flatter". > > > > Thanks João, I've tested your patch and verified it addresses my > issue. Since I'm at my limit for patches without copyright > assignment, can you apply your correction for this? João, would you please install your patch? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 06 05:18:46 2024 Received: (at 71353-done) by debbugs.gnu.org; 6 Jul 2024 09:18:46 +0000 Received: from localhost ([127.0.0.1]:45596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ1Z7-00089X-RV for submit@debbugs.gnu.org; Sat, 06 Jul 2024 05:18:46 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:45227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ1Z5-00089H-NX for 71353-done@debbugs.gnu.org; Sat, 06 Jul 2024 05:18:44 -0400 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-424ad289912so16068475e9.2 for <71353-done@debbugs.gnu.org>; Sat, 06 Jul 2024 02:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720257454; x=1720862254; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cuk0z2S+O5WsQNTlGjlJ/Unj7gJWXzV2QP0HwsQkvWM=; b=nsl43PJ0IFmZZl1kJBZXVe6yuzS8S9rrXB7cyDVh9PpbBUrSSrJBMJdyFkxahJneuA RmLeNe6ijzVS0BLD3v7fCEmz9cJJTp/ZwYYKP7ohf48qRbukrUpVw9vCMqiZipd2fz7T m0CVPsDxaOAV5e70aMf7DHk452rTToZncDmVysozUNgsz2smKiQqMtF5ODZBXxohD3Jf kOjcc7/z106eG/fQLGJ6LHRhWcprD8BT9xKNB4AIHfdsEDP/oMu05HbuyXP4LJMCXVKP fArLkz0bwIf9IlApasW+cWqh7rKoV0AhQhqbUksxsi/9198+bpB5Ju3NA7OLs3nI0tkq F1CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720257454; x=1720862254; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cuk0z2S+O5WsQNTlGjlJ/Unj7gJWXzV2QP0HwsQkvWM=; b=KXy1XuLaL1V0sr6HKJ5xERQhVTeZkJvTeIdvs9+qUBcTwUwOys5EE8nzNcWMl+MP4J G/M7YW9mKU/HYH97X0B5cP/osVp1fOl1x3UyBCDI6wCEfrwQx33wsS1zKfdTIZTYI6Ck Xf7Y3ajIXnJ08tRNAdy10RguiqNqU7ATW94tcoSWn1KoRv+RaApDy1EWiw2ckecZXyZb HVSo8wRrt9xFLMhCcEF8x9/8WYaKNkHlLhLMjmxruMkGyXDjdDN/NHL/rKUXnqMVNEii 0e/rfWgqyquLZzz56zMVtlBHt3UBr2I/owIq4nd0yDnsBEujvIR+vw/yVwza2mFpcUNO EYlw== X-Forwarded-Encrypted: i=1; AJvYcCWd8xIO8lD71K3W/51V8q12NaCOoXVmRGQL5OymqJ1ZO7xFVwf+EaB1uU5pNSZZ6XH0Yyq7EvkgUwrIEft1N7tYBO5NvhoIkr+tsw== X-Gm-Message-State: AOJu0YwdpwUx22o8eoWKQ8mTyqjxuqIwxORCFU5Nj6qA0P9KgvxjABuQ jZuRJfgkU+eZMKhVgvXL5x/J+NImqrw2S4IPrLqJlfvMMOCoLg+vqA3aszLG X-Google-Smtp-Source: AGHT+IExmkq3v0zdb2wbINRS0+ytTYKVfUwJDL7CN0nNahl5so4l8okcN3nh91EsgBiH6btRp+s/AA== X-Received: by 2002:a5d:5188:0:b0:367:892a:b32 with SMTP id ffacd0b85a97d-367a068b252mr4191706f8f.60.1720257453822; Sat, 06 Jul 2024 02:17:33 -0700 (PDT) Received: from krug (87-196-76-11.net.novis.pt. [87.196.76.11]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3678fe13ef4sm9523425f8f.117.2024.07.06.02.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jul 2024 02:17:33 -0700 (PDT) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks In-Reply-To: <86wmly52w0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Jul 2024 11:41:03 +0300") References: <87ed9dl0wq.fsf@betli.tmit.bme.hu> <87zfs1j6lo.fsf@betli.tmit.bme.hu> <878qzk8pr1.fsf@betli.tmit.bme.hu> <86tthuvd3z.fsf@gnu.org> <86v82atmb8.fsf@gnu.org> <86wmly52w0.fsf@gnu.org> Date: Sat, 06 Jul 2024 10:18:46 +0100 Message-ID: <87a5iuho95.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71353-done Cc: 71353-done@debbugs.gnu.org, Troy Brown , felician.nemeth@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Jo=C3=A3o, would you please install your patch? Done in the emacs-30 branch. Closing this bug. From unknown Mon Aug 18 20:13:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Aug 2024 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator