Subject: [bug#71348] [PATCH 0/2] Update GRUB to 2.12

From: Maxim Cournoyer <[email-masked]>
Date: Sat, 08 Jun 2024 21:47:33 -0400

Hi Ludovic,

+CC Josselin, who also had a GRUB 2.12 patch somewhere (can't find it)

Ludovic Courtès <[email-masked]> writes:

> Hello Guix!
>
> Following the discussion with Ada Stevenson¹ who reported that
> the e2fsprogs upgrade to 1.47.0 broke system installation, here
> is an upgrade of GRUB.
>
> I tested it on x86_64-linux with:
>
>   ./pre-inst-env guix build grub-efi{,32} grub-coreboot grub-hybrid grub{,-minimal}

That's a welcome update.  I believe it'll fix our LUKS2 issues and we
could do without mentioning the caveats in the manual, like so:

--8<---------------cut here---------------start------------->8---
modified   doc/guix.texi
@@ -2384,21 +2384,12 @@ Keyboard Layout and Networking and Partitioning
 @uref{https://linux.die.net/man/8/cryptsetup, @code{man cryptsetup}},
 @code{man cryptsetup}} for more information).
 
-@quotation Warning
-While efforts are in progress to extend support to LUKS2, please note
-that Guix only supports devices of type LUKS1 at the moment. You can
-verify that your existing LUKS device is of the right type by running
-@command{cryptsetup luksDump @var{device}}. Alternatively, you can
-create a new LUKS1 device with @command{cryptsetup luksFormat --type
-luks1 @var{device}}.
-@end quotation
-
 Assuming you want to store the root partition on @file{/dev/sda2}, the
-command sequence to format it as a LUKS1 partition would be along these
+command sequence to format it as a LUKS partition would be along these
 lines:
 
 @example
-cryptsetup luksFormat --type luks1 /dev/sda2
+cryptsetup luksFormat /dev/sda2
 cryptsetup open /dev/sda2 my-partition
 mkfs.ext4 -L my-root /dev/mapper/my-partition
 @end example
--8<---------------cut here---------------end--------------->8---

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim