From unknown Sun Jun 22 04:34:47 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71320] [PATCH] services: nix: Fix activation. Resent-From: Oleg Pykhalov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 09:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71320@debbugs.gnu.org Cc: kiasoc5 , Oleg Pykhalov X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17173200441817 (code B ref -1); Sun, 02 Jun 2024 09:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 09:20:44 +0000 Received: from localhost ([127.0.0.1]:57825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhON-0000TF-Nw for submit@debbugs.gnu.org; Sun, 02 Jun 2024 05:20:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:40460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhOL-0000T1-4b for submit@debbugs.gnu.org; Sun, 02 Jun 2024 05:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDhO8-0003BR-Jn for guix-patches@gnu.org; Sun, 02 Jun 2024 05:20:28 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDhO2-00038v-CQ for guix-patches@gnu.org; Sun, 02 Jun 2024 05:20:28 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2e95ab5a45dso3307881fa.3 for ; Sun, 02 Jun 2024 02:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717320019; x=1717924819; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UHtjNanIfieKxwccU2UKrc/cN2TzA7Xr7R2GXGgwpDw=; b=djCUYlXPPsFyv8WlmPd1CvkOH3KN8x6w7xtlgLyIh9+4s259HEOYfO8gpHQZw41atb 8s9OfBRGHKqxPBdagfIsm+hG6NjUblTJpndx4KpQlC25e+dcx9lDLx2GJe0XhO2FQcjV lQgrBYQLMyBgeEA59931yoXZY0HuszGvYPd8N5QvgEJZA3qavBCIfDcz8r3UjrnAN2YT FHjcLvwGDGG3F1FjqLdXQE0h0Aj1GXuOrc8TtszU6ksR6YGuhNFa/YVIftxYWGdIu5KM PcC+vVoosCLAnBwqmsekrFWTYBVimPPjfU83SLA4PfK9xD0yRVyYbxFO7f8d1vXzflP2 NmHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717320019; x=1717924819; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UHtjNanIfieKxwccU2UKrc/cN2TzA7Xr7R2GXGgwpDw=; b=WSyvJI2laCWQ76YClnMaNOIN67fr/9zecg3wG25sGEsOoyMxytnrQrpMo947LhkLRQ Pjkfl1sMyajZ3IcMvIj117UPSHshTQpTugCl1+dDbtYly7XjYtaPbKWxyTRQ/wM27Z/R iz5P7wqreoIv4TZbjmbgupb8q099A/cI3b41G4Vp8DQb7ubKZ8qAhXorV4jZ0RhCE2cL fi8HszoYqnmDzGnw1DIfzpoGwxVq/zc9kidLBvMgyR1Hh+gQ8GWns6XPXKVPgitb4Y+3 yszm/iMoMZxX70OJLEWIt0KbJH87WiKP1FnWHMDZuARcr/lCiwhViJGTvuRwRgUXuWAb mJmQ== X-Gm-Message-State: AOJu0YxsehHV58ow2PcENuGZKuTOORwr9pu1gZOoIQgHJ2+k20mmPCHO jb/+1fkqDS8R/eUSnfGccB0pCBFbyxG3TS1xSXvGLBzFIYWOBPMnUnHrsA== X-Google-Smtp-Source: AGHT+IERs8SwITgkLRLZ1gtbF/qwc+FTspXm0iP8CNwL745zjsnHpY6olVGTTUun6TltrfPsRnX21A== X-Received: by 2002:ac2:52a6:0:b0:529:b796:1ca with SMTP id 2adb3069b0e04-52b895a8530mr3301047e87.2.1717320018797; Sun, 02 Jun 2024 02:20:18 -0700 (PDT) Received: from guixsd.wugi.info ([93.100.15.190]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b84d8966asm888676e87.257.2024.06.02.02.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 02:20:18 -0700 (PDT) From: Oleg Pykhalov Date: Sun, 2 Jun 2024 12:19:15 +0300 Message-ID: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=go.wigust@gmail.com; helo=mail-lj1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if it already exists. Reported-by: kiasoc5 Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 --- gnu/services/nix.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/services/nix.scm b/gnu/services/nix.scm index 419e5968fe..9749fc9e0f 100644 --- a/gnu/services/nix.scm +++ b/gnu/services/nix.scm @@ -98,12 +98,14 @@ (define (nix-activation _) #~(begin (use-modules (guix build utils) (srfi srfi-26)) - (for-each (cut mkdir-p <>) '("/nix/store" "/nix/var/log" + (for-each (cut mkdir-p <>) '("/nix/var/log" "/nix/var/nix/gcroots/per-user" "/nix/var/nix/profiles/per-user")) - (chown "/nix/store" - (passwd:uid (getpw "root")) (group:gid (getpw "nixbld01"))) - (chmod "/nix/store" #o775) + (unless (file-exists? #$%nix-store-directory) + (mkdir-p #$%nix-store-directory) + (chown #$%nix-store-directory + (passwd:uid (getpw "root")) (group:gid (getpw "nixbld01"))) + (chmod #$%nix-store-directory #o775)) (for-each (cut chmod <> #o777) '("/nix/var/nix/profiles" "/nix/var/nix/profiles/per-user")))) base-commit: 6f72ad465c1e2df965e8d73b209497b4ef456527 -- 2.41.0 From unknown Sun Jun 22 04:34:47 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71320] [PATCH] services: nix: Fix activation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 13:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: kiasoc5 , 71320@debbugs.gnu.org Received: via spool by 71320-submit@debbugs.gnu.org id=B71320.171733412013622 (code B ref 71320); Sun, 02 Jun 2024 13:16:03 +0000 Received: (at 71320) by debbugs.gnu.org; 2 Jun 2024 13:15:20 +0000 Received: from localhost ([127.0.0.1]:58054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDl3P-0003Xe-TM for submit@debbugs.gnu.org; Sun, 02 Jun 2024 09:15:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDl3N-0003XG-6k for 71320@debbugs.gnu.org; Sun, 02 Jun 2024 09:15:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDl35-0001Xf-55; Sun, 02 Jun 2024 09:14:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=pNCMtQZlabgrhU/b5ijMhokUC8d22hqM6lE2A26tNic=; b=DTC8Rbp75IUp8Z+mX+US UfS66rfXPtYavJnOguxoDWkTWj1m87bN9qjI8Mrvfxr2sigsurglQ0vgD3qV+hwYV4yhoYvel5ndB Zhg7fG5DQC59t/JHJeyu/lmWAiLqlg8Akx0T0GBzWp1iDPAHuIwp7CWA6ub/wxMGuJsso70SCGVDY pDgw/O06A9jUGuiMS6F81AfjJp2rnbntK13rTp176VqIcWxHr/RRbqUuRsZ7hQRW6zkw+OHasfA6U bvGhy8aaeBPsBMyV+kiUrzpx9W2m7IuMW/uvYKkicnbMPfFcA1cHHjDWvbjNzYz2agyYx35c3Haeo DOuAlN63ARuIhQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> (Oleg Pykhalov's message of "Sun, 2 Jun 2024 12:19:15 +0300") References: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> Date: Sun, 02 Jun 2024 15:14:56 +0200 Message-ID: <87cyozlc4v.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Oleg Pykhalov skribis: > This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. > > * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if = it > already exists. > > Reported-by: kiasoc5 > Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 Please add =E2=80=9CFixes =E2=80=A6=E2=80=9D if there=E2=80=99s an associat= ed bug report. Otherwise LGTM, thanks! Ludo=E2=80=99. From unknown Sun Jun 22 04:34:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Oleg Pykhalov Subject: bug#71320: closed (Re: [bug#71320] [PATCH] services: nix: Fix activation.) Message-ID: References: <8734pv9wnr.fsf@gmail.com> <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> X-Gnu-PR-Message: they-closed 71320 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 71320@debbugs.gnu.org Date: Sun, 02 Jun 2024 15:47:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1717343223-12150-1" This is a multi-part message in MIME format... ------------=_1717343223-12150-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71320: [PATCH] services: nix: Fix activation. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71320@debbugs.gnu.org. --=20 71320: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71320 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1717343223-12150-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71320-done) by debbugs.gnu.org; 2 Jun 2024 15:46:04 +0000 Received: from localhost ([127.0.0.1]:60171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDnPH-00038A-NG for submit@debbugs.gnu.org; Sun, 02 Jun 2024 11:46:03 -0400 Received: from mail-lj1-f181.google.com ([209.85.208.181]:40075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDnPE-00037Z-4y for 71320-done@debbugs.gnu.org; Sun, 02 Jun 2024 11:46:01 -0400 Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ea9610eca7so1973451fa.0 for <71320-done@debbugs.gnu.org>; Sun, 02 Jun 2024 08:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717343082; x=1717947882; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=og6hX/6PizbYYX3wO9zaXGZxL6IfDf/OlDFojIb5xhk=; b=IN9k2Vmhh0gX+QJ+kfyNcwZUfJIGPvGXIaUQ6EVs/RzIW4SN1K1sfIZFwocnvjjqY4 AdKZbybAegTuX+/GhTeU29oHA6iFkCEF7uAOY9yTMdW80XdKnhmlvIzxkhPMjnefxzgp g7w9WR+92+q2RiyN3KZJQzm0JlseG9eyRe2asYjtaEnskhREDiGCdCGoAVlptLl1xa+f RbYlLuSsv408/g/DdFjVu3lnvIGElCzvUlZPduK5pzu4zr7JCNVDZhlPQV4dErsefirT kZFb0+u9qY/i4v6DhcA/kvSrJHI3hZdpwr1sTqMYenO6ysulG7E35xfBwYBaLtrboewA oR6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717343082; x=1717947882; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=og6hX/6PizbYYX3wO9zaXGZxL6IfDf/OlDFojIb5xhk=; b=c3zzDU216m/r3MBAzVvQhLlyFm09wEQOzkPEq4vXbT7EHUna2P557F80vaRslPaccv VHssmdXvkT/ggGXbgUh+MZMdkRsY4CiLAJvrKONsF9/TBfEnWnqQ7c+EJy3ot6vq5wPw YnoTfhKTdqWpAyBY/YsVp1g0mSaIk3HRHhWbzro31YgpQMOtbx+GXz3DkRjNJzhfkCsl nWqxue0u2aPvCX7oBS5ICgymfHqp7wkeTl+0Tx/ICKWd530bLv5vz5rMBxFUF9vk+8BG NioGWZEs282C0fUaZgBBMDpqaTMfM7a5JJiQtmBdF8OpcXsEKMCzKLQcW0PiQhpcmRcw fC9g== X-Gm-Message-State: AOJu0YwMQ2sDGCFA1R1HHYLC7deRcWKTGRxkY0M3ogL4g1hNgwFyBzwW On3fO6puxexlbpBQ8xJixirRrjp7AwYLHjfz1aLQTy104mgzKc30 X-Google-Smtp-Source: AGHT+IFNiM/+pWdbTFPfTnyFKsTvNy6oP+aGHioUFI0fsqHLzzLuhfdOVYrAr4/VAgpCvq99XDbw2w== X-Received: by 2002:ac2:5b8c:0:b0:528:1067:4637 with SMTP id 2adb3069b0e04-52b89597879mr4031893e87.1.1717343081387; Sun, 02 Jun 2024 08:44:41 -0700 (PDT) Received: from localhost ([93.100.15.190]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b9a745aa4sm66317e87.152.2024.06.02.08.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 08:44:40 -0700 (PDT) From: Oleg Pykhalov To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#71320] [PATCH] services: nix: Fix activation. In-Reply-To: <87cyozlc4v.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 02 Jun 2024 15:14:56 +0200") References: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> <87cyozlc4v.fsf@gnu.org> Date: Sun, 02 Jun 2024 18:44:40 +0300 Message-ID: <8734pv9wnr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71320-done Cc: kiasoc5 , 71320-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Thank you for the review. Ludovic Court=C3=A8s writes: > Oleg Pykhalov skribis: > >> This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. >> >> * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if= it >> already exists. >> >> Reported-by: kiasoc5 >> Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 > > Please add =E2=80=9CFixes =E2=80=A6=E2=80=9D if there=E2=80=99s an associ= ated bug report. > > Otherwise LGTM, thanks! I've replaced 'Reported-by: kiasoc5 ' with: Reported by kiasoc5 at . similar to other commits. Pushed as bc06affabcf68bbe93e9afee13bef8cc8c6336a2 to master. Regards, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmZck2gUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pzhrhAAonCXHeCrXx3r6JgDUdoBFtzRhGy+ O8FcGz+ppq9S0c9nOVdibvRxSNmnqaXoHfn3QkTZ8GbKvaTYYsgoCMZ2nv0jpWK8 I/n8ZMHf54NKHlfL2p7EbRC2qSTS6QCQzUXPdfTmz/qcWtqL6x22QGF+P7M0EEDU ypmim9Yx2jPr3Z+Dap9qljW00JljVZNqn1JQPGUAbgljCZZ8nbOYf/4ibdMcZB+8 WmtIo7G/gBhzLJApU3hLVY3LqqiHXv9TnjjV109voMAEgdGpw7PFr3TIX79qcfx+ aHTxJckvpzLtqY7wUXOaDil9N73Zfd39cuBySkhTRw4aoARcYoLshMreA7XyDUuc NjJLIvDW1L92g3Nxfyhv/bPg6VhPZVp60CJPW/Iedwt77BJEah43/SRVMkSDO4R2 wqsXdnP89aqr3xVntaoQhC58wfqbd/6bswPM/jfjeRPX7/KKlXAQxd9CQWrcIv0I MbWvnROI1Y5LZiN0syeOzrGUKMV3i3PZMX+J/1QUqYgQsQkyqbgHSaghVZTQ7NO0 x9rZWuXUqahqHjv2qEZ5/ejCkJp4+tonhUPBXSs4S/1QrUx8BtO7+LomWWvl52or EjfXxGD+vnykptpfAzx1Pa2Gm0DK6XPa+e2zsaQNagyeiUDSCw7KKgFuUUW5Q+JJ VOwygEi2dUaU18M= =f/78 -----END PGP SIGNATURE----- --=-=-=-- ------------=_1717343223-12150-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 09:20:44 +0000 Received: from localhost ([127.0.0.1]:57825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhON-0000TF-Nw for submit@debbugs.gnu.org; Sun, 02 Jun 2024 05:20:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:40460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhOL-0000T1-4b for submit@debbugs.gnu.org; Sun, 02 Jun 2024 05:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDhO8-0003BR-Jn for guix-patches@gnu.org; Sun, 02 Jun 2024 05:20:28 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDhO2-00038v-CQ for guix-patches@gnu.org; Sun, 02 Jun 2024 05:20:28 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2e95ab5a45dso3307881fa.3 for ; Sun, 02 Jun 2024 02:20:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717320019; x=1717924819; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UHtjNanIfieKxwccU2UKrc/cN2TzA7Xr7R2GXGgwpDw=; b=djCUYlXPPsFyv8WlmPd1CvkOH3KN8x6w7xtlgLyIh9+4s259HEOYfO8gpHQZw41atb 8s9OfBRGHKqxPBdagfIsm+hG6NjUblTJpndx4KpQlC25e+dcx9lDLx2GJe0XhO2FQcjV lQgrBYQLMyBgeEA59931yoXZY0HuszGvYPd8N5QvgEJZA3qavBCIfDcz8r3UjrnAN2YT FHjcLvwGDGG3F1FjqLdXQE0h0Aj1GXuOrc8TtszU6ksR6YGuhNFa/YVIftxYWGdIu5KM PcC+vVoosCLAnBwqmsekrFWTYBVimPPjfU83SLA4PfK9xD0yRVyYbxFO7f8d1vXzflP2 NmHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717320019; x=1717924819; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UHtjNanIfieKxwccU2UKrc/cN2TzA7Xr7R2GXGgwpDw=; b=WSyvJI2laCWQ76YClnMaNOIN67fr/9zecg3wG25sGEsOoyMxytnrQrpMo947LhkLRQ Pjkfl1sMyajZ3IcMvIj117UPSHshTQpTugCl1+dDbtYly7XjYtaPbKWxyTRQ/wM27Z/R iz5P7wqreoIv4TZbjmbgupb8q099A/cI3b41G4Vp8DQb7ubKZ8qAhXorV4jZ0RhCE2cL fi8HszoYqnmDzGnw1DIfzpoGwxVq/zc9kidLBvMgyR1Hh+gQ8GWns6XPXKVPgitb4Y+3 yszm/iMoMZxX70OJLEWIt0KbJH87WiKP1FnWHMDZuARcr/lCiwhViJGTvuRwRgUXuWAb mJmQ== X-Gm-Message-State: AOJu0YxsehHV58ow2PcENuGZKuTOORwr9pu1gZOoIQgHJ2+k20mmPCHO jb/+1fkqDS8R/eUSnfGccB0pCBFbyxG3TS1xSXvGLBzFIYWOBPMnUnHrsA== X-Google-Smtp-Source: AGHT+IERs8SwITgkLRLZ1gtbF/qwc+FTspXm0iP8CNwL745zjsnHpY6olVGTTUun6TltrfPsRnX21A== X-Received: by 2002:ac2:52a6:0:b0:529:b796:1ca with SMTP id 2adb3069b0e04-52b895a8530mr3301047e87.2.1717320018797; Sun, 02 Jun 2024 02:20:18 -0700 (PDT) Received: from guixsd.wugi.info ([93.100.15.190]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52b84d8966asm888676e87.257.2024.06.02.02.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 02:20:18 -0700 (PDT) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH] services: nix: Fix activation. Date: Sun, 2 Jun 2024 12:19:15 +0300 Message-ID: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::232; envelope-from=go.wigust@gmail.com; helo=mail-lj1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: kiasoc5 , Oleg Pykhalov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if it already exists. Reported-by: kiasoc5 Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 --- gnu/services/nix.scm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gnu/services/nix.scm b/gnu/services/nix.scm index 419e5968fe..9749fc9e0f 100644 --- a/gnu/services/nix.scm +++ b/gnu/services/nix.scm @@ -98,12 +98,14 @@ (define (nix-activation _) #~(begin (use-modules (guix build utils) (srfi srfi-26)) - (for-each (cut mkdir-p <>) '("/nix/store" "/nix/var/log" + (for-each (cut mkdir-p <>) '("/nix/var/log" "/nix/var/nix/gcroots/per-user" "/nix/var/nix/profiles/per-user")) - (chown "/nix/store" - (passwd:uid (getpw "root")) (group:gid (getpw "nixbld01"))) - (chmod "/nix/store" #o775) + (unless (file-exists? #$%nix-store-directory) + (mkdir-p #$%nix-store-directory) + (chown #$%nix-store-directory + (passwd:uid (getpw "root")) (group:gid (getpw "nixbld01"))) + (chmod #$%nix-store-directory #o775)) (for-each (cut chmod <> #o777) '("/nix/var/nix/profiles" "/nix/var/nix/profiles/per-user")))) base-commit: 6f72ad465c1e2df965e8d73b209497b4ef456527 -- 2.41.0 ------------=_1717343223-12150-1-- From unknown Sun Jun 22 04:34:47 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#71320] [PATCH] services: nix: Fix activation. Resent-From: kiasoc5 Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 71320-done@debbugs.gnu.org Received: via spool by 71320-done@debbugs.gnu.org id=D71320.17173700077453 (code D ref 71320); Sun, 02 Jun 2024 23:14:02 +0000 Received: (at 71320-done) by debbugs.gnu.org; 2 Jun 2024 23:13:27 +0000 Received: from localhost ([127.0.0.1]:48687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDuOE-0001w9-VJ for submit@debbugs.gnu.org; Sun, 02 Jun 2024 19:13:27 -0400 Received: from layka.disroot.org ([178.21.23.139]:36218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDuOB-0001vo-Qd for 71320-done@debbugs.gnu.org; Sun, 02 Jun 2024 19:13:25 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6D2E240C71; Mon, 3 Jun 2024 01:03:44 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NStRZZml3-uo; Mon, 3 Jun 2024 01:03:43 +0200 (CEST) Message-ID: <948fa1a4-7955-4cc2-94dd-097ecae619da@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1717369420; bh=z7LYHrPkkZnWlJn9AWU0TxkRCODV2Pl5roANFaeBNXI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=jv79LO/KG2CpVJTb5bTDEsHMs3MsouE0HnYtE5HogHigz0jW5fEnl6KPl37dnHgl/ x0RkdaWEk+hENuvrZQ50OLRagOAK1qhh3jP8QqyWBNFBuUsHbEs8pH4IwVq1UFuu/Y iVAuTgek0TIyqEZKr3ILE3FzLiztgtWsrO/JFB9q165p6JAUOP3wjf/XCOlUqru5XI LZhr6thr5QeAXu9jicjpBCzWI8HwjC5OEDKvCoxzcr4aS9o9umzJDd37f2hMG9EEeG bFu0/vmSgQobce5NnnkpFmTqLOAWmZ5WCxba8xvIKfjcgmyWj2Ub5iiQzgbLH9Pb5J ix8rsIXUEgXcA== Date: Sun, 2 Jun 2024 19:03:36 -0400 MIME-Version: 1.0 References: <0634886cfb6a49988f427b2e0f7d10492decc931.1717319955.git.go.wigust@gmail.com> <87cyozlc4v.fsf@gnu.org> <8734pv9wnr.fsf@gmail.com> From: kiasoc5 Content-Language: en-US In-Reply-To: <8734pv9wnr.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 6/2/24 11:44, Oleg Pykhalov wrote: > Hi Ludovic, > > Thank you for the review. > > Ludovic Courtès writes: > >> Oleg Pykhalov skribis: >> >>> This commit follows 797be0ea5c3703ad96acd32c98dca5f946cf5c95. >>> >>> * gnu/services/nix.scm (nix-activation): Avoid provisioning the store if it >>> already exists. >>> >>> Reported-by: kiasoc5 >>> Change-Id: I159e8af5d7bd6ce62857b356d6e9ac68fe16acf4 >> >> Please add “Fixes …” if there’s an associated bug report. >> >> Otherwise LGTM, thanks! > > I've replaced 'Reported-by: kiasoc5 ' with: > > Reported by kiasoc5 at > . > > similar to other commits. > > Pushed as bc06affabcf68bbe93e9afee13bef8cc8c6336a2 to master. > > > Regards, > Oleg. Thanks! I'll report bugs to bug-guix next time.