Subject: bug#7132: closed (Re: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 09 Oct 2010 10:57:02 +0000

Your bug report

#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
7132: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7132
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9
From: [email-masked] (Nick Roberts)
To: Stefan Monnier <[email-masked]>
Cc: [email-masked], Chong Yidong <[email-masked]>, [email-masked]
Date: Sun, 10 Oct 2010 00:00:10 +1300
List-Id: <debbugs-submit.debbugs.gnu.org>

 > A fix for the emacs-23 branch would be welcome, yes,

I've done this and hopefully closed the report.

-- 
Nick                                           http://users.snap.net.nz/~nickrob

Subject: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9
From: [email-masked]
To: [email-masked]
Date: Wed, 29 Sep 2010 10:02:09 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

The control mouse 1 in the fringe area is supposed to toggle whether
breakpoints are enabled or not.  It fails to do this when the
breakpoint number exceeds 9.  This is because it only picks up the
a single digit of a breakpoint number due to a bug in the string-match
regexp argument.

Here is a fix:

sharmanpc 7% diff -c gdb-ui.el.orig gdb-ui.el
*** gdb-ui.el.orig	Wed Sep 29 09:41:10 2010
--- gdb-ui.el	Wed Sep 29 09:42:05 2010
***************
*** 2098,2104 ****
  	      (setq obj (overlay-get overlay 'before-string))))
  	  (when (stringp obj)
  	    (let* ((bptno (get-text-property 0 'gdb-bptno obj)))
! 	      (string-match "\\([0-9+]\\)*" bptno)
  	      (gdb-enqueue-input
  	       (list
  		(concat gdb-server-prefix
--- 2098,2104 ----
  	      (setq obj (overlay-get overlay 'before-string))))
  	  (when (stringp obj)
  	    (let* ((bptno (get-text-property 0 'gdb-bptno obj)))
! 	      (string-match "\\([0-9]+\\)*" bptno)
  	      (gdb-enqueue-input
  	       (list
  		(concat gdb-server-prefix
sharmanpc 8% diff -c gdb-ui.el.orig gdb-ui.el > gdb-ui.el.cdif
sharmanpc 9% 

In GNU Emacs 23.1.1 (i686-pc-linux-gnu, X toolkit)
 of 2009-11-20 on sharmanpc.mitel.com
Windowing system distributor `The X.Org Foundation', version 11.0.60802000
configured using `configure  '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' '--without-sound''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Shell

Minor modes in effect:
  shell-dirtrack-mode: t
  global-highlight-changes-mode: t
  highlight-changes-visible-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
C-f C-a C-k ~ / t m p / g d b - u i <tab> . e l C-g 
C-x C-b C-x o C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-p <return> C-x o M-x s h e <tab> <return> p u 
s n d SPC ~ / <backspace> <backspace> <backspace> <backspace> 
<backspace> h d SPC ~ / t m p <return> C-x o C-x M-f 
C-x o c p SPC C-y SPC . <return> g u n z i p SPC f 
g <backspace> <backspace> g d b u <backspace> - u I 
<backspace> I <backspace> <tab> <return> M-p C-a C-k 
C-p C-f C-f C-f C-f C-f C-f C-f C-2 C-M-f M-w C-n C-x 
4 C-f C-y . e l <return> C-x o l <backspace> m v SPC 
C-p C-f C-f C-f C-f C-2 C-M-f C-M-f M-w C-n C-y SPC 
C-y . o r i g <return> C-x o C-x C-b C-x o C-n C-n 
C-s c h g e C-a C-n C-n C-n C-n <return> C-M-b C-s 
C-w C-w C-w C-w C-w C-x o C-s C-s C-a C-x o C-a <kp-enter> 
C-a C-s C-w C-w C-w C-w C-w C-w C-w <kp-add> C-s C-s 
C-a <kp-add> C-a <kp-enter> C-x o C-f C-t <end> C-a 
C-x C-s M-x e v a l - c u <tab> <return> C-x o M-x 
s h e <tab> <return> d i f f SPC c <backspace> - c 
SPC C-p C-f C-f C-f C-f C-f C-f C-b C-2 C-e M-w C-n 
C-y C-x u C-e C-y SPC C-y <backspace> <backspace> <backspace> 
<backspace> <backspace> <return> M-p SPC > S-SPC M-b 
M-b M-b C-2 C-M-f C-M-f M-w C-e C-y . c d i f <return> 
<switch-frame> <switch-frame> <help-echo> M-x r e p 
o r t - e m a <tab> <return>

Recent messages:
Mark saved where search started [2 times]
Mark set [2 times]
Saving file /home/gx5000/sharman/tmp/gdb-ui.el...
Wrote /home/gx5000/sharman/tmp/gdb-ui.el
ad-handle-definition: `gdb-invalidate-frames' got redefined
Mark set [2 times]
Undo!
Mark set [2 times]
History item: 1
Mark set [2 times]