From unknown Fri Aug 15 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Resent-From: richard_sharman@mitel.com Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7132@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128577468121869 (code B ref -1); Wed, 29 Sep 2010 15:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Sep 2010 15:38:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yjI-0005ga-3F for submit@debbugs.gnu.org; Wed, 29 Sep 2010 11:38:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xCA-0004xd-8j for submit@debbugs.gnu.org; Wed, 29 Sep 2010 09:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEp-0006XD-EW for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38386) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEp-0006X9-9T for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Received: from [140.186.70.92] (port=60802 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0xEh-0004kS-9f for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEb-0006Uj-IE for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:19 -0400 Received: from smtp.mitel.com ([216.191.234.102]:50517) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEb-0006UL-Ax for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:13 -0400 Received: from localhost (smtp.mitel.com [127.0.0.1]) by smtp.mitel.com (Postfix) with ESMTP id 1FC9F2C04A for ; Wed, 29 Sep 2010 10:02:10 -0400 (EDT) X-Virus-Scanned: by amavisd-new (virusonly) at mitel.com Received: from smtp.mitel.com ([127.0.0.1]) by localhost (smtp.mitel.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T3iUrYH06V6Y for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Received: from sharmanpc.mitel.com (unknown [10.35.21.61]) by smtp.mitel.com (Postfix) with ESMTP id E2FA42C041 for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Received: from sharmanpc.mitel.com (localhost.localdomain [127.0.0.1]) by sharmanpc.mitel.com (8.13.1/8.13.1) with ESMTP id o8TE29hw002288 for ; Wed, 29 Sep 2010 10:02:09 -0400 Received: (from sharman@localhost) by sharmanpc.mitel.com (8.13.1/8.13.1/Submit) id o8TE2965002287; Wed, 29 Sep 2010 10:02:09 -0400 Date: Wed, 29 Sep 2010 10:02:09 -0400 Message-Id: <201009291402.o8TE2965002287@sharmanpc.mitel.com> X-Authentication-Warning: sharmanpc.mitel.com: sharman set sender to richard_sharman@mitel.com using -f From: richard_sharman@mitel.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-Mailman-Approved-At: Wed, 29 Sep 2010 11:37:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) The control mouse 1 in the fringe area is supposed to toggle whether breakpoints are enabled or not. It fails to do this when the breakpoint number exceeds 9. This is because it only picks up the a single digit of a breakpoint number due to a bug in the string-match regexp argument. Here is a fix: sharmanpc 7% diff -c gdb-ui.el.orig gdb-ui.el *** gdb-ui.el.orig Wed Sep 29 09:41:10 2010 --- gdb-ui.el Wed Sep 29 09:42:05 2010 *************** *** 2098,2104 **** (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9+]\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix --- 2098,2104 ---- (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9]+\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix sharmanpc 8% diff -c gdb-ui.el.orig gdb-ui.el > gdb-ui.el.cdif sharmanpc 9% In GNU Emacs 23.1.1 (i686-pc-linux-gnu, X toolkit) of 2009-11-20 on sharmanpc.mitel.com Windowing system distributor `The X.Org Foundation', version 11.0.60802000 configured using `configure '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' '--without-sound'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: C value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Shell Minor modes in effect: shell-dirtrack-mode: t global-highlight-changes-mode: t highlight-changes-visible-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-f C-a C-k ~ / t m p / g d b - u i . e l C-g C-x C-b C-x o C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-x o M-x s h e p u s n d SPC ~ / h d SPC ~ / t m p C-x o C-x M-f C-x o c p SPC C-y SPC . g u n z i p SPC f g g d b u - u I I M-p C-a C-k C-p C-f C-f C-f C-f C-f C-f C-f C-2 C-M-f M-w C-n C-x 4 C-f C-y . e l C-x o l m v SPC C-p C-f C-f C-f C-f C-2 C-M-f C-M-f M-w C-n C-y SPC C-y . o r i g C-x o C-x C-b C-x o C-n C-n C-s c h g e C-a C-n C-n C-n C-n C-M-b C-s C-w C-w C-w C-w C-w C-x o C-s C-s C-a C-x o C-a C-a C-s C-w C-w C-w C-w C-w C-w C-w C-s C-s C-a C-a C-x o C-f C-t C-a C-x C-s M-x e v a l - c u C-x o M-x s h e d i f f SPC c - c SPC C-p C-f C-f C-f C-f C-f C-f C-b C-2 C-e M-w C-n C-y C-x u C-e C-y SPC C-y M-p SPC > S-SPC M-b M-b M-b C-2 C-M-f C-M-f M-w C-e C-y . c d i f M-x r e p o r t - e m a Recent messages: Mark saved where search started [2 times] Mark set [2 times] Saving file /home/gx5000/sharman/tmp/gdb-ui.el... Wrote /home/gx5000/sharman/tmp/gdb-ui.el ad-handle-definition: `gdb-invalidate-frames' got redefined Mark set [2 times] Undo! Mark set [2 times] History item: 1 Mark set [2 times] From unknown Fri Aug 15 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2010 01:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: richard_sharman@mitel.com, Nick Roberts Cc: 7132@debbugs.gnu.org Received: via spool by 7132-submit@debbugs.gnu.org id=B7132.12860695076287 (code B ref 7132); Sun, 03 Oct 2010 01:32:02 +0000 Received: (at 7132) by debbugs.gnu.org; 3 Oct 2010 01:31:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2DQY-0001dM-HX for submit@debbugs.gnu.org; Sat, 02 Oct 2010 21:31:46 -0400 Received: from pantheon-po24.its.yale.edu ([130.132.50.118]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2DQW-0001dH-SF for 7132@debbugs.gnu.org; Sat, 02 Oct 2010 21:31:45 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o931YkPL018016 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 2 Oct 2010 21:34:46 -0400 Received: by furry (Postfix, from userid 1000) id 462F8C018; Sat, 2 Oct 2010 21:34:46 -0400 (EDT) From: Chong Yidong References: <201009291402.o8TE2965002287@sharmanpc.mitel.com> Date: Sat, 02 Oct 2010 21:34:46 -0400 In-Reply-To: <201009291402.o8TE2965002287@sharmanpc.mitel.com> (richard sharman's message of "Wed, 29 Sep 2010 10:02:09 -0400") Message-ID: <87fwwogitl.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) richard_sharman@mitel.com writes: > The control mouse 1 in the fringe area is supposed to toggle whether > breakpoints are enabled or not. It fails to do this when the > breakpoint number exceeds 9. This is because it only picks up the > a single digit of a breakpoint number due to a bug in the string-match > regexp argument. In Emacs 23.2, the graphical gdb code base was revamped, and I don't think this bug exists any more. Nick, could you check? > Here is a fix: > > sharmanpc 7% diff -c gdb-ui.el.orig gdb-ui.el > *** gdb-ui.el.orig Wed Sep 29 09:41:10 2010 > --- gdb-ui.el Wed Sep 29 09:42:05 2010 > *************** > *** 2098,2104 **** > (setq obj (overlay-get overlay 'before-string)))) > (when (stringp obj) > (let* ((bptno (get-text-property 0 'gdb-bptno obj))) > ! (string-match "\\([0-9+]\\)*" bptno) > (gdb-enqueue-input > (list > (concat gdb-server-prefix > --- 2098,2104 ---- > (setq obj (overlay-get overlay 'before-string)))) > (when (stringp obj) > (let* ((bptno (get-text-property 0 'gdb-bptno obj))) > ! (string-match "\\([0-9]+\\)*" bptno) > (gdb-enqueue-input > (list > (concat gdb-server-prefix > sharmanpc 8% diff -c gdb-ui.el.orig gdb-ui.el > gdb-ui.el.cdif > sharmanpc 9% > > > > In GNU Emacs 23.1.1 (i686-pc-linux-gnu, X toolkit) > of 2009-11-20 on sharmanpc.mitel.com > Windowing system distributor `The X.Org Foundation', version 11.0.60802000 > configured using `configure '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' '--without-sound'' > > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: C > value of $XMODIFIERS: nil > locale-coding-system: nil > default-enable-multibyte-characters: t > > Major mode: Shell > > Minor modes in effect: > shell-dirtrack-mode: t > global-highlight-changes-mode: t > highlight-changes-visible-mode: t > tooltip-mode: t > mouse-wheel-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > global-auto-composition-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > line-number-mode: t > > Recent input: > C-f C-a C-k ~ / t m p / g d b - u i . e l C-g > C-x C-b C-x o C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n > C-n C-p C-x o M-x s h e p u > s n d SPC ~ / > h d SPC ~ / t m p C-x o C-x M-f > C-x o c p SPC C-y SPC . g u n z i p SPC f > g g d b u - u I > I M-p C-a C-k > C-p C-f C-f C-f C-f C-f C-f C-f C-2 C-M-f M-w C-n C-x > 4 C-f C-y . e l C-x o l m v SPC > C-p C-f C-f C-f C-f C-2 C-M-f C-M-f M-w C-n C-y SPC > C-y . o r i g C-x o C-x C-b C-x o C-n C-n > C-s c h g e C-a C-n C-n C-n C-n C-M-b C-s > C-w C-w C-w C-w C-w C-x o C-s C-s C-a C-x o C-a > C-a C-s C-w C-w C-w C-w C-w C-w C-w C-s C-s > C-a C-a C-x o C-f C-t C-a > C-x C-s M-x e v a l - c u C-x o M-x > s h e d i f f SPC c - c > SPC C-p C-f C-f C-f C-f C-f C-f C-b C-2 C-e M-w C-n > C-y C-x u C-e C-y SPC C-y > M-p SPC > S-SPC M-b > M-b M-b C-2 C-M-f C-M-f M-w C-e C-y . c d i f > M-x r e p > o r t - e m a > > Recent messages: > Mark saved where search started [2 times] > Mark set [2 times] > Saving file /home/gx5000/sharman/tmp/gdb-ui.el... > Wrote /home/gx5000/sharman/tmp/gdb-ui.el > ad-handle-definition: `gdb-invalidate-frames' got redefined > Mark set [2 times] > Undo! > Mark set [2 times] > History item: 1 > Mark set [2 times] From unknown Fri Aug 15 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Resent-From: nickrob@snap.net.nz (Nick Roberts) Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Oct 2010 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: richard_sharman@mitel.com, 7132@debbugs.gnu.org Received: via spool by 7132-submit@debbugs.gnu.org id=B7132.128618795327372 (code B ref 7132); Mon, 04 Oct 2010 10:26:01 +0000 Received: (at 7132) by debbugs.gnu.org; 4 Oct 2010 10:25:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2iEz-00077R-5g for submit@debbugs.gnu.org; Mon, 04 Oct 2010 06:25:53 -0400 Received: from unit0.ironport.snap.net.nz ([202.37.100.104]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2iEw-00077M-82 for 7132@debbugs.gnu.org; Mon, 04 Oct 2010 06:25:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEANNIqUxvRfzL/2dsb2JhbACiPsAkDYU6BIpA X-IronPort-AV: E=Sophos;i="4.57,277,1283688000"; d="scan'208";a="18810621" Received: from rupert.snap.net.nz ([202.37.100.140]) by smtp0.ironport.snap.net.nz with ESMTP; 04 Oct 2010 23:28:54 +1300 X-Sender-IP: 111.69.252.203 X-Sender-IP: 111.69.252.203 X-Sender-IP: 111.69.252.203 Received: from totara (203.252.69.111.dynamic.snap.net.nz [111.69.252.203]) by rupert.snap.net.nz (Postfix) with ESMTP id 9774B2038C; Mon, 4 Oct 2010 23:28:53 +1300 (NZDT) Received: by totara (Postfix, from userid 1000) id A1702C177; Mon, 4 Oct 2010 23:28:52 +1300 (NZDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19625.44132.580109.230453@totara.tehura.co.nz> Date: Mon, 4 Oct 2010 23:28:52 +1300 In-Reply-To: <87fwwogitl.fsf@stupidchicken.com> References: <201009291402.o8TE2965002287@sharmanpc.mitel.com> <87fwwogitl.fsf@stupidchicken.com> X-Mailer: VM 7.19 under Emacs 22.2.1 From: nickrob@snap.net.nz (Nick Roberts) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > In Emacs 23.2, the graphical gdb code base was revamped, and I don't > think this bug exists any more. > > Nick, could you check? It looks like it exists in 23.2 (which is similar to 23.1) but not in trunk. I can't remember why a string match was done on bptno but bptno is used directly in gdb-mi.el so I think there is no problem there. Richard might like to check. I can check a change in on the emacs-23 branch if you like. Nick From unknown Fri Aug 15 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Oct 2010 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: nickrob@snap.net.nz (Nick Roberts) Cc: richard_sharman@mitel.com, Chong Yidong , 7132@debbugs.gnu.org Received: via spool by 7132-submit@debbugs.gnu.org id=B7132.128639333531893 (code B ref 7132); Wed, 06 Oct 2010 19:29:02 +0000 Received: (at 7132) by debbugs.gnu.org; 6 Oct 2010 19:28:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P3Zfa-0008IM-PW for submit@debbugs.gnu.org; Wed, 06 Oct 2010 15:28:54 -0400 Received: from smtp2e.orange.fr ([80.12.242.112]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P3ZfY-0008IH-RZ for 7132@debbugs.gnu.org; Wed, 06 Oct 2010 15:28:53 -0400 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf2e09.orange.fr (SMTP Server) with ESMTP id 4D6BC8000557; Wed, 6 Oct 2010 21:32:04 +0200 (CEST) Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf2e09.orange.fr (SMTP Server) with ESMTP id 3EE8C80002E4; Wed, 6 Oct 2010 21:32:04 +0200 (CEST) Received: from fmsmemgm.homelinux.net (AMontsouris-552-1-107-212.w92-140.abo.wanadoo.fr [92.140.114.212]) by mwinf2e09.orange.fr (SMTP Server) with ESMTP id 202FD8000557; Wed, 6 Oct 2010 21:32:04 +0200 (CEST) X-ME-UUID: 20101006193204131.202FD8000557@mwinf2e09.orange.fr Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 651E8AE515; Wed, 6 Oct 2010 21:32:03 +0200 (CEST) From: Stefan Monnier Message-ID: References: <201009291402.o8TE2965002287@sharmanpc.mitel.com> <87fwwogitl.fsf@stupidchicken.com> <19625.44132.580109.230453@totara.tehura.co.nz> Date: Wed, 06 Oct 2010 21:32:03 +0200 In-Reply-To: <19625.44132.580109.230453@totara.tehura.co.nz> (Nick Roberts's message of "Mon, 4 Oct 2010 23:28:52 +1300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) >> In Emacs 23.2, the graphical gdb code base was revamped, and I don't >> think this bug exists any more. >> Nick, could you check? > It looks like it exists in 23.2 (which is similar to 23.1) but not in > trunk. I can't remember why a string match was done on bptno but > bptno is used directly in gdb-mi.el so I think there is no problem > there. Richard might like to check. I can check a change in on the > emacs-23 branch if you like. A fix for the emacs-23 branch would be welcome, yes, Stefan From unknown Fri Aug 15 16:22:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: richard_sharman@mitel.com Subject: bug#7132: closed (Re: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9) Message-ID: References: <19632.19258.267151.687876@totara.tehura.co.nz> <201009291402.o8TE2965002287@sharmanpc.mitel.com> X-Gnu-PR-Message: they-closed 7132 X-Gnu-PR-Package: emacs Reply-To: 7132@debbugs.gnu.org Date: Sat, 09 Oct 2010 10:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1286621822-12754-1" This is a multi-part message in MIME format... ------------=_1286621822-12754-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 7132@debbugs.gnu.org. --=20 7132: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7132 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1286621822-12754-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 7132-done) by debbugs.gnu.org; 9 Oct 2010 10:56:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P4X6o-0003JX-VR for submit@debbugs.gnu.org; Sat, 09 Oct 2010 06:56:59 -0400 Received: from snapmx1.ironport.snap.net.nz ([202.37.100.100]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P4X6k-0003JS-Vc for 7132-done@debbugs.gnu.org; Sat, 09 Oct 2010 06:56:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAIbor0xvRfZA/2dsb2JhbACiQ7hxDYU6BIpA X-IronPort-AV: E=Sophos;i="4.57,307,1283688000"; d="scan'208";a="17136424" Received: from rupert.snap.net.nz ([202.37.100.140]) by smtp1.ironport.snap.net.nz with ESMTP; 10 Oct 2010 00:00:11 +1300 X-Sender-IP: 111.69.246.64 X-Sender-IP: 111.69.246.64 X-Sender-IP: 111.69.246.64 X-Sender-IP: 111.69.246.64 Received: from totara (64.246.69.111.dynamic.snap.net.nz [111.69.246.64]) by rupert.snap.net.nz (Postfix) with ESMTP id 4F92F20383; Sun, 10 Oct 2010 00:00:11 +1300 (NZDT) Received: by totara (Postfix, from userid 1000) id 581D2C176; Sun, 10 Oct 2010 00:00:10 +1300 (NZDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19632.19258.267151.687876@totara.tehura.co.nz> Date: Sun, 10 Oct 2010 00:00:10 +1300 To: Stefan Monnier Subject: Re: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 In-Reply-To: References: <201009291402.o8TE2965002287@sharmanpc.mitel.com> <87fwwogitl.fsf@stupidchicken.com> <19625.44132.580109.230453@totara.tehura.co.nz> X-Mailer: VM 7.19 under Emacs 22.2.1 From: nickrob@snap.net.nz (Nick Roberts) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7132-done Cc: richard_sharman@mitel.com, Chong Yidong , 7132-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > A fix for the emacs-23 branch would be welcome, yes, I've done this and hopefully closed the report. -- Nick http://users.snap.net.nz/~nickrob ------------=_1286621822-12754-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Sep 2010 15:38:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yjI-0005ga-3F for submit@debbugs.gnu.org; Wed, 29 Sep 2010 11:38:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xCA-0004xd-8j for submit@debbugs.gnu.org; Wed, 29 Sep 2010 09:59:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEp-0006XD-EW for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38386) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEp-0006X9-9T for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Received: from [140.186.70.92] (port=60802 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0xEh-0004kS-9f for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0xEb-0006Uj-IE for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:19 -0400 Received: from smtp.mitel.com ([216.191.234.102]:50517) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xEb-0006UL-Ax for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 10:02:13 -0400 Received: from localhost (smtp.mitel.com [127.0.0.1]) by smtp.mitel.com (Postfix) with ESMTP id 1FC9F2C04A for ; Wed, 29 Sep 2010 10:02:10 -0400 (EDT) X-Virus-Scanned: by amavisd-new (virusonly) at mitel.com Received: from smtp.mitel.com ([127.0.0.1]) by localhost (smtp.mitel.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T3iUrYH06V6Y for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Received: from sharmanpc.mitel.com (unknown [10.35.21.61]) by smtp.mitel.com (Postfix) with ESMTP id E2FA42C041 for ; Wed, 29 Sep 2010 10:02:09 -0400 (EDT) Received: from sharmanpc.mitel.com (localhost.localdomain [127.0.0.1]) by sharmanpc.mitel.com (8.13.1/8.13.1) with ESMTP id o8TE29hw002288 for ; Wed, 29 Sep 2010 10:02:09 -0400 Received: (from sharman@localhost) by sharmanpc.mitel.com (8.13.1/8.13.1/Submit) id o8TE2965002287; Wed, 29 Sep 2010 10:02:09 -0400 Date: Wed, 29 Sep 2010 10:02:09 -0400 Message-Id: <201009291402.o8TE2965002287@sharmanpc.mitel.com> X-Authentication-Warning: sharmanpc.mitel.com: sharman set sender to richard_sharman@mitel.com using -f From: richard_sharman@mitel.com To: bug-gnu-emacs@gnu.org Subject: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 29 Sep 2010 11:37:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) The control mouse 1 in the fringe area is supposed to toggle whether breakpoints are enabled or not. It fails to do this when the breakpoint number exceeds 9. This is because it only picks up the a single digit of a breakpoint number due to a bug in the string-match regexp argument. Here is a fix: sharmanpc 7% diff -c gdb-ui.el.orig gdb-ui.el *** gdb-ui.el.orig Wed Sep 29 09:41:10 2010 --- gdb-ui.el Wed Sep 29 09:42:05 2010 *************** *** 2098,2104 **** (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9+]\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix --- 2098,2104 ---- (setq obj (overlay-get overlay 'before-string)))) (when (stringp obj) (let* ((bptno (get-text-property 0 'gdb-bptno obj))) ! (string-match "\\([0-9]+\\)*" bptno) (gdb-enqueue-input (list (concat gdb-server-prefix sharmanpc 8% diff -c gdb-ui.el.orig gdb-ui.el > gdb-ui.el.cdif sharmanpc 9% In GNU Emacs 23.1.1 (i686-pc-linux-gnu, X toolkit) of 2009-11-20 on sharmanpc.mitel.com Windowing system distributor `The X.Org Foundation', version 11.0.60802000 configured using `configure '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' '--without-sound'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: C value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Shell Minor modes in effect: shell-dirtrack-mode: t global-highlight-changes-mode: t highlight-changes-visible-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-f C-a C-k ~ / t m p / g d b - u i . e l C-g C-x C-b C-x o C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-x o M-x s h e p u s n d SPC ~ / h d SPC ~ / t m p C-x o C-x M-f C-x o c p SPC C-y SPC . g u n z i p SPC f g g d b u - u I I M-p C-a C-k C-p C-f C-f C-f C-f C-f C-f C-f C-2 C-M-f M-w C-n C-x 4 C-f C-y . e l C-x o l m v SPC C-p C-f C-f C-f C-f C-2 C-M-f C-M-f M-w C-n C-y SPC C-y . o r i g C-x o C-x C-b C-x o C-n C-n C-s c h g e C-a C-n C-n C-n C-n C-M-b C-s C-w C-w C-w C-w C-w C-x o C-s C-s C-a C-x o C-a C-a C-s C-w C-w C-w C-w C-w C-w C-w C-s C-s C-a C-a C-x o C-f C-t C-a C-x C-s M-x e v a l - c u C-x o M-x s h e d i f f SPC c - c SPC C-p C-f C-f C-f C-f C-f C-f C-b C-2 C-e M-w C-n C-y C-x u C-e C-y SPC C-y M-p SPC > S-SPC M-b M-b M-b C-2 C-M-f C-M-f M-w C-e C-y . c d i f M-x r e p o r t - e m a Recent messages: Mark saved where search started [2 times] Mark set [2 times] Saving file /home/gx5000/sharman/tmp/gdb-ui.el... Wrote /home/gx5000/sharman/tmp/gdb-ui.el ad-handle-definition: `gdb-invalidate-frames' got redefined Mark set [2 times] Undo! Mark set [2 times] History item: 1 Mark set [2 times] ------------=_1286621822-12754-1-- From unknown Fri Aug 15 16:22:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7132: 23.1; gdb toggling breakpoints in fringe fails when brbkpt number > 9 Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Oct 2010 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7132@debbugs.gnu.org, nickrob@snap.net.nz Received: via spool by 7132-submit@debbugs.gnu.org id=B7132.128662635317440 (code B ref 7132); Sat, 09 Oct 2010 12:13:01 +0000 Received: (at 7132) by debbugs.gnu.org; 9 Oct 2010 12:12:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P4YHw-0004XF-Qe for submit@debbugs.gnu.org; Sat, 09 Oct 2010 08:12:33 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P4YHv-0004XA-5W for 7132@debbugs.gnu.org; Sat, 09 Oct 2010 08:12:31 -0400 Received: by iwn10 with SMTP id 10so1762665iwn.3 for <7132@debbugs.gnu.org>; Sat, 09 Oct 2010 05:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=+6pD3/8TKVwonT6QVMFOnKs7LBbKxIhxIKHWEMMhtns=; b=iMskqLoTEakGT9C1VdJbDZtOc6zWRKKKGelWxespnsoXj+02gpxP5msVftT5U6O5/u MiSeKHgvxVZPvK/HtYIcx54eMKVbNQJYkFRE18d8mdHTRP61rb08IdN5Pq6vDgXLkF10 RvmpTKyE0KpsregpDyqfXVzUMzoB2GRJYHvIs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=hGKvVUyEGSLdJPC0dIypScRP56GS3PSlsEhVACJ5Y805G5c3e/ybkBhiFI0zGvqWuC XDZyCWznXs9wO4Zb4knNSom6+mtlkgO4ODUn5tCa2fUzwIwjuOo47qZjcie61Ppz1ziP MrCM5kQuphlIfnWNgnzYMfltwJYpaWKqq/U1Y= Received: by 10.231.11.71 with SMTP id s7mr2315015ibs.85.1286626548817; Sat, 09 Oct 2010 05:15:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.180.226 with HTTP; Sat, 9 Oct 2010 05:15:08 -0700 (PDT) In-Reply-To: <19632.19258.267151.687876@totara.tehura.co.nz> References: <201009291402.o8TE2965002287@sharmanpc.mitel.com> <87fwwogitl.fsf@stupidchicken.com> <19625.44132.580109.230453@totara.tehura.co.nz> <19632.19258.267151.687876@totara.tehura.co.nz> From: Juanma Barranquero Date: Sat, 9 Oct 2010 14:15:08 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > I've done this and hopefully closed the report. Could you please add a note to the ChangeLog entry stating that this change is not for the trunk? It'll help with the merging. =C2=A0 =C2=A0 Juanma