GNU bug report logs - #71319
[PATCH 0/2] gnu: emacs-ddskk: Update to 17.1 revision 0.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: 71319 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>, Andrew Tropin <andrew <at> trop.in>
Subject: [bug#71319] [PATCH v2 3/3] gnu: emacs-ddskk-nicola: Improve package style.
Date: Wed, 19 Jun 2024 13:14:37 +0200

Hello,

gemmaro <gemmaro.dev <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use newer
> package style.  This is necessary due to the emacs-ddskk package style update
> since emacs-ddskk-nicola inherits this.  It also removes the last #t values
> from the lambda expressions in phases.

Thank you. Some comments follow.

> +     (append
> +      (list #:make-flags
> +            #~(let ((out (assoc-ref %outputs "out")))

You can remove this and use #$output instead.

> +                (append
> +                 (list (string-append "PREFIX=" out)
> +                       (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))

See above.

> +            #:tests? #f                 ;no tests in this subtree
> +            )

Please do not leave dangling parenthesis like this one.

> +      (substitute-keyword-arguments (package-arguments emacs-ddskk)
> +        ((#:phases phases)
> +         #~(modify-phases #$phases
> +             (add-after 'unpack 'chdir
> +               (lambda _
> +                 (chdir "nicola")))
> +             (replace 'configure
> +               (lambda* (#:key outputs #:allow-other-keys)
> +                 (make-file-writable "NICOLA-DDSKK-CFG")
> +                 (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
> +                   ("setq NICOLA-DDSKK_PREFIX" "")))))))))

You can use (lambda _ ...) instead of (lambda* (#:key outputs ...) ...)
since you don't make use of OUTPUTS argument.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.