Subject: Re: [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0.

From: Nicolas Goaziou <[email-masked]>
Date: Wed, 19 Jun 2024 13:12:33 +0200

Hello,

gemmaro <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ddskk): Update to 17.1 revision
> 0 (commit 8c47f46).

Thank you. Some comments follow.

>  (define-public emacs-ddskk
> -  ;; XXX: Upstream adds code names to their release tags, so version and code
> -  ;; name below need to be updated together.
> +  ;; XXX: Upstream adds code names to their release tags, so version
> +  ;; and code name need to be declared and updated together when the
> +  ;; next version is released (e.g. "Neppu" in 17.1.)

Since you're moving the package away from code names, you should also
remove references to them in the comment above. I.e., we just use
cherry-picked commits instead of tags.

>    (let ((version "17.1")
> -        (code-name "Neppu"))
> +        (commit "8c47f46e38a29a0f3eabcd524268d20573102467")
> +        (revision "0"))
>      (package
>        (name "emacs-ddskk")
> -      (version version)
> +      (version (git-version version revision commit))

You can replace version above with "17.1" and remove the binding above,
as it is usually done.

Regards,
-- 
Nicolas Goaziou