GNU bug report logs - #71317
[PATCH] fixed dependencies for latexindent

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71317 in the body.
You can then email your comments to 71317 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: aria <at> chytrid.org
To: guix-patches <at> gnu.org
Subject: [PATCH] fixed dependencies for latexindent
Date: Sat, 01 Jun 2024 15:10:13 -0400

From eec57fe778c5dd90f1a773793740a39177e3a9a4 Mon Sep 17 00:00:00 2001
From: Aria Nolan <aria <at> chytrid.org>
Date: Sat, 1 Jun 2024 15:01:16 -0400
Subject: [PATCH] fixed dependencies for latexindent

Change-Id: I70e90419b0a513c66292218ae307fc186465ca60
---
 gnu/packages/tex.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 4e46c1a..1df707f 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -38510,6 +38510,7 @@ (define-public texlive-latexindent
     (build-system texlive-build-system)
     (arguments (list #:link-scripts #~(list "latexindent.pl")))
     (inputs (list perl))
+    (propagated-inputs (list perl perl-yaml-tiny perl-file-homedir))
     (home-page "https://ctan.org/pkg/latexindent")
     (synopsis "Indent a LaTeX document, highlighting the programming 
structure")
     (description
-- 
2.45.1

Message #8 received at 71317 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: aria <at> chytrid.org
Cc: 71317 <at> debbugs.gnu.org
Subject: Re: [bug#71317] [PATCH] fixed dependencies for latexindent
Date: Sun, 02 Jun 2024 15:05:09 +0200

Hello,

aria <at> chytrid.org writes:

>  From eec57fe778c5dd90f1a773793740a39177e3a9a4 Mon Sep 17 00:00:00 2001
>  From: Aria Nolan <aria <at> chytrid.org>
> Date: Sat, 1 Jun 2024 15:01:16 -0400
> Subject: [PATCH] fixed dependencies for latexindent

Thank you.

>       (inputs (list perl))
> +    (propagated-inputs (list perl perl-yaml-tiny perl-file-homedir))

Perl is already an input, it should not be a propagated input, too.
`perl-yaml-tiny' and `perl-file-homedir' should also be moved to inputs.
In that case, you will probably need to add a phase such as this one:

          (add-after 'link-scripts 'wrap-perl-script
            (lambda _
              (wrap-program (string-append #$output "/bin/latexindent")
                `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))


Could you send an updated patch?


Regards,
-- 
Nicolas Goaziou

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org>
Cc: 71317-done <at> debbugs.gnu.org, aria <at> chytrid.org
Subject: Re: [bug#71317] [PATCH] fixed dependencies for latexindent
Date: Mon, 10 Jun 2024 20:34:35 +0200

Hello,

Nicolas Goaziou via Guix-patches via <guix-patches <at> gnu.org> writes:

> Perl is already an input, it should not be a propagated input, too.
> `perl-yaml-tiny' and `perl-file-homedir' should also be moved to inputs.
> In that case, you will probably need to add a phase such as this one:
>
>           (add-after 'link-scripts 'wrap-perl-script
>             (lambda _
>               (wrap-program (string-append #$output "/bin/latexindent")
>                 `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB"))))))

I went ahead and applied the changes suggested, then pushed it.

Thank you for your initial report!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.