From unknown Sat Sep 06 03:34:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2024 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71314 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71314@debbugs.gnu.org Cc: larsi@gnus.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: larsi@gnus.org Received: via spool by submit@debbugs.gnu.org id=B.171728917322407 (code B ref -1); Sun, 02 Jun 2024 00:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 00:46:13 +0000 Received: from localhost ([127.0.0.1]:57570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMT-0005pK-CE for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:57564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMS-0005pC-3W for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMF-0001sf-KP for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMD-0007mH-M7 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717289153; x=1717893953; i=jimjoe@gmx.net; bh=nUVFbwAMRuoFtL0xYGowI0lOeWcD17zKE3rWjzPNSZY=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=fCPt0qTAxQjS1pYjetaV5Em6/bgKcSQJeKyWk6BHdu3BiNZ7iPiZL3VMxhZIXW+U ku5SWn8NugnzmpkRB8YGwD1cIpjLPhutMQEgvxivl1MbrNSi2soy+Zq5p5DqSqYwy EDaEYUc7d2FzPak5/pgJRfLv8RlQwlFN5hD4V3KuFbUjnD3HfN6hP5TWvUxJVLokT mX+OYpy2lpe1HNKwb2OuuJYivhYNxsBHlnZEaEOR5qpol8vNlErhQDDMLPcAOdGmF OqfEqUf+vQ3VUXviovTbQi6uYsJpD7Ty7yt5tTSAec2fhoby35Hli5BsFQzDxJHwc VSW7ZiG0dhdrckwy5A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([59.92.166.156]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MLzFr-1rvcxt2I09-00LC9q for ; Sun, 02 Jun 2024 02:45:53 +0200 From: James Thomas Date: Sun, 02 Jun 2024 06:15:48 +0530 Message-ID: <86h6ecjhoj.fsf@outlook.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:bahAiiOF85t+kjzjkbZ4uTsFzb7P9TfmI9G6X33Ur+bqZCInRYq u/TJsAq1Yakvdg3TSj1+q7cHz8EhzmjNyseQBfjkLP1xqqGoscKuHqiU1CHXigdmTiEmzP/ sbOU04I3UQPRivURhGKJ/q4KldPdw/Evv1Uvd+98E+xZunt/10c2cdH8SGEaeRGYIVc9pD8 xnQeyx8DWZlB+i62z/+Xg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SzHI30cnWCs=;2op9LHN/PEwSthpLzSXMviFnmFp m5C8xbufVwOAodWDJXHeGkrOP4azWBUD+lS+2K7brWFKEK2QpbJJHihgGzUqKJ+th6Mjd+Qwh bOtsyZvw1jOVCcJE7XaPt5JrbF8mkdYLLfoiF+kLUnP7/PJg2VP+PimiLSt3xFpV+gdXUea82 04egw9llDaUGVhH9LHjaV/GYhin84Tp/JEMi14MHzZV+Obn45rxiiuUHQmgnitoiABZ14fjZ0 0h+DLphn+QfPW5wPL5OT6mlEQuYovuAivdgCD6ojZgTAU9Y+b/GrwTPy76mgQ66oNVFjUjKMK HQJ40jrQctur34hk3p0VuE73BeZPUIy0OZnR53/OKkm7jNDggULLoq2q/fGCwK4JbCl21H6FU 5vH8bMKPQtnGmATJ/9yA0za1mfbTNozxp4t1o3xsT2JXj/VCewghvwlAp1oCIy3T8tMbd8seH fdWF4fdwn8aRFDRstQNG/uOapA4DaEUuWwUELIFq3LJGQ0xOSjkoZ0Aw/qNiFuVwm2dgoEs6L ur0PYd3iraklb6lxBHU92EihwyrRpl8rtWMxAqPvJRY/KczPAt+wsn/iHWXo/YCjMRzhZmPQk KkmDZUInUxxd/ICh+yVNyfzamtYgCcHN6u329n8AFJCLQZlG6uLscyZtp3fBTRm5GObVSook7 RDYaADA/5kXycAb5ovobirNlHFMYbNkVBfRWigm5LfE1WYnqXPrmhP38u+emBjTcweka0Qlar SW/MDgiTmZNE27CiHpyKWCestes5OZ2l7bNjC1Szj72aLJvl1Fq/U/wLvG7UqTVBq4IEDF8HS 4oe/Za1nBGhRCeEeBWvxEMgxDnC+PXqcH2lTMeeNFt8QA= Received-SPF: pass client-ip=212.227.15.18; envelope-from=jimjoe@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain - Make sure python info docs are installed (in Debian-derivatives, 'sudo apt install python3-doc') - emacs -Q - Open a buffer test.py and type: print - C-h S fails, even after typing RET, but... - Then do info-lookup-reset, and the previous step works. Here's a possible patch, which hasn't been tested as much as needed: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-for-doc-spec-function-early--in-interactive.patch Content-Description: [PATCH] Check for doc-spec-function early, in interactive Content-Transfer-Encoding: quoted-printable =46rom 81b3a7b0c2be3c974729d1a4ffc44351d5393a45 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sun, 2 Jun 2024 05:59:35 +0530 Subject: [PATCH] Check for doc-spec-function early, in interactive * lisp/info-look.el (info-lookup-interactive-arguments): Move here. (info-lookup): From here. =2D-- lisp/info-look.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/info-look.el b/lisp/info-look.el index cd59fdf17d7..2baf133c7d3 100644 =2D-- a/lisp/info-look.el +++ b/lisp/info-look.el @@ -327,8 +327,11 @@ info-lookup-interactive-arguments If optional argument QUERY is non-nil, query for the help mode." (let* ((mode (cond (query (info-lookup-change-mode topic)) - ((info-lookup->mode-value topic (info-lookup-select-mode)) - info-lookup-mode) + ((when-let + ((info (info-lookup->mode-value + topic (info-lookup-select-mode)))) + (info-lookup--expand-info info)) + info-lookup-mode) ((info-lookup-change-mode topic)))) (completions (info-lookup->completions topic mode)) (default (info-lookup-guess-default topic mode)) @@ -404,9 +407,6 @@ info-lookup different window." (or mode (setq mode (info-lookup-select-mode))) (setq mode (info-lookup--item-to-mode item mode)) - (if-let ((info (info-lookup->mode-value topic mode))) - (info-lookup--expand-info info) - (error "No %s help available for `%s'" topic mode)) (let* ((completions (info-lookup->completions topic mode)) (ignore-case (info-lookup->ignore-case topic mode)) (entry (or (assoc (if ignore-case (downcase item) item) completi= ons) =2D- 2.40.1 --=-=-= Content-Type: text/plain -- --=-=-=-- From unknown Sat Sep 06 03:34:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2024 04:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71314 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: James Thomas Cc: larsi@gnus.org, 71314@debbugs.gnu.org Received: via spool by 71314-submit@debbugs.gnu.org id=B71314.171730342011283 (code B ref 71314); Sun, 02 Jun 2024 04:44:01 +0000 Received: (at 71314) by debbugs.gnu.org; 2 Jun 2024 04:43:40 +0000 Received: from localhost ([127.0.0.1]:57639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDd4F-0002vv-Og for submit@debbugs.gnu.org; Sun, 02 Jun 2024 00:43:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDd4D-0002vh-Ak for 71314@debbugs.gnu.org; Sun, 02 Jun 2024 00:43:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDd1p-0001bs-Az; Sun, 02 Jun 2024 00:41:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tiPJVXsknW3ZlKbBAOd8fHnIfbrnIBpDlco011aB8Q0=; b=WggziF9FaVYu cpHM8Nniofu9WQXY+f9l2bjNYt/8HjrvO1HX02/fGs9EKmprgIcsqu1RgBiRIm159mWtpTxLfRFZ9 Gq9BpIBa0Amx3+4wmtJYREqZw9YYaVexIvh8m1kTnmbYdOINiRopI9yc3hUFjLzUqD7apfWu10kxb pOhFiu94H7Qjil0f2IhrbjQ+69hJaPVkfNwcRopBqSug9rpBOVFviZ0XUh6njw71KiXHFMZk+cXz1 XHgOBdTPgavkxQuFR9+atqICK3vzKIVxkVTdKu0NItfnXZ5JmoCZ5z7G9Lqg27/OE/OzhrGKmD5cJ Bi+Ng7Unl00Cwl+pVsrx+w==; Date: Sun, 02 Jun 2024 07:41:06 +0300 Message-Id: <868qzonehp.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86h6ecjhoj.fsf@outlook.com> (bug-gnu-emacs@gnu.org) References: <86h6ecjhoj.fsf@outlook.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org > Date: Sun, 02 Jun 2024 06:15:48 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > - Make sure python info docs are installed (in Debian-derivatives, 'sudo > apt install python3-doc') > - emacs -Q > - Open a buffer test.py and type: print > - C-h S fails, even after typing RET, but... > > - Then do info-lookup-reset, and the previous step works. > > Here's a possible patch, which hasn't been tested as much as needed: Thanks, but can you also explain why the original recipe fails, and the main idea of the fix? From unknown Sat Sep 06 03:34:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2024 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71314 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: larsi@gnus.org, 71314@debbugs.gnu.org Received: via spool by 71314-submit@debbugs.gnu.org id=B71314.171732664413031 (code B ref 71314); Sun, 02 Jun 2024 11:11:01 +0000 Received: (at 71314) by debbugs.gnu.org; 2 Jun 2024 11:10:44 +0000 Received: from localhost ([127.0.0.1]:57970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDj6q-0003O6-AL for submit@debbugs.gnu.org; Sun, 02 Jun 2024 07:10:44 -0400 Received: from mout.gmx.net ([212.227.17.20]:42123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDj6n-0003Nt-H2 for 71314@debbugs.gnu.org; Sun, 02 Jun 2024 07:10:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717326623; x=1717931423; i=jimjoe@gmx.net; bh=9RGmVJe+aNOuidmOm71vUt2rCbN5H/0Dm9gN5g/w4bM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=PxeIgwqbI/yMwmq5gdpmsG4N7/t8eViTkwzja/p2Jdr52w1LORr3A5eAUkqHjETI sWoNaNhhkousvIXIoYjflSpP01M3BZlRGTay+32O432e0u0TgfWRc2YBR/xP+2M15 K/NSZFgxQ2QO0QWgXx7M2r2Dvlr1PdiV0n6g2IsXUk16AmdkD3eC84R/GjMxNZfRK 1di+KGik+ARXiIrzBjaRFFq9SAL4eHbg7nQtYVba9Lm9X2iACuDfCZI34k/5F50Xn iI5AcpEbSI/KJtVV3SnGRFeJlOzHrZUg6w36d/PktCaHftyI/FnFRQqqpxSeBzIwP d88JX+EE5NV3WZohLQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([59.92.166.156]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mnpnm-1sppsS03Ra-00oTfe; Sun, 02 Jun 2024 13:10:22 +0200 From: James Thomas In-Reply-To: <868qzonehp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Jun 2024 07:41:06 +0300") References: <86h6ecjhoj.fsf@outlook.com> <868qzonehp.fsf@gnu.org> Date: Sun, 02 Jun 2024 16:40:15 +0530 Message-ID: <861q5f38iw.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:nPk6FMeqeyvdZoG8BLZPK4VESnw0TN6EMO6H/lRnaau+KXcHSdv KIEXZjTFs3GgOnC2G5mFt1UElfjOePHNZggLEKMYS1guvlp+Hk1CAneUWFieG7JCYTQB9bl xk73h+XHWmuiAdrxHsYIzb63dD54qR/DB4yQNvSGT7/sqbpOlXhLe4XVunPizanmIs2M8f3 Jgeg4asRbtMsl9RLOvnJA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XZFW06y1JmQ=;FcOs6RT0aC6reDpxCo2GyUtM5Z6 7bOpyKEBh9PO/T66+XIPiHkL0+gEr0RGDUz30M719Om26Ym5AFYFwInOcDlJPmdjAMuWBy5bJ 7HmVKhcm7/CWDns2im3aIAiMVBBC8+urWDwSNNMCeDISwdpKjTnW5ttdiYUzuX32MYu7Rle2b invGeyjy0zQs1iU6ojyyTHD0kf2BHA8Y8oGanP0njptKmSP1PC5+LIqxoJrZW0J1KAfzSyYlT g17EkUhPFNbcRcnaThKeFAzaqFiJDLqiHodIH0o1ISCLZK70idHUrfNHbMorydzmOYsuWEMJc WzFQ8wemQZPAZIBVI67ZVMKbG7iJXTB9y/PUe3r/1NjGoR21dHW0othkV4YOFPXlT19cYp6yT b+ku6eThpuxqyNFmE1nyLibLLb1A9gQl0clTO+AeLdrZxDXEtGNsNlM2paUUpL8qZkTF9Vwd2 3h6WEv4dxB/xaWVb7AgjB/e1mMatLUhSAiky/9aE78F7rlUUbr6QrDjsTt1g27ovxHi0rh/es sBr3KNeJ9Ohjs3CKcg+UGp92LDliyc3XWxgOdInWski6rzDaY9d6c1GteA0jm86GnPciIRGF2 XJ7W6sJDHcOJZ9r77ksqcv6H6EsSDkFttOhcgGaj1uHv5edNAveBdMGie8FMPL5czVr1lbM64 LIS6YYv/BMn5mfMep10s9NqTxLrmwpJst+I7dqt5HGsiyw9TifToY0HTTVuqjDnneL2I26nT1 B7sL6dfc4bnYaXKvm9dPaptkLB0LHcSw3TrX85NKEVAz/BNFXCi5uPFdwy5fsx5f2xv2iyzZC fE8jJwuOOHP0Z13UOYejnUY4ol8om7cL7SIXCgKipcGCCroQ7Ym2ZdUYzQnQNc4Fzv Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii wrote: >> Cc: larsi@gnus.org >> Date: Sun, 02 Jun 2024 06:15:48 +0530 >> From: James Thomas via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> - Make sure python info docs are installed (in Debian-derivatives, 'sud= o >> apt install python3-doc') >> - emacs -Q >> - Open a buffer test.py and type: print >> - C-h S fails, even after typing RET, but... >> >> - Then do info-lookup-reset, and the previous step works. >> >> Here's a possible patch, which hasn't been tested as much as needed: > > Thanks, but can you also explain why the original recipe fails, and > the main idea of the fix? The problem seems to be that info-lookup-interactive-arguments sets the cache as 'initialized' for the mode (python-mode, in this case) without accounting for the new case of :doc-spec-function (which needs info-lookup--expand-info to be run), so that subsequent calls don't bother running info-lookup-setup-mode again. It could later work, for e.g., when the initialization was marked 'undone' by calling info-lookup-reset as I'd said above, because by that time the --expand had been already run. (I didn't include this explanation earlier as I'd considered the fix a kind of POC) =2D- From unknown Sat Sep 06 03:34:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: James Thomas Subject: bug#71314: closed (Re: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode) Message-ID: References: <86le3fd3lg.fsf@gnu.org> <86h6ecjhoj.fsf@outlook.com> X-Gnu-PR-Message: they-closed 71314 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71314@debbugs.gnu.org Date: Sat, 08 Jun 2024 12:26:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1717849562-12885-1" This is a multi-part message in MIME format... ------------=_1717849562-12885-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71314: [PATCH] info-lookup-symbol does not work in python-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71314@debbugs.gnu.org. --=20 71314: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71314 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1717849562-12885-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71314-done) by debbugs.gnu.org; 8 Jun 2024 12:25:10 +0000 Received: from localhost ([127.0.0.1]:37714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFv8A-0003KQ-3O for submit@debbugs.gnu.org; Sat, 08 Jun 2024 08:25:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFv87-0003K5-Hw for 71314-done@debbugs.gnu.org; Sat, 08 Jun 2024 08:25:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFv7m-0005KU-CR; Sat, 08 Jun 2024 08:24:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KmlMYNzYo5sGo0oE/EVS1qQjt59SvksFNBZ9ILi4o8Y=; b=EHcj3h2VRqef 4EbHWrbvvzNaodNixYMhIKH/+voeYSPxPNqGdWzxZDmq6UFQxzployNkXVyhoZvcbYXlQAuJC7elz LEva18YfO+BT3lpcKyxdAmOXOv289j1nVD18hoTTvxtx+9ooYVPaOlAtfVkBJ0vwIKVEFMEWCUTjP h7YvmNEsZvfVQn4dYGKJkVFQrDhSnd0jwEdNzg8U4UGpgCbqLUro1/4rcVzQzfRAm1732OAxVYE+r Ig0XtclLH2ZB/N4QnMJZyWaW5IR1oR1ck4pTttBWebDLLAYrNnsvGm4R3QKjs8C+wZdQfMz+KxOgl CTjdbCgnwUQv+4VaA4XRPQ==; Date: Sat, 08 Jun 2024 15:24:43 +0300 Message-Id: <86le3fd3lg.fsf@gnu.org> From: Eli Zaretskii To: James Thomas In-Reply-To: <86h6ecjhoj.fsf@outlook.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#71314: [PATCH] info-lookup-symbol does not work in python-mode References: <86h6ecjhoj.fsf@outlook.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71314-done Cc: 71314-done@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: larsi@gnus.org > Date: Sun, 02 Jun 2024 06:15:48 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > - Make sure python info docs are installed (in Debian-derivatives, 'sudo > apt install python3-doc') > - emacs -Q > - Open a buffer test.py and type: print > - C-h S fails, even after typing RET, but... > > - Then do info-lookup-reset, and the previous step works. > > Here's a possible patch, which hasn't been tested as much as needed: Thanks, installed on master, and closing the bug. ------------=_1717849562-12885-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 00:46:13 +0000 Received: from localhost ([127.0.0.1]:57570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMT-0005pK-CE for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:57564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZMS-0005pC-3W for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMF-0001sf-KP for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDZMD-0007mH-M7 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:45:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1717289153; x=1717893953; i=jimjoe@gmx.net; bh=nUVFbwAMRuoFtL0xYGowI0lOeWcD17zKE3rWjzPNSZY=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=fCPt0qTAxQjS1pYjetaV5Em6/bgKcSQJeKyWk6BHdu3BiNZ7iPiZL3VMxhZIXW+U ku5SWn8NugnzmpkRB8YGwD1cIpjLPhutMQEgvxivl1MbrNSi2soy+Zq5p5DqSqYwy EDaEYUc7d2FzPak5/pgJRfLv8RlQwlFN5hD4V3KuFbUjnD3HfN6hP5TWvUxJVLokT mX+OYpy2lpe1HNKwb2OuuJYivhYNxsBHlnZEaEOR5qpol8vNlErhQDDMLPcAOdGmF OqfEqUf+vQ3VUXviovTbQi6uYsJpD7Ty7yt5tTSAec2fhoby35Hli5BsFQzDxJHwc VSW7ZiG0dhdrckwy5A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-3493 ([59.92.166.156]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MLzFr-1rvcxt2I09-00LC9q for ; Sun, 02 Jun 2024 02:45:53 +0200 From: James Thomas To: bug-gnu-emacs@gnu.org Subject: [PATCH] info-lookup-symbol does not work in python-mode X-Debbugs-CC: larsi@gnus.org Date: Sun, 02 Jun 2024 06:15:48 +0530 Message-ID: <86h6ecjhoj.fsf@outlook.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:bahAiiOF85t+kjzjkbZ4uTsFzb7P9TfmI9G6X33Ur+bqZCInRYq u/TJsAq1Yakvdg3TSj1+q7cHz8EhzmjNyseQBfjkLP1xqqGoscKuHqiU1CHXigdmTiEmzP/ sbOU04I3UQPRivURhGKJ/q4KldPdw/Evv1Uvd+98E+xZunt/10c2cdH8SGEaeRGYIVc9pD8 xnQeyx8DWZlB+i62z/+Xg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SzHI30cnWCs=;2op9LHN/PEwSthpLzSXMviFnmFp m5C8xbufVwOAodWDJXHeGkrOP4azWBUD+lS+2K7brWFKEK2QpbJJHihgGzUqKJ+th6Mjd+Qwh bOtsyZvw1jOVCcJE7XaPt5JrbF8mkdYLLfoiF+kLUnP7/PJg2VP+PimiLSt3xFpV+gdXUea82 04egw9llDaUGVhH9LHjaV/GYhin84Tp/JEMi14MHzZV+Obn45rxiiuUHQmgnitoiABZ14fjZ0 0h+DLphn+QfPW5wPL5OT6mlEQuYovuAivdgCD6ojZgTAU9Y+b/GrwTPy76mgQ66oNVFjUjKMK HQJ40jrQctur34hk3p0VuE73BeZPUIy0OZnR53/OKkm7jNDggULLoq2q/fGCwK4JbCl21H6FU 5vH8bMKPQtnGmATJ/9yA0za1mfbTNozxp4t1o3xsT2JXj/VCewghvwlAp1oCIy3T8tMbd8seH fdWF4fdwn8aRFDRstQNG/uOapA4DaEUuWwUELIFq3LJGQ0xOSjkoZ0Aw/qNiFuVwm2dgoEs6L ur0PYd3iraklb6lxBHU92EihwyrRpl8rtWMxAqPvJRY/KczPAt+wsn/iHWXo/YCjMRzhZmPQk KkmDZUInUxxd/ICh+yVNyfzamtYgCcHN6u329n8AFJCLQZlG6uLscyZtp3fBTRm5GObVSook7 RDYaADA/5kXycAb5ovobirNlHFMYbNkVBfRWigm5LfE1WYnqXPrmhP38u+emBjTcweka0Qlar SW/MDgiTmZNE27CiHpyKWCestes5OZ2l7bNjC1Szj72aLJvl1Fq/U/wLvG7UqTVBq4IEDF8HS 4oe/Za1nBGhRCeEeBWvxEMgxDnC+PXqcH2lTMeeNFt8QA= Received-SPF: pass client-ip=212.227.15.18; envelope-from=jimjoe@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain - Make sure python info docs are installed (in Debian-derivatives, 'sudo apt install python3-doc') - emacs -Q - Open a buffer test.py and type: print - C-h S fails, even after typing RET, but... - Then do info-lookup-reset, and the previous step works. Here's a possible patch, which hasn't been tested as much as needed: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Check-for-doc-spec-function-early--in-interactive.patch Content-Description: [PATCH] Check for doc-spec-function early, in interactive Content-Transfer-Encoding: quoted-printable =46rom 81b3a7b0c2be3c974729d1a4ffc44351d5393a45 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sun, 2 Jun 2024 05:59:35 +0530 Subject: [PATCH] Check for doc-spec-function early, in interactive * lisp/info-look.el (info-lookup-interactive-arguments): Move here. (info-lookup): From here. =2D-- lisp/info-look.el | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lisp/info-look.el b/lisp/info-look.el index cd59fdf17d7..2baf133c7d3 100644 =2D-- a/lisp/info-look.el +++ b/lisp/info-look.el @@ -327,8 +327,11 @@ info-lookup-interactive-arguments If optional argument QUERY is non-nil, query for the help mode." (let* ((mode (cond (query (info-lookup-change-mode topic)) - ((info-lookup->mode-value topic (info-lookup-select-mode)) - info-lookup-mode) + ((when-let + ((info (info-lookup->mode-value + topic (info-lookup-select-mode)))) + (info-lookup--expand-info info)) + info-lookup-mode) ((info-lookup-change-mode topic)))) (completions (info-lookup->completions topic mode)) (default (info-lookup-guess-default topic mode)) @@ -404,9 +407,6 @@ info-lookup different window." (or mode (setq mode (info-lookup-select-mode))) (setq mode (info-lookup--item-to-mode item mode)) - (if-let ((info (info-lookup->mode-value topic mode))) - (info-lookup--expand-info info) - (error "No %s help available for `%s'" topic mode)) (let* ((completions (info-lookup->completions topic mode)) (ignore-case (info-lookup->ignore-case topic mode)) (entry (or (assoc (if ignore-case (downcase item) item) completi= ons) =2D- 2.40.1 --=-=-= Content-Type: text/plain -- --=-=-=-- ------------=_1717849562-12885-1--