From unknown Sat Sep 06 00:11:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71313 <71313@debbugs.gnu.org> To: bug#71313 <71313@debbugs.gnu.org> Subject: Status: [PATCH] Allow insert other elisp keywords in auto-insert Reply-To: bug#71313 <71313@debbugs.gnu.org> Date: Sat, 06 Sep 2025 07:11:05 +0000 retitle 71313 [PATCH] Allow insert other elisp keywords in auto-insert reassign 71313 emacs submitter 71313 "Elijah G." severity 71313 normal tag 71313 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 20:18:06 2024 Received: (at submit) by debbugs.gnu.org; 2 Jun 2024 00:18:06 +0000 Received: from localhost ([127.0.0.1]:57563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDYvF-00056l-LJ for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:18:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:42696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDYvD-00056d-SS for submit@debbugs.gnu.org; Sat, 01 Jun 2024 20:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDYuz-0004vr-KX for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:17:51 -0400 Received: from mail-oa1-x44.google.com ([2001:4860:4864:20::44]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sDYux-0003Hn-UP for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2024 20:17:49 -0400 Received: by mail-oa1-x44.google.com with SMTP id 586e51a60fabf-250aaae6d93so500022fac.2 for ; Sat, 01 Jun 2024 17:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717287465; x=1717892265; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=BzGPZktZg/3dnKwKxM4NBF76/BLoMp0LakGZdHG2rOY=; b=Y9JjMEsXjB+vUP7Dss5huH0HJGmJ8eOALfc8MzBbkVkN1dp9DFi3I1+Ei36UO6Fd6x 0wBXj6SLZZBkJUzO5oWGH6GIcS7a9akPyRZkNu7EbwC+vYxXs1Xuc0Y/rM49mqj1p+Sk abPigfhSZgY9OkK49PAhb3/NtS7qPq2/4c63yvUIfkykpjt7iONDwnmLRDOkIeI53Da6 aEq7vN3Ogcu5XShwxmVfx+nhM9nnOQylGLT5NNoX7OSsnUL6SCdejVGXAoy75/uqgECM mKxX50uaFCM7kt8B2JotEnBNwWfsI69q/TG+D34mX3pSPMO/S3pRiGKRi1b8WNHh6LL4 MiWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717287465; x=1717892265; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BzGPZktZg/3dnKwKxM4NBF76/BLoMp0LakGZdHG2rOY=; b=c5yknfa3nBFblpEqL2f/ls/kAB+LNWEY9dC8TSau+IqoK8LJT3TwJ1pf2/BBHkQ4uR EFMX/Huv0xKoCAuUL9lvLWJldED8VRnJIqCV4wlKPZC/eTNDxIYoWdAn2omd4klbYChS OkfFnyBLXmHNo9kWbIHjk8HBdlC5uKSHpXDcMe095sy3iUw06oT1RE002l6g2dHgxep5 yXlgY/9YIHiiTS/2IksNCUddaXd88cDtyKM6bsW9VAMmLwLTnVibpM5iITIMlwmFn/d+ KK5Bsz/6nWsBqpAgNz4vkw/s66QskYxj6w885BGvCIPxWpRqK1z7nRqp7WeM/A9fSBxJ UAUg== X-Gm-Message-State: AOJu0YwT+MEodQmlzB/3n1YGqWCDbK7077DoSK80SWPLHxq8KE7wHIIL Z5VauYcbX0qhGw5sWVw1Wk9GsORnnyUomQaAbCZrZe7AlbeRqQl+vwKPuPkb X-Google-Smtp-Source: AGHT+IFv3UGFxeL4nA+02KGce1d3dattZp/9q+N+rOD3UqnE4XaxJsoIIM9+7S17iC29wrGLTrw3Pw== X-Received: by 2002:a05:6870:528:b0:24f:e5e1:b0cb with SMTP id 586e51a60fabf-2508b9b1b0fmr5663581fac.15.1717287465103; Sat, 01 Jun 2024 17:17:45 -0700 (PDT) Received: from LIBERO ([187.184.27.187]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f9105a96c5sm882182a34.76.2024.06.01.17.17.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 17:17:44 -0700 (PDT) From: "Elijah G." To: bug-gnu-emacs@gnu.org Subject: [PATCH] Allow insert other elisp keywords in auto-insert Date: Sat, 01 Jun 2024 18:17:42 -0600 Message-ID: <86v82smc49.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4860:4864:20::44; envelope-from=eg642616@gmail.com; helo=mail-oa1-x44.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Tags: patch Hello, this little patch allow insert any package keywords when using auto-insert for insert elisp header lines. This is more a bugfix, since there is a bug when using Vertico that get stuck in the keywords part, that bug can also apply to other completion UIs or frameworks. Also there are some packages that uses non-standard keywords, i think it would be better allowing insert other keywords. In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2024-05-23 built on AVALON Repository revision: 64cced2c37a9926fe6ff1c6ad9b9540abd47e21c Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.19045 System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.4046) Configured using: 'configure --with-modules --without-dbus --with-native-compilation --without-compress-install --with-tree-sitter CFLAGS=-O2' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Allow-insert-other-elisp-keywords-in-auto-insert.patch >From 89f990c6393d90fd76efb4e3665f431d7c0300b3 Mon Sep 17 00:00:00 2001 From: "Elias G. Perez" Date: Sat, 1 Jun 2024 16:51:54 -0600 Subject: [PATCH] Allow insert other elisp keywords in auto-insert Allow to user confirm for insert other keywords than default ones when using auto-insert in an elisp file. * lisp/autoinsert.el (auto-insert-alist): Use 'confirm' instead 't' in completing-read REQUIRE-MATCH from Emacs Lisp header template. --- lisp/autoinsert.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/autoinsert.el b/lisp/autoinsert.el index f2631422c62..561626e474b 100644 --- a/lisp/autoinsert.el +++ b/lisp/autoinsert.el @@ -212,7 +212,7 @@ auto-insert-alist finder-known-keywords "\n")) ((let ((minibuffer-help-form v2)) - (completing-read "Keyword, C-h: " v1 nil t)) + (completing-read "Keyword, C-h: " v1 nil 'confirm)) str ", ") & -2 " -- 2.44.0.windows.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 01:44:29 2024 Received: (at 71313) by debbugs.gnu.org; 2 Jun 2024 05:44:29 +0000 Received: from localhost ([127.0.0.1]:57685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDe16-0005HU-NM for submit@debbugs.gnu.org; Sun, 02 Jun 2024 01:44:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDe14-0005H8-Gs for 71313@debbugs.gnu.org; Sun, 02 Jun 2024 01:44:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDe0m-0003FH-UP; Sun, 02 Jun 2024 01:44:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ahcMsQ7XfA6K73jbe2qqD8JdMdCJ3P/BPjBLQMmyEEQ=; b=lTNGtlHSFA0r 5lDmvLdNUno0M6U7RRtOEtTotmS+k1iQQbRxVS2YD35MfL2BX34fX1mPMZbXQa7phqfgrfj7Aljvc qoQVdHmRsnvu8t9SOIlImVpXGScvh5mVRTLLoY7FQFncHOO3pyKX/ewaXZSLBgkSdcGGxw2/Zhiwj FNoz8QUWAubTfJELsm/25BmsZngf8WG1wqd9HbaBZmzMW+n45M2tHTxbZnFsM72MWVJEmQsAX4m+s SIdfQVSKyXHXKct7alvCdu+HLam1P0kzFNBgPnaa9Y1FiZR0iLYyxt/6H0zgnIxvCJ45IDxjvDSMK OArTxMqKEhC47BF//lsvPA==; Date: Sun, 02 Jun 2024 08:44:05 +0300 Message-Id: <8634pvoq56.fsf@gnu.org> From: Eli Zaretskii To: "Elijah G." In-Reply-To: <86v82smc49.fsf@gmail.com> (eg642616@gmail.com) Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert References: <86v82smc49.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Elijah G." > Date: Sat, 01 Jun 2024 18:17:42 -0600 > > this little patch allow insert any package keywords when using > auto-insert for insert elisp header lines. > > This is more a bugfix, since there is a bug when using Vertico that get > stuck in the keywords part, that bug can also apply to other completion > UIs or frameworks. > > Also there are some packages that uses non-standard keywords, i think it > would be better allowing insert other keywords. I'm not sure why it makes sense to allow keywords that are not in finder-known-keywords. Such a keyword will never be used by any finder commands. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 23:15:55 2024 Received: (at 71313) by debbugs.gnu.org; 3 Jun 2024 03:15:55 +0000 Received: from localhost ([127.0.0.1]:36127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDyAt-00043J-Ez for submit@debbugs.gnu.org; Sun, 02 Jun 2024 23:15:55 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:52677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDyAs-00042x-3F for 71313@debbugs.gnu.org; Sun, 02 Jun 2024 23:15:54 -0400 Received: by mail-oi1-f193.google.com with SMTP id 5614622812f47-3d1d65a471aso2309757b6e.1 for <71313@debbugs.gnu.org>; Sun, 02 Jun 2024 20:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717384475; x=1717989275; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vOP9QgQHH0Bl925cNtPFXSPoU/eQI45nWRIgFh2srjI=; b=AKWvNwSt1hNCDKLPATMbJxlZZD9vKTyhq9ajfvVTWKYFfyCSZxTGcExjmqaHrUf+p5 gXI7UZkoiolM9dikEazrIpprQwPBKLUw6CjKGbSIXtD1RZ8nz1bSGJ7JTGkx9Vbh4f8z IcTql04wtT3VzcEoYcyzdkO5OecPWIv2Jon7f1W29/pdBpxjYo699CGXF+MxEC0KdEt/ jYKhnux3rlxcaZFcMYOulrtfNUtwkxJ9Nx1qsU0DduaNrWeAEnsJiF9hlkPVkfJ2uoZz Gsjrf4JUmGrX6FTJecUS7XPe06LvOJhxXH49CDoIww4UJVCG2nL0UauNnAzcfioYL0JH 1Miw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717384475; x=1717989275; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vOP9QgQHH0Bl925cNtPFXSPoU/eQI45nWRIgFh2srjI=; b=RM113DSSCG2rqEdmqmWvDyLjBBvN0PdzEKdKIbMXmxWdtff8WgK8SmwgRlECZ2kmGD Ry2U1iM93sHg5Ufywn4m3KdkSq5y69Gm5whZ1Ljk3KOw78YBZ19eOO15P/8qGTU4xwTU FMxc7/Q6yZ+i5kNyBoR69/iQv+602dCBjq71zGcZOGl+9yAIfmqstLfO446UXXWkd79b y8AFO5etsz+mlexhflz9OuvBZMDIlYpHDur2yJ/dUVAEg8NOJVKXj6WNXX/s5Xvqk7rc cwC4SE/KkxPVbRMWT3bo50EaAws9ua1CFyQb6jqROrBtFp4bVJ3zm2PngqA9DJc0pKsn WGhA== X-Gm-Message-State: AOJu0Ywt7BQD9R/Tk0oZOYajDydHsFWYyS+nzaFSnriFLdvTFWQk2KOE IR3OS3zJ2OKzy+C2ZJmQRcIdm+9E59ichPdmkh853Oyj3Q/1R2UfqATejeQ+ X-Google-Smtp-Source: AGHT+IHiElfG+rh0+tKHV3dVvE/V3VH6rPxRB0ueNNZZOdDiqvui+I7fU7YueYO3ygdvR7lwWRP3GA== X-Received: by 2002:a05:6808:16a8:b0:3ce:cd76:30bc with SMTP id 5614622812f47-3d1e3476e76mr10093130b6e.9.1717384475390; Sun, 02 Jun 2024 20:14:35 -0700 (PDT) Received: from LIBERO ([187.184.27.187]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3d1e1a0724dsm1153725b6e.34.2024.06.02.20.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 20:14:34 -0700 (PDT) From: "Elijah G." To: Eli Zaretskii Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert In-Reply-To: <8634pvoq56.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 02 Jun 2024 08:44:05 +0300") References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> Date: Sun, 02 Jun 2024 21:14:34 -0600 Message-ID: <86mso23eg5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: "Elijah G." >> Date: Sat, 01 Jun 2024 18:17:42 -0600 >> >> this little patch allow insert any package keywords when using >> auto-insert for insert elisp header lines. >> >> This is more a bugfix, since there is a bug when using Vertico that get >> stuck in the keywords part, that bug can also apply to other completion >> UIs or frameworks. >> >> Also there are some packages that uses non-standard keywords, i think it >> would be better allowing insert other keywords. > > I'm not sure why it makes sense to allow keywords that are not in > finder-known-keywords. Such a keyword will never be used by any > finder commands. You are right, I think I've found a better way for this bugfix. Please see the new patch attached below, thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-autoinsert.el-auto-insert-alist-Allow-empty-inp.patch >From 2f7f3647e2f623f3fc20fab4d130a66e191f360d Mon Sep 17 00:00:00 2001 From: "Elias G. Perez" Date: Sun, 2 Jun 2024 20:59:23 -0600 Subject: [PATCH] * lisp/autoinsert.el (auto-insert-alist): Allow empty input in elisp Allow insert empty string as initial input. This should fix bugs from 3rd-party completion UI. --- lisp/autoinsert.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/autoinsert.el b/lisp/autoinsert.el index f2631422c62..9418590aaee 100644 --- a/lisp/autoinsert.el +++ b/lisp/autoinsert.el @@ -212,7 +212,7 @@ auto-insert-alist finder-known-keywords "\n")) ((let ((minibuffer-help-form v2)) - (completing-read "Keyword, C-h: " v1 nil t)) + (completing-read "Keyword, C-h: " v1 nil t nil nil "")) str ", ") & -2 " -- 2.44.0.windows.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 08:10:21 2024 Received: (at 71313) by debbugs.gnu.org; 3 Jun 2024 12:10:21 +0000 Received: from localhost ([127.0.0.1]:34567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sE6W5-0002pG-6O for submit@debbugs.gnu.org; Mon, 03 Jun 2024 08:10:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sE6Cu-0007YE-BT for 71313@debbugs.gnu.org; Mon, 03 Jun 2024 07:50:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE63D-0003cH-AR; Mon, 03 Jun 2024 07:40:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ba9yuvDO0EqAFwSKbrq+3k2+pcc6pAR7yZi8FnZ4ynM=; b=bHXBXvSW1HwQ IcTKVQm2yJ688t4apl4h/qjGm/d5ftnQV1W8ddc0xMbnpFbLRxGerRiTqtPxavab8jPpjqwehxOMb k1hi5LZTLOagCfj1ZUpJk3Ur94fTVDQiVx7zadxuD+XUeuXF91pTIP0/3Wj1A0F2DcjHClMLKUEBn V0shaZ5Jumem+ws3GKVo0mwbCPEnllLK+/sKGWtebR5x2aoaYbUwZuzFyKZVYZKkQ1x2vFPZ4qYnO mOMOzR7A8y3pgUTn2LujiqebfAvlLURDC/f13EAYlyy7AXZK3V9847GvWlERHE+oh63T1d0HDpZdf bsDJwswIvrNM0Lq505vDMg==; Date: Mon, 03 Jun 2024 14:40:23 +0300 Message-Id: <8634pumezc.fsf@gnu.org> From: Eli Zaretskii To: "Elijah G." , Stefan Monnier In-Reply-To: <86mso23eg5.fsf@gmail.com> (eg642616@gmail.com) Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Elijah G." > Cc: 71313@debbugs.gnu.org > Date: Sun, 02 Jun 2024 21:14:34 -0600 > > >> From: "Elijah G." > >> Date: Sat, 01 Jun 2024 18:17:42 -0600 > >> > >> this little patch allow insert any package keywords when using > >> auto-insert for insert elisp header lines. > >> > >> This is more a bugfix, since there is a bug when using Vertico that get > >> stuck in the keywords part, that bug can also apply to other completion > >> UIs or frameworks. > >> > >> Also there are some packages that uses non-standard keywords, i think it > >> would be better allowing insert other keywords. > > > > I'm not sure why it makes sense to allow keywords that are not in > > finder-known-keywords. Such a keyword will never be used by any > > finder commands. > > You are right, I think I've found a better way for this bugfix. > Please see the new patch attached below, thanks. Thanks, but how will an empty string "fix bugs from 3rd-party completion UI"? What am I missing here? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 04 20:55:46 2024 Received: (at 71313) by debbugs.gnu.org; 5 Jun 2024 00:55:46 +0000 Received: from localhost ([127.0.0.1]:38902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEewM-0005p2-13 for submit@debbugs.gnu.org; Tue, 04 Jun 2024 20:55:46 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:44115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEewJ-0005oc-67 for 71313@debbugs.gnu.org; Tue, 04 Jun 2024 20:55:44 -0400 Received: by mail-ot1-f65.google.com with SMTP id 46e09a7af769-6f9390ab86eso905584a34.0 for <71313@debbugs.gnu.org>; Tue, 04 Jun 2024 17:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717548863; x=1718153663; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=3EAWV6yltF/WWvp5uNHGAZeB3ttV+hpsRlavInrklHQ=; b=dbE+ah5T+PN5MTezgMmDebpC/fWWFcH4cVBKLCYj4/wr7lwztxkITY8oGU+JIkJ6gI 7OOuvyeNJxVgBwIpOQ4d9KwQ+75qgtOowSNBfExazc3AD0xHpGjbCLIC/MQnANqHACTp 2ArINva5COBhi5sNGYFOM4N+939GH5eU13K+q6UQlP/QQJTRuSxjvF2QTpO7ahTdYxhL c8KpfuaRLIprx8qZmBnKA+VT4FMWMn0K0kJXVPmiuE0pjiQwuuoUIbS0oCuDFE3BUb/8 7ZMttPPZ+bCq3gifOQWtoXDbbAd6XPYKQ6wsE+nE32FkRUydcnkPXSyvla+uPZldbAcK QciQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717548863; x=1718153663; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3EAWV6yltF/WWvp5uNHGAZeB3ttV+hpsRlavInrklHQ=; b=Wl5UfRTirv1aOvId05Ab+fRdtHApQaLKsiWqb7fq36+z26CAanFg7xMJGZu9cjy/v9 zqq5Lvtdg4JymkPSe4rWU3cyjRXG1yZYJaqCS07W6bmanLcRwubZCUnSKYTI0uuMLk1X jSEWx8fpE8ewKgsFIty2ZM6avSoQ7wRzcsNPPyZzeSscUYIb4K6vNsd4Y/yCUUzd5JNk PcKKcZBumz9NH8VFn/Jjx/Iq9l+2zJGPpsBm5jchOd5CJJEyaXOnOSYQV825wz9TCYLu cWarM+Do4VFgbXMulwH1RMQ5VXVnIlHuhjTs8r4JsB19O9KTSBFvySlt6AEtdCOH5dxM o8+A== X-Forwarded-Encrypted: i=1; AJvYcCVSB2JhwfoW4n497McQ5cQ0M9MHsf4l4YryZ8CHOrQViRiui/G4bVNK2ldpvIwXqsu0c0g9jc1rItUXm351hRnHTZCqoNk= X-Gm-Message-State: AOJu0YwyPpHmt4wPyLbQiu2JjCT0Pq2D6sjHsKsDyLBQxBeF/Ufl/iGS TgO+8u83uS7VtFnaNKeh/TegW7ucUv06hmIfJf5Tz7c9Gd92XASYxrD63tUx X-Google-Smtp-Source: AGHT+IHtaWPXwCRMWzPJvEEeCbUSmmnv9jPE7FPFN7zcxll5/B8oDdnA8SiBQfWE2zmMuvQqoBXTuA== X-Received: by 2002:a05:6870:a446:b0:24f:c715:a4d4 with SMTP id 586e51a60fabf-25121fec152mr1448385fac.40.1717548863179; Tue, 04 Jun 2024 17:54:23 -0700 (PDT) Received: from LIBERO ([187.184.27.187]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-25084f9a381sm3643171fac.18.2024.06.04.17.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 17:54:22 -0700 (PDT) From: "Elijah G." To: Eli Zaretskii Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert In-Reply-To: <8634pumezc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 03 Jun 2024 14:40:23 +0300") References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> Date: Tue, 04 Jun 2024 18:54:19 -0600 Message-ID: <86wmn4ky4k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: "Elijah G." >> Cc: 71313@debbugs.gnu.org >> Date: Sun, 02 Jun 2024 21:14:34 -0600 >> >> >> From: "Elijah G." >> >> Date: Sat, 01 Jun 2024 18:17:42 -0600 >> >> >> >> this little patch allow insert any package keywords when using >> >> auto-insert for insert elisp header lines. >> >> >> >> This is more a bugfix, since there is a bug when using Vertico that get >> >> stuck in the keywords part, that bug can also apply to other completion >> >> UIs or frameworks. >> >> >> >> Also there are some packages that uses non-standard keywords, i think it >> >> would be better allowing insert other keywords. >> > >> > I'm not sure why it makes sense to allow keywords that are not in >> > finder-known-keywords. Such a keyword will never be used by any >> > finder commands. >> >> You are right, I think I've found a better way for this bugfix. >> Please see the new patch attached below, thanks. > > Thanks, but how will an empty string "fix bugs from 3rd-party > completion UI"? What am I missing here? When using Completions UI such as Vertico or Helm, there is no way to exit from Keyword Section to go to next auto-insert Sections unless the user press a key sequense, for auto-insert input a empty string allow close Keyword section without cancelling the next auto-insert actions. This can be more a problem with `completing-read' than Completions UI, that is why setting an empty string as default value fix this and can fix this similar issue to other completions packages. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 01:24:23 2024 Received: (at 71313) by debbugs.gnu.org; 5 Jun 2024 05:24:24 +0000 Received: from localhost ([127.0.0.1]:56640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEj8J-0000pA-Ii for submit@debbugs.gnu.org; Wed, 05 Jun 2024 01:24:23 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:38406 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEj8H-0000ow-Rb for 71313@debbugs.gnu.org; Wed, 05 Jun 2024 01:24:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1717565047; bh=zq1fjWjNpMu2ccJW5BGgm5nj+B4laS04c2y6xmukVps=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Q5htcLUY45Yw22NvJcQEl3MXNs5OJHc/421AuUx0ivDZ0/HhFxxIwoxZwvD7QREkD R9u/8/P4gAFgNIrk0zBR42aL3eZfz9ktXRLvcGUxHYhrCASra3gu9mY17FMpIkUKd5 H7hisHTnQM+v+UdSp8P0i7aopJQsf+Y2cXIDUrYL2DWOCMvnyflWWSPjVkcVlRqErt QXBzVpJRS+KgI+wP+nLKbwbodP/99cklsQiSAHF6ZmKPXI46lwwJo6nVQQXMtUcNTJ KrjdG2TCeAxS/o5KirxMkkCaEt/Oy6ez2v6eRvl2ovtpmELj3sqDE4Lt+tPZeNfg1A rJ3geNV8jMUxA== From: Eshel Yaron To: "Elijah G." Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert In-Reply-To: <86wmn4ky4k.fsf@gmail.com> (Elijah G.'s message of "Tue, 04 Jun 2024 18:54:19 -0600") References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> Date: Wed, 05 Jun 2024 07:24:04 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Elijah, "Elijah G." writes: > Eli Zaretskii writes: > >>> From: "Elijah G." >>> Cc: 71313@debbugs.gnu.org >>> Date: Sun, 02 Jun 2024 21:14:34 -0600 >>> >>> >> From: "Elijah G." >>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600 >>> >> >>> >> this little patch allow insert any package keywords when using >>> >> auto-insert for insert elisp header lines. >>> >> >>> >> This is more a bugfix, since there is a bug when using Vertico that get >>> >> stuck in the keywords part, that bug can also apply to other completion >>> >> UIs or frameworks. >>> >> >>> >> Also there are some packages that uses non-standard keywords, i think it >>> >> would be better allowing insert other keywords. >>> > >>> > I'm not sure why it makes sense to allow keywords that are not in >>> > finder-known-keywords. Such a keyword will never be used by any >>> > finder commands. >>> >>> You are right, I think I've found a better way for this bugfix. >>> Please see the new patch attached below, thanks. >> >> Thanks, but how will an empty string "fix bugs from 3rd-party >> completion UI"? What am I missing here? > > When using Completions UI such as Vertico or Helm, there is no way to > exit from Keyword Section to go to next auto-insert Sections unless the > user press a key sequense, for auto-insert input a empty string allow > close Keyword section without cancelling the next auto-insert actions. FWIW, I'm not sure I understand the problem: I just tried using Vertico to fill in a new .el file with auto-insert, and ISTM that in the Keywords step both C-M-m and C-M-c already work as expected and let you continue to the next step. Best, Eshel From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 07:48:06 2024 Received: (at 71313) by debbugs.gnu.org; 5 Jun 2024 11:48:06 +0000 Received: from localhost ([127.0.0.1]:55071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEp7d-0001Z2-Ec for submit@debbugs.gnu.org; Wed, 05 Jun 2024 07:48:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEp7b-0001Xs-8y for 71313@debbugs.gnu.org; Wed, 05 Jun 2024 07:48:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEot0-0004rr-8g; Wed, 05 Jun 2024 07:32:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1gpHR3TVTZtgNUr9kaksP7ymP0zsWLnyrDjzU/5zyMg=; b=gy7JNu1mqVxB hgtYo/4BDugHUe0mzVXBPPId+yvrdOyUIH4Q9t0vcaBvh4KDGy/Q3vsi6dVBsH1aGpjaNB/wSzM/Y FslnfGZ+V7BKdqNnvoWf3K1sX67oeFbRTY5DecMdaues5e8bkltabqlhGuIZChZL9b5zxICk/mdPJ AoWrsdkKProSfAlWDBYeYjqdwNBu1JIs9L0MOSemNuZxQ9+PNPHlN0ixMzBbubp1uFCb6aHNHcxIU rYI5ZnUEFx4hwzN1GwpaX3qagqFTAER4peuI1dbQfzGXajD0DumhvDKMK82lVGYDhTsur6zrBpIES G9jJ3cCGsAVSggr58CNRfQ==; Date: Wed, 05 Jun 2024 14:32:54 +0300 Message-Id: <86le3jk4k9.fsf@gnu.org> From: Eli Zaretskii To: "Elijah G." In-Reply-To: <86wmn4ky4k.fsf@gmail.com> (eg642616@gmail.com) Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Elijah G." > Cc: Stefan Monnier , 71313@debbugs.gnu.org > Date: Tue, 04 Jun 2024 18:54:19 -0600 > > Eli Zaretskii writes: > > > Thanks, but how will an empty string "fix bugs from 3rd-party > > completion UI"? What am I missing here? > > When using Completions UI such as Vertico or Helm, there is no way to > exit from Keyword Section to go to next auto-insert Sections unless the > user press a key sequense, for auto-insert input a empty string allow > close Keyword section without cancelling the next auto-insert actions. But why would the user want to exit the Keyword Section without inputting keywords? And why are Vertico and Helm special in this regard? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 01:12:33 2024 Received: (at 71313) by debbugs.gnu.org; 7 Jun 2024 05:12:33 +0000 Received: from localhost ([127.0.0.1]:47904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFRtw-0004j7-Kh for submit@debbugs.gnu.org; Fri, 07 Jun 2024 01:12:33 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:50222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFRtu-0004id-4B for 71313@debbugs.gnu.org; Fri, 07 Jun 2024 01:12:30 -0400 Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-44025bb945dso9123631cf.0 for <71313@debbugs.gnu.org>; Thu, 06 Jun 2024 22:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717737069; x=1718341869; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0crT2dGkKPXFK48+/e/PmEJ8srgQipsRL86bKuWr1XU=; b=V+SyUz6eu0/c8qVEEo7EEg8sTCvdEZWz/QT+c/Jx68aIGpH1mJtTafNVcEUOXoHTBc TRzPHvuIKBkTZ9vbNBR4iXjDxsCyjP8I5S1aBYVIl9jiQPzQR5nYf1XRjYRFpGx/FYIw hBWatpyxE9lhJeG/DqFh4sn0NSwM9E6fNAN6Ql7VLT/C4W5i9L6xwe8n97DKvhoymM6Z ak3iaSzSOYndslLhCtFszXf3Wql32qsr8GwC8/pq9maFWAB5JlI3Dhu5tUbHIVVWwxG8 1fTfh3lHc7xuZ3h5zOcaWQBURko23KvrPrqMeibIiPSzVMDmJJVOuzA9mVbPIRAWOQBg 9Wvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717737069; x=1718341869; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0crT2dGkKPXFK48+/e/PmEJ8srgQipsRL86bKuWr1XU=; b=F1bT6EJ7fdb8/x9lN/bHMTDyZwLtqinMUNa5FpNKyK7fGLVrqHIhj438dmIa4shwT6 h+fakwyHhyZKWF1uANBjFGWwn1vfrIHbDgWaAzYINcvu8EjzQFvGwIDJx2khTn8ShYNs JL2p6XK/7mny22sfqWruxs4mOW94BDh17cDLOG/tFyayG+rim8eqU/OfrqsHog3ckoVd 3OTV+fZ+Xy+NOTOM5Eq7sYtQl+C+rybu/+w7/WXwT2LWOwF9YM+CG5+4LJY93cj0Uj4O C3tz4/86OP7uV+j0fiZcQiqq3bJjQmSzB/xVkybqvrbVuzq1y09l/FFBWbWvW8WxvnSh CUyw== X-Forwarded-Encrypted: i=1; AJvYcCVcvJsSwY57MjEZZuAfwCMINlxw182bKGoHMCLUqbkRaxH3pTYo19iyRq4Ca800zIlwIiJRgBqRaf1ZbHcpXRXAKbnkYg8= X-Gm-Message-State: AOJu0Yy08iQ6lfM9RN7cMLEanPhPm0Mf0gGXIYHAo0SYFf38xkD2MByI LJJpxDyohyrZkINccs1AkZT8ukv3Kn2in0fHm+OtD4JrxqUrB2QJswOobLaZLUPGEHwi3lM95cB jwNDhSYyOuI4dPke/1EywDC9Zcrs= X-Google-Smtp-Source: AGHT+IG/ywcPai71vebI7D+xmRRQVPCJW4OqZRQBGW6TmC22DhzJv9YYJSL8yn3dGSrw+7MYLal2JzWX64U4hPapfi8= X-Received: by 2002:a05:622a:180b:b0:440:28b3:450e with SMTP id d75a77b69052e-44041c28441mr19880601cf.12.1717737069319; Thu, 06 Jun 2024 22:11:09 -0700 (PDT) MIME-Version: 1.0 References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> <86le3jk4k9.fsf@gnu.org> In-Reply-To: <86le3jk4k9.fsf@gnu.org> From: Elijah G Date: Thu, 6 Jun 2024 23:10:54 -0600 Message-ID: Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000d59f3b061a45d340" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000d59f3b061a45d340 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El mi=C3=A9., 5 de junio de 2024 5:32 a. m., Eli Zaretskii escribi=C3=B3: > > From: "Elijah G." > > Cc: Stefan Monnier , 71313@debbugs.gnu.org > > Date: Tue, 04 Jun 2024 18:54:19 -0600 > > > > Eli Zaretskii writes: > > > > > Thanks, but how will an empty string "fix bugs from 3rd-party > > > completion UI"? What am I missing here? > > > > When using Completions UI such as Vertico or Helm, there is no way to > > exit from Keyword Section to go to next auto-insert Sections unless the > > user press a key sequense, for auto-insert input a empty string allow > > close Keyword section without cancelling the next auto-insert actions. > > But why would the user want to exit the Keyword Section without > inputting keywords? And why are Vertico and Helm special in this > regard? > I didn't mean to exit without input any keyword, after inserting the keyword it will ask again for add more keywords, the problem is that It's an infinite loop that it's not possible exit without pressing any keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK Vertico (and helm according to some commentaries) have this problem because they use strictly the completing-read completion table for their candidates when require-match is non-nil, the patch can be applied since it is just a little change without any side-effect. I think i will need to change the commit message for the patch, because it can misunderstand. > --000000000000d59f3b061a45d340 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
El mi=C3=A9., 5 de junio de 2024 5:32 a. m., Eli Zaretskii <= ;eliz@gnu.org> escribi=C3=B3:
> From: "Elijah G." <eg64= 2616@gmail.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,=C2=A0 <= a href=3D"mailto:71313@debbugs.gnu.org" target=3D"_blank" rel=3D"noreferrer= ">71313@debbugs.gnu.org
> Date: Tue, 04 Jun 2024 18:54:19 -0600
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Thanks, but how will an empty string "fix bugs from 3rd-part= y
> > completion UI"?=C2=A0 What am I missing here?
>
> When using Completions UI such as Vertico or Helm, there is no way to<= br> > exit from Keyword Section to go to next auto-insert Sections unless th= e
> user press a key sequense, for auto-insert input a empty string allow<= br> > close Keyword section without cancelling the next auto-insert actions.=

But why would the user want to exit the Keyword Section without
inputting keywords?=C2=A0 And why are Vertico and Helm special in this
regard?

I didn't mean to exit without input any keyword, after inserting= the keyword it will ask again for add more keywords, the problem is that I= t's an infinite loop that it's not possible exit without pressing a= ny keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK Ver= tico (and helm according to some commentaries) have this problem because th= ey use strictly the completing-read completion table for their candidates w= hen require-match is non-nil, the patch can be applied since it is just a l= ittle change without any side-effect.

I think i will need to change the commit message for the patc= h, because it can misunderstand.
--000000000000d59f3b061a45d340-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 07 01:46:13 2024 Received: (at 71313) by debbugs.gnu.org; 7 Jun 2024 05:46:13 +0000 Received: from localhost ([127.0.0.1]:50535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFSQW-0006Pp-Ln for submit@debbugs.gnu.org; Fri, 07 Jun 2024 01:46:13 -0400 Received: from mout02.posteo.de ([185.67.36.66]:37511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFSQT-0006PM-Bk for 71313@debbugs.gnu.org; Fri, 07 Jun 2024 01:46:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3638B240101 for <71313@debbugs.gnu.org>; Fri, 7 Jun 2024 07:45:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717739148; bh=2azXy+BqaXWma4KXzLNxRb8Q/3NfNm9II6KBkYy5dco=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:Autocrypt:OpenPGP:From; b=OD1ci2MYGkyvrUIEgMOvMrWy5KU+PWCP7F0SvxhNw2IKo9ecaOTn4pRK3wzd13K5A Flnyc6yoRdEDX4bxMJrt+aWWXpNGEF5V/trJyWox7D69JfQvStCukLhiXQvfSq16Rq ReNILYBeBxaVDO1GVMYWUSBjEuBQZy4b7qCT/dBbkXP+ain0i86WcrtMDDWZLpuGBm Lsw8aHn6/Nz+NuuXaCfCPsdc4H5nVyUI7bcDivrowcReLQ7cWewWyGKfFLjK0CuI3V 9I83tecItGmBcw7F5AnfqkzoqJMDxE/d9mkgUwI/Kv2C9ssL97Amh8r4v9vQt5zNKz KQzTvKMJZY3SA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VwVY56Rwwz6txL; Fri, 7 Jun 2024 07:45:45 +0200 (CEST) From: Thierry Volpiatto To: Elijah G Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert In-Reply-To: (Elijah G.'s message of "Thu, 6 Jun 2024 23:10:54 -0600") References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> <86le3jk4k9.fsf@gnu.org> Date: Fri, 07 Jun 2024 05:48:20 +0000 Message-ID: <87cyote21n.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaAtdXm5bYnSHsnL7cx8z7lukA/ EsJocE+GD7QXnsrdlicvdobI0TEN4l73221a72oCvHfYLCVsB6YsNJ5ZGkA1zSjzln5uLAgZ/2r/ aqlao/AlSZkAk6+hvK0RyAZ/YR4YRZxO8Fsd0gWgFkanRfKfufJ1V0OHZg7yszi3q/hRzS+rZtJ0 OuzDlh/dyQkxVkZb9vis/+HnGDJrBE5MsmJLcy2Sy3uUnio0fq8q9CrZbudvd1DajlZxPzTm0csP eUk45QEgbhEU7MfyAX/mkKxjHajz2cMcHKIap1BqEgJl4BKFeLMcBZ4O1p9ivwtf1Ht2JTp5lOi0 ItPfhQ4DP8LZ1ZIkN5Kg9v0cyw9meRzAuuR0V2GtzsDNBF8ylcIBDADnIDHEkmk4lUwTlOhwb2yj UfmGPnpH3MCCHkjM9H/P1gTHxFWtwFVPcNMCwXWvKSBTF2dZXKERD0yzG06zT53ZMN7EIIeuY6m4 R8IcMvpohciisWxbFoB4ZY117tVSeqjo946itgbpdeESKl9a8dpn7ytZMyYxPdojlQAqxeAJ8444 raESh1oTKXb64hlk4l2pSRlrLgjpJBo8asAfZndaxIUKhw68tV8sqeZh9P6cGtHbUELKVJqefNV7 V7jF5wf3xvRG6Ces3kSKXalLfs+vrVaoOjQeWrc0AtwFWHmt9JLfKrqF+Q2Q7jUidboWmazQM56E SJFPpPHmWq8k6DHspsFHOforLouTHJL1556IPne7IV2BGfWc0+xLxalZ8F5F+vnPF/OkrC1CD5iC KTjXKa2iZbcYdYQAiL6P8Ac8CgN6EkhpbxRtzrEgChuNGevdi/G/GHG4Zqrh6YFwIa/NHq2aVaFq 5C1yNTMJd1FRjRzs5JPPlJKpYDnNx+MSp7UAEQEAAcLA9gQYAQoAIAIbDBYhBCPbcH0Te6954oP8 cA7FbRQdFu+TBQJi9x1ZAAoJEA7FbRQdFu+To6QMAIcvUSiFwCIggxkmYy3ZY0QAMLmIPga8DNPM XbfSOBDb2KLGBd+FAA8p2GExpul4r6kOYnGogtojByHmVgrd30/3ZURTM8Vj51wwD05viMZccQHl Wd9J/qZIvhBJlJWYnwVxh+2Kg4/hkx7SGc7JJS5GS37+PFQOJHPGMxc+fe4Ty2FdjIOVf3P1Hov9 K6yBI7Af66qqcL3aKJ4jJidRYN8sMaKOqEu4rcSpTxp8/3Ddbs9HezUgXeUzOLJMcEYFlvCyC8ZS l/QDZmpobKbxZ1JAqZM8lnmcZYSV7OsWnxJIYDV1gH5LTLj7bGswXaB4B+qkckihWkRZixu8q1IK 0c/xwUzyF092uFRM/sQKrSmnwA1+hQiiIuEl4XVz5li0/TmMta3ijUM7GNbl2IjioTRxWWecwad1 mNHvKTcXPsKDAbHFdLvQzurnroBHQV0jSPNLTP5Suo7RnLbehfg5INpGjToCUlrd2qQqgXW7h5qZ TgUq5UmBc7YZ0JYWQgPTbQ== OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Elijah G writes: > El mi=C3=A9., 5 de junio de 2024 5:32 a. m., Eli Zaretskii > escribi=C3=B3: > > > From: "Elijah G." > > Cc: Stefan Monnier ,=C2=A0 > 71313@debbugs.gnu.org > > Date: Tue, 04 Jun 2024 18:54:19 -0600 > > > > Eli Zaretskii writes: > > > > > Thanks, but how will an empty string "fix bugs from 3rd-party > > > completion UI"?=C2=A0 What am I missing here? > > > > When using Completions UI such as Vertico or Helm, there is no > way to > > exit from Keyword Section to go to next auto-insert Sections > unless the > > user press a key sequense, for auto-insert input a empty string > allow > > close Keyword section without cancelling the next auto-insert > actions. >=20=20=20=20 > But why would the user want to exit the Keyword Section without > inputting keywords?=C2=A0 And why are Vertico and Helm special in this > regard? > > I didn't mean to exit without input any keyword, after inserting the > keyword it will ask again for add more keywords, the problem is that > It's an infinite loop that it's not possible exit > without pressing any keybinding for insert an empty string (e.g. M-RET > in Vertico), AFAIK Vertico (and helm according to some commentaries) > have this problem because they use strictly the > completing-read completion table for their candidates when > require-match is non-nil, the patch can be applied since it is just a > little change without any side-effect. You can exit the minibuffer with empty string in Helm with C-RET. --=20 Thierry From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 00:42:02 2024 Received: (at 71313) by debbugs.gnu.org; 8 Jun 2024 04:42:02 +0000 Received: from localhost ([127.0.0.1]:39122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFntx-00023J-T4 for submit@debbugs.gnu.org; Sat, 08 Jun 2024 00:42:02 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:42375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFntv-00022i-Mm for 71313@debbugs.gnu.org; Sat, 08 Jun 2024 00:42:00 -0400 Received: by mail-vk1-f194.google.com with SMTP id 71dfb90a1353d-4eb0ae42c7bso1444429e0c.1 for <71313@debbugs.gnu.org>; Fri, 07 Jun 2024 21:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717821638; x=1718426438; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ouP4k7MgNhtbYr73320NA7x5gx99BWcuBsTPyPknCGo=; b=JpVFYMhYQ8nSZY2+r5LbG/CEQ73fViDolck+uFmkX4qLXAODYvBowsND9yrey3sNJY GXn5ZyjAr2/PsSTJZZXOMvFZHQ7aVAciaBoknWeYRnb2gHR1R9L88TZbGP6vCZcLm8bw mKVk0eern7RZizBiuLSumkypq5/2zVwQ6cP2naIjQxChLyBHM0Nc19yD1LGpOOfmrcbR HyPuUtXgne/bcGVTpYeEODxbNta0UQ3h1g6PWKdBdq+kp3zajaReFGMsm9qXMRbXFAmI 04Yfp10ooQ8A53Dvbx91KWVOIw5KWmQZnsUttDkja6S7S79D0xluVtEeZ6IbTK0Mie35 QHJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717821638; x=1718426438; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ouP4k7MgNhtbYr73320NA7x5gx99BWcuBsTPyPknCGo=; b=UtKOgIlLVGsKHw3P3zq9ZuG6Chw0Cbau9JZCQe5pIrWlwqr+Z9P0dM4ouLRXeQhRrG CZVn49ezK0kgfyDeWSxiagFEiNpv9CfN6cUcR8F2+XotQoId3/ox6p+WIVSlLpDx8Yoh sYobwV9tm7uiQfeGG0WG/WmEATeqjgSm8OqkE+hhbbXSaODlIxzvqyTgJKlY5glb9tFa JLf11TMYkqp2O6KKQq1lzxV62Vpf8yuHt2S2ZGRpKjgbOnD7Q1vcQ32Z5rhsklbKyeBN DJubnHCBFjqCJ24foLif6Cnb2k9S9iJ7WoodhhUl9bk+//BrNjOfKfsMe6Ky45X5DJm2 RnBg== X-Forwarded-Encrypted: i=1; AJvYcCWD1JfaQKZJnvd3h3Teghlh4+J1hD1lieQCf4FOZ+xIYVRm6NGNv6IgFs9p/ciyqAgzbfu9PnQgfVMxGUGzZFkE3fMyRcw= X-Gm-Message-State: AOJu0Yw8ImCpwciUqfC6k8b/u8xkMeFce1EvHQEnESIBreJ72olJERcv UbfQjn1beS83/D8vVo3oOxqfKGAAD3XwnW2t1rRQRinNeVYYwqPW7zehv7dRQ2ui/V4WBOOZQ4+ iWsI7tm/Qg0kJpUFMG2KSOCM0bdB1/oj5 X-Google-Smtp-Source: AGHT+IFQIcS7RHc4sYB/FM5S0s7L2NyXmvuOTK5E+7ojjrP6i8kzZAeGiD2RhexOU9bgFmEuBm4T2gtEzSuWkDya8Fc= X-Received: by 2002:a05:622a:1388:b0:440:2a5b:ed6 with SMTP id d75a77b69052e-440361fbc96mr127621831cf.5.1717821179313; Fri, 07 Jun 2024 21:32:59 -0700 (PDT) MIME-Version: 1.0 References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> <86le3jk4k9.fsf@gnu.org> In-Reply-To: From: Elijah G Date: Fri, 7 Jun 2024 22:32:47 -0600 Message-ID: Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000002e4d5a061a59695a" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 71313 Cc: 71313@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000002e4d5a061a59695a Content-Type: text/plain; charset="UTF-8" I think this can be closed since this is more a problem with Vertico (and probably Helm) as far as i could see. --0000000000002e4d5a061a59695a Content-Type: text/html; charset="UTF-8"
I think this can be closed since this is more a problem with Vertico (and probably Helm) as far as i could see.
--0000000000002e4d5a061a59695a-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 08 09:27:18 2024 Received: (at 71313-done) by debbugs.gnu.org; 8 Jun 2024 13:27:18 +0000 Received: from localhost ([127.0.0.1]:37900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFw6H-0005bd-OF for submit@debbugs.gnu.org; Sat, 08 Jun 2024 09:27:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFw6F-0005bN-Ak for 71313-done@debbugs.gnu.org; Sat, 08 Jun 2024 09:27:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFw5t-00073M-M7; Sat, 08 Jun 2024 09:26:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=s+6UhFXb7ZJOvRpm/cdYDJypPkMT4l8D4qOHvGFoojY=; b=Squ2hJMbWzh2 A5CNWPZ32lirDPwCSQaqqq9pA7az5i/+NA/oktWtSaccS2cVA04A56blxGQEfk1oFuEddpluLTAFj vKJJOTJ/ZSLYv5Ei5UEfvtoyuXM0ACmf1P00SRel9q/d0O/qzRHd7TqHlaMZ537Fx130FHFgczRaI FCddxUZiAurb8TssO2kqAVyj0+/8a+xCJtdPuWE85lRzmiZinjBN47A9mlJBdHjvZTocjisnmLuOV 0B5EhmZ2qeom95df8nvo2cxbCYSlcsdRmmDEzy6fnxJHu+sFcvLl40pCwO9V6Y/C8ucyeODS4vU12 mVW/S+XzxzPNr12sKVqhLQ==; Date: Sat, 08 Jun 2024 16:26:44 +0300 Message-Id: <868qzfd0q3.fsf@gnu.org> From: Eli Zaretskii To: Elijah G In-Reply-To: (message from Elijah G on Fri, 7 Jun 2024 22:32:47 -0600) Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> <86le3jk4k9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71313-done Cc: 71313-done@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah G > Date: Fri, 7 Jun 2024 22:32:47 -0600 > Cc: Stefan Monnier , 71313@debbugs.gnu.org > > I think this can be closed since this is more a problem with Vertico (and probably Helm) as far as i could see. Thanks, done. From unknown Sat Sep 06 00:11:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Jul 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator