GNU bug report logs - #71306
[PATCH gnome-team] gnu: gtk: Fix build on i686-linux.

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Sat, 1 Jun 2024 05:04:02 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71306 in the body.
You can then email your comments to 71306 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org:
bug#71306; Package guix-patches. (Sat, 01 Jun 2024 05:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
New bug report received and forwarded. Copy sent to liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org. (Sat, 01 Jun 2024 05:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team] gnu: gtk: Fix build on i686-linux.
Date: Thu, 30 May 2024 10:25:01 +0200

* gnu/packages/gtk.scm (gtk)[#:phases]<patch>: Add section dedicated to
failures on i686-linux.
---
 gnu/packages/gtk.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index d5777ae67b..1c78a969f6 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1235,7 +1235,20 @@ (define-public gtk
                 ;; The inscription-markup.ui fails due to /etc/machine-id
                 ;; related warnings (see:
                 ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
-                (("[ \t]*'inscription-markup.ui',") ""))))
+                (("[ \t]*'inscription-markup.ui',") ""))
+              ;; XXX: These failures appear specific to i686 – investigate them.
+              #$@(if (target-x86-32?)
+                     #~((substitute* "testsuite/gsk/meson.build"
+                          (("'empty-(fill|stroke)\\.node',") "")
+                          (("'fill2?\\.node',") "")
+                          (("'stroke\\.node',") "")
+                          (("'fill-fractional-([a-z-]*)-nogl',") "")
+                          (("\\[ 'path-special-cases' \\],") "")
+                          (("\\[ '(path|curve)-special-cases' \\],") "")
+                          (("\\[ 'path-private' \\],") ""))
+                        (substitute* "testsuite/a11y/meson.build"
+                           (("\\{ 'name': 'text(view)?' \\},") "")))
+                    #~())))
           (add-before 'build 'set-cache
             (lambda _
               (setenv "XDG_CACHE_HOME" (getcwd))))

base-commit: 4b5b1fa8125c3055ddea36f37e0c5311489e1563
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#71306; Package guix-patches. (Sat, 01 Jun 2024 15:06:02 GMT) Full text and rfc822 format available.

Message #8 received at 71306 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, 71306 <at> debbugs.gnu.org
Subject: Re: [bug#71306] [PATCH gnome-team] gnu: gtk: Fix build on i686-linux.
Date: Sat, 01 Jun 2024 11:04:07 -0400

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/gtk.scm (gtk)[#:phases]<patch>: Add section dedicated to
> failures on i686-linux.
> ---
>  gnu/packages/gtk.scm | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index d5777ae67b..1c78a969f6 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -1235,7 +1235,20 @@ (define-public gtk
>                  ;; The inscription-markup.ui fails due to /etc/machine-id
>                  ;; related warnings (see:
>                  ;; https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
> -                (("[ \t]*'inscription-markup.ui',") ""))))
> +                (("[ \t]*'inscription-markup.ui',") ""))
> +              ;; XXX: These failures appear specific to i686 – investigate them.
> +              #$@(if (target-x86-32?)
> +                     #~((substitute* "testsuite/gsk/meson.build"
> +                          (("'empty-(fill|stroke)\\.node',") "")
> +                          (("'fill2?\\.node',") "")
> +                          (("'stroke\\.node',") "")
> +                          (("'fill-fractional-([a-z-]*)-nogl',") "")
> +                          (("\\[ 'path-special-cases' \\],") "")
> +                          (("\\[ '(path|curve)-special-cases' \\],") "")
> +                          (("\\[ 'path-private' \\],") ""))
> +                        (substitute* "testsuite/a11y/meson.build"
> +                           (("\\{ 'name': 'text(view)?' \\},") "")))
> +                    #~())))

Are you sure these are specific to i686 and not to 32 bit architectures
such as armhf also?

-- 
Thanks,
Maxim
Information forwarded to guix-patches <at> gnu.org:
bug#71306; Package guix-patches. (Sat, 01 Jun 2024 16:22:02 GMT) Full text and rfc822 format available.

Message #11 received at 71306 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, 71306 <at> debbugs.gnu.org
Subject: Re: [bug#71306] [PATCH gnome-team] gnu: gtk: Fix build on i686-linux.
Date: Sat, 01 Jun 2024 18:20:24 +0200

Am Samstag, dem 01.06.2024 um 11:04 -0400 schrieb Maxim Cournoyer:
> Hi Liliana,
> 
> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
> 
> > * gnu/packages/gtk.scm (gtk)[#:phases]<patch>: Add section
> > dedicated to
> > failures on i686-linux.
> > ---
> >  gnu/packages/gtk.scm | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> > index d5777ae67b..1c78a969f6 100644
> > --- a/gnu/packages/gtk.scm
> > +++ b/gnu/packages/gtk.scm
> > @@ -1235,7 +1235,20 @@ (define-public gtk
> >                  ;; The inscription-markup.ui fails due to
> > /etc/machine-id
> >                  ;; related warnings (see:
> >                  ;;
> > https://gitlab.gnome.org/GNOME/gtk/-/issues/5169).
> > -                (("[ \t]*'inscription-markup.ui',") ""))))
> > +                (("[ \t]*'inscription-markup.ui',") ""))
> > +              ;; XXX: These failures appear specific to i686 –
> > investigate them.
> > +              #$@(if (target-x86-32?)
> > +                     #~((substitute* "testsuite/gsk/meson.build"
> > +                          (("'empty-(fill|stroke)\\.node',") "")
> > +                          (("'fill2?\\.node',") "")
> > +                          (("'stroke\\.node',") "")
> > +                          (("'fill-fractional-([a-z-]*)-nogl',")
> > "")
> > +                          (("\\[ 'path-special-cases' \\],") "")
> > +                          (("\\[ '(path|curve)-special-cases'
> > \\],") "")
> > +                          (("\\[ 'path-private' \\],") ""))
> > +                        (substitute* "testsuite/a11y/meson.build"
> > +                           (("\\{ 'name': 'text(view)?' \\},")
> > "")))
> > +                    #~())))
> 
> Are you sure these are specific to i686 and not to 32 bit
> architectures such as armhf also?
Well, I only tested it on x86-32.  If we see the same failures on
armhf, I can just update the predicate.

WDYT?
Information forwarded to guix-patches <at> gnu.org:
bug#71306; Package guix-patches. (Mon, 03 Jun 2024 12:12:02 GMT) Full text and rfc822 format available.

Message #14 received at 71306 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, 71306 <at> debbugs.gnu.org
Subject: Re: [bug#71306] [PATCH gnome-team] gnu: gtk: Fix build on i686-linux.
Date: Mon, 03 Jun 2024 08:10:20 -0400

Hi,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Samstag, dem 01.06.2024 um 11:04 -0400 schrieb Maxim Cournoyer:
>> Hi Liliana,
>> 
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>> 
>> > * gnu/packages/gtk.scm (gtk)[#:phases]<patch>: Add section
>> > dedicated to
>> > failures on i686-linux.

OK, let's do this!

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim
Reply sent to Andreas Enge <andreas <at> enge.fr>:
You have taken responsibility. (Sat, 06 Jul 2024 11:00:03 GMT) Full text and rfc822 format available.
Notification sent to Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
bug acknowledged by developer. (Sat, 06 Jul 2024 11:00:03 GMT) Full text and rfc822 format available.

Message #19 received at 71306-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 71306-done <at> debbugs.gnu.org
Subject: Close
Date: Sat, 6 Jul 2024 12:59:14 +0200

This has been applied to master as commit ad7505d16f882e69926008a22f9c12c37b32f4ee .
Closing the bug.

Thanks,

Andreas
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 03 Aug 2024 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 315 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.