GNU bug report logs - #71304
[PATCH] Add support for 'else' clause in R7RS cond-expand.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71304 in the body.
You can then email your comments to 71304 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guile <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] Add support for 'else' clause in R7RS cond-expand.
Date: Fri, 31 May 2024 23:59:04 -0400

* module/ice-9/r7rs-libraries.scm (define-library)
<handle-cond-expand>: Add a pattern to match an 'else' clause.

Series-to: bug-guile <at> gnu.org
---
 module/ice-9/r7rs-libraries.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/module/ice-9/r7rs-libraries.scm b/module/ice-9/r7rs-libraries.scm
index 63a300a26..86b3dee24 100644
--- a/module/ice-9/r7rs-libraries.scm
+++ b/module/ice-9/r7rs-libraries.scm
@@ -64,8 +64,10 @@
            ;; FIXME: R7RS (features) isn't quite the same as
            ;; %cond-expand-features; see scheme/base.scm.
            (memq (syntax->datum #'id) %cond-expand-features))))
-      (syntax-case clauses ()
+      (syntax-case clauses (else)
         (() #'())  ; R7RS says this is not specified :-/
+        (((else decl ...))
+         #'(decl ...))
         (((test decl ...) . clauses)
          (if (has-req? #'test)
              #'(decl ...)

base-commit: 779a83d9c682345802f9a605cb8e2b4892129316
-- 
2.41.0

Message #8 received at 71304 <at> debbugs.gnu.org (full text, mbox):

From: "Dr. Arne Babenhauserheide" <arne_bab <at> web.de>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 71304 <at> debbugs.gnu.org
Subject: Re: bug#71304: [PATCH] Add support for 'else' clause in R7RS
 cond-expand.
Date: Mon, 01 Jul 2024 23:52:53 +0200

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> * module/ice-9/r7rs-libraries.scm (define-library)
> <handle-cond-expand>: Add a pattern to match an 'else' clause.

This looks good to me. I applied and pushed it.

Best wishes,
Arne
-- 
Unpolitisch sein
heißt politisch sein,
ohne es zu merken.
draketo.de

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 71304 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: "Dr. Arne Babenhauserheide" <arne_bab <at> web.de>
Cc: 71304 <at> debbugs.gnu.org
Subject: Re: bug#71304: [PATCH] Add support for 'else' clause in R7RS
 cond-expand.
Date: Tue, 02 Jul 2024 08:24:18 -0400

Hello Arne,

"Dr. Arne Babenhauserheide" <arne_bab <at> web.de> writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:
>
>> * module/ice-9/r7rs-libraries.scm (define-library)
>> <handle-cond-expand>: Add a pattern to match an 'else' clause.
>
> This looks good to me. I applied and pushed it.

Yay!  Thank you.

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.