Subject: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell

From: Eli Zaretskii <[email-masked]>
Date: Fri, 31 May 2024 09:05:30 +0300

> Cc: [email-masked]
> Date: Thu, 30 May 2024 22:18:44 -0700
> From: Jim Porter <[email-masked]>
> 
> This patch adds support for outline-minor-mode to Eshell. When enabled, 
> this will just add outline buttons to the prompt (as the top level), and 
> one to the start of the output (as level 2).

Thanks.

> diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
> index 873d14aff32..071a2e59191 100644
> --- a/doc/misc/eshell.texi
> +++ b/doc/misc/eshell.texi
> @@ -2967,12 +2967,6 @@ Bugs and ideas
>  
>  @item Support zsh's ``Parameter Expansion'' syntax, i.e., @samp{$@{@var{name}:-@var{val}@}}
>  
> -@item Create a mode @code{eshell-browse}
> -
> -It would treat the Eshell buffer as an outline.  Collapsing the outline
> -hides all of the output text.  Collapsing again would show only the
> -first command run in each directory
> -
>  @item Allow other revisions of a file to be referenced using @samp{file@{rev@}}
>  
>  This would be expanded by @code{eshell-expand-file-name} (see above).
> diff --git a/etc/NEWS b/etc/NEWS
> index 3c672ffed8f..b5d4c9cfe6e 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -877,6 +877,9 @@ can make it executable like other shell scripts:
>  
>      #!/usr/bin/env -S emacs --batch -f eshell-batch-file
>  
> +---
> +*** Eshell now supports 'outline-minor-mode'.

This is what I call "anti-documentation": the text you removed, which
described a non-existing feature, told more about the feature than the
text you added after implementing it ;-)

Seriously, though: since it is completely un-obvious what would
outline-minor-mode mean for command-line-oriented modes like Eshell,
both NEWS and the Eshell manual should say at least a couple of words
about what that does.  We cannot get away by just mentioning the
support and keeping silent about the rest.