From unknown Wed Jun 18 23:13:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71282 <71282@debbugs.gnu.org> To: bug#71282 <71282@debbugs.gnu.org> Subject: Status: 30.0.50; hl-line overlay priority has no affect Reply-To: bug#71282 <71282@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:16 +0000 retitle 71282 30.0.50; hl-line overlay priority has no affect reassign 71282 emacs submitter 71282 Mohsin Kaleem severity 71282 normal tag 71282 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Thu May 30 18:36:07 2024 Received: (at submit) by debbugs.gnu.org; 30 May 2024 22:36:07 +0000 Received: from localhost ([127.0.0.1]:52736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCoNS-0002ey-Q3 for submit@debbugs.gnu.org; Thu, 30 May 2024 18:36:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:55884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCoNN-0002eS-9s for submit@debbugs.gnu.org; Thu, 30 May 2024 18:36:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCoNC-0002xa-8D for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 18:35:50 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119] helo=mail.kisara.moe) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCoMz-0001bk-HH for bug-gnu-emacs@gnu.org; Thu, 30 May 2024 18:35:49 -0400 Received: from mk-desktop (0545388a.skybroadband.com [5.69.56.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 05358A2796 for ; Fri, 31 May 2024 00:27:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1717108025; bh=UHM9y7rQuLxT6/mQ2UlTWJtm1hq++GMtVtHlEeDtefM=; h=From:To:Subject:Date:From; b=WjJU/KjI+4yy1PTQalykRvskhixfotZ04G98xz+YsmHqLddWulWuuL2jY9Rwjvf7g RHJOdyOf6Gxlu3fHwngpJ1y2TIciME1oWeNsOIMrOfVHb1D80im6g/JROsif1y0JgX 9KDv/2ktMaQ6vRVn7LlwMihC5aYxFg3b2D2oX9o867LBa3EtLhmi+TGIaP2CDyd+G2 ojqFoyYrISq59u9CEJmYIG6Bh3K8h7Ft7lfCevyZQAxtIuvn19yVZZ73IAdeSgJfpy 4bqggn1JWC6h5NpdMCbTGHu8m94zDEUpjmAt3eZVnn3EK/cF5+wgpIV6ZweZge3k59 pLoVBpYa3MxGg== From: Mohsin Kaleem To: bug-gnu-emacs@gnu.org Subject: 30.0.50; hl-line overlay priority has no affect Date: Thu, 30 May 2024 23:27:02 +0100 Message-ID: <87plt3lyvd.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=51.38.65.119; envelope-from=mohkale@kisara.moe; helo=mail.kisara.moe X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi there, Looks like there's no way to give hl-line a higher priority than other text overlays. This impacts things like eglot-inlay-hints-mode or overlay-error-string among other modes and has the affect of making hints or annotations from these modes look out of place. I can reproduce this with something as minimal as: $ emacs -Q $ M-: (progn (setq hl-line-overlay-priority 10) (hl-line-mode) (erase-buffer) (insert ";; This buffer is for text that is not saved, and for Lisp evalu= ation. ;; To create a file, visit it with =E2=80=98SPC f f=E2=80=99 and enter text= in its buffer.") (let ((ov (make-overlay (+ (point-min) 2) (+ (point-min) 3)))) (overlay-put ov 'before-string "foo") (overlay-put ov 'priority 5))) If you move the point to the first line you can see the overlay and its face background completely disregards hl-lines background despite having a lower priority. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-05-08 built on mk-desktop Repository revision: 840c33070dc789d5095a47fa65f4f77564cd6e59 Repository branch: master System Description: Arch Linux Configured using: 'configure --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib --localstatedir=3D/var --mandir=3D/usr/share/man --with-gameuser=3D:games --with-modules --without-m17n-flt --without-gconf --with-native-compilation=3Dyes --with-xinput2 --with-x-toolkit=3Dgtk3 --without-xaw3d --with-sound=3Dno --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=3Ds/\([ec]tags\)/\1.emacs/' 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3D3 -Wformat -Werror=3Dformat-security -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -g -ffile-prefix-map=3D/home/mohkale/.cache/yay/emacs-git/src=3D/usr/src/debu= g/emacs-git -flto=3Dauto' 'LDFLAGS=3D-Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=3Dauto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_MESSAGES: C value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: hl-line-mode: t straight-use-package-mode: t straight-package-neutering-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils hl-line compile text-property-search comint ansi-osc ansi-color ring comp-run comp-common rx straight-autoloads cl-seq cl-extra help-mode straight cl-macs cl-loaddefs cl-lib +core-setup-paths xdg subr-x term/st term/xterm xterm byte-opt gv bytecomp byte-compile rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 135391 97166) (symbols 48 12063 45) (strings 32 37667 9732) (string-bytes 1 2453600) (vectors 16 17732) (vector-slots 8 966098 204470) (floats 8 37 12) (intervals 56 463 162) (buffers 992 13)) --=20 Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 01:44:49 2024 Received: (at 71282) by debbugs.gnu.org; 31 May 2024 05:44:50 +0000 Received: from localhost ([127.0.0.1]:52974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCv4L-0006Uq-Bf for submit@debbugs.gnu.org; Fri, 31 May 2024 01:44:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCv4F-0006UW-9p; Fri, 31 May 2024 01:44:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCv3x-0000yQ-Pe; Fri, 31 May 2024 01:44:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3Bt6Y3mNTSagfl81ZgY0nImwFSjCNkdeM3V1YOmOSYs=; b=UTNYW+YcE+k/dgesxXfS kGFtDkswmLyyQ0ZXFg7etfz7cDjP0HOSifw7NfHOfWZ6kiodME7MHhkge+wgiyOH4S6ZpP9dAtS6q DGaTidukzIOncsszDsdB3L2nieqjD6+UJYQzuiOB5xqk4YZ04KCvVzX6gChBh8lLcaohPGcBcDbBP 22F5+laLny35CQGFzcFmUVsWNnpHq2k701fsC/hHiDDVCubEpm7bJOLMyI0vqtlb4f14y/Ur7oXOP UI3/gWuBSxU4HYQgwuSuk9ut55eLuhcbs9cBs1DJf+/HO3nNeuuGgBQb4PvfRtpDsjIHBTbIojbmE vstKxAJ/JB0gsg==; Date: Fri, 31 May 2024 08:44:23 +0300 Message-Id: <8634pyr0w8.fsf@gnu.org> From: Eli Zaretskii To: Mohsin Kaleem In-Reply-To: <87plt3lyvd.fsf@kisara.moe> (message from Mohsin Kaleem on Thu, 30 May 2024 23:27:02 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 71282 notabug thanks > From: Mohsin Kaleem > Date: Thu, 30 May 2024 23:27:02 +0100 > > Looks like there's no way to give hl-line a higher priority than other > text overlays. Of course there is: use the hl-line-overlay-priority option, like you did below. But the problem you are trying to solve cannot be solved by overlay priorities, see below. > This impacts things like eglot-inlay-hints-mode or > overlay-error-string among other modes and has the affect of making > hints or annotations from these modes look out of place. Those 2 examples are not expected to be affected by the priority of the hl-line overlay, albeit for different reasons: . eglot-inlay-hints-mode overlays have their priorities at 50+, and these overlays display strings (so are similar to your snippet below) . overlay-error-string is not an overlay (despite its confusing name) > I can reproduce this with something as minimal as: > > $ emacs -Q > $ M-: > (progn > (setq hl-line-overlay-priority 10) > (hl-line-mode) > (erase-buffer) > (insert ";; This buffer is for text that is not saved, and for Lisp evaluation. > ;; To create a file, visit it with ‘SPC f f’ and enter text in its buffer.") > (let ((ov (make-overlay (+ (point-min) 2) (+ (point-min) 3)))) > (overlay-put ov 'before-string "foo") > (overlay-put ov 'priority 5))) > > If you move the point to the first line you can see the overlay and its > face background completely disregards hl-lines background despite having > a lower priority. This is intended behavior: overlay priority affects only the text to which the overlay is applied. In the above snippet, the overlay is applied to buffer text, whereas "foo" is an overlay string, and has its own face information (which defaults to the face of the underlying buffer text). So the hl-line overlay's face does not affect the face of the before-string. There's no bug here, only a well-documented behavior. See the node "Displaying Faces" in the ELisp manual for the details. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 02:11:43 2024 Received: (at 71282-done) by debbugs.gnu.org; 30 Jun 2024 06:11:43 +0000 Received: from localhost ([127.0.0.1]:54689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNnmp-0002cb-9H for submit@debbugs.gnu.org; Sun, 30 Jun 2024 02:11:43 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:58725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNnmm-0002cG-De for 71282-done@debbugs.gnu.org; Sun, 30 Jun 2024 02:11:41 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57d1d614049so2367403a12.1 for <71282-done@debbugs.gnu.org>; Sat, 29 Jun 2024 23:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719727835; x=1720332635; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=Egchm2IFurPZoq47IA44qGtvPpziDfzo6W6aOLW70jc=; b=YItahGykjA5LW7uca/ihARjCbAU7OAPZ/Pj+DuHdnHBcIkc5agVJViQjPmlONTqBXa LtFoOBd7f0b7kxUGeWIHs+qCFTvYGkXQGSfqpd98+CByO7qxvKyvMw0oD9cwTaWwVUWi m5LLfCtb2C9xEgZya37rz794Fx8L09ebFzMSQARVsUP0YWPFIRTuRC9z9ry0C9mYccEG r4DLJae3HG3BMwKJkgOC1d+MOvnHa4Ov+d/6HWOYdR81R430tL3YFJ3wxmylWOlngO4V 6MJb8CVEciCGIyhPw3Rq8kZ/nHisQg66s0Lyq80nVn7ncGzOxkhWHxgojdtBxlL2nExZ uNgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719727835; x=1720332635; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Egchm2IFurPZoq47IA44qGtvPpziDfzo6W6aOLW70jc=; b=XOqLxSuQCWCynZosCqyCiyJveLYyS2UQDXPJdmIGlhx4XrSxdyUoXd+arm6oN9BMPw ddrdWcaW8nZoOMvTUPHPZMhnZTYnlR03kenwxJ51o8HacUaHqtY1G0+KMT+FIW+qDLQr aVlGy1FhoYFTq+ZeuMhggRtXvD/miH6E1OotOkclShpuFFfFWHq7tRlygXGModf+d/H0 GT9kzRSijD1BxDwI9a/o4zc2TBn+5iMIYHqZWwQhyYdkNYZJfXs6E0kGOHrTZtVVeT+/ xQmdNnT5mvx8AVy9YUxjLM/eCbgIykzcHZCC0fDAyR3joDAE1YZk6+c2Jtfzx6O/jFO4 XohA== X-Forwarded-Encrypted: i=1; AJvYcCWJceQAhwCwgco1r71+R72q9guluLESseW9Z/aEaa0Muv1dE5d5reRnLk25S/36zx+zy7GAaaKDvrW00rFqD72ZtCxvrcXQaLJcFA== X-Gm-Message-State: AOJu0Yz808QuS6jzBSeExIqKwaqZbWTCz+KR2NbItbd/UJNVEV+/xnjF Jj7cN5g8iLhv4m/UOKssr4Ki6f9R57RpWFKvqSavSWljSzOCCBJAPBeFxpuJwc1mSEXMLc69wFO MRpW+av+RqAXqPOnTKDGvrAykp0k= X-Google-Smtp-Source: AGHT+IEDLekTthel4Y5+N7wk2Ebx/TqSIUo5ZmXqZYKzfwm8OYQIyg1aMWXw8mEp/xE+UdBPaSQSo04VJcdarmbJbvA= X-Received: by 2002:a05:6402:3486:b0:57c:758d:86f8 with SMTP id 4fb4d7f45d1cf-5879f69c67fmr2014680a12.23.1719727834969; Sat, 29 Jun 2024 23:10:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 29 Jun 2024 23:10:34 -0700 From: Stefan Kangas In-Reply-To: <8634pyr0w8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 31 May 2024 08:44:23 +0300") References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> MIME-Version: 1.0 Date: Sat, 29 Jun 2024 23:10:34 -0700 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71282-done Cc: Mohsin Kaleem , 71282-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > tags 71282 notabug > thanks > >> From: Mohsin Kaleem >> Date: Thu, 30 May 2024 23:27:02 +0100 >> >> Looks like there's no way to give hl-line a higher priority than other >> text overlays. > > Of course there is: use the hl-line-overlay-priority option, like you > did below. But the problem you are trying to solve cannot be solved > by overlay priorities, see below. > >> This impacts things like eglot-inlay-hints-mode or >> overlay-error-string among other modes and has the affect of making >> hints or annotations from these modes look out of place. > > Those 2 examples are not expected to be affected by the priority of > the hl-line overlay, albeit for different reasons: > > . eglot-inlay-hints-mode overlays have their priorities at 50+, and > these overlays display strings (so are similar to your snippet > below) > . overlay-error-string is not an overlay (despite its confusing > name) > >> I can reproduce this with something as minimal as: >> >> $ emacs -Q >> $ M-: >> (progn >> (setq hl-line-overlay-priority 10) >> (hl-line-mode) >> (erase-buffer) >> (insert ";; This buffer is for text that is not saved, and for Lisp ev= aluation. >> ;; To create a file, visit it with =E2=80=98SPC f f=E2=80=99 and enter t= ext in its buffer.") >> (let ((ov (make-overlay (+ (point-min) 2) (+ (point-min) 3)))) >> (overlay-put ov 'before-string "foo") >> (overlay-put ov 'priority 5))) >> >> If you move the point to the first line you can see the overlay and its >> face background completely disregards hl-lines background despite having >> a lower priority. > > This is intended behavior: overlay priority affects only the text to > which the overlay is applied. In the above snippet, the overlay is > applied to buffer text, whereas "foo" is an overlay string, and has > its own face information (which defaults to the face of the underlying > buffer text). So the hl-line overlay's face does not affect the face > of the before-string. > > There's no bug here, only a well-documented behavior. See the node > "Displaying Faces" in the ELisp manual for the details. I'm therefore closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 07:42:48 2024 Received: (at 71282-done) by debbugs.gnu.org; 30 Jun 2024 11:42:48 +0000 Received: from localhost ([127.0.0.1]:55780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNsxD-0000bn-Pv for submit@debbugs.gnu.org; Sun, 30 Jun 2024 07:42:48 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119]:44710 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNsxB-0000be-Ch for 71282-done@debbugs.gnu.org; Sun, 30 Jun 2024 07:42:46 -0400 Received: from mk-desktop (unknown [140.228.49.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 4E44CA2796; Sun, 30 Jun 2024 13:42:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1719747763; bh=5EbmsfOT8soN9F4Isr7p8SFETy+DmzU0aSPDVtUowfA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LDe2DHR1VQsuKrteFWjUJYlI/wva7Tlk3zleGwAX0CVNEs+6+gFxf4qd1NmeM1Kyc +pAtJdh6zSzb32Gu8YlBr0CST8D8AEWcTTp9ayh8X5YnoPseCp8r5kOAetQsKpWdz5 iQjzJhDlpCQIc+zG19Xevujnu8F2M1lNKThvO1YUrSs0fZ4GxuhE3mzmlL0Z9SyaBK /Qwx4HCDmQsJh3qFZDm7MMFp/hnN24CFVLbsjFmQLvn2uuV+Kadlc33m+uY5EhFeyM 0yREXPrzA7aIXoe00OjrJNjqB7YNErNAbo7hMU0Zqhd6D9HP6S6W4PpAdkDAuVz/sO a5PCyWxmPAWyg== From: Mohsin Kaleem To: Stefan Kangas , Eli Zaretskii Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect In-Reply-To: References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> Date: Sun, 30 Jun 2024 12:42:41 +0100 Message-ID: <878qymd5ce.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 71282-done Cc: 71282-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Stefan Kangas writes: >> This is intended behavior: overlay priority affects only the text to >> which the overlay is applied. In the above snippet, the overlay is >> applied to buffer text, whereas "foo" is an overlay string, and has >> its own face information (which defaults to the face of the underlying >> buffer text). So the hl-line overlay's face does not affect the face >> of the before-string. >> >> There's no bug here, only a well-documented behavior. See the node >> "Displaying Faces" in the ELisp manual for the details. > > I'm therefore closing this bug report. Hi, sorry, I forgot I opened this. If it's expected behaviour is the usage of overlays here by eglot and related packages wrong? Even if it's expected this is the only editor I've used which has inlay hints that override attributes like hl-line. Is there an alternative way for eglot to support inlay hints that isn't in conflict with hl-line? -- Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 08:23:28 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 12:23:28 +0000 Received: from localhost ([127.0.0.1]:55846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNtaa-0001dZ-0S for submit@debbugs.gnu.org; Sun, 30 Jun 2024 08:23:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNtaX-0001dM-Px for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 08:23:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNtaR-0002kh-R9; Sun, 30 Jun 2024 08:23:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=cNUHMimKQA7IEuJfo6kpybQIm7YoYf8bxYr5Nr6ZSSs=; b=aqp3uZ70z+KCNlDm4Mlf W+pB7r0zeJWKJuY3gwcTEZNnLrMGoNVoa8/tQSrG5MgGL8YuCJGj1CcNZ9QiOzoq+XC5FqWsEUWyM KDno4a5yDDeTzLleZgK9ER4eODp3ftiKFRfMT1wuTk9xhBCTHJy9jHs3mBhzeDwUyH4agp4hPi6Ud 3IpAw9IvbflN5lUeSVfzPQNjLGDs37aXL8a+Nzc/8AvapxfyP1SdjKu+GTzimyIkxidTPzphcp8yW ljkO078spDldNQ1XktdvABxcGTA45iP9wx1CXev0PEPW0cxEPPuJR1kl43tcwhQpyIT/+W5PAfO30 /S7HE18a2aJ/+A==; Date: Sun, 30 Jun 2024 15:23:00 +0300 Message-Id: <86a5j2hb6j.fsf@gnu.org> From: Eli Zaretskii To: Mohsin Kaleem , =?iso-8859-1?Q?Jo=E3o_T=E1vora?= In-Reply-To: <878qymd5ce.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 30 Jun 2024 12:42:41 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mohsin Kaleem > Cc: 71282-done@debbugs.gnu.org > Date: Sun, 30 Jun 2024 12:42:41 +0100 > > Stefan Kangas writes: > > >> This is intended behavior: overlay priority affects only the text to > >> which the overlay is applied. In the above snippet, the overlay is > >> applied to buffer text, whereas "foo" is an overlay string, and has > >> its own face information (which defaults to the face of the underlying > >> buffer text). So the hl-line overlay's face does not affect the face > >> of the before-string. > >> > >> There's no bug here, only a well-documented behavior. See the node > >> "Displaying Faces" in the ELisp manual for the details. > > > > I'm therefore closing this bug report. > > Hi, sorry, I forgot I opened this. If it's expected behaviour is the > usage of overlays here by eglot and related packages wrong? Even if it's > expected this is the only editor I've used which has inlay hints that > override attributes like hl-line. Is there an alternative way for eglot > to support inlay hints that isn't in conflict with hl-line? The only way I can think of is for Eglot to be sensitive to hl-line and to set up the colors of the inlay hints to be consistent with the hl-line's background. Not sure if João (CC'ed) will like this. FWIW, I see no problem in the current behavior, but then I'm not an hl-line user. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 09:41:19 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 13:41:19 +0000 Received: from localhost ([127.0.0.1]:55926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNunu-0003pS-T8 for submit@debbugs.gnu.org; Sun, 30 Jun 2024 09:41:19 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119]:35294 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNuns-0003pH-0W for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 09:41:16 -0400 Received: from mk-desktop (unknown [140.228.49.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 59F0FA2796; Sun, 30 Jun 2024 15:41:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1719754874; bh=I8QPW3f1xceyI1CaAqZH5FKSnmvGRvauJ6gbEGRSW2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=zpsRl25yka1cVONbeqrAOdg8uRbH9RKu5RSsu0EcQCpeV5V5+Fk0uLhKumT3v0ril DgnFiuihJ2HxDvrhAQskY5v5z71Mt7OrDLLnqe41BoYjbOzxyktw4vmu1fJCkRCP6p Pzkdz12mJpdcv1/kZUnMUwFOl9pnhQkKy4EeHzyJk/TrELo3hdwy1LEihBDBzAbRf2 6VeyW7IUAERblHFDVhAsSyKHSnRYSFw3ath9V7w0a/XSV4xbJbzGiMup8nDiPfknE1 83kSnDzRMXOxq/vPd4Zq5HTDvI0Dgn8H8YTubr1h7O7luO2u1c3VaszqC+wCXIRNp+ rGSbe+yKp6WIA== From: Mohsin Kaleem To: Eli Zaretskii , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect In-Reply-To: <86a5j2hb6j.fsf@gnu.org> References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> Date: Sun, 30 Jun 2024 14:41:13 +0100 Message-ID: <875xtqczuu.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Eli Zaretskii writes: > The only way I can think of is for Eglot to be sensitive to hl-line > and to set up the colors of the inlay hints to be consistent with the > hl-line's background. Not sure if Jo=C3=A3o (CC'ed) will like this. > > FWIW, I see no problem in the current behavior, but then I'm not an > hl-line user. This seems at least to me like a problem not specific to eglot. Any package trying to support overlay annotations in buffer will have the same problem. This is either a limitation of hl-line and it should have bespoke logic to override overlay faces or the overlay mechanism itself should be flexible enough to respect this (with the priority suggestion from before). Although probably makes sense to wait and see what Jo=C3=A3o says :-). --=20 Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 10:47:08 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 14:47:08 +0000 Received: from localhost ([127.0.0.1]:58654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNvpb-0006LU-SY for submit@debbugs.gnu.org; Sun, 30 Jun 2024 10:47:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNvpZ-0006Kz-AQ for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 10:47:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNvpS-0007dY-VY; Sun, 30 Jun 2024 10:46:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=9ik6DK+ZtiU1iL76d2asNSu04bH9Fz5PPZ05+k6ADxg=; b=VP9Q+zJCZ/7hRJ7IElAV oQ0cOYbCMN8PlyvM0WK1YyJsD2T9Dg0LBGRmEdrRue2odINStqWm4qqktMmVosgxppOmBepRSPtRo O53Cb02Vu0+6PzPygrCs8gHPnZxrSBVkDmI9pBIsdn1gWiz8Wlx+NnvLnvom1OMMC7XBqEMtJNM6L 46U9627n0HdbaFucmC692wl4yf5yQIqRl2JWGGLjjFFbRTA9TPCVn3tQjfUNSwbV89k2Euhwx6Ekf dD1Ic/y9ch0WGt0iV879ChWfi7PDaAP0MuYaYIGRFlHKNdtfxjkRv1y5o+mBS9QW+Rl7tZtJpBswQ X9A7z1UGE4a5pA==; Date: Sun, 30 Jun 2024 17:46:53 +0300 Message-Id: <867ce6h4iq.fsf@gnu.org> From: Eli Zaretskii To: Mohsin Kaleem In-Reply-To: <875xtqczuu.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 30 Jun 2024 14:41:13 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, joaotavora@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mohsin Kaleem > Cc: stefankangas@gmail.com, 71282@debbugs.gnu.org > Date: Sun, 30 Jun 2024 14:41:13 +0100 > > Eli Zaretskii writes: > > > The only way I can think of is for Eglot to be sensitive to hl-line > > and to set up the colors of the inlay hints to be consistent with the > > hl-line's background. Not sure if João (CC'ed) will like this. > > > > FWIW, I see no problem in the current behavior, but then I'm not an > > hl-line user. > > This seems at least to me like a problem not specific to eglot. Any > package trying to support overlay annotations in buffer will have the > same problem. I don't think it's a "problem". Overlay strings have their own faces, and those override the faces of buffer text. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:14:15 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:14:15 +0000 Received: from localhost ([127.0.0.1]:58709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwFr-00075k-7u for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:14:15 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:54523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwFo-00075V-L5 for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:14:13 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52ce01403f6so2456694e87.0 for <71282@debbugs.gnu.org>; Sun, 30 Jun 2024 08:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719760387; x=1720365187; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=plPymUu/fXVdhURwONc7Hf46ev2paEv0xBjU3V+CoY8=; b=WvV8K3laj4pJ51F9PiwbiBiPVOyfL2quUZp9ZL/ruOiQZFzT2VvTotJIqAcAExa9wP d3CEF1iWP/yA8NbrBYoi7AEF20oCPG33/FBe3CIj7bdimRnMIMeSDOnyz9PNncLxQRmn KKk1p05hxwYHUzblTuvilItFYDEWXqewBmLF+Y9Wucb9BcaEpaGACnJ1CQebc5IiYQbc sk8zKazrUVHjPekKmK++SD+vQvPx0hNcMtZWVFrKTfZUnI0MY87ooaX3QkQxuL6G3s4V zooAJYqoO71oEsKPECy2q+deBcjIaSYb3CrnExehOacTLTY5pXFOzFtc8BYd8f22dzHN xgWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719760387; x=1720365187; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=plPymUu/fXVdhURwONc7Hf46ev2paEv0xBjU3V+CoY8=; b=c8CgF5sxuGrko++OKHVJkXXqhzWnTcNbqcg/q/xh0Gr8VkTAlG7GMHFikrVSACkmoY Ce1eZVpudAZMwUzzR7/7rS9XntyFbLQvRXs6kMG1IOtb3LJWlLmxxxmyOaIRuvRYKXvy TFCrwlD4lriSaBbIWRBHneMkjPgH246/vup16lG7SmM233SN3qxURQc4/a4x84761OI2 jx/ScSH3QpBmgsg63vIN1qUz2eGv/dipbysnwEIcTYzL9xTB5qIV8tmIdK28pCeI4XOR jm5VKMT67UkOYFQWNNdqJ772xvabYUyphTn5jmYay2C90DHWfmmqxmXQBm9LLPk69YUo 8nXQ== X-Forwarded-Encrypted: i=1; AJvYcCVJKcXhCMiK2LYrWIMjHyPVsxCoGiYrR1PuyLneHKasko0+6MlbhZ6jiOCamz/vHmZ/KoekzggyZqNHP47Lbd40epMA89w= X-Gm-Message-State: AOJu0Yx8dSaTQebeQ3fkdA6e8ubPrCNiA2i6eV5N5Sin1oQN7CNO7vI2 Agj3jBPGrt1e7R8Y8y5OoCQlLiLgYSg3/ED4NEpGy5Uqi7ZYokQ5PLm2Vhz4DdxGr6AEuviYen1 48sA79YzZ5NZ3acA632sAdfarJiJ7YApG X-Google-Smtp-Source: AGHT+IGJ5G66mZVYbZrOROeaZUzceArlji1Z71+bv030YmxcQJhqZO+0Jei/7uUds6FuWRr8I3wEvOIz9Q5pSrGpzs4= X-Received: by 2002:a05:6512:318e:b0:52e:6ff9:1957 with SMTP id 2adb3069b0e04-52e8273f50amr2288835e87.60.1719760386398; Sun, 30 Jun 2024 08:13:06 -0700 (PDT) MIME-Version: 1.0 References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> In-Reply-To: <867ce6h4iq.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 30 Jun 2024 16:12:55 +0100 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 71282 Cc: Mohsin Kaleem , 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 30, 2024 at 3:47=E2=80=AFPM Eli Zaretskii wrote: > > > From: Mohsin Kaleem > > Cc: stefankangas@gmail.com, 71282@debbugs.gnu.org > > Date: Sun, 30 Jun 2024 14:41:13 +0100 > > > > Eli Zaretskii writes: > I don't think it's a "problem". Overlay strings have their own faces, > and those override the faces of buffer text. If I understand the scenario correctly, I agree with Moshin that this is a more general issue. There should be some way for overlays used by a package X to easily combine with an existing an existing background color, even if that background color is mandated by some hl-current-line extension Y. This mechanism shouldn't rely on making X aware of Y. Maybe if the implementation of Y were moved to C display core, like display-line-numbers-mode. Or maybe not, I haven't looked into it (and I don't plan to, sorry). Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:18:49 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:18:49 +0000 Received: from localhost ([127.0.0.1]:58716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwKG-0007DO-Um for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:18:49 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119]:54292 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwKE-0007DC-BZ for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:18:47 -0400 Received: from mk-desktop (unknown [140.228.49.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 7B597A2796; Sun, 30 Jun 2024 17:18:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1719760712; bh=qdLeO48WhOAdmmTImReDxE7OzsoxUYVh6zoZxG328b4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VgFZnJpIqbr1Y+ODVvt4szwhH8s62wI8J3rLdddeKAw6/XZxpBejJn5MHOb3LI8KI 7vdyWCR90Sef5ITjG9x6D4IUZf1xTKi1mOFq1RMMrxi7xxfQqnAbQ8ALT+O8HnIgyR O5eGTZVJncqm1GIwMij5VsYkX9WSNj60RmSILOlQ/xf0H6/A6ZpGiGObfC40FUTTuj MV43fPS+65QOQS5sY0sdp+MpAyWc5Kg/snrPkeyJ13R3IxYpgYkk5DWoO/sGYsJBcp CDgkV5IFsRR2SZryepCIroqNq40AjtueEBSqN7MZbWecVHX2YfrJmJZn3FNQY2lr2t yZEpw1AZNIXkg== From: Mohsin Kaleem To: Eli Zaretskii Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect In-Reply-To: <867ce6h4iq.fsf@gnu.org> References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> Date: Sun, 30 Jun 2024 16:18:31 +0100 Message-ID: <8734oucvco.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, joaotavora@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Eli Zaretskii writes: > I don't think it's a "problem". Overlay strings have their own faces, > and those override the faces of buffer text. Yes, but hl-line is meant to overlay all of that no? It's supposed to a give consistent highlighted background to the contents of the current line. Which as of now does not work with annotations implemented as overlays. -- Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:21:10 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:21:10 +0000 Received: from localhost ([127.0.0.1]:58724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwMY-0007I0-D6 for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:21:10 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119]:32884 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwMV-0007Hr-Hm for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:21:09 -0400 Received: from mk-desktop (unknown [140.228.49.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 49BFAA2797; Sun, 30 Jun 2024 17:21:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1719760866; bh=G8Tu/i+OHbUml8x0/DVwDQZZWvGlDnN+tLuNQRjmdAQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PEkq0k7ELjsb/JgrI9qayn21CfToEe8OkMCsOh5y5+LqRfHDJ/ja79mJLtv5PyyZ8 4+VMkP0W5RwBUtTfyCDhVq8VUMynZqmK/GHzwJ6fldPzBOEoaI4jAHpeBMfLMpaKdk yG3NVG87C7bmwlQha5bS5P9pHktPcv3xvP1Q5cHmAYWUBYzolsZzn5kB6yvW8LSZSj SqSkS1nKRI5bpR1nTA4+5cwFyP7dbgckJ15dB4OaQyMUE7pQIgKG89YMRhiUQRYLfJ /8jvk0HswWbEQvg2p9rJy++11/e//5lasz5vMR9kURFWmHI1MWG5SX0izoRkBx+6Js SPUn/wX8aMVog== From: Mohsin Kaleem To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , Eli Zaretskii Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect In-Reply-To: References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> Date: Sun, 30 Jun 2024 16:21:05 +0100 Message-ID: <87zfr2bgny.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Jo=C3=A3o T=C3=A1vora writes: > This mechanism shouldn't rely on making X aware of Y. Maybe if the > implementation of Y were moved to C display core, like > display-line-numbers-mode. Or maybe not, I haven't looked into it (and > I don't plan to, sorry). Thanks Jo=C3=A3o. Going to back to the original discussion is there a reason before-strings in overlays don't respect priorities? I realise it's documented but I'm more curious about the why than the what? Was there a use case for these properties in overlays to not be overridable (which from what I understand is the reason for this conflict between hl-line and overlay annotations is happening). --=20 Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:37:05 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:37:05 +0000 Received: from localhost ([127.0.0.1]:58738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwbq-0007ib-C4 for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:37:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwbo-0007iN-7C for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:36:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwZc-0004kB-PR; Sun, 30 Jun 2024 11:34:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MyJeLUyT2eLXoBU8B5O/CmomO4zbCl4KBfi1eiAzX7U=; b=pbB4bdAVpyzUpkGNAz3B LKqc7OL5vntxCtAtdBTsXR6UeyLw0WUiYoQUFS8z7nrMjMo0SKR45qAjFF0odCw7VhfJdlAfkXn5l MLxOvxI97F26uRSiMu9yp2gShBsawmolo3GnEKVZTQmH8EAssqPfQja4JEajWViwCXjbRWWe8Eoni k+5GGeI/DpDnVvvstiKs4s7GVkGCC1nR5vshVxh7J92xgtaRwUSoqtmxLq/XAzq6jssD7SfbvXdwp Y1DDnHWoz9C45MS77NpFqPJlrsItb/ZB9+ZksVkrN6L5C1cv4EJq5xrVwPRiU6mTPHxOwmsuD3YsJ iRu4X8pWlVNW/A==; Date: Sun, 30 Jun 2024 18:34:36 +0300 Message-Id: <865xtqh2b7.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 30 Jun 2024 16:12:55 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sun, 30 Jun 2024 16:12:55 +0100 > Cc: Mohsin Kaleem , stefankangas@gmail.com, 71282@debbugs.gnu.org > > On Sun, Jun 30, 2024 at 3:47 PM Eli Zaretskii wrote: > > > > > From: Mohsin Kaleem > > > Cc: stefankangas@gmail.com, 71282@debbugs.gnu.org > > > Date: Sun, 30 Jun 2024 14:41:13 +0100 > > > > > > Eli Zaretskii writes: > > > I don't think it's a "problem". Overlay strings have their own faces, > > and those override the faces of buffer text. > > If I understand the scenario correctly, I agree with Moshin that this > is a more general issue. There should be some way for overlays > used by a package X to easily combine with an existing an > existing background color, even if that background color is mandated > by some hl-current-line extension Y. This mechanism shouldn't rely > on making X aware of Y. The mechanism exists: find the face of the buffer text, and use it (or some of its attributes, like background color) in determining the face of the overlay string. In some cases, Emacs does this merging automatically, but this is not one of those cases. (I think in this case if hl-line uses text properties instead of overlays, this will happen automatically. But I didn't try that, and I might be missing something in this complex issue.) > Maybe if the implementation of Y were moved to C display core, like > display-line-numbers-mode. Or maybe not, I haven't looked into it > (and I don't plan to, sorry). That's unrelated. The order of merging face information is documented in the ELisp manual, and changing it is out of the question, because it worked like that for many years, and any change in it is bound to break something out there. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:37:49 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:37:49 +0000 Received: from localhost ([127.0.0.1]:58742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwcf-0007k0-CU for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:37:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwce-0007jo-98 for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:37:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNwcY-0006Xa-Oq; Sun, 30 Jun 2024 11:37:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c8n9CQrsur4jUnGpdCiAIen7vxYVNK7JLiJDs/6qc/Y=; b=OlUDxoWcXsVT zF55wZuwHSBatjF8E0dmxN8EwL/7JpGN7fSs71BLXg1CkUYYNjnw54ftaNKH4A0E2v6YDes1orlW4 3OszPd/vHqTN04EnMX997vZuxAC2kDq5UxR4ybGuEKEmB0Y337rpdK/P8h6vdCdPhgtj5cNd3hLYf jy6HR5TX5BFNWuKqhiYUMikZM4AxPj5HwpCb9ayaUWe/gGx7pa4Pt00GMG+IgoBBdIWKijsH4L+N9 z/SovaoIFldT3sVrCuMFd+8hYJ73niWUqERQyDEr4xSYrzAPBArVEH9PkHs+SCr6NtAffEI0Vy8j0 aCwELgSH8mFypdljq/XEYQ==; Date: Sun, 30 Jun 2024 18:37:40 +0300 Message-Id: <864j9ah263.fsf@gnu.org> From: Eli Zaretskii To: Mohsin Kaleem In-Reply-To: <87zfr2bgny.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 30 Jun 2024 16:21:05 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <87zfr2bgny.fsf@kisara.moe> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, joaotavora@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mohsin Kaleem > Cc: stefankangas@gmail.com, 71282@debbugs.gnu.org > Date: Sun, 30 Jun 2024 16:21:05 +0100 > > Going to back to the original discussion is there a reason > before-strings in overlays don't respect priorities? I realise it's > documented but I'm more curious about the why than the what? Was there a > use case for these properties in overlays to not be overridable (which > from what I understand is the reason for this conflict between hl-line and > overlay annotations is happening). I thought I explained that: priorities are a way of determining which overlay "wins" when several overlays affect the same text and provide different values for the same properties. But in this case, each overlay affects different text, so there's no need to consider priorities, and therefore Emacs doesn't. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 11:50:33 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 15:50:33 +0000 Received: from localhost ([127.0.0.1]:58759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwoz-00084I-9z for submit@debbugs.gnu.org; Sun, 30 Jun 2024 11:50:33 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:47575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNwox-000849-Bj for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 11:50:32 -0400 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-52cf4ca8904so3403698e87.3 for <71282@debbugs.gnu.org>; Sun, 30 Jun 2024 08:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719762570; x=1720367370; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UFST5wIdkZ9O+PXWhQc15/FnyEwEN/GrB6WmHAFGMNw=; b=jINQSuJrSJX+LdhVTA3exMjlpd3LxG8k2mO05Xv/eHBBteYsFgTdIBvHTm//TjU5cC sxYegiLtrBu0aHdE6/0Q4Hg/u1v29oAUtxMVVsRbtxTThRpTf89VkRfnp8S1GmUaOvjF WozVFZ/mh4aSn/GMv+jV3Oi0Ft8ASz+Iiz6xRchS+Eb2Cf17UHGIQKsUVlFqo5H/mtQS oBwW576LxMNQDHxBNzs2Ti/yZGcr/ya6k0J7qm4ypBXacRumrSt3zCd6u5AXWfkBjqrr Bp4ixqVwRY/h/Asxo51+BaVtY4Bf9NkbBsrf5QJkPEc5B0go5Eiz64ycZJwmgbbgxdsM bIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719762570; x=1720367370; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UFST5wIdkZ9O+PXWhQc15/FnyEwEN/GrB6WmHAFGMNw=; b=PkaAd5Om6oxKV+QL73rqUfLipuVt/T2MFf8wcpjzaE3GHdubEi52Drh1eDQ+p4gTZk xp4skoKvYb1p6o1Kw+lBcSvK4Tuo0V+du7Twf8d7xicTBi4R+P5wTCkF4HTLJDRu3qUC jV9DwO0oclqJr4ZslQwGFqP01qqHiHT7raLqUmPZOpeanb0AvY9jy9sVMAd/nBCQnyBz WDwltsM1sBtjjl/UcMtosZ4LBJTrEh7jaCQ8cJLpGEQ+GO+Kt8yfUup2T7hI3ua6EGO6 BBP2/uIlQ8fTWK4FAduEUMG1xb4Xm47Bh/WsA1rfFNMOiiskz54/P6UjZO/wcs9C0+JX jVng== X-Forwarded-Encrypted: i=1; AJvYcCUrdA73UOQTflR0H+9hKi1Mc/cRmBxow9lKuGpOmUaFHZtS3trJSaI4pK1jDbPl8ESSg7OtvmL9GzFQ2MykJ+bpOvCAi+U= X-Gm-Message-State: AOJu0YxfeaXU2tP7qvMH3v4pq10l8VvUwjd9HMGJhijJ0u4Qe3olD5+d 7z6XL7v5NK7MS/A8xcmmA5xJiFvc2LjhVND4HnLjhWPlbrJxDDBL7gpFx05cE2V454OAsEl1Q/w PQlKR84I3YYeZa/Um28fSK8aRqmQ= X-Google-Smtp-Source: AGHT+IGKQrGa2USTuq0jBejC5qXZr6l7CMh3Hd6gYN1N2THkuyWAUPxCHqsndcUrsndpcbPmB0lkc/U+kRuCspOETh8= X-Received: by 2002:ac2:46c4:0:b0:52c:dfa2:5ac1 with SMTP id 2adb3069b0e04-52e8266ebddmr1720171e87.24.1719762570076; Sun, 30 Jun 2024 08:49:30 -0700 (PDT) MIME-Version: 1.0 References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> In-Reply-To: <865xtqh2b7.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 30 Jun 2024 16:50:32 +0100 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71282 Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 30, 2024 at 4:34=E2=80=AFPM Eli Zaretskii wrote: > The mechanism exists: find the face of the buffer text, and use it (or > some of its attributes, like background color) in determining the face > of the overlay string. Then if that mechanism doesn't require anything specific of package X or Y, it should be possible to condense in a function (that shouldn't live in Eglot, but OK it it starts life there, I guess) that takes a face with a number of attributes,merges with whatever is "the face of the buffer text" and return an (anonymous) face. If so, then that "mistery" function is the fix to this issue. (overlay-put ov (if peg-after-p 'before-string 'after-string) (propertize text - 'face (pcase kind - (1 'eglot-type-hint-face) - (2 'eglot-parameter-hint-face= ) - (_ 'eglot-inlay-hint-face)))) + 'face + (mistery (pcase kind + (1 'eglot-type-hint-face) + (2 'eglot-parameter-hint-f= ace) + (_ 'eglot-inlay-hint-face)= )))) Else, your earlier suggestion proposing "Eglot to be sensitive to hl-line" -- which I understood as creating an explicit dependency between Eglot and hl-line -- is not a good one, and this is where I agree with Moshin. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 12:37:58 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 16:37:58 +0000 Received: from localhost ([127.0.0.1]:58831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNxYr-0003oO-Vo for submit@debbugs.gnu.org; Sun, 30 Jun 2024 12:37:58 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:54514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNxYq-0003oB-QV for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 12:37:57 -0400 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52ce01403f6so2495584e87.0 for <71282@debbugs.gnu.org>; Sun, 30 Jun 2024 09:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719765410; x=1720370210; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ssW6NrU68b6AsSBtNx253vhrzsXWBt7RvOtIF4C8dec=; b=JVFFpBB75aoCE4GGO23eHPllpAfE7XNMj7jfgLOE1qY7nTupMaUi6Lmy6vqgsJ2B6U L32oMekmptH3HK757VhC8mQwgL03IuVRsJj9NfdpQ24f7a1hqEDE4efRLr9XRf4GKhTg SXPGgo2iw2I1qjFp32zOBBHTSckU75IZpNlQAfAEZ4vazQ1Of3hER/1gLOrYJGYOBDNv sl31q141qjYqDLC4aP8DBTa0qNDxXpZCR/LhSeQ0tAeVJ371RTz0M7EaaMmWrfEc3t2B fmLV1w1D9xiS5lF49GRAMjArVmDMo0EkKm/xDegz3+9Ar7bWGRug6tqmw4vsJztyyijC Qu7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719765410; x=1720370210; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ssW6NrU68b6AsSBtNx253vhrzsXWBt7RvOtIF4C8dec=; b=oLkvkHTV5zZ8CGci/TiGNH6/Uz69mx+2tvPr/S1BPE5WtGZSDg79woD97E/F+ftTJY 8fgP4BZlGwUX/9ur/KvQfMqtJZ2EcoogOHCTDIM2Mq0SooqRh8nRRzYFlS92kRC+5A+A 57XZJS2WVzt6lFVbd4hBfAY7Xir6Vr22TeaONFf/pFgtNVzZMilvgVOQbQDGVG2T2eAI DH+UVlzKqDRBdzNq6V7MgpNBixpUUKSUJ/0wtcnUnaWZGG+ex0dx2fTbN0Gqb+V2/BD2 o/HfiIJR1V70XQppkq5ffxtxZneDsaOuFcm9CPjkyKP2r7Ho3V/NbwN4Y+1ze41W0IgY Af8w== X-Forwarded-Encrypted: i=1; AJvYcCXmRQlDWfimilLqIbDb9hQylCikhdqaAg6dfNEAoo4VfugOOtcy+pxwnVPwbdGfUDABVihlfa0qVI2djVLM9eQGuZO+yA0= X-Gm-Message-State: AOJu0Ywr6V+wN4KulWon3BXIaBP68jnltpTpDNCT+vLavkEdb6fmZf4A lOc28loaYeey1eozgCREotxveS4SgiAgOJKI9Eo41JxLtYc9xaqNyXhr7WybDu+CaK9S6EGC7Hd RBq2+cLNvjiyVb5sRcQMdWpjYsWE= X-Google-Smtp-Source: AGHT+IF3Zg8hM8p0Trt7+et+CKOT0bAPKAIxD63dINdQrFeedpwuSezRrAZuVusqwp5pxe53Pi05z86LlqqZ8z4kItM= X-Received: by 2002:a05:6512:3993:b0:52c:e030:144e with SMTP id 2adb3069b0e04-52e827016e4mr2360674e87.47.1719765410230; Sun, 30 Jun 2024 09:36:50 -0700 (PDT) MIME-Version: 1.0 References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> In-Reply-To: From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 30 Jun 2024 17:37:52 +0100 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71282 Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 30, 2024 at 4:50=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Sun, Jun 30, 2024 at 4:34=E2=80=AFPM Eli Zaretskii wrot= e: > > > The mechanism exists: find the face of the buffer text, and use it (or > > some of its attributes, like background color) in determining the face > > of the overlay string. > > Then if that mechanism doesn't require anything specific of package X or > Y, it should be possible to condense in a function (that shouldn't live i= n > Eglot, but OK it it starts life there, I guess) that takes a face with > a number of > attributes,merges with whatever is "the face of the buffer text" and retu= rn > an (anonymous) face. If so, then that "mistery" function is the fix > to this issue. > > (overlay-put ov (if peg-after-p 'before-string > 'after-string) > (propertize > text > - 'face (pcase kind > - (1 'eglot-type-hint-face) > - (2 'eglot-parameter-hint-fa= ce) > - (_ 'eglot-inlay-hint-face))= )) > + 'face > + (mistery (pcase kind > + (1 'eglot-type-hint-face= ) > + (2 'eglot-parameter-hint= -face) > + (_ 'eglot-inlay-hint-fac= e))))) Never mind, this won't work as whatever face is determined at any given moment, will cease to be adequate as soon as the hl-line extension chooses another face for those positions. So if no low-level automatic merging of overlay faces is to happen in the display engine, this problem doesn't have a solution. Or maybe hl-line could forcibly and constantly repropertize all the overlays on a given line with a given background color if that attribute isn't explicit in the overlay's faces (main text, before string or after string). Then restore those things it as soon as the line is released. If this idea is not too complicated, too brittle or too inneficient, it is at any rate not something that concerns Eglot. Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 13:28:35 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 17:28:36 +0000 Received: from localhost ([127.0.0.1]:58950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNyLr-0005Jt-Lj for submit@debbugs.gnu.org; Sun, 30 Jun 2024 13:28:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNyLq-0005Jh-0R for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 13:28:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNyLj-0002f6-B3; Sun, 30 Jun 2024 13:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MtYJNkHCg7cllMCai8OVMvkcr4i5R7Ip2evw+QmMkdo=; b=juw0dDU8QMsH AZ/YndfTI9+Lq/hJGKKsJ0zJf7eVjpYydxbPvx3ZIHy4J5hceBPbDw54auBVRAxGb1FhCJ1fqndPc iHrbuboQfyR6/1vbFRWL5qGLzL4i9qc2ucYa1ARj/dS0xndAGp5M6nh9v5hCL+TnaKAjqTMAamB8M kaQ7GVf9HZuxdmpGb2tBCjpGwd7yaXRnjX8dFjkKlWrDHEuhSnItTsjQ+RhdDfwu/4sjaeaNOmSKp EuBPywwAk6++ippyJsOkl5hMQ4ARP6D8Qgj4erB7JbEH/sXFf2ZtfCZboQHGjzuTfdabVcmPP1JjI B1tQoKAs/MS9MUlCFGXenw==; Date: Sun, 30 Jun 2024 20:28:23 +0300 Message-Id: <8634ougx1k.fsf@gnu.org> From: Eli Zaretskii To: Mohsin Kaleem In-Reply-To: <8734oucvco.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 30 Jun 2024 16:18:31 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <8734oucvco.fsf@kisara.moe> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, joaotavora@gmail.com, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mohsin Kaleem > Cc: joaotavora@gmail.com, stefankangas@gmail.com, 71282@debbugs.gnu.org > Date: Sun, 30 Jun 2024 16:18:31 +0100 > > Eli Zaretskii writes: > > > I don't think it's a "problem". Overlay strings have their own faces, > > and those override the faces of buffer text. > > Yes, but hl-line is meant to overlay all of that no? Maybe that's what hl-line wants to do (and I'm not sure even that is correct), but doing that is impossible in Emacs, not with a single overlay on the line's text. Emacs simply doesn't support that, never did. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 13:37:30 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 17:37:30 +0000 Received: from localhost ([127.0.0.1]:58992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNyUU-0005bl-7L for submit@debbugs.gnu.org; Sun, 30 Jun 2024 13:37:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNyUS-0005bV-7O for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 13:37:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNyUL-0006ky-Ux; Sun, 30 Jun 2024 13:37:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=PjFyvVHox1EQiuKyCJfDBF4JtsyvqivZ12gFXBMwP1Q=; b=KDsi1s5VBARtH3vPDSO8 CgZJvwbhoTqtKg0GCTJKaM5JO6brHivkiqDlljSOj63HsV0d9sUWJQjOuAOhXb6xVmJuhwf35B0Yd PnBSseaD8g/sZi30lC8HmmmIdc1JTWLgZCAr6D2kZ/vwY0y8Vi4wQIfQCTtv6Bk9u93gxtP7/Hc6o B1t/d0yyanRYM+jsGTimWtbkMSoh4vduB2MKjJK9Ky7FyPGE8vjPfM3bUOJtd9ik9pzJ9eo0l4BZU 770A4J4bbZlhLvpHXRARZ3PB6FLnHLZvdHnuTtTloxJuVuyHItMcuyB4rDKr9JimSHv+NDySPSEXm UPY0zM1UlSEw4A==; Date: Sun, 30 Jun 2024 20:36:53 +0300 Message-Id: <861q4egwne.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 30 Jun 2024 16:50:32 +0100) Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71282 Cc: mohkale@kisara.moe, 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sun, 30 Jun 2024 16:50:32 +0100 > Cc: mohkale@kisara.moe, stefankangas@gmail.com, 71282@debbugs.gnu.org > > On Sun, Jun 30, 2024 at 4:34 PM Eli Zaretskii wrote: > > > The mechanism exists: find the face of the buffer text, and use it (or > > some of its attributes, like background color) in determining the face > > of the overlay string. > > Then if that mechanism doesn't require anything specific of package X or > Y, it should be possible to condense in a function (that shouldn't live in > Eglot, but OK it it starts life there, I guess) that takes a face with > a number of > attributes,merges with whatever is "the face of the buffer text" and return > an (anonymous) face. If so, then that "mistery" function is the fix > to this issue. Patches welcome. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 30 14:11:06 2024 Received: (at 71282) by debbugs.gnu.org; 30 Jun 2024 18:11:06 +0000 Received: from localhost ([127.0.0.1]:59071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNz10-0006XG-AK for submit@debbugs.gnu.org; Sun, 30 Jun 2024 14:11:06 -0400 Received: from mail-lj1-f176.google.com ([209.85.208.176]:51393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNz0x-0006Wh-Sb for 71282@debbugs.gnu.org; Sun, 30 Jun 2024 14:11:05 -0400 Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2ec52fbb50cso21991171fa.2 for <71282@debbugs.gnu.org>; Sun, 30 Jun 2024 11:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719770997; x=1720375797; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YxrVGa+p5BQJhS5HHH7Osvu7Gm1LEiTztnUyFBzS8SU=; b=Mj6nemZ+CWn6ABlhIMl2ryiFKHFvAfTtZCmF1LZ3jfkDx6sNbp74rn3NFK5IYp4Hls 1T/92aoJoo6HpEn8a991l8o7sxJIWCVMkr6t96kvMs2JdfHUIe+oH//r1qHl0J2so3Ig n1936UzB710aP+0GqCRpVLo+tAcZ28M9nYAZpCEDuW+jYs1RDr+zOqIvDjpmQJvwG+Fb 5pbKHYNe6QoU/V4fLRzGVMId1u4Mpiier+T9QPtAH2PsYkbmE75NAwwYTZ9f9vo+iX9s dLHIssyR+zHT0/Hi7kpbZU7Hmx3q8VtlNgLnzcnC09A+1tAYFs104iiSosPRJJQ4wooH kl5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719770997; x=1720375797; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YxrVGa+p5BQJhS5HHH7Osvu7Gm1LEiTztnUyFBzS8SU=; b=rNqqDzMhwGW8VD9e3LiXyNyS0XhBqfapIQiLuemJ7HIh9X7LRV90HLeaReR9UUimZQ bcfbh56/DvhEuqPkUngI8ikuhIbtUFm535a+Zk1eFGdrOkMYu/7pNg+mCNim+UYHQqVh QAujZvhfCO6FFfsbryub6BFHT37roRuxgN6fZ7E8My8t87Mw57V0mFMvLCUL3HLq9wus viAfjl9KN9O6RTGMHAD51jFGSzRKVmymLnv+JjXgVKlRw11ee9O1lEVQZEn5XImk5yb4 d/FBba/iYG0GxnuscHepLqAtv6Uqa4jcG1dV1I3m/qTyDDkBzrzw+CKxW71DdPPiGcnh bIVg== X-Forwarded-Encrypted: i=1; AJvYcCVj88HRM4dwD2fDb2eTxUVTCll5bmTVLYJUolON92Vsl1NOdkUogTAtQGAQkFE3MlklPuk0nRD5qTyA5ZTd5p79IzmBrbw= X-Gm-Message-State: AOJu0YwUKZ7V1VmSijg+eSsrakd7cthOUPER9Gn4jgg5fwskAjA1LW2h US6T4fzKm+dgYODlDT0Zc24D+4L6P+LgWH2ttyG1Ochn6KCtC3J5H/WzC5tU/HsPkyuFTHXLj1L Cq1k0alF+lVNbMPTd4+XF0TnfEkg= X-Google-Smtp-Source: AGHT+IE/I8m890Q5gtGmTtjXc7WFwrNW+I9/y25ATEPV9yIn6/SsVdAuDEsS9ot48/XJ0JLmY+tsVYsjPDrZzOGaemo= X-Received: by 2002:a05:6512:31c9:b0:52c:daa4:2f5c with SMTP id 2adb3069b0e04-52e826fc0d0mr2196149e87.42.1719770997376; Sun, 30 Jun 2024 11:09:57 -0700 (PDT) MIME-Version: 1.0 References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> <861q4egwne.fsf@gnu.org> In-Reply-To: <861q4egwne.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 30 Jun 2024 19:09:45 +0100 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000064cde1061c1f636f" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 71282 Cc: mohsin kaleem , 71282@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000064cde1061c1f636f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jun 30, 2024, 18:37 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Sun, 30 Jun 2024 16:50:32 +0100 > > Cc: mohkale@kisara.moe, stefankangas@gmail.com, 71282@debbugs.gnu.org > > > > On Sun, Jun 30, 2024 at 4:34=E2=80=AFPM Eli Zaretskii wr= ote: > > > > > The mechanism exists: find the face of the buffer text, and use it (o= r > > > some of its attributes, like background color) in determining the fac= e > > > of the overlay string. > > > > Then if that mechanism doesn't require anything specific of package X o= r > > Y, it should be possible to condense in a function (that shouldn't live > in > > Eglot, but OK it it starts life there, I guess) that takes a face with > > a number of > > attributes,merges with whatever is "the face of the buffer text" and > return > > an (anonymous) face. If so, then that "mistery" function is the fix > > to this issue. > > Patches welcome. > No need, not for this at last. I've already explained how it doesn't fix the problem, but anyone is free to experiment. > --00000000000064cde1061c1f636f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jun 30, 2024, 18:37 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavo= ra@gmail.com>
> Date: Sun, 30 Jun 2024 16:50:32 +0100
> Cc: mohkale@kisara.moe, stefankangas@gmail.com, 71282@debbu= gs.gnu.org
>
> On Sun, Jun 30, 2024 at 4:34=E2=80=AFPM Eli Zaretskii <eliz@gnu.org&g= t; wrote:
>
> > The mechanism exists: find the face of the buffer text, and use i= t (or
> > some of its attributes, like background color) in determining the= face
> > of the overlay string.
>
> Then if that mechanism doesn't require anything specific of packag= e X or
> Y, it should be possible to condense in a function (that shouldn't= live in
> Eglot, but OK it it starts life there, I guess) that takes a face with=
> a number of
> attributes,merges with whatever is "the face of the buffer text&q= uot; and return
> an (anonymous) face.=C2=A0 If so, then that "mistery" functi= on is the fix
> to this issue.

Patches welcome.

No need, not for this at last. I've already explained h= ow it doesn't fix the problem, but anyone is free to experiment.
<= div dir=3D"auto">
--00000000000064cde1061c1f636f-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 08:35:57 2024 Received: (at 71282) by debbugs.gnu.org; 1 Jul 2024 12:35:57 +0000 Received: from localhost ([127.0.0.1]:60457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOGGD-000287-FD for submit@debbugs.gnu.org; Mon, 01 Jul 2024 08:35:57 -0400 Received: from 119.ip-51-38-65.eu ([51.38.65.119]:57388 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOGGC-00027x-2B for 71282@debbugs.gnu.org; Mon, 01 Jul 2024 08:35:56 -0400 Received: from mk-desktop (unknown [140.228.49.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 185CCA2796; Mon, 1 Jul 2024 14:35:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1719837354; bh=soE3Z8UvY2FNrYl1uSTrd+bqKcw5d0bTqzd1aiq8VzA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=2C6Qdd588CSFuYa8jTphTjIsIT1dl10ydYQ6JWUpwAUa8LVVBjlmCaQYjpxXrwMFi RnfPTQ8y1WTl06PFsetIRhH/tNRpkysPN1+jXC5fBKJpUIZYycWZhjxi8aU0sLD+RE oejpjWZaD+91F4IH6tI5B5ChRgnkG/ai4zfSIW0rn06Fet8PjlVPX5SYJ93A9f1a6T rUT8RPJU0jmCFMbJiEMmlc+8sELlNpzUsMbN2Fyf468aMKCQWk6Fmemnv4Jde8PJyR E7i+7j9U/1gGVute5AjnO9C7oWtz0+ScZU35uymPWYUEGTa1ae1dL2aGG4aKrH9Pky wYZLMbGWaZolQ== From: Mohsin Kaleem To: Eli Zaretskii , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect In-Reply-To: <861q4egwne.fsf@gnu.org> References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> <861q4egwne.fsf@gnu.org> Date: Mon, 01 Jul 2024 13:35:52 +0100 Message-ID: <87tth9uw5z.fsf@kisara.moe> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 71282 Cc: 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) Eli Zaretskii writes: >> >> Then if that mechanism doesn't require anything specific of package X or >> Y, it should be possible to condense in a function (that shouldn't live in >> Eglot, but OK it it starts life there, I guess) that takes a face with >> a number of >> attributes,merges with whatever is "the face of the buffer text" and return >> an (anonymous) face. If so, then that "mistery" function is the fix >> to this issue. > > Patches welcome. Any tips or suggestions for where to start if one wants to implement something like this? I'll try taking a look at some of the related code and how to get some kind of merging setup. Probably not very soon tho XD. In the meantime could this issue ticket be re-opened? I think it was closed as resolved but I think it's still a problem with the way annotations are setup in Emacs. -- Mohsin Kaleem From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 01 09:52:22 2024 Received: (at 71282) by debbugs.gnu.org; 1 Jul 2024 13:52:22 +0000 Received: from localhost ([127.0.0.1]:60614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOHS9-0004bQ-RV for submit@debbugs.gnu.org; Mon, 01 Jul 2024 09:52:22 -0400 Received: from mail-lf1-f50.google.com ([209.85.167.50]:57622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sOHS7-0004b9-0k for 71282@debbugs.gnu.org; Mon, 01 Jul 2024 09:52:20 -0400 Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52cdc4d221eso3312435e87.3 for <71282@debbugs.gnu.org>; Mon, 01 Jul 2024 06:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719841871; x=1720446671; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JiTGSc6F9iqfpXh8nKTsKngrCZ3RALWHI4B6DDN/hjI=; b=bjDMGJPRhZzWzQgKaxxykHPN8SWTl64tdkF1zhHX5DRGyyulHrPK/DUK43opWIhpDo l32HYxd3LXDbDejLCsjwVLTrT545dW9Xg+DbAL5ruhTqwiUaAWfHG9pceobWXOYebBs9 LrHlqvn1TyR/tKyEvfzq9Xf5ttTs8WP2WhzgfmsPBrLgPN3q02z+4pRjmk5th3Y1h51g 139bzlKhpVHjZ1EjaxqF5LdhV62mBWLsos1aFkN1PczcQZx317Oz/kfC179zC+K7SuHS pGDO0fIy82CaJkIqLjdJ9pX5H2xEoFVZixF56/jS8Ty/sQ2bz0ChPzY81tv3hzJiQIzK H7JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719841871; x=1720446671; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JiTGSc6F9iqfpXh8nKTsKngrCZ3RALWHI4B6DDN/hjI=; b=NmZJrP8YiQRsFxLjZFthIv9ggezpQXeRhLW2qMOc9E4Ywg0GNpyweTkLQHJ/gd2Bqg vrBTb77gXL6+3+L+1YYeAzB9Va+W/yjsZzccz180+k6hjKN0iCaiaL2wD/RUgH4I+9mG u78RBAe2GcGwWyUNAC0dg+aSGzphYGniA5Apk/JcFynSj2dH+YOuZloKnKShDPuu0fed rMEVgxMEZ+ctoKkeRYovwRE4qSz6vP5livoZct1zkfhJ/+xCsT7Y8Nbn3c9xN2lGjjIM /TREt2YFm/g20hcvv191sQPFZFaNZL1pxQDyyN8IaodKcVm7Dtl8sxsPmlv7bUx9vkBM SJnw== X-Forwarded-Encrypted: i=1; AJvYcCVFoSwh6BRWQ5VY8MqM4akMnz4S7XC3Os3aCVGNg0Ntdm3hC97d658xii9V4P+7ryRNmfTP6z1avnH91kRquG9KJqVVA98= X-Gm-Message-State: AOJu0YyZyxPkEEt1HUAsKFB/+3KhAiKmFB4dJcfQqLcX7lRaxB1KSwGo HuDSQZ3Ga+W+qXiN0ngwq4CMEo7b1SpbaniUU6YMYYdrBtI8dVwSgAKayvoNscjsv867/lVAjCi CjTvSLRvMHYiauuHizyKgfdVqOFk= X-Google-Smtp-Source: AGHT+IHlIoreKUJQT506Q4Sb+7J4J8T0RnGJZCDOCd+EYS9QpxuZB4r2bZrCdtN3pmNWMHidziPu7oGXojmch2xSw2Y= X-Received: by 2002:a19:5f41:0:b0:52d:b1c9:34e with SMTP id 2adb3069b0e04-52e82666444mr2880596e87.21.1719841871208; Mon, 01 Jul 2024 06:51:11 -0700 (PDT) MIME-Version: 1.0 References: <87plt3lyvd.fsf@kisara.moe> <8634pyr0w8.fsf@gnu.org> <878qymd5ce.fsf@kisara.moe> <86a5j2hb6j.fsf@gnu.org> <875xtqczuu.fsf@kisara.moe> <867ce6h4iq.fsf@gnu.org> <865xtqh2b7.fsf@gnu.org> <861q4egwne.fsf@gnu.org> <87tth9uw5z.fsf@kisara.moe> In-Reply-To: <87tth9uw5z.fsf@kisara.moe> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 1 Jul 2024 14:50:59 +0100 Message-ID: Subject: Re: bug#71282: 30.0.50; hl-line overlay priority has no affect To: Mohsin Kaleem Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71282 Cc: Eli Zaretskii , 71282@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, Jul 1, 2024 at 1:35=E2=80=AFPM Mohsin Kaleem w= rote: > > Eli Zaretskii writes: > >> > >> Then if that mechanism doesn't require anything specific of package X = or > >> Y, it should be possible to condense in a function (that shouldn't liv= e in > >> Eglot, but OK it it starts life there, I guess) that takes a face with > >> a number of > >> attributes,merges with whatever is "the face of the buffer text" and r= eturn > >> an (anonymous) face. If so, then that "mistery" function is the fix > >> to this issue. > > > > Patches welcome. > > Any tips or suggestions for where to start if one wants to implement > something like this? I'll try taking a look at some of the related code > and how to get some kind of merging setup. Probably not very soon tho > XD. Moshin, I don't know if you read my later email, but I'd like to point out that that function, which I briefly thought could be used to fix this issue, is NOT the solution. I'm fairly sure it won't work, at least not for the hl-line use case you bring forth. As far as I can see, short of an xdisp.c fix for this, the Elisp solution is very hard and involves hl-line doing perhaps extraordinary amounts of work in 'hl-line-highlight' and 'hl-line-unhighlight' to account for intersecting overlays, their after strings, before strings, but only in those parts that touch the line to be highlighted. Jo=C3=A3o From unknown Wed Jun 18 23:13:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Jul 2024 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator