GNU bug report logs - #71269
[PATCH 1/2] sdiff: Match execvp argument types

Previous Next

Full log

View this message in rfc822 format

From: Khem Raj <raj.khem <at> gmail.com>
To: 71269 <at> debbugs.gnu.org
Cc: Khem Raj <raj.khem <at> gmail.com>
Subject: bug#71269: [PATCH 1/2] sdiff: Match execvp argument types
Date: Wed, 29 May 2024 21:55:24 -0700

Fixes build with GCC-14

../../diffutils-3.10/src/sdiff.c:579:28: error: passing argument 2 of '_execvp' from incompatible pointer type [-Wincompatible-pointer-types]
  579 |       execvp (diffargv[0], (char **) diffargv);
      |                            ^~~~~~~~~~~~~~~~~~
      |                            |
      |                            char **

* src/sdiff.c (main): execpv expects const pointer.

Upstream-Status: Submitted [https://lists.gnu.org/archive/html/diffutils-devel/2024-05/msg00000.html]
Signed-off-by: Khem Raj <raj.khem <at> gmail.com>
---
 src/sdiff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sdiff.c b/src/sdiff.c
index 0b638d4..a4642b1 100644
--- a/src/sdiff.c
+++ b/src/sdiff.c
@@ -576,7 +576,7 @@ main (int argc, char *argv[])
       diffarg (argv[optind]);
       diffarg (argv[optind + 1]);
       diffarg (0);
-      execvp (diffargv[0], (char **) diffargv);
+      execvp (diffargv[0], diffargv);
       perror_fatal (diffargv[0]);
     }
   else
-- 
2.45.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.