From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 05:59:03 2024 Received: (at submit) by debbugs.gnu.org; 28 May 2024 09:59:03 +0000 Received: from localhost ([127.0.0.1]:45711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBtbj-0006pG-Ad for submit@debbugs.gnu.org; Tue, 28 May 2024 05:59:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:43324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBtbg-0006oq-NT for submit@debbugs.gnu.org; Tue, 28 May 2024 05:59:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtbX-0004M3-4Q for guix-patches@gnu.org; Tue, 28 May 2024 05:58:51 -0400 Received: from 18.mo581.mail-out.ovh.net ([188.165.56.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtax-0001pq-C0 for guix-patches@gnu.org; Tue, 28 May 2024 05:58:19 -0400 Received: from director1.ghost.mail-out.ovh.net (unknown [10.108.17.189]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4VpScs1GyWz1LCF for ; Tue, 28 May 2024 09:58:05 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-4pkjc (unknown [10.108.54.121]) by director1.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 487351FE9A; Tue, 28 May 2024 09:58:02 +0000 (UTC) Received: from ngraves.fr ([37.59.142.101]) by ghost-submission-6684bf9d7b-4pkjc with ESMTPSA id GxvXKaqqVWZEcgAAtEeXKg (envelope-from ); Tue, 28 May 2024 09:58:02 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-101G004422002f1-2591-45c0-9372-68246d969a55, 82F8FC4CBDF1420FC49AACA8B22D65D2A430FDE8) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.146.208 From: Nicolas Graves To: guix-patches@gnu.org Subject: [PATCH] gnu: Add emacs-dape. Date: Tue, 28 May 2024 11:57:57 +0200 Message-ID: <20240528095800.20728-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 12298486158845076194 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrvdejiedgvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepgfehheegueduheeuveffkeffieektedtleegffejgfdvjeeivdekjeefveekvddunecuffhomhgrihhnpehgihhthhhusgdrtghomhdpshhrrdhhthenucfkphepuddvjedrtddrtddruddpkedurdeijedrudegiedrvddtkedpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkedupdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=188.165.56.163; envelope-from=ngraves@ngraves.fr; helo=18.mo581.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/emacs-xyz.scm (emacs-dape): New variable. Change-Id: Ia07745dd47b2e1e5b85654a5b4b2400dd4c4cc13 --- gnu/packages/emacs-xyz.scm | 52 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 1c890a5b008..9f93d582f3f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -31088,6 +31088,58 @@ (define-public emacs-lsp-docker in Docker environment.") (license license:gpl3+)))) +(define-public emacs-dape + (let ((commit "51fad7df7473778fbc4bac703317de7f7713b307") + (revision "0")) + (package + (name "emacs-dape") + (version (git-version "0.12.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/svaante/dape") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1jics02b9fxjs0lykiv7z924z18id550mqhf6piqzv0sgan91pg2")))) + (build-system emacs-build-system) + (arguments + ;; FIXME python tests pass, JS tests require additional dependencies + ;; See https://lists.sr.ht/~abcdw/rde-devel/patches/51878 + (list #:tests? #f + #:test-command #~'("emacs" "--batch" "-l" "dape.el" + "-l" "dape-tests.el" + "-f" "ert-run-tests-batch-and-exit") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'support-unwrapped-python + (lambda _ + (substitute* "dape.el" + (("command \"python\"") + "command \"python3\"")))) + (add-before 'check 'pre-check + (lambda* (#:key tests? inputs #:allow-other-keys) + (if tests? + (setenv + "PATH" + (string-append + (getenv "PATH") + ":" (dirname (search-input-file inputs "/bin/python3")) + ":" (dirname (search-input-file inputs "/bin/node")))) + (format #t "test suite not run~%"))))))) + (native-inputs (list node-lts python-minimal python-debugpy)) + (propagated-inputs (list emacs-jsonrpc)) + (home-page "https://github.com/svaante/dape") + (synopsis "Debug Adapter Protocol for Emacs") + (description + "Dape is a debug adapter client for Emacs. The debug adapter protocol, +much like its more well-known counterpart, the language server protocol, +aims to establish a common API for programming tools. However, instead of +functionalities such as code completions, it provides a standardized +interface for debuggers.") + (license license:gpl3+)))) + (define-public emacs-dap-mode (package (name "emacs-dap-mode") -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 09 16:53:04 2024 Received: (at submit) by debbugs.gnu.org; 9 Jun 2024 20:53:04 +0000 Received: from localhost ([127.0.0.1]:59986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGPXD-0000X4-NH for submit@debbugs.gnu.org; Sun, 09 Jun 2024 16:53:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:54010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGPXB-0000Wd-Pc for submit@debbugs.gnu.org; Sun, 09 Jun 2024 16:53:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGPWu-00043M-Vn for guix-patches@gnu.org; Sun, 09 Jun 2024 16:52:44 -0400 Received: from mail1.fsfe.org ([2001:aa8:ffed:f5f3::151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGPWs-0001VL-1H for guix-patches@gnu.org; Sun, 09 Jun 2024 16:52:44 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1717966354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i1QktoRvfefncPTFuwNgVEe/g3Eyayexpj9lLqrC3II=; b=eGLVgODMVxGwKAWoMK6esTQrgz3EJcBZliYlt01D43VgK7JVARAM8n8jSTIFgUdQkWLuxi 9/xGPM9irBf0HBzaGgfBxoDOIzw6091f3ktmOMP1RjO7hUrb4ztVXcLfGbwHX4cyc3CMcr zUygSk84WkqfV9HYHX60y2G/Qstkd1U= To: Nicolas Graves via Guix-patches via , 71239@debbugs.gnu.org Subject: Re: [bug#71239] [PATCH] gnu: Add emacs-dape. In-Reply-To: <20240528095800.20728-1-ngraves@ngraves.fr> References: <20240528095800.20728-1-ngraves@ngraves.fr> Date: Sun, 09 Jun 2024 22:52:32 +0200 Message-ID: <87r0d5et4f.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:aa8:ffed:f5f3::151; envelope-from=jlicht@fsfe.org; helo=mail1.fsfe.org X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: ngraves@ngraves.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi Nicolas, I've got some nitpicks, and one question as the package does not seem to run for me, which could very well be an issue on my end. Nicolas Graves via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-dape): New variable. > > Change-Id: Ia07745dd47b2e1e5b85654a5b4b2400dd4c4cc13 > --- > gnu/packages/emacs-xyz.scm | 52 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 1c890a5b008..9f93d582f3f 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -31088,6 +31088,58 @@ (define-public emacs-lsp-docker > in Docker environment.") > (license license:gpl3+)))) > > +(define-public emacs-dape > + (let ((commit "51fad7df7473778fbc4bac703317de7f7713b307") > + (revision "0")) > + (package > + (name "emacs-dape") > + (version (git-version "0.12.0" revision commit)) Is there a particular reason not to stick to the 'proper' releases? If so, could you add a comment explaining why? > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/svaante/dape") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1jics02b9fxjs0lykiv7z924z18id550mqhf6piqzv0sgan91pg2")))) > + (build-system emacs-build-system) > + (arguments > + ;; FIXME python tests pass, JS tests require additional dependencies > + ;; See https://lists.sr.ht/~abcdw/rde-devel/patches/51878 > + (list #:tests? #f Can't we patch out or disable the JS tests, instead of not running any tests? > + #:test-command #~'("emacs" "--batch" "-l" "dape.el" > + "-l" "dape-tests.el" > + "-f" "ert-run-tests-batch-and-exit") > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'support-unwrapped-python > + (lambda _ > + (substitute* "dape.el" > + (("command \"python\"") > + "command \"python3\"")))) I don't think we do this kind of patching for other packages, but I could be mistaken of course. If this was needed to get the python tests to succeed, maybe it could also work with python-minimal-wrapper instead of patching. > + (add-before 'check 'pre-check > + (lambda* (#:key tests? inputs #:allow-other-keys) > + (if tests? > + (setenv > + "PATH" > + (string-append > + (getenv "PATH") > + ":" (dirname (search-input-file inputs "/bin/python3")) > + ":" (dirname (search-input-file inputs "/bin/node")))) Ditto wrt my earlier remark about the JS tests. > + (format #t "test suite not run~%"))))))) > + (native-inputs (list node-lts python-minimal python-debugpy)) > + (propagated-inputs (list emacs-jsonrpc)) Did running this package once installed actually work on your local setup? If so, I'd love to know how you are running this package, as I'm running into the issue as the one I reported at https://issues.guix.gnu.org/71065 > + (home-page "https://github.com/svaante/dape") > + (synopsis "Debug Adapter Protocol for Emacs") > + (description > + "Dape is a debug adapter client for Emacs. The debug adapter protocol, > +much like its more well-known counterpart, the language server protocol, > +aims to establish a common API for programming tools. However, instead of > +functionalities such as code completions, it provides a standardized > +interface for debuggers.") > + (license license:gpl3+)))) > + > (define-public emacs-dap-mode > (package > (name "emacs-dap-mode") > -- > 2.41.0 Thanks for the package, - Jelle From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 03:55:32 2024 Received: (at submit) by debbugs.gnu.org; 10 Jun 2024 07:55:32 +0000 Received: from localhost ([127.0.0.1]:42646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZsI-0007EA-N8 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 03:55:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:59406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZoG-00070x-Q1 for submit@debbugs.gnu.org; Mon, 10 Jun 2024 03:51:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGZnz-00007E-EI for guix-patches@gnu.org; Mon, 10 Jun 2024 03:51:03 -0400 Received: from 12.mo581.mail-out.ovh.net ([178.33.107.167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGZnw-0003vC-Jg for guix-patches@gnu.org; Mon, 10 Jun 2024 03:51:03 -0400 Received: from director6.ghost.mail-out.ovh.net (unknown [10.108.17.59]) by mo581.mail-out.ovh.net (Postfix) with ESMTP id 4VyPB04cy1z1HTl for ; Mon, 10 Jun 2024 07:50:48 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-d6g8g (unknown [10.110.96.146]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 1F7FF1FD4B; Mon, 10 Jun 2024 07:50:48 +0000 (UTC) Received: from ngraves.fr ([37.59.142.109]) by ghost-submission-6684bf9d7b-d6g8g with ESMTPSA id +Yf5AliwZmY0GgAAdzjNUA (envelope-from ); Mon, 10 Jun 2024 07:50:48 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-109S003c17faedd-4de2-41e9-86ba-65ed37b6467b, 65DE7E7CE59A20633CAAFB457A882DDB495B4BE4) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 90.110.172.34 From: Nicolas Graves To: Jelle Licht , Nicolas Graves via Guix-patches via , 71239@debbugs.gnu.org Subject: Re: [bug#71239] [PATCH] gnu: Add emacs-dape. In-Reply-To: <87r0d5et4f.fsf@fsfe.org> References: <20240528095800.20728-1-ngraves@ngraves.fr> <87r0d5et4f.fsf@fsfe.org> Date: Mon, 10 Jun 2024 09:50:28 +0200 Message-ID: <87o789tewr.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12706906351449072368 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrfedtledgieekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeiueegteefleffheeiieetueffheffgefftdeukefhheetfeehleduhfejjedugfenucffohhmrghinhepshhrrdhhthdpghhnuhdrohhrghenucfkphepuddvjedrtddrtddruddpledtrdduuddtrddujedvrdefgedpfeejrdehledrudegvddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehkedupdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=178.33.107.167; envelope-from=ngraves@ngraves.fr; helo=12.mo581.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 2024-06-09 22:52, Jelle Licht wrote: > Hi Nicolas, > > I've got some nitpicks, and one question as the package does not seem to > run for me, which could very well be an issue on my end. > >> + (name "emacs-dape") >> + (version (git-version "0.12.0" revision commit)) > Is there a particular reason not to stick to the 'proper' releases? > If so, could you add a comment explaining why? There are no upstream tags, this is simply the commit of the tag, IIRC. So it's the proper release. Maybe I should simply put the version here and use git-version in the origin field instead ? >> + (arguments >> + ;; FIXME python tests pass, JS tests require additional dependencies >> + ;; See https://lists.sr.ht/~abcdw/rde-devel/patches/51878 >> + (list #:tests? #f > Can't we patch out or disable the JS tests, instead of not running any > tests? Doable, although using I'm not sure there's a light approach for this rather than patching half the file, which I think is not worth it. Will investigate. >> + #:test-command #~'("emacs" "--batch" "-l" "dape.el" >> + "-l" "dape-tests.el" >> + "-f" "ert-run-tests-batch-and-exit") >> + #:phases >> + #~(modify-phases %standard-phases >> + (add-after 'unpack 'support-unwrapped-python >> + (lambda _ >> + (substitute* "dape.el" >> + (("command \"python\"") >> + "command \"python3\"")))) > > I don't think we do this kind of patching for other packages, but I > could be mistaken of course. If this was needed to get the python tests > to succeed, maybe it could also work with python-minimal-wrapper instead > of patching. Since python is not propagated, this would mean that we expect the user to have python-wrapper instead of python, I'm not sure we want to enforce that because it might cause users to have to debug this. We can of course propagate python-wrapper instead, but then we increase the closure size. >> + (format #t "test suite not run~%"))))))) >> + (native-inputs (list node-lts python-minimal python-debugpy)) >> + (propagated-inputs (list emacs-jsonrpc)) > > Did running this package once installed actually work on your local > setup? If so, I'd love to know how you are running this package, as I'm > running into the issue as the one I reported at > https://issues.guix.gnu.org/71065 No, actually I couldn't, but I didn't settled for a stable configuration, I wanted to send that to RDE, but haven't done it yet. > Thanks for the package, > - Jelle -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 03:56:57 2024 Received: (at 71239) by debbugs.gnu.org; 10 Jun 2024 07:56:57 +0000 Received: from localhost ([127.0.0.1]:42766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZth-0007Ik-6g for submit@debbugs.gnu.org; Mon, 10 Jun 2024 03:56:57 -0400 Received: from 7.mo561.mail-out.ovh.net ([46.105.57.200]:41965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZte-0007IV-09 for 71239@debbugs.gnu.org; Mon, 10 Jun 2024 03:56:55 -0400 Received: from director4.ghost.mail-out.ovh.net (unknown [10.109.176.51]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 4VyPJg2hNwz19xy for <71239@debbugs.gnu.org>; Mon, 10 Jun 2024 07:56:35 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-gbttq (unknown [10.110.178.59]) by director4.ghost.mail-out.ovh.net (Postfix) with ESMTPS id C07EE1FDF8; Mon, 10 Jun 2024 07:56:34 +0000 (UTC) Received: from ngraves.fr ([37.59.142.107]) by ghost-submission-6684bf9d7b-gbttq with ESMTPSA id bA3mKbKxZmYMHgAAzsHhqg (envelope-from ); Mon, 10 Jun 2024 07:56:34 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S0017bc0a202-786c-412e-924d-a26f0840403b, 65DE7E7CE59A20633CAAFB457A882DDB495B4BE4) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 90.110.172.34 From: Nicolas Graves To: Jelle Licht , Nicolas Graves via Guix-patches via , 71239@debbugs.gnu.org Subject: Re: [bug#71239] [PATCH] gnu: Add emacs-dape. In-Reply-To: <87r0d5et4f.fsf@fsfe.org> References: <20240528095800.20728-1-ngraves@ngraves.fr> <87r0d5et4f.fsf@fsfe.org> Date: Mon, 10 Jun 2024 09:56:33 +0200 Message-ID: <87le3dtemm.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12804578168779236080 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrfedtledgieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeetveeifeelveduffffudeifeethfekgfefgfekjedtlefhvddtkedtudehjeelhfenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhsrhdrhhhtpdhgnhhurdhorhhgnecukfhppeduvdejrddtrddtrddupdeltddruddutddrudejvddrfeegpdefjedrheelrddugedvrddutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpehnghhrrghvvghssehnghhrrghvvghsrdhfrhdpnhgspghrtghpthhtohepuddprhgtphhtthhopeejuddvfeelseguvggssghughhsrdhgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedupdhmohguvgepshhmthhpohhuth X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71239 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2024-06-09 22:52, Jelle Licht wrote: > Hi Nicolas, > > I've got some nitpicks, and one question as the package does not seem to > run for me, which could very well be an issue on my end. Ow I probably have forgotten to block the patch, but it depends on emacs-jsonrpc@0.25, which is not the current version in Guix. I've sent a patch in 70998. Although I understand now that updating native emacs packages is not that simple - I've seen a mail thread about this. > > Nicolas Graves via Guix-patches via writes: > >> * gnu/packages/emacs-xyz.scm (emacs-dape): New variable. >> >> Change-Id: Ia07745dd47b2e1e5b85654a5b4b2400dd4c4cc13 >> --- >> gnu/packages/emacs-xyz.scm | 52 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index 1c890a5b008..9f93d582f3f 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -31088,6 +31088,58 @@ (define-public emacs-lsp-docker >> in Docker environment.") >> (license license:gpl3+)))) >> >> +(define-public emacs-dape >> + (let ((commit "51fad7df7473778fbc4bac703317de7f7713b307") >> + (revision "0")) >> + (package >> + (name "emacs-dape") >> + (version (git-version "0.12.0" revision commit)) > Is there a particular reason not to stick to the 'proper' releases? > If so, could you add a comment explaining why? > >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/svaante/dape") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "1jics02b9fxjs0lykiv7z924z18id550mqhf6piqzv0sgan91pg2")))) >> + (build-system emacs-build-system) >> + (arguments >> + ;; FIXME python tests pass, JS tests require additional dependencies >> + ;; See https://lists.sr.ht/~abcdw/rde-devel/patches/51878 >> + (list #:tests? #f > Can't we patch out or disable the JS tests, instead of not running any tests? > >> + #:test-command #~'("emacs" "--batch" "-l" "dape.el" >> + "-l" "dape-tests.el" >> + "-f" "ert-run-tests-batch-and-exit") >> + #:phases >> + #~(modify-phases %standard-phases >> + (add-after 'unpack 'support-unwrapped-python >> + (lambda _ >> + (substitute* "dape.el" >> + (("command \"python\"") >> + "command \"python3\"")))) > > I don't think we do this kind of patching for other packages, but I > could be mistaken of course. If this was needed to get the python tests > to succeed, maybe it could also work with python-minimal-wrapper instead > of patching. > >> + (add-before 'check 'pre-check >> + (lambda* (#:key tests? inputs #:allow-other-keys) >> + (if tests? >> + (setenv >> + "PATH" >> + (string-append >> + (getenv "PATH") >> + ":" (dirname (search-input-file inputs "/bin/python3")) >> + ":" (dirname (search-input-file inputs "/bin/node")))) > > Ditto wrt my earlier remark about the JS tests. > >> + (format #t "test suite not run~%"))))))) >> + (native-inputs (list node-lts python-minimal python-debugpy)) >> + (propagated-inputs (list emacs-jsonrpc)) > > Did running this package once installed actually work on your local > setup? If so, I'd love to know how you are running this package, as I'm > running into the issue as the one I reported at > https://issues.guix.gnu.org/71065 > >> + (home-page "https://github.com/svaante/dape") >> + (synopsis "Debug Adapter Protocol for Emacs") >> + (description >> + "Dape is a debug adapter client for Emacs. The debug adapter protocol, >> +much like its more well-known counterpart, the language server protocol, >> +aims to establish a common API for programming tools. However, instead of >> +functionalities such as code completions, it provides a standardized >> +interface for debuggers.") >> + (license license:gpl3+)))) >> + >> (define-public emacs-dap-mode >> (package >> (name "emacs-dap-mode") >> -- >> 2.41.0 > > > Thanks for the package, > - Jelle -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 10 04:10:32 2024 Received: (at control) by debbugs.gnu.org; 10 Jun 2024 08:10:32 +0000 Received: from localhost ([127.0.0.1]:43701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGa6p-00080I-4i for submit@debbugs.gnu.org; Mon, 10 Jun 2024 04:10:32 -0400 Received: from 9.mo576.mail-out.ovh.net ([46.105.56.78]:60679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGZuQ-0007LE-7s for control@debbugs.gnu.org; Mon, 10 Jun 2024 03:57:43 -0400 Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.148.87]) by mo576.mail-out.ovh.net (Postfix) with ESMTP id 4VyPKc0sZMz1gG1 for ; Mon, 10 Jun 2024 07:57:24 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-ktxqj (unknown [10.110.168.37]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id C3E831FD1C for ; Mon, 10 Jun 2024 07:57:23 +0000 (UTC) Received: from ngraves.fr ([37.59.142.99]) by ghost-submission-6684bf9d7b-ktxqj with ESMTPSA id Bl8pLeOxZmbvDAAAF72/SQ (envelope-from ) for ; Mon, 10 Jun 2024 07:57:23 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-99G003737609ed-af7f-47c7-bd58-099ca56273f1, 65DE7E7CE59A20633CAAFB457A882DDB495B4BE4) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 90.110.172.34 From: Nicolas Graves To: control@debbugs.gnu.org Subject: control message for bug #71239 Date: Mon, 10 Jun 2024 09:57:23 +0200 Message-ID: <87ikyhtel8.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 12818370440539136613 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvledrfedtledgieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvffufffkgggtsehttdertddttddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepueejleeileejfffhleetjedtleejheevudffleevgfdufeekhefgvddvveegveefnecukfhppeduvdejrddtrddtrddupdeltddruddutddrudejvddrfeegpdefjedrheelrddugedvrdelleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtoheptghonhhtrhholhesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheejiedpmhhouggvpehsmhhtphhouhht X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) block 71239 by 70998 quit -- Best regards, Nicolas Graves From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 19 03:59:23 2024 Received: (at submit) by debbugs.gnu.org; 19 Jun 2024 07:59:23 +0000 Received: from localhost ([127.0.0.1]:36262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJqDz-00042t-7m for submit@debbugs.gnu.org; Wed, 19 Jun 2024 03:59:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:47108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJqDw-00042h-Lu for submit@debbugs.gnu.org; Wed, 19 Jun 2024 03:59:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJqDt-0003iT-7I for guix-patches@gnu.org; Wed, 19 Jun 2024 03:59:17 -0400 Received: from msg-1.mailo.com ([213.182.54.11] helo=mailo.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJqDr-0007AO-QV for guix-patches@gnu.org; Wed, 19 Jun 2024 03:59:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1718783954; bh=EbKZ5fh1NG8JwF0hctvYtz4jZoW7EqziljsgBjzSAmk=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=bGB/TU+UhGd6lu5H2fZVJGJ97gT40hTqO6mxLkL/ZidcHRANRAhMZBh15pcGpjnmO +WHYNlyfCxORXSkAH2okJyfgepHuWb/T8qWGjLxsTiia9mIn2l3H4TQYZrimxMtQgz rxYj/4daW6zuy4thIsWrJlpMgn4Q3pSfVJt78VhU= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 19 Jun 2024 09:59:14 +0200 (CEST) X-EA-Auth: qfrlAmWg2voWWOaI4RSrIRrMdrE4KQWqzgM+l/cQVEcfY3kE75v0nqquOr52Ol3YpGEpoeaHGdjxCFaQ2dQqRK1ZdTBqtWseET1kvZixtA8= From: Nicolas Goaziou To: Nicolas Graves via Guix-patches via Subject: Re: [bug#71239] [PATCH] gnu: Add emacs-dape. In-Reply-To: <20240528095800.20728-1-ngraves@ngraves.fr> (Nicolas Graves via Guix-patches via's message of "Tue, 28 May 2024 11:57:57 +0200") References: <20240528095800.20728-1-ngraves@ngraves.fr> Date: Wed, 19 Jun 2024 09:58:58 +0200 Message-ID: <87le315pod.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=213.182.54.11; envelope-from=mail@nicolasgoaziou.fr; helo=mailo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Nicolas Graves , 71239-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, Nicolas Graves via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-dape): New variable. Applied. Thank you. Regards, -- Nicolas Goaziou From unknown Sun Aug 10 11:48:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 Jul 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator