GNU bug report logs - #71213
[PATCH] Use the current face foreground for read-passwd icons

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71213: closed ([PATCH] Use the current face foreground for
 read-passwd icons)
Date: Mon, 03 Jun 2024 17:16:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 03 Jun 2024 19:14:05 +0200
with message-id <87y17mne3m.fsf <at> gmail.com>
and subject line Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons
has caused the debbugs.gnu.org bug report #71213,
regarding [PATCH] Use the current face foreground for read-passwd icons
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71213: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71213
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use the current face foreground for read-passwd icons
Date: Sun, 26 May 2024 19:53:23 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

Been driving with this one for some time and somehow never got around to
submitting it.

We've done something similar for other icons, e.g. in 2021-11-02 "Use
current face foreground for SVG icons in customize" (11702a6dd7c).  I
think it makes sense for these too, since "#2e3436" (and any shade of
not-strictly-gray-but-close-enough) is liable to have low contrast with
the mode line background depending on the theme (e.g. modus-vivendi).

Let me know what you think.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-03-24 built on amdahl30
Repository revision: 0da57fa2789d180ae533b6721d60eac14f76eaee
Repository branch: master
Windowing system distributor 'SUSE LINUX', version 11.0.12401000
System Description: openSUSE Tumbleweed

Configured using:
 'configure --prefix=/home/peniblec/apps/emacs --with-cairo
 --with-sqlite3 --with-xinput2'

[0001-Use-the-current-face-foreground-for-read-passwd-icon.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 71213-done <at> debbugs.gnu.org
Subject: Re: bug#71213: [PATCH] Use the current face foreground for
 read-passwd icons
Date: Mon, 03 Jun 2024 19:14:05 +0200

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> Michael Albinus <michael.albinus <at> gmx.de> writes:
>
>>>>> We've done something similar for other icons, e.g. in 2021-11-02 "Use
>>>>> current face foreground for SVG icons in customize" (11702a6dd7c).  I
>>>>> think it makes sense for these too, since "#2e3436" (and any shade of
>>>>> not-strictly-gray-but-close-enough) is liable to have low contrast with
>>>>> the mode line background depending on the theme (e.g. modus-vivendi).
>>>>>
>>>>> Let me know what you think.
>>>>
>>>> I have absolutely no knowledge about image formats. I've stolen the two
>>>> files from the Gnome repository, that's it. So I won't object any
>>>> change.
>>>
>>> Right, AFAIU we followed the same approach for the icons I mention above
>>> (grabbed the icons somewhere, realized their foreground fared poorly
>>> depending on the background, stripped their 'fill' attribute).
>>
>> So I would say it is OK to install your patch. Other people will comment
>> only if they see an unexpected change, so this is likely the best way to
>> test your proposal :-)
>
> A'ight 🫡 thanks for weighing in; will install momentarily then, after
> adding the bug# to the changelog.

… and then promptly forget to close the bug 😳 Doing so now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.