From unknown Sat Aug 16 20:56:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71213 <71213@debbugs.gnu.org> To: bug#71213 <71213@debbugs.gnu.org> Subject: Status: [PATCH] Use the current face foreground for read-passwd icons Reply-To: bug#71213 <71213@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:56:16 +0000 retitle 71213 [PATCH] Use the current face foreground for read-passwd icons reassign 71213 emacs submitter 71213 K=C3=A9vin Le Gouguec severity 71213 normal tag 71213 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 13:53:41 2024 Received: (at submit) by debbugs.gnu.org; 26 May 2024 17:53:41 +0000 Received: from localhost ([127.0.0.1]:42511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBI3w-0001Nu-OV for submit@debbugs.gnu.org; Sun, 26 May 2024 13:53:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:57262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBI3u-0001Nm-AY for submit@debbugs.gnu.org; Sun, 26 May 2024 13:53:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBI3l-0007dT-Q8 for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:29 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBI3j-0003y5-SN for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 13:53:29 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42016c8db2aso42902875e9.0 for ; Sun, 26 May 2024 10:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716746005; x=1717350805; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=F+ofj9O+wgKiPUFsMqtwETFI+Yk7TOxATXpkS2777yA=; b=Fq+oqG4PQtH0IMEYEX1fKVw6QzYnnSKAfilIvvjn1Be9pZhfSxhHoLcl5RTgRHR4ev q+ZbZcRIICbGAFxcnKmZEs4LBSJZgJGukwsj64C+Z0ixrgSgGnbzDQkiIoqn2g1F/IAz 6hkBg+2sZSy8kAnIO7u6du3UYS/4eUxowqZk0bGEoRaqtfu3m5xFdyJ+vv0ChENxo9Gb v/+yeNEnVVTYnHXkprCDnOJbVq0Jo+37RVBjwpgaOEz8EnsyulkW9RHQnSCezdmObWZD 0mupOfledcTTv35ZxH2osE7HFIsEVX/vMYY34MSbZ6nqTrfn1sCyxiGFYOvl+LP5aWaN E6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716746005; x=1717350805; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=F+ofj9O+wgKiPUFsMqtwETFI+Yk7TOxATXpkS2777yA=; b=UgYhLGn9PQMzn4X0KN7tA1AP/qFHsjjp5YWfJBTsmRlXaWqf34Pwq6GPcY6qdn8QS6 mj2RyDpLs4twkJTy9mmVyBsdNgJ8kh2S7usgg1fSSDq/gNYtimkgw1VPF83micMgJs8p JKqFOY1SK9Q1QlFZAYbYKQ3Ne8LLklQ1+GxGKSVaDB+3hfOhlE0WliqQ74eCWd2YBU3t 0A1jmVZsW7aWjClXghv1pWR8Gwk/ibPWi4jNQWvT6wmG/XO+deIshcHBL3yVQvxmI3nc OxJ77jV+TgexR9qkup6zOM9Nb8zTaWL4ZsM2dctVwci2DfK/lPXUl4Vp75A7VnTTC/d1 +2hA== X-Gm-Message-State: AOJu0Yxr4m5vUCKJGsWbltZclmizW0KSFgF7oba2Pc6cgS7LQbyT/n6Y ZTtYrbYEGoPf3j9Dwz13KoTmTLVkzO8Pb7QxEgPNcVx5YDC0TljBB/0ClQ== X-Google-Smtp-Source: AGHT+IE4a9A54l3zTy6cNvyP/yL2AKdwFs426gB78P8e4ZYwPKwapqbsYZTXQHKGon+BfcSaqn3zTg== X-Received: by 2002:a05:600c:214c:b0:41b:3c4c:211b with SMTP id 5b1f17b1804b1-421089ffd41mr60032025e9.22.1716746004831; Sun, 26 May 2024 10:53:24 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42108966ce0sm84511195e9.8.2024.05.26.10.53.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 10:53:24 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use the current face foreground for read-passwd icons X-Debbugs-Cc: Michael Albinus Date: Sun, 26 May 2024 19:53:23 +0200 Message-ID: <87o78stq7g.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch Been driving with this one for some time and somehow never got around to submitting it. We've done something similar for other icons, e.g. in 2021-11-02 "Use current face foreground for SVG icons in customize" (11702a6dd7c). I think it makes sense for these too, since "#2e3436" (and any shade of not-strictly-gray-but-close-enough) is liable to have low contrast with the mode line background depending on the theme (e.g. modus-vivendi). Let me know what you think. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-24 built on amdahl30 Repository revision: 0da57fa2789d180ae533b6721d60eac14f76eaee Repository branch: master Windowing system distributor 'SUSE LINUX', version 11.0.12401000 System Description: openSUSE Tumbleweed Configured using: 'configure --prefix=/home/peniblec/apps/emacs --with-cairo --with-sqlite3 --with-xinput2' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Use-the-current-face-foreground-for-read-passwd-icon.patch Content-Transfer-Encoding: quoted-printable >From 18a9430e438dbf7894bebed4374f51bce0e040ad Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?K=3DC3=3DA9vin=3D20Le=3D20Gouguec?=3D Date: Fri, 22 Mar 2024 20:24:46 +0100 Subject: [PATCH] Use the current face foreground for read-passwd icons * etc/images/conceal.svg: * etc/images/reveal.svg: Remove 'fill' attribute so that the current face's background is applied: this helps the icon's SVG representation remain legible regardless of how the mode-line is themed. --- etc/images/conceal.svg | 2 +- etc/images/reveal.svg | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/etc/images/conceal.svg b/etc/images/conceal.svg index 172b73ed3d3..65695c0024e 100644 --- a/etc/images/conceal.svg +++ b/etc/images/conceal.svg @@ -1,4 +1,4 @@ - + diff --git a/etc/images/reveal.svg b/etc/images/reveal.svg index 41ae3733a53..f950311ac5a 100644 --- a/etc/images/reveal.svg +++ b/etc/images/reveal.svg @@ -1,4 +1,4 @@ - + --=20 2.45.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 03:41:39 2024 Received: (at 71213) by debbugs.gnu.org; 27 May 2024 07:41:39 +0000 Received: from localhost ([127.0.0.1]:43010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBUzD-0003qo-IR for submit@debbugs.gnu.org; Mon, 27 May 2024 03:41:39 -0400 Received: from mout.gmx.net ([212.227.15.18]:38799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBUzA-0003qZ-HW for 71213@debbugs.gnu.org; Mon, 27 May 2024 03:41:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1716795681; x=1717400481; i=michael.albinus@gmx.de; bh=S0rq8eqe+Ue1zLnjvcdD0IVjzsNpkTRVKbeCqvZ5pCU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Z3s0Z+TH90YQU8yhFJfqxpSV8xaHDmUbeyYfnOhJKYox8viH8N+ON6Q+PybHOZle R7Fv5+kQzE199tGdgFV8lOTyec+UxnQPxKn95yN1+jsMgFR2J0h9dXfO49FujsXws 3DdLfqHMO8VqP6riCjMl01muCRQZq5ybu1QHPFS6rCyg9+q3GDeMLFtNWJTYXfuht vKDo43FgBNKO5ch6tJvSyS3U33pGybzNBPBRglQjYDbkrUa4Q+2isHsGAOc2FLaEi m+I3yhiiBjXd2P7uSb6oYfp9qqQmnu1i4rQTc3vow003WID0vXGDlpQyoOxZil8xY lhQgvGo1+JsThXw2bw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.151]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNswE-1rrk9B1iye-00N6AB; Mon, 27 May 2024 09:41:21 +0200 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons In-Reply-To: <87o78stq7g.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Sun, 26 May 2024 19:53:23 +0200") References: <87o78stq7g.fsf@gmail.com> Date: Mon, 27 May 2024 09:41:20 +0200 Message-ID: <8734q3u2fz.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XfuYNCd9D+bI79IRnqlM6qtLWyeY7Fo48MKdkOQMcwXrYNBxYhE 38S2/n2LUkJrRyoJMrdmzi3mcQzwYgcWvMJNsv3QsQLlHRg4gHCaCCiaXSI+TPVXamLLAaN iOWCTQ7TpIav1oo62iviwcbvvUoIo1ykNdnCN0lwfa/ZRZA1cFxw5g6m5H/oazggFoHnthu bJpQtrywzeEPUBzJhIMwg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:P/P/CYH2PZM=;Np2G/sQlXCGqnuXJKEcShWDUvWp ZyQODiUXjUf1Bw3J8sANZOavSCocfg7zxSjzrWNPjUzPNcZ4UFgmCR3idS/sPIuStu0njR3b5 UT4C2IfABxGr+C6+a8Cv0wAKvZvXjdlmBfDLgms+gfo3YFlkqi4wne+CZM/v+IqKX5R5tGoir 9TIWgHtZArEaH1fWm16EJYbm6RFWEzvC+2e/sDswcOMBBuyBttoXIYuFWIVFz0ZdVHremK+8s dyvoaSBHF5nB5kir7YqNACEU0qrL4bHvR9DKMtcAvP5YGJ/jG4U6RauMi9ELFHAZsN2CqZ3xd O7kpFlDqnhu3beIlAaBFH6ltGYuKsQtmJggLnGeP+xu2I32uEs/0JouGzOhQK4t3VMfmz49vC kVT2u2T4GOaF2VmtPyxCd9nDMlSPvWv3h03nAHLDXC4I6PTL70BLgZjYdYkRKd91UmGz98fCF wfeVk4uzHOZIDouR2zZ3+B2CPS9hbQEHphRjwSBanz0lR1EOddnB/Cz7ttlVNK4Lmy1K5pNp3 DT3e7pMEvkQtSgxCnnzSXOLCknz1aaFWDc8GuBh1lj3yH6pkED+Ni4IP5drpah4+fU+bQfU0V nPmWBl7EE0KOhBTWzIrXsq29b1PW6osh9CmluEJngoFxoiljhOZ3AYlNMQCz8Tg1vcjNoKvSu 9mXi5nj3orgoWqfu15QkNQgF7RENFo0JFMi/DDkg2AoQXWHOvvWQXkGkNmxUlGAOdYWxLy/5c dnMMWG9+Tmlo9czas9W9XcJCzVc2t+BfnIbexo6tAT5krICCEFEsCGPgDIKj+KIK6ZFN0T3hK rRo6e6spZ8RU6Ad/ZWZ1Aoou8mS3OHKzqKLrLMErdsXM+RMpYMQXiSojiaphKtMrhf X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Kévin Le Gouguec writes: Hi Kévin, > We've done something similar for other icons, e.g. in 2021-11-02 "Use > current face foreground for SVG icons in customize" (11702a6dd7c). I > think it makes sense for these too, since "#2e3436" (an [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.151 listed in zen.spamhaus.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71213 Cc: 71213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Kévin Le Gouguec writes: Hi Kévin, > We've done something similar for other icons, e.g. in 2021-11-02 "Use > current face foreground for SVG icons in customize" (11702a6dd7c). I > think it makes sense for these too, since "#2e3436" (an [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.18 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.151 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.18 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, > We've done something similar for other icons, e.g. in 2021-11-02 "Use > current face foreground for SVG icons in customize" (11702a6dd7c). I > think it makes sense for these too, since "#2e3436" (and any shade of > not-strictly-gray-but-close-enough) is liable to have low contrast with > the mode line background depending on the theme (e.g. modus-vivendi). > > Let me know what you think. I have absolutely no knowledge about image formats. I've stolen the two files from the Gnome repository, that's it. So I won't object any change. While we're at it: do the two correspinding *.pbm files also need some care? And do we need to create also *.xbm files? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 14:12:32 2024 Received: (at 71213) by debbugs.gnu.org; 27 May 2024 18:12:32 +0000 Received: from localhost ([127.0.0.1]:45232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBepi-0000Tj-Hv for submit@debbugs.gnu.org; Mon, 27 May 2024 14:12:32 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:48275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBepX-0000TF-VV for 71213@debbugs.gnu.org; Mon, 27 May 2024 14:12:29 -0400 Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5241b49c0daso45048e87.0 for <71213@debbugs.gnu.org>; Mon, 27 May 2024 11:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716833465; x=1717438265; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4nE9xnPMMttVXs++7n1jCNh6ip3crWzRS6X1FX+iUvc=; b=G7VQ2h76ytql2KSYaNjZ23OtF8JHQUXX0iQZm5cZ4jMP7rWgweaHj5rubAAbtr4hOa 5QHT4hgL8Ip716AILVVarrQ83iU/rER97TD6tZS0JAAoWGtILdUeeXMsA8Cv0Re05l6b 5mldf9k2CT9oAJhY7qi6gjErp0l3AR7RX6Yra3PqKuVnZXYfFHdNd5l9AuEvRNkN4HtG eSPEEocjg2viCMpHu27aHc3iJ6gstbNRma8NpYjAJyxKB6MtPiAdyobTq7AjFsmPbRUk fOfVUoK0Ip8xNus+ePV09153X61GiUrlrZzFt9eoz3C+KOb+6G+g54S5MGa4RgEzsi43 KEaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716833465; x=1717438265; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4nE9xnPMMttVXs++7n1jCNh6ip3crWzRS6X1FX+iUvc=; b=aZCl6qpOMKRRRmiRmB28woDzCT44As2I979NobVtedc5p4nWNUhbokyCQnInrbgys+ kKWlU17TLIap4cQvtpB0AIC7xz6kL4wc7juXeDwoN8HISOLB5VmSGfX3VLVUiT75WIAN uqyy+y8VDMAYblH1A+38wmrlVl1oYptO+RAjOKjmz99k0bQBv5ZqSknfV1wKSBjFwHnS yR3X0sSAxpfnmvpQsuJ0p24uLpA9PMKD7KVnTFNAh+mytTz01QsZ7FqqIXqZXEj6rxOx rMYUVvfKV3c9oe0X/OFgI42MbkKp9J+t16b5YzKUZuObtBI3sYS5hOIUC1Vm2eJR4CYB 8fgA== X-Gm-Message-State: AOJu0Yx+iW++JS3FG3mCsJVu3OSH6y4qgmy8l2fqCWuaMJkKjHA7/Lju 7XWIkllUV5XYWyrXFNXjCdq2X1WcD/NIVhTNSMGCF3J2WwB/LYfq3iE0eA== X-Google-Smtp-Source: AGHT+IHaRYebCXjlj9wUZ5zjzRUbySNKx6pE5QtXf2Sr1Ve2Io+tERbSvRBSresj9jZrDBBNwVWnBw== X-Received: by 2002:ac2:5dc4:0:b0:529:b6ea:d545 with SMTP id 2adb3069b0e04-529b6ead6fbmr692332e87.29.1716833464250; Mon, 27 May 2024 11:11:04 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3558889fb57sm9737200f8f.114.2024.05.27.11.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 11:11:03 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons In-Reply-To: <8734q3u2fz.fsf@gmx.de> (Michael Albinus via's message of "Mon, 27 May 2024 09:41:20 +0200") References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> Date: Mon, 27 May 2024 20:11:02 +0200 Message-ID: <87jzjff7m1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71213 Cc: 71213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> We've done something similar for other icons, e.g. in 2021-11-02 "Use >> current face foreground for SVG icons in customize" (11702a6dd7c). I >> think it makes sense for these too, since "#2e3436" (and any shade of >> not-strictly-gray-but-close-enough) is liable to have low contrast with >> the mode line background depending on the theme (e.g. modus-vivendi). >> >> Let me know what you think. > > I have absolutely no knowledge about image formats. I've stolen the two > files from the Gnome repository, that's it. So I won't object any > change. Right, AFAIU we followed the same approach for the icons I mention above (grabbed the icons somewhere, realized their foreground fared poorly depending on the background, stripped their 'fill' attribute). > While we're at it: do the two correspinding *.pbm files also need some > care? It's not a format I am familiar with, but empirically, (insert-image (create-image "conceal.pbm")) inserts an icon that automagically changes color as I switch between light and dark themes. pbm(5) says the format is monochrome, and (info "(elisp) Other Image Types") confirms Emacs does the obvious thing by default (frame foreground for one bits; frame background for zero bits). > And do we need to create also *.xbm files? Not sure if we have a policy or guidelines there; etc/images/README explains how to convert from xpm > xbm > pbm, but does not provide judgments on which are needed. (info "(elisp) Image Formats") says Supported image formats (and the required support libraries) include PBM and XBM (which do not depend on support libraries and are always available), which makes me tempted to say "if we have lowest-common-denominator formats like PBM or XBM for our icons, then we're good, the rest is bonus"? From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 03:35:09 2024 Received: (at 71213) by debbugs.gnu.org; 28 May 2024 07:35:09 +0000 Received: from localhost ([127.0.0.1]:45599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBrMS-0003CD-MI for submit@debbugs.gnu.org; Tue, 28 May 2024 03:35:09 -0400 Received: from mout.gmx.net ([212.227.17.20]:49603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBrMQ-0003Ba-VV for 71213@debbugs.gnu.org; Tue, 28 May 2024 03:35:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1716881691; x=1717486491; i=michael.albinus@gmx.de; bh=kLKISLq37jXZLoiSaTMtvH+6/ugvDXFYJe4zEqjUpSc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VswoHX5k3x8MO+fuyijRc+HACUmEorINfT/sXUwvEer/hj3NmMDyAfB9zIsdWpV8 jipw4PEwF0qo6swd2vUZzFODZuFuCi3PE5Iu7RHpaC67XzYg2pZhu4OKTN3OFxJgD LFAq4HRvJrxj9/UPjhACew8AjK5bRV6hkTv2n30rJWuQoO3J4NoaKez/USMOw1EWf F9/z0hfPyMPnrl+lg+nzcZhV9ELT58/ZCvKLz2yHvy0FaTBq4XwNaarKeXo7KkqZi uDapFJLaH8CtxkUknv9jJSPJAQOgyE/A55E2cxSTsoWZG/ZqRAfPKeR8qAGkF4hj0 GRnbrqL6QD9wWMAyMA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.38.151]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqs0X-1sp5zf3zmr-00mr4R; Tue, 28 May 2024 09:34:51 +0200 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons In-Reply-To: <87jzjff7m1.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Mon, 27 May 2024 20:11:02 +0200") References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> <87jzjff7m1.fsf@gmail.com> Date: Tue, 28 May 2024 09:34:50 +0200 Message-ID: <87a5kas82t.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:vmH/j1iQiV29Sc4RrCYDGyOrbSOr0JCclz8dToytZTVWhgrpY4l yNW0gVQA/pt51iJeimjlHi5DoxKDTWo6Z6rRDhfEvRTaCKmiZXIOb0Y8PkHpBbF7vyq0S91 7WTajjru+br7H/0nGmSQj1U/2a5FbJfmbfKgbi3MMNKC0sbamQ+L4TqzOFk7Mp5Q4N6huRj GrsIFwcqu3ZTp9zkhfrlA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:82x+N592iD8=;PnRF3eK09otI1R4DVg3WO6DjmQ1 +YMux82FP+luy4QipID2UGpMvXzO+Eqku2s2Zg2O9SMCd4V00+1AsEacj3FIw9TFbV6Km1Ldk vSpvyWp/JN5kJQngY9ETNm3vB3/XtziqPpFUV+sUT/Vg2lzLhRkgqegUrqUbcvHbwe5eYODpL kFyBcRqQb7xNBRn8R5JeGmPXFeKmhDw2nY8zTh7AxtnuNzKoOzbnFJJXZGjY+FjcC/1RoCiue FRSoTXctwn6hMb46vssX2SAczJciKcMthvAH1angY/xRC6QW+jb5Rlp0Vi3VDxQ1jE05roXog suM6OzgCrJXWGSrEGqxowLC4dkdW3HTtCKEWY9P5QyvAGuVOytolCz1vyHz1sK5nHlSinnyW6 opzNLzqYX/xVBgQDe/2OV6rWks71lFaLbo1qlStGUwGnW0I7kXV34aIhigSWEjLfhot+3hMgX y2FDBbyMiptmirC7xoITcdIhMY8IsmwGqDePZJHyoVE1xa8ORdPvT2r1SRQmF8uiDa59nD3fC z/5o0P5hw0qDk2b8ZgZLoXe9uLPVwvCz+VL9AkulZQhUxqYQzMRsXKiQZBZnuAm4HLD/p9tNI 3P+gmeHJWcB/Gil2R0IxRxxrdyNoRuKZ1OAxNbWvEJtPPJv+odBYjUQSpz8MV7DQel6MdMJzQ Wr8w5N1ifdZaUin9TCqZ8NlCENP8V7ZREHqO2sUHDfbi+YEecxWVWhComJVNCJu2yV0b9rr1K eNRcl+4IebY9vUFH9nptPIfYT7speQc9Sqs+u9oF9mHsTIVsbBZowXML/jFKaWVgDkv0e1p9/ N3ICGMobaLfhICsOsAyxy92OpI1xdxBdEacd5cnhR27xKf3qLYIF+1eTMAPiIR1ACx X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Kévin Le Gouguec writes: Hi Kévin, >>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>> think it makes sense for these too, since "#2e343 [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.151 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 71213 Cc: 71213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Kévin Le Gouguec writes: Hi Kévin, >>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>> think it makes sense for these too, since "#2e343 [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [212.227.17.20 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.38.151 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, >>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>> think it makes sense for these too, since "#2e3436" (and any shade of >>> not-strictly-gray-but-close-enough) is liable to have low contrast with >>> the mode line background depending on the theme (e.g. modus-vivendi). >>> >>> Let me know what you think. >> >> I have absolutely no knowledge about image formats. I've stolen the two >> files from the Gnome repository, that's it. So I won't object any >> change. > > Right, AFAIU we followed the same approach for the icons I mention above > (grabbed the icons somewhere, realized their foreground fared poorly > depending on the background, stripped their 'fill' attribute). So I would say it is OK to install your patch. Other people will comment only if they see an unexpected change, so this is likely the best way to test your proposal :-) >> While we're at it: do the two correspinding *.pbm files also need some >> care? > > It's not a format I am familiar with, but empirically, > > (insert-image (create-image "conceal.pbm")) > > inserts an icon that automagically changes color as I switch between > light and dark themes. pbm(5) says the format is monochrome, and (info > "(elisp) Other Image Types") confirms Emacs does the obvious thing by > default (frame foreground for one bits; frame background for zero bits). > >> And do we need to create also *.xbm files? > > Not sure if we have a policy or guidelines there; etc/images/README > explains how to convert from xpm > xbm > pbm, but does not provide > judgments on which are needed. (info "(elisp) Image Formats") says > > Supported image formats (and the required support libraries) inclu= de > PBM and XBM (which do not depend on support libraries and are always > available), > > which makes me tempted to say "if we have lowest-common-denominator > formats like PBM or XBM for our icons, then we're good, the rest is > bonus"? OK. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 13:35:07 2024 Received: (at 71213) by debbugs.gnu.org; 28 May 2024 17:35:07 +0000 Received: from localhost ([127.0.0.1]:48721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC0j4-0005XK-Hl for submit@debbugs.gnu.org; Tue, 28 May 2024 13:35:06 -0400 Received: from mail-wm1-f50.google.com ([209.85.128.50]:53349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC0j1-0005W5-RZ for 71213@debbugs.gnu.org; Tue, 28 May 2024 13:35:05 -0400 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-420180b5922so12738895e9.2 for <71213@debbugs.gnu.org>; Tue, 28 May 2024 10:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716917628; x=1717522428; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRcPSiLGH2vZUS0ANcDeRUfayBmG95sCe5wrOb9NFFc=; b=cmW5GqdKLuDjxMDwA4+D3DSyuUQ8rUDnfDccsAQwDsNmK6XvTxkGY48eaF2mVNcOan vLZ4kqefs2+BtjQmOZgmOZTsI7uMOqL4RNdTnGGyVadLW7Fe5rBvXtfrHsdsaD0u437i zgyQ02OQs/WFuXHIfMJp9DTLIpgSXDHXogWjeJLTBQkVwU02n0H6vJ21hdL4DBTXvEkd 2Ib0N8cSuC31Fb9fQfnbQBUXl8bIXC0cX4k/eB3fjC35BxNod0AwYnIgz4mNkgHaAI5F X9EbipFdjhuaXmU0g5sZW5OlANB24MbNGhg9KyjLFJqsB0ZW5lz6YhSzTjkoPMwr80k8 i2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716917628; x=1717522428; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jRcPSiLGH2vZUS0ANcDeRUfayBmG95sCe5wrOb9NFFc=; b=MCPV7a71sGpStZtz7ZQpQ99e9thWTUfjkU+Mf7ravmBL0kRoamjY/MLax3Z+acW2Pj U503rRJWmf02Npy0kgML5yGSYqrlpGdYsA6rBnw5b18tl1+GawOqcCLDfvve0+lnGNwF 1Wkz/gS2G7sBqoUYEgJgwB6FNeDz6a+XX4Yler6+Qs2AgkZs6VRsdvay32vIKRsU5tDa 5YfPrGheyd2TZBF2qdyR4warW4hkc+RBOAXFQkz9R6RrpCbUWfoKB+pM+ymDvDv88nfg BVTvaJGcWsRQz+ekZFb62im4QIuInAZfumoLY2BNcYA7BxhcxQ7Putlmmgg6n1lAJupZ 4X9A== X-Gm-Message-State: AOJu0Ywv8WVjpIAtB32eWSkqdKRilxr5dSoKEZ2ldCw9ubzNyLiFZF2y ZDTQswcUVZd0iO9nHcCYxJRacya/e6G7mubmbYb7znlperimaKvrPUJeAA== X-Google-Smtp-Source: AGHT+IFwCrjWvdqJ1+yh2PapTFHroMdEr4uw70pWqstZ3d3o1mMpEE4DGh1WkQovCj7c37MxngCdhw== X-Received: by 2002:a5d:47a6:0:b0:357:bd78:4964 with SMTP id ffacd0b85a97d-357bd784af5mr8175560f8f.27.1716917627741; Tue, 28 May 2024 10:33:47 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557a1c9546sm12256676f8f.82.2024.05.28.10.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 10:33:47 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons In-Reply-To: <87a5kas82t.fsf@gmx.de> (Michael Albinus's message of "Tue, 28 May 2024 09:34:50 +0200") References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> <87jzjff7m1.fsf@gmail.com> <87a5kas82t.fsf@gmx.de> Date: Tue, 28 May 2024 19:33:46 +0200 Message-ID: <87v82x4z9h.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71213 Cc: 71213@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >>>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>>> think it makes sense for these too, since "#2e3436" (and any shade of >>>> not-strictly-gray-but-close-enough) is liable to have low contrast with >>>> the mode line background depending on the theme (e.g. modus-vivendi). >>>> >>>> Let me know what you think. >>> >>> I have absolutely no knowledge about image formats. I've stolen the two >>> files from the Gnome repository, that's it. So I won't object any >>> change. >> >> Right, AFAIU we followed the same approach for the icons I mention above >> (grabbed the icons somewhere, realized their foreground fared poorly >> depending on the background, stripped their 'fill' attribute). > > So I would say it is OK to install your patch. Other people will comment > only if they see an unexpected change, so this is likely the best way to > test your proposal :-) A'ight =F0=9F=AB=A1 thanks for weighing in; will install momentarily then, = after adding the bug# to the changelog. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 13:15:29 2024 Received: (at 71213-done) by debbugs.gnu.org; 3 Jun 2024 17:15:30 +0000 Received: from localhost ([127.0.0.1]:51432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEBHN-0005yz-Go for submit@debbugs.gnu.org; Mon, 03 Jun 2024 13:15:29 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:49266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEBHK-0005en-P2 for 71213-done@debbugs.gnu.org; Mon, 03 Jun 2024 13:15:28 -0400 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e73359b900so1257381fa.2 for <71213-done@debbugs.gnu.org>; Mon, 03 Jun 2024 10:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717434847; x=1718039647; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bWv8xcMfoBEQEIELh17KMQotLaIm5FoviFFIXHhlc94=; b=fKj5rn7/4wZ4CJ3SxF1jERn4QyhhQS3+bXNw8vGBXv3NYwlD3FAVSihwnlEus32PXI nnMU9z5H8sqRISUxF6H1g98vJhFlV7MJtrQ2w6HB9fRP9T1UhhwiON5ucxOn5kmYItqw loItA/6mAwd35u5pW5kVvuQ6BTlmMj6x8s5Q2QPotQBUORobvX2MCPjwscr5yqiS3aeD m/cmjBVu4wmvnC1xWIlVhACr0lGD8S+1onf7K1o0UYcWEfixExdCZAFurIZ/pAdWcB8M n1kGSFt1RnAWJrsyqczhvYyjuaOXcj2z37570wvl7OH+lcxwBZ+FJSvZtg82Es/nD519 Ecdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717434847; x=1718039647; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bWv8xcMfoBEQEIELh17KMQotLaIm5FoviFFIXHhlc94=; b=EKDhlgORyuszQ1qYYPxf5j4+SujHWaj/d+/IDJkylLZVaUt6ellJdigyET8nuTpcNt YsAyHlzUQsoNnEZJtjGpOj5nNEFpo09iux3PXLT6lBf6UhH7ZOUCDQXzMWlG13KBtNTr 3urfX05/DYbrUPwJppAl5fWH0lqISxFrMNY5m/4P0JsZ2NJpoz/J+jm9jtmcL6OfhSFy FeqooYRTkp1pGGTXno5z4mLj9M0AK5JIZKtwS1mnYR9yMX4zl5QR03/HnhgKQKqWTmuA yd3fXXJv6WYcir3glVetUaCn9je5qreZxTf1GT9gzkIdDngjc8iJ6i0Ms7FE7lnpCWr8 cuAQ== X-Gm-Message-State: AOJu0YxqWbgp0Y2xToHZw06cyMWWiXI9sOf0AQ8e2CfE3YiWW2zr6y3y RrGWQKYtfkUTELDM6hrzyvBSt5FUQWTJK11nP6TAvTUgSm3R2keCsvtoZA== X-Google-Smtp-Source: AGHT+IGT8BQbH78Oftby0rz4ZOxhM0wPP36Nw6HoxGoXDG2DVGj9N38FdicrPK5zZZ+IV+yz+7yElA== X-Received: by 2002:a2e:97d4:0:b0:2ea:7a26:d155 with SMTP id 38308e7fff4ca-2ea9511467emr52097571fa.30.1717434846872; Mon, 03 Jun 2024 10:14:06 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42127056cc2sm158769005e9.2.2024.06.03.10.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 10:14:06 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#71213: [PATCH] Use the current face foreground for read-passwd icons In-Reply-To: <87v82x4z9h.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Tue, 28 May 2024 19:33:46 +0200") References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> <87jzjff7m1.fsf@gmail.com> <87a5kas82t.fsf@gmx.de> <87v82x4z9h.fsf@gmail.com> Date: Mon, 03 Jun 2024 19:14:05 +0200 Message-ID: <87y17mne3m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71213-done Cc: 71213-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) K=C3=A9vin Le Gouguec writes: > Michael Albinus writes: > >>>>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>>>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>>>> think it makes sense for these too, since "#2e3436" (and any shade of >>>>> not-strictly-gray-but-close-enough) is liable to have low contrast wi= th >>>>> the mode line background depending on the theme (e.g. modus-vivendi). >>>>> >>>>> Let me know what you think. >>>> >>>> I have absolutely no knowledge about image formats. I've stolen the two >>>> files from the Gnome repository, that's it. So I won't object any >>>> change. >>> >>> Right, AFAIU we followed the same approach for the icons I mention above >>> (grabbed the icons somewhere, realized their foreground fared poorly >>> depending on the background, stripped their 'fill' attribute). >> >> So I would say it is OK to install your patch. Other people will comment >> only if they see an unexpected change, so this is likely the best way to >> test your proposal :-) > > A'ight =F0=9F=AB=A1 thanks for weighing in; will install momentarily then= , after > adding the bug# to the changelog. =E2=80=A6 and then promptly forget to close the bug =F0=9F=98=B3 Doing so n= ow. From unknown Sat Aug 16 20:56:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Jul 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator