Subject: bug#71204: closed (Re: [bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 24 Jun 2024 03:01:02 +0000

Your bug report

#71204: [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
71204: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71204
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#71204] [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.
From: Maxim Cournoyer <[email-masked]>
To: Zheng Junjie <[email-masked]>
Cc: [email-masked]
Date: Sun, 23 Jun 2024 22:58:53 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Zheng Junjie <[email-masked]> writes:

> Maxim Cournoyer <[email-masked]> writes:
>
>> Hi Zheng,
>>
>> Zheng Junjie <[email-masked]> writes:
>>
>>> Maxim Cournoyer <[email-masked]> writes:
>>>
>>>> This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
>>
>>> I think maybe should add them to manifest.scm? And just 'guix shell' or
>>> 'guix shell -m manifest.scm'?
>>
>> I think it's nice that 'make distcheck' works out of the box, even for
>> 'guix shell -D guix ...'.  According to 'guix size' the
>> new $GUIX_ENVIRONMENT produced with the added inputs do not add any
>
> ok, LGTM. 

Applied, thanks for taking a look!

-- 
Thanks,
Maxim

Subject: [PATCH 1/2] gnu: guix: Add imagemagick, perl and use full graphviz.
From: Maxim Cournoyer <[email-masked]>
To: [email-masked]
Cc: Maxim Cournoyer <[email-masked]>
Date: Sun, 26 May 2024 04:26:16 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
environment.

* gnu/packages/package-management.scm (guix)
[native-inputs]: Replace graphviz-minimal with graphviz.  Add imagemagick and
perl.

Change-Id: Ie400c622d8fc77108df29c03e11f36159d6f6238
---
 gnu/packages/package-management.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 862de9f942..2f1434d5be 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -490,8 +490,10 @@ (define-public guix
                        ("automake" ,automake)
                        ("gettext" ,gettext-minimal)
                        ("texinfo" ,texinfo)
-                       ("graphviz" ,graphviz-minimal)
+                       ("graphviz" ,graphviz) ;non-minimal for PDF support
                        ("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
+                       ("imagemagick" ,imagemagick) ;for 'make dist'
+                       ("perl" ,perl)               ;for 'make dist'
                        ("help2man" ,help2man)
                        ("po4a" ,po4a-minimal)))
       (inputs

base-commit: 77771036f0970083c146b709d792d128f4235125
-- 
2.41.0