GNU bug report logs - #7118
24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Mon, 27 Sep 2010 18:46:03 UTC

Severity: wishlist

Found in version 24.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 7118 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 7118 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.:
	necessarily buffer-local
Date: Thu, 14 Jul 2011 16:45:28 +0200

> What's the best way to make this change?  Just say
>
> (make-variable-buffer-local 'var)
>
> after the `defvar', and then removing all the `make-local-variable'
> calls?

Yes.

BTW, it's a mystery to me why `revert-buffer-function' is not
automatically buffer-local, when every single package that sets it
does so locally; having a global non-nil revert-buffer-function does
not make any sense whatsoever.

But IMHO, neither changing `revert-buffer-function' nor
`dired-subdir-alist' and `dired-directory' is really a bug fix. Yes,
as they are now is error prone, but the uses in the sources are
already correct. That should be a wishlist item for 24.2.

    Juanma
This bug report was last modified 3 years and 165 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.