GNU bug report logs - #7118
24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Mon, 27 Sep 2010 18:46:03 UTC

Severity: wishlist

Found in version 24.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 7118 <at> debbugs.gnu.org
Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Tue, 28 Sep 2010 01:35:12 +0200

On Mon, Sep 27, 2010 at 20:47, Drew Adams <drew.adams <at> oracle.com> wrote:

> We should use `make-variable-buffer-local' with vars such as
> `dired-subdir-alist' and `dired-directory', instead of just calling
> `make-local-variable'.  Why?  Because these vars MUST be buffer local,
> and we might as well make the code clearer by pointing that out.  That
> is precisely the use case for `make-variable-buffer-local': a var that
> is necessarily buffer-local.

On the same vein, every single use of revert-buffer-function starts with

  (make-local-variable 'revert-buffer-function)
  (setq revert-buffer-function XXXXX)

or

  (set (make-local-variable 'revert-buffer-function) XXXXXX)

except the one in dired-x.el, which relies in dired-mode doing it
before. There have been at least three bugs in the past year caused by
revert-buffer-function not being automatically buffer-local.

    Juanma
This bug report was last modified 3 years and 165 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.