From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 14:45:02 2010 Received: (at submit) by debbugs.gnu.org; 27 Sep 2010 18:45:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0IhB-0000bn-NB for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:45:01 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ih9-0000bX-Oc for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:45:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0Ijr-0007Eg-EQ for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:47:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:50262) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ijr-0007Ec-8t for submit@debbugs.gnu.org; Mon, 27 Sep 2010 14:47:47 -0400 Received: from [140.186.70.92] (port=36887 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0Ijq-0004ai-2d for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0Ijo-0007Dx-PN for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:45 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:33110) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Ijo-0007Dj-Id for bug-gnu-emacs@gnu.org; Mon, 27 Sep 2010 14:47:44 -0400 Received: from rcsinet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o8RIlf8v030295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Sep 2010 18:47:43 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet13.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o8RIgrBb000794 for ; Mon, 27 Sep 2010 18:47:41 GMT Received: from abhmt004.oracle.com by acsmt354.oracle.com with ESMTP id 640730431285613258; Mon, 27 Sep 2010 11:47:38 -0700 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 27 Sep 2010 11:47:38 -0700 From: "Drew Adams" To: Subject: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Date: Mon, 27 Sep 2010 11:47:39 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: ActedHWdZ8VRbaNdT7yU3uwVdwQ6kg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) We should use `make-variable-buffer-local' with vars such as `dired-subdir-alist' and `dired-directory', instead of just calling `make-local-variable'. Why? Because these vars MUST be buffer local, and we might as well make the code clearer by pointing that out. That is precisely the use case for `make-variable-buffer-local': a var that is necessarily buffer-local. Also, the doc strings are otherwise incomplete/vague: for `dired-subdir-alist', for example, it speaks of "the buffer". The var's value is local to each particular Dired buffer, and this needs to be made more clear. If we use `make-variable-buffer-local' that will add the necessary info to `C-h v' so that the doc strings begin to make sense. (Still, we should mention in the doc string of `dired-subdir-alist' that the subdirs are subdirs of `dired-directory'.) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-09-20 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 17:02:12 2010 Received: (at 7118) by debbugs.gnu.org; 27 Sep 2010 21:02:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Kpw-0001Ye-8Z for submit@debbugs.gnu.org; Mon, 27 Sep 2010 17:02:12 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Kpu-0001YZ-SX for 7118@debbugs.gnu.org; Mon, 27 Sep 2010 17:02:11 -0400 Received: from dyn.83-228-217-009.dsl.vtx.ch ([83.228.217.9]:14253 helo=fmsmemgm.homelinux.net) by fencepost.gnu.org with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1P0Ksc-0005Wc-Uk; Mon, 27 Sep 2010 17:04:59 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id EECA46611D; Mon, 27 Sep 2010 23:05:00 +0200 (CEST) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Message-ID: References: Date: Mon, 27 Sep 2010 23:05:00 +0200 In-Reply-To: (Drew Adams's message of "Mon, 27 Sep 2010 11:47:39 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) > We should use `make-variable-buffer-local' with vars such as > `dired-subdir-alist' and `dired-directory', instead of just calling > `make-local-variable'. Sounds OK. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 19:33:09 2010 Received: (at 7118) by debbugs.gnu.org; 27 Sep 2010 23:33:09 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NC0-0002Yl-GV for submit@debbugs.gnu.org; Mon, 27 Sep 2010 19:33:08 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0NBy-0002YO-H3 for 7118@debbugs.gnu.org; Mon, 27 Sep 2010 19:33:07 -0400 Received: by iwn3 with SMTP id 3so5108098iwn.3 for <7118@debbugs.gnu.org>; Mon, 27 Sep 2010 16:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=+PL+cdvs6tj8GV4uF/aa6uvoIyBGiKX1Z446hODR3tA=; b=ChsjwBVFtSrqpbAiREW7n7ObJ7blEGgXKoN6irNRFl1yL0KPLidnwWcAcmQ6T/hfnl wymij0PobdtpmmpNcSvFz98UvuQYrC2OBC1mA1Ptjx46uWAimRYvQOojsm+UUpbMruvP Rox0xaZaXeKAciE5RFpiwLf915AQwLkc4UgeA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=qjyCHD78wHHPtnb3hCfMsLPwnaoCfqISgDdHqRXncnupT/pCTcFMew9pBoZBCie9W/ LAC3MEskRyYz9qjVpI8/nG9Ok/0KdSBEt172U/DYfBDZsJJu9aT3oaWu2WJYD75itIYx FWXxi1RhMmUQYEw1KeTPtasvsfXDdtJLkT/mk= Received: by 10.231.144.74 with SMTP id y10mr9874101ibu.65.1285630552271; Mon, 27 Sep 2010 16:35:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Mon, 27 Sep 2010 16:35:12 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 28 Sep 2010 01:35:12 +0200 Message-ID: Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local To: Drew Adams Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Mon, Sep 27, 2010 at 20:47, Drew Adams wrote: > We should use `make-variable-buffer-local' with vars such as > `dired-subdir-alist' and `dired-directory', instead of just calling > `make-local-variable'. =C2=A0Why? =C2=A0Because these vars MUST be buffer= local, > and we might as well make the code clearer by pointing that out. =C2=A0Th= at > is precisely the use case for `make-variable-buffer-local': a var that > is necessarily buffer-local. On the same vein, every single use of revert-buffer-function starts with (make-local-variable 'revert-buffer-function) (setq revert-buffer-function XXXXX) or (set (make-local-variable 'revert-buffer-function) XXXXXX) except the one in dired-x.el, which relies in dired-mode doing it before. There have been at least three bugs in the past year caused by revert-buffer-function not being automatically buffer-local. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:32:18 2011 Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:32:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhMxa-0006Wk-EU for submit@debbugs.gnu.org; Thu, 14 Jul 2011 10:32:18 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhMxR-0006VK-9l for 7118@debbugs.gnu.org; Thu, 14 Jul 2011 10:32:09 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QhMx0-0007qv-1w; Thu, 14 Jul 2011 16:31:38 +0200 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local In-Reply-To: (Stefan Monnier's message of "Mon, 27 Sep 2010 23:05:00 +0200") Date: Thu, 14 Jul 2011 16:21:32 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Depeche Mode's _A Question of Lust_: "A Question of Lust" X-Hashcash: 1:23:110714:drew.adams@oracle.com::G6bEaQAMXnDcL/76:00000000000000000000000000000000000000006v7u X-Hashcash: 1:23:110714:monnier@iro.umontreal.ca::NxF4ZievUWhsTBi2:0000000000000000000000000000000000000NOk1 X-Hashcash: 1:23:110714:7118@debbugs.gnu.org::TUadkeUxlMjGyShv:00000000000000000000000000000000000000000y7iD MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QhMx0-0007qv-1w X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311258698.30495@EFsxmOP/aftr0fgi3+udiQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: >> We should use `make-variable-buffer-local' with vars such as >> `dired-subdir-alist' and `dired-directory', instead of just calling >> `make-local-variable'. > > Sounds OK. What's the best way to make this change? Just say (make-variable-buffer-local 'var) after the `defvar', and then removing all the `make-local-variable' calls? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:46:16 2011 Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:46:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhNBA-0007my-1X for submit@debbugs.gnu.org; Thu, 14 Jul 2011 10:46:16 -0400 Received: from mail-pv0-f172.google.com ([74.125.83.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhNB8-0007ml-8I for 7118@debbugs.gnu.org; Thu, 14 Jul 2011 10:46:14 -0400 Received: by pvh18 with SMTP id 18so315576pvh.3 for <7118@debbugs.gnu.org>; Thu, 14 Jul 2011 07:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=gmF+pS6lXWk1s0WtgqfDQx9ZOCRkmnzNUtwcYffYJ/8=; b=KeWRkOIviASpMqtEJpibkReC1o7I9vW3+UsX5Mp2JttqhpfD/FawbsRfLRTELs7f/2 E56jAru5TmMBqHX6LOX/2CQDDcSvCmSLdPx310PrZp2eDc5MeHUqgiA2jde/N9+4jCz0 lN82qZHZr0mTmLfsBwxD8Sxc9o8pMVXBhbvPs= Received: by 10.142.120.1 with SMTP id s1mr1038354wfc.252.1310654768135; Thu, 14 Jul 2011 07:46:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Thu, 14 Jul 2011 07:45:28 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Thu, 14 Jul 2011 16:45:28 +0200 Message-ID: Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local To: Lars Magne Ingebrigtsen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) > What's the best way to make this change? =C2=A0Just say > > (make-variable-buffer-local 'var) > > after the `defvar', and then removing all the `make-local-variable' > calls? Yes. BTW, it's a mystery to me why `revert-buffer-function' is not automatically buffer-local, when every single package that sets it does so locally; having a global non-nil revert-buffer-function does not make any sense whatsoever. But IMHO, neither changing `revert-buffer-function' nor `dired-subdir-alist' and `dired-directory' is really a bug fix. Yes, as they are now is error prone, but the uses in the sources are already correct. That should be a wishlist item for 24.2. =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 10:50:37 2011 Received: (at 7118) by debbugs.gnu.org; 14 Jul 2011 14:50:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhNFM-0007sg-E6 for submit@debbugs.gnu.org; Thu, 14 Jul 2011 10:50:37 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QhNFK-0007sR-R3 for 7118@debbugs.gnu.org; Thu, 14 Jul 2011 10:50:35 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QhNF9-0008IZ-LX; Thu, 14 Jul 2011 16:50:23 +0200 From: Lars Magne Ingebrigtsen To: Juanma Barranquero Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local In-Reply-To: (Juanma Barranquero's message of "Thu, 14 Jul 2011 16:45:28 +0200") Date: Thu, 14 Jul 2011 16:49:19 +0200 Message-ID: References: User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU4UokADkMACj4ACT0A CDwADD+C3i9YAAACfklEQVQ4jT1UgZXrIAwjf4KYKwNgYICj6QAHzgCQeP9Vvpy05V5zryjGsiTq CMvzWSv7yHmvm+xP1amOruUjURj4N3MvJehRPsDAI1IIPHPloT8fYBbGcyXOtf9OvPA5iutwzi0U qhZ8DfqpOOPqbPmeWqShLABsI/O174LkxoEOuYHVbc0tq50VH02L6gUQDX+C0QVQZg165g+Q6VHJ rQBKimHws7sRSDV1khrdam+psUfFUNKU/36EaVkxiYcIeooBQ2eOZ8eEbqwh1DpKBsCq3IUEn3X5 xTFJuFgFChT9pEpc/YjWPWl+0wWtlmokDiVQliRiQDDBfU21xCwlermXMyUVr/EWEnNUZulb38AK Ug5KG8fAAPC35asCY5Thxdiufl18lt42A6YWno9N4uLcP/OSmB75psvDwyjT0Ax2Z0u9sUPniZiw AebBuqSbFRedxFzpttBMu4FkLnO/K257Ryllc0UHGDPfFr+BWtj8GGDM6/csRKbNijnCsNGc/5SQ nzVbfNRiFJcQ723Ym5qwM0FCAXBXLJiQQKo56EOzImXv7pfje29uMsYdSPq7w4JgZ0EAFUS1zPwF IKhIf7nZ6YfLlL8PQIXr0dTNF8aDikj1YoFDvWrAjTJSuFosRLeMYfIezpcBeGW2XnV1yC+ITGyN C3juUJShylRalnAMmgCIjleZrXAiZ+OHlkbYEGqywSeXdPUXV5FJyldKMDhDhdwwC8IavwDvz6fI BktxpRd0M7XcdUUlV6hg2sV/eHwBPebWdZrV8edbgf1wHKm2KwR/OAoGnQD0HjFdId9xyQRtrULH /dvA1mMHH7ECAOO6kOG5vaw5QXOYLvIfWvOxLtPqDYAAAAAASUVORK5CYII= X-Now-Playing: Joni Mitchell's _Blue_: "All I Want" X-Hashcash: 1:23:110714:7118@debbugs.gnu.org::J59MU+XujbNk9RTw:000000000000000000000000000000000000000001NDp X-Hashcash: 1:23:110714:monnier@iro.umontreal.ca::vltKiMB26zrdTvuV:0000000000000000000000000000000000000CMLr X-Hashcash: 1:23:110714:lekktu@gmail.com::o5nF8qzZks6R9lSR:1QTYx MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QhNF9-0008IZ-LX X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311259823.73447@yNhFXOwUauk0rnm9u/8clQ X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juanma Barranquero writes: > But IMHO, neither changing `revert-buffer-function' nor > `dired-subdir-alist' and `dired-directory' is really a bug fix. Yes, > as they are now is error prone, but the uses in the sources are > already correct. That should be a wishlist item for 24.2. Yeah, that's true. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 22:24:46 2011 Received: (at 7118) by debbugs.gnu.org; 17 Jul 2011 02:24:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiH2D-0002i6-Cb for submit@debbugs.gnu.org; Sat, 16 Jul 2011 22:24:45 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiH2B-0002ht-Bl for 7118@debbugs.gnu.org; Sat, 16 Jul 2011 22:24:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAJpHIk5MCqt8/2dsb2JhbABSp3V4iHzBEIY8BJ8nhDA X-IronPort-AV: E=Sophos;i="4.67,215,1309752000"; d="scan'208";a="126229815" Received: from 76-10-171-124.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.124]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 16 Jul 2011 22:24:37 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 96EBE660D5; Sat, 16 Jul 2011 22:24:37 -0400 (EDT) From: Stefan Monnier To: Lars Magne Ingebrigtsen Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Message-ID: References: Date: Sat, 16 Jul 2011 22:24:37 -0400 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 14 Jul 2011 16:49:19 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7118 Cc: Juanma Barranquero , 7118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >> But IMHO, neither changing `revert-buffer-function' nor >> `dired-subdir-alist' and `dired-directory' is really a bug fix. Yes, >> as they are now is error prone, but the uses in the sources are >> already correct. That should be a wishlist item for 24.2. Indeed. Also always be extra careful that none of the `setq' (resulting from removal of make-local-variable) can run before the make-variable-buffer-local. This is usually trivially the case, but problems can appear if the setq is within an autoloaded expression or when several files are involved. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 16:08:31 2011 Received: (at control) by debbugs.gnu.org; 2 Aug 2011 20:08:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoLGR-0002lK-JT for submit@debbugs.gnu.org; Tue, 02 Aug 2011 16:08:31 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoLGP-0002l8-BM for control@debbugs.gnu.org; Tue, 02 Aug 2011 16:08:30 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QoLFo-0000BO-TR for control@debbugs.gnu.org; Tue, 02 Aug 2011 22:07:52 +0200 Date: Tue, 02 Aug 2011 22:07:30 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #7118 X-MailScanner-ID: 1QoLFo-0000BO-TR X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1312920473.01208@mx6SMBa9eclACzeoM985/A X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) severity 7118 wishlist From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 17:12:46 2011 Received: (at 7118) by debbugs.gnu.org; 2 Aug 2011 21:12:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMGc-0005A3-Jn for submit@debbugs.gnu.org; Tue, 02 Aug 2011 17:12:46 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoMGa-00059u-FD for 7118@debbugs.gnu.org; Tue, 02 Aug 2011 17:12:44 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p72LCBop014408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Aug 2011 21:12:13 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p72LCAEq003171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 2 Aug 2011 21:12:11 GMT Received: from abhmt110.oracle.com (abhmt110.oracle.com [141.146.116.62]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p72LC7r6006801; Tue, 2 Aug 2011 16:12:08 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Aug 2011 14:11:46 -0700 THREAD-INDEX: AcxEKM1CKuHtohEYSqWbL9GS8mDIywNL81iw X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 MIME-Version: 1.0 Message-ID: <5B1509F3414B4493B0CC29BAEED357E3@us.oracle.com> Date: Tue, 2 Aug 2011 14:11:46 -0700 (PDT) From: Drew Adams To: "'Stefan Monnier'" , "'Lars Magne Ingebrigtsen'" Subject: RE: bug#7118: 24.0.50;dired-subdir-alist, dired-directory, etc.: necessarily buffer-local References: In-Reply-To: X-Mailer: Microsoft Office Outlook 11 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4E38682D.00EC:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 7118 Cc: 'Juanma Barranquero' , 7118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Please don't forget this part of the bug report, which has been ignored so far: > Still, we should mention in the doc string of > `dired-subdir-alist' that the subdirs are subdirs of > `dired-directory'. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 06 19:31:50 2022 Received: (at 7118) by debbugs.gnu.org; 7 Feb 2022 00:31:50 +0000 Received: from localhost ([127.0.0.1]:40349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrwc-0006wS-5P for submit@debbugs.gnu.org; Sun, 06 Feb 2022 19:31:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrwZ-0006pW-U5 for 7118@debbugs.gnu.org; Sun, 06 Feb 2022 19:31:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7l3vBxtp53JwAHNT/QZHv8jITXDlwGD+ZUbLJ3D3y+I=; b=BxP8qWI19KsFHJfz8CKM935UvH fBnihuRjRlHdSYT1VQFPqU63h+o0k04O5ZmnRGyL8IahOYD8pBRCfJXEbUQu3Dg0sTyvlpTLb/yEQ mtvNsX83dJHvWic8CeQ48XBeO+iaEdiOLYlt81chr5uMx0kEEZXKTinuAY7hiQyw37Fk=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGrwO-0001aW-FH; Mon, 07 Feb 2022 01:31:39 +0100 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local References: X-Now-Playing: David Bowie's _Station to Station_: "Word On A Wing" Date: Mon, 07 Feb 2022 01:31:35 +0100 In-Reply-To: (Drew Adams's message of "Mon, 27 Sep 2010 11:47:39 -0700") Message-ID: <871r0f34bc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Drew Adams" writes: > We should use `make-variable-buffer-local' with vars such as > `dired-subdir-alist' and `dired-directory', instead of just calling > `make-local-variable'. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 7118 Cc: 7118@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Drew Adams" writes: > We should use `make-variable-buffer-local' with vars such as > `dired-subdir-alist' and `dired-directory', instead of just calling > `make-local-variable'. I've now fixed this in Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 06 19:31:51 2022 Received: (at control) by debbugs.gnu.org; 7 Feb 2022 00:31:51 +0000 Received: from localhost ([127.0.0.1]:40351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrwd-0006xX-G5 for submit@debbugs.gnu.org; Sun, 06 Feb 2022 19:31:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrwb-0006rR-Nn for control@debbugs.gnu.org; Sun, 06 Feb 2022 19:31:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rn6/CoOLOF4OMeA1EgCOk1b8nE1alDMeEmnUoyZ0cqM=; b=FWaQ9Yxg9tZSzT7EHjOg3hJetW qq/U3vPegC17fyKioQc0cnUgvnjkN92J806FLUW8Y64Gxsux1d976KmvMo+NRSQihbdBzurAZ0tU+ e9cT1GSrxYVq3lQaWOlHmIiXVma85MDRVIdmQv1+GGywEKlJrzIgJrhcS9hBB2gNDMOU=; Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGrwT-0001ab-MV for control@debbugs.gnu.org; Mon, 07 Feb 2022 01:31:44 +0100 Date: Mon, 07 Feb 2022 01:31:41 +0100 Message-Id: <87zgn31pqq.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #7118 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 7118 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 7118 29.1 quit From unknown Mon Aug 18 04:38:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Mar 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator