GNU bug report logs - #71179
[PATCH] In rgrep, check matching files before excluding files

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 71179 <at> debbugs.gnu.org
Subject: bug#71179: [PATCH] In rgrep, check matching files before excluding files
Date: Sat, 25 May 2024 17:51:11 +0300

On 25/05/2024 17:13, Eli Zaretskii wrote:
>>   For example, you never
>>   considered the cases where the files which match the pattern to search
>>   also match the ignored-extensions, and many other possibilities.
>>
>> In that case the file will not be searched, same as before this change.  No behavior change.
> We are talking about performance here.

FWIW I don't see which performance problem you have in mind.

If you mean the possible regression in the case "user picked file 
extension that's already in ignores", then I don't think it's going to 
be any noticeably slower in vast majority of cases. And it's not a 
scenario to optimize for anyway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.