GNU bug report logs - #71179
[PATCH] In rgrep, check matching files before excluding files

Previous Next

Package: emacs;

Reported by: Spencer Baugh <sbaugh <at> janestreet.com>

Date: Fri, 24 May 2024 20:15:02 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #44 received at 71179 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: dmitry <at> gutov.dev, 71179 <at> debbugs.gnu.org
Subject: Re: bug#71179: [PATCH] In rgrep, check matching files before
 excluding files
Date: Sat, 25 May 2024 17:13:17 +0300
> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Date: Sat, 25 May 2024 10:02:02 -0400
> Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 71179 <at> debbugs.gnu.org
> 
> On Sat, May 25, 2024, 9:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  For example, you never
>  considered the cases where the files which match the pattern to search
>  also match the ignored-extensions, and many other possibilities.  
> 
> In that case the file will not be searched, same as before this change.  No behavior change.

We are talking about performance here.

> What other possibilities?

Who knows?  Why risk any changes at all?

Anyway, I suggested an approach that should leave everyone happy.  Why
are we still arguing?




This bug report was last modified 1 year and 40 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.