From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 May 2024 19:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 71178@debbugs.gnu.org Cc: Stefan Monnier X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.171657862322402 (code B ref -1); Fri, 24 May 2024 19:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 May 2024 19:23:43 +0000 Received: from localhost ([127.0.0.1]:38733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAaVz-0005pG-Is for submit@debbugs.gnu.org; Fri, 24 May 2024 15:23:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:43080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAaVx-0005pA-HT for submit@debbugs.gnu.org; Fri, 24 May 2024 15:23:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAaVp-0006XI-NX for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 15:23:33 -0400 Received: from mail.muc.de ([193.149.48.3]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAaVn-0006li-P5 for bug-gnu-emacs@gnu.org; Fri, 24 May 2024 15:23:33 -0400 Received: (qmail 15265 invoked by uid 3782); 24 May 2024 21:23:15 +0200 Received: from muc.de (p4fe15616.dip0.t-ipconnect.de [79.225.86.22]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Fri, 24 May 2024 21:23:15 +0200 Received: (qmail 17894 invoked by uid 1000); 24 May 2024 19:23:14 -0000 Date: Fri, 24 May 2024 19:23:14 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de Received-SPF: pass client-ip=193.149.48.3; envelope-from=acm@muc.de; helo=mail.muc.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, Stefan and Emacs. In my development branch, based on master, last updated ~March 2024. (i) Build emacs. (ii) make -j17 check. The ert session this starts goes well, apart from in lisp/erc/erc-tests.el. This gets aborted by ert after 62 from 92 tests have passed. Test 63 fails for known reasons, a mismatch of two strings compared with `equal'. The log file, erc-tests.log, looks like this around the output for test 63: ......................................................... passed 60/92 erc--update-user-modes (0.000093 sec) passed 61/92 erc--user-modes (0.000053 sec) passed 62/92 erc--valid-local-channel-p (0.000071 sec) Test erc--with-dependent-type-match backtrace: Aborted: Ran 92 tests, 62 results as expected, 1 unexpected (2024-05-24 15:26:55+0000, 2.791555 sec) 1 unexpected results: FAILED erc--with-dependent-type-match UNKNOWN erc--with-entrypoint-environment UNKNOWN erc-channel-p UNKNOWN erc-channel-user ........................................................ Note that (i) No error message or backtrace gets printed for test 63. This is a bug. (ii) The test run gets aborted. This shouldn't happen, and is a bug. erc-tests.el runs satisfactorally in an Emacs session, started by M-x ert, and accepting the default selection t. -- Alan Mackenzie (Nuremberg, Germany). From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.171675444412244 (code B ref 71178); Sun, 26 May 2024 20:15:01 +0000 Received: (at 71178) by debbugs.gnu.org; 26 May 2024 20:14:04 +0000 Received: from localhost ([127.0.0.1]:42632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBKFo-0003BQ-0Q for submit@debbugs.gnu.org; Sun, 26 May 2024 16:14:04 -0400 Received: from mail-108-mta17.mxroute.com ([136.175.108.17]:35191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBKFm-0003BI-8W for 71178@debbugs.gnu.org; Sun, 26 May 2024 16:14:03 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta17.mxroute.com (ZoneMTA) with ESMTPSA id 18fb689b128000efce.001 for <71178@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 26 May 2024 20:13:48 +0000 X-Zone-Loop: 733d5c2821642fea36ffcd534c9ba46d7d1cd42d866a X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2Ea51jzbNq9BB8CYLNMG9PlEPEKyrcJGFUWUFpGq9A4=; b=WemNNqU0qqz9t/SZtu5XY5QUig h929IttPYSGuYERVWb88yMGfDX89Gs1XuFruPuIQQgVrGv+xv1PU8uR9YWXHXd0L9EBs1fBrhLmr2 gGj5yPC8fJdyWHmsHqYIjhLkagetihE10HNAeq4fMV4rt3EsdtFUhfJKerWaB7E3gDJAnzpZk7mk5 rUYEFC4PBcbrxPMPzF7ldDeu0FCdkyxiXNNTwcTy6bIRbMnQisqmRkcGuf0P9VPab5e70lLg+X5im Ewv6l4k+qAZ5qXCxGv3gRHCflptgFxBMMADjT/4DeDqPthuQUBG2mn2MIkH4FT5RwG6u+SJurFW7h gvGSQmlQ==; From: "J.P." In-Reply-To: (Alan Mackenzie's message of "Fri, 24 May 2024 19:23:14 +0000") References: Date: Sun, 26 May 2024 13:13:43 -0700 Message-ID: <87ikz0xrew.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Alan, Alan Mackenzie writes: > Hello, Stefan and Emacs. > > In my development branch, based on master, last updated ~March 2024. > > (i) Build emacs. > (ii) make -j17 check. > > The ert session this starts goes well, apart from in > lisp/erc/erc-tests.el. This gets aborted by ert after 62 from 92 tests > have passed. Test 63 fails for known reasons, a mismatch of two strings > compared with `equal'. > > The log file, erc-tests.log, looks like this around the output for test > 63: > > ......................................................... > passed 60/92 erc--update-user-modes (0.000093 sec) > passed 61/92 erc--user-modes (0.000053 sec) > passed 62/92 erc--valid-local-channel-p (0.000071 sec) > Test erc--with-dependent-type-match backtrace: > > Aborted: Ran 92 tests, 62 results as expected, 1 unexpected (2024-05-24 > 15:26:55+0000, 2.791555 sec) > > 1 unexpected results: > FAILED erc--with-dependent-type-match > UNKNOWN erc--with-entrypoint-environment > UNKNOWN erc-channel-p > UNKNOWN erc-channel-user I'm afraid I must claim this as my own handiwork. My apologies. > ........................................................ > > Note that > (i) No error message or backtrace gets printed for test 63. This is a > bug. > (ii) The test run gets aborted. This shouldn't happen, and is a bug. Yes, this is unfortunate. > erc-tests.el runs satisfactorally in an Emacs session, started by M-x > ert, and accepting the default selection t. It seems you have identified the underlying cause: https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html The test itself is of minimal utility and is therefore rubbish (if not outright vandalism), so I will remove it unless you'd rather it stick around until the conversation on the list gets going. Thanks, J.P. From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "J.P." Cc: Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.17168237217488 (code B ref 71178); Mon, 27 May 2024 15:29:01 +0000 Received: (at 71178) by debbugs.gnu.org; 27 May 2024 15:28:41 +0000 Received: from localhost ([127.0.0.1]:45068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBcHA-0001wh-O3 for submit@debbugs.gnu.org; Mon, 27 May 2024 11:28:41 -0400 Received: from mail.muc.de ([193.149.48.3]:60356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBcH8-0001wU-EG for 71178@debbugs.gnu.org; Mon, 27 May 2024 11:28:39 -0400 Received: (qmail 28773 invoked by uid 3782); 27 May 2024 17:28:23 +0200 Received: from muc.de (p4fe150ab.dip0.t-ipconnect.de [79.225.80.171]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 27 May 2024 17:28:22 +0200 Received: (qmail 21390 invoked by uid 1000); 27 May 2024 15:28:21 -0000 Date: Mon, 27 May 2024 15:28:21 +0000 Message-ID: References: <87ikz0xrew.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ikz0xrew.fsf@neverwas.me> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, JP. On Sun, May 26, 2024 at 13:13:43 -0700, J.P. wrote: > Hi Alan, > Alan Mackenzie writes: > > Hello, Stefan and Emacs. > > In my development branch, based on master, last updated ~March 2024. > > (i) Build emacs. > > (ii) make -j17 check. > > The ert session this starts goes well, apart from in > > lisp/erc/erc-tests.el. This gets aborted by ert after 62 from 92 tests > > have passed. Test 63 fails for known reasons, a mismatch of two strings > > compared with `equal'. > > The log file, erc-tests.log, looks like this around the output for test > > 63: > > ......................................................... > > passed 60/92 erc--update-user-modes (0.000093 sec) > > passed 61/92 erc--user-modes (0.000053 sec) > > passed 62/92 erc--valid-local-channel-p (0.000071 sec) > > Test erc--with-dependent-type-match backtrace: > > Aborted: Ran 92 tests, 62 results as expected, 1 unexpected (2024-05-24 > > 15:26:55+0000, 2.791555 sec) > > 1 unexpected results: > > FAILED erc--with-dependent-type-match > > UNKNOWN erc--with-entrypoint-environment > > UNKNOWN erc-channel-p > > UNKNOWN erc-channel-user > I'm afraid I must claim this as my own handiwork. My apologies. Thanks! But I think that erc--restore-initialize-priors has triggered the error rather than containing the error itself. I don't really think you should be apologising for this. ;-) > > ........................................................ > > Note that > > (i) No error message or backtrace gets printed for test 63. This is a > > bug. > > (ii) The test run gets aborted. This shouldn't happen, and is a bug. > Yes, this is unfortunate. > > erc-tests.el runs satisfactorally in an Emacs session, started by M-x > > ert, and accepting the default selection t. > It seems you have identified the underlying cause: > https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html I've been looking at lisp/emacs-lisp/ert.el, and I think that suppressing the debug output (or rather, not invoking a backtrace dump in batch mode) is where the problem lies. However, when I enabled these in my own copy, they produced an erc.log of over 100 MB. But that was in my customised Emacs where I've changed quite a few things always to get a complete backtrace. So I'm not sure what is best, here. > The test itself is of minimal utility and is therefore rubbish (if not > outright vandalism), so I will remove it unless you'd rather it stick > around until the conversation on the list gets going. I think I'd rather the test should stay there a bit longer. It highlights problems in pcase.el and ert.el which might get fixed sooner if the test is still there. _MIGHT_ (here's hoping!). > Thanks, > J.P. -- Alan Mackenzie (Nuremberg, Germany). From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.17169032112035 (code B ref 71178); Tue, 28 May 2024 13:34:02 +0000 Received: (at 71178) by debbugs.gnu.org; 28 May 2024 13:33:31 +0000 Received: from localhost ([127.0.0.1]:45986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBwxG-0000Wh-2b for submit@debbugs.gnu.org; Tue, 28 May 2024 09:33:30 -0400 Received: from mail-108-mta253.mxroute.com ([136.175.108.253]:38285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBwxD-0000WS-H3 for 71178@debbugs.gnu.org; Tue, 28 May 2024 09:33:28 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta253.mxroute.com (ZoneMTA) with ESMTPSA id 18fbf67ab26000efce.001 for <71178@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 28 May 2024 13:33:13 +0000 X-Zone-Loop: 52d88d53a5f6204763b5c88a6dae64215b2356eb53f7 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=st4YvkAU+PmUGwrtD1UzQzU6uSfzTl0yCvjUHRfx0uI=; b=UIHLQMj+abF1S3HMwOEnzZUx7L N7B3L2pGYqxoiq7uLqma3DJQAmETF3yKOo/3Ffq3160WWnWp652rNFgcVs9t/soSVpu9+ueLMhCSL EBIg0BtEguMQNep1tzn7ry63UpRaRRnDjL5DcUQ5KFOUy7FLf+Zeb7IgHuCyZGgY68DaMZtkWmKK9 AUBVN+JfEebn9DXVcmxIZhuS1YAYxTi3WHxVJYi9EvEz6Ajtgs7NkTx/BcMsJ1MXHF7d6ThzLGocS krEVsyYtlh5jVrvlKd1aQqZ5GeNECXVz2dCTCWZPl0/vzTSMOQ6VZdUZOlQ7/yj3QtFCTKTfW0vqh 91mcyoOQ==; From: "J.P." In-Reply-To: (Alan Mackenzie's message of "Mon, 27 May 2024 15:28:21 +0000") References: <87ikz0xrew.fsf@neverwas.me> Date: Tue, 28 May 2024 06:33:08 -0700 Message-ID: <871q5moycr.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Alan, Alan Mackenzie writes: >> It seems you have identified the underlying cause: > >> https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01140.html > > I've been looking at lisp/emacs-lisp/ert.el, and I think that suppressing > the debug output (or rather, not invoking a backtrace dump in batch mode) > is where the problem lies. However, when I enabled these in my own copy, > they produced an erc.log of over 100 MB. But that was in my customised > Emacs where I've changed quite a few things always to get a complete > backtrace. So I'm not sure what is best, here. I too have bumped into failures that don't produce a backtrace, at least in recent versions. However, the ones I typically see look more like: Error in process sentinel Make[3] *** [Makefile:184 lisp/erc/erc-*.log] Error 255 ... 1 files did not finish: lisp/erc/erc-*.log Make *** [Makefile:266 check-lisp-erc] Error 2 With these, it seems debug output is being intentionally suppressed on account of the error originating from some process sentinel or timer. And when I enable `debug-on-error', a backtrace appears as expected. This leads me to assume such occurrences are somewhat unrelated to what you're experiencing. That said, I'm fairly convinced I've encountered the odd mystery failure with no specified error. And the "aborted" line in your excerpt does look familiar. Sadly, though, I cannot reliably reproduce anything similar (yet). >> The test itself is of minimal utility and is therefore rubbish (if not >> outright vandalism), so I will remove it unless you'd rather it stick >> around until the conversation on the list gets going. > > I think I'd rather the test should stay there a bit longer. It > highlights problems in pcase.el and ert.el which might get fixed sooner > if the test is still there. _MIGHT_ (here's hoping!). Good point. I've added a FIXME to remind myself or some future person to delete the test once things have settled. Cheers, J.P. From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 22:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.171762631721380 (code B ref 71178); Wed, 05 Jun 2024 22:26:02 +0000 Received: (at 71178) by debbugs.gnu.org; 5 Jun 2024 22:25:17 +0000 Received: from localhost ([127.0.0.1]:42628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEz4G-0005Yi-8O for submit@debbugs.gnu.org; Wed, 05 Jun 2024 18:25:16 -0400 Received: from mail-108-mta3.mxroute.com ([136.175.108.3]:41865) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEytD-000559-2O for 71178@debbugs.gnu.org; Wed, 05 Jun 2024 18:13:52 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta3.mxroute.com (ZoneMTA) with ESMTPSA id 18fea76edaa00017a3.001 for <71178@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 05 Jun 2024 22:13:33 +0000 X-Zone-Loop: ae5ad510337241d05ab9904879ed3c4b55d933d9d8ff X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=N1i9xmzK+mf3rltJoKuNyOC4ADqI+nlGbDe/mTHsdIc=; b=UgV7s4Q4qH5MkDVTWNGYyhhVLs gk2LKweX3rEqUzNfq+0DGAjHzG9vJ1ZZMnYv9RXwwr7eJu8VElkhaH0FzblEBBkq6LTEbjyDHptKK YIHJg+L0VyluPZvByXpyTl8B9goXupew1SqyK/Q7xFj6GvlM/yo6yyc14FlB6Ron0U4srG66L3gze c5Px77Jypof1fc2LAHlZkvyF932KLr88sJpeLwvv69vkrEmZmKdlq1yUkRcTinShlwAGiwwhgniKU wWOJKQpoN7gWEoTWzVG0hb6Dfrae2G9uOnkGrZaKEytlfk0PLXqTp2OHPhCGmZU1E905OXn3eRtJ8 nWrL7EGQ==; From: "J.P." In-Reply-To: <871q5moycr.fsf@neverwas.me> (J. P.'s message of "Tue, 28 May 2024 06:33:08 -0700") References: <87ikz0xrew.fsf@neverwas.me> <871q5moycr.fsf@neverwas.me> Date: Wed, 05 Jun 2024 15:13:29 -0700 Message-ID: <877cf3nily.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "J.P." writes: >> I think I'd rather the test should stay there a bit longer. It >> highlights problems in pcase.el and ert.el which might get fixed sooner >> if the test is still there. _MIGHT_ (here's hoping!). > > Good point. I've added a FIXME to remind myself or some future person to > delete the test once things have settled. The issue of the large pcase expansion appears to have been addressed by 16fc5b6c0c7 * pcase.el (\`): Try and handle large patterns better I have therefore deleted the offending test. I'm leaving this bug open because its main concern is the absence of adequate reporting under certain failure conditions. Thanks. From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2024 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "J.P." Cc: acm@muc.de, Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.173013909119580 (code B ref 71178); Mon, 28 Oct 2024 18:12:01 +0000 Received: (at 71178) by debbugs.gnu.org; 28 Oct 2024 18:11:31 +0000 Received: from localhost ([127.0.0.1]:54669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UDD-00055j-0N for submit@debbugs.gnu.org; Mon, 28 Oct 2024 14:11:31 -0400 Received: from mail.muc.de ([193.149.48.3]:28177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UDB-00055S-8E for 71178@debbugs.gnu.org; Mon, 28 Oct 2024 14:11:30 -0400 Received: (qmail 36944 invoked by uid 3782); 28 Oct 2024 19:10:44 +0100 Received: from muc.de (p4fe15284.dip0.t-ipconnect.de [79.225.82.132]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 28 Oct 2024 19:10:44 +0100 Received: (qmail 14054 invoked by uid 1000); 28 Oct 2024 18:10:43 -0000 Date: Mon, 28 Oct 2024 18:10:43 +0000 Message-ID: References: <87ikz0xrew.fsf@neverwas.me> <871q5moycr.fsf@neverwas.me> <877cf3nily.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877cf3nily.fsf@neverwas.me> X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, J.P. On Wed, Jun 05, 2024 at 15:13:29 -0700, J.P. wrote: > "J.P." writes: > >> I think I'd rather the test should stay there a bit longer. It > >> highlights problems in pcase.el and ert.el which might get fixed sooner > >> if the test is still there. _MIGHT_ (here's hoping!). > > Good point. I've added a FIXME to remind myself or some future person to > > delete the test once things have settled. > The issue of the large pcase expansion appears to have been addressed by > 16fc5b6c0c7 * pcase.el (\`): Try and handle large patterns better > I have therefore deleted the offending test. > I'm leaving this bug open because its main concern is the absence of > adequate reporting under certain failure conditions. Thanks. Back in the springtime, I identified the cause of my particular bug, namely the backtrace function trying to print a copy of the too big structure which triggered the bug in the first place. This led to a recursive error signalling. Stefan Monnier amended pcase earlier on this year better to handle "big" structures, and I think you deleted the ert test which triggered the bug anyway. The circumstances which triggered this bug don't seem to have occurred in the last few months. So it seems it is now time to close this bug. Would you have anything against me closing it as "won't fix"? Thanks! -- Alan Mackenzie (Nuremberg, Germany). From unknown Thu Aug 14 21:56:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71178: Batch ert wrongly aborts a test run, and wrongly fails to say why. Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Oct 2024 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alan Mackenzie Cc: Stefan Monnier , 71178@debbugs.gnu.org Received: via spool by 71178-submit@debbugs.gnu.org id=B71178.173013965321108 (code B ref 71178); Mon, 28 Oct 2024 18:21:02 +0000 Received: (at 71178) by debbugs.gnu.org; 28 Oct 2024 18:20:53 +0000 Received: from localhost ([127.0.0.1]:54688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UMH-0005Ty-3Q for submit@debbugs.gnu.org; Mon, 28 Oct 2024 14:20:53 -0400 Received: from mail-108-mta177.mxroute.com ([136.175.108.177]:44607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5UMA-0005Q2-FV for 71178@debbugs.gnu.org; Mon, 28 Oct 2024 14:20:52 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta177.mxroute.com (ZoneMTA) with ESMTPSA id 192d45b48090003e01.001 for <71178@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 28 Oct 2024 18:20:05 +0000 X-Zone-Loop: a3cbb066f9ac9870980ab33364cda4f1ce245b1679c4 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=G4j4E88W/7Izjxf6WS7a5+ERMaxTfSk3+ofLOnycK3g=; b=L8aUXUTV4WNE/yBtCJVSVLqaKx cGflMudvgyLo7QD3PtbbinYMl0RADjPTwthjaWmTTydc2lflS0561HOlSSWPqV95VzpwduPrlqupd hKcxxBG0H1zE0A+1CB/3FKQA8CYIsHH/vdzjnLs/IerRu9O7eZ7VWf3l/yiHf1y4mugQZnZpoCxZK xUxOziw9M1DpJmu36oi63ulvqMFPuIJ44t5q6xE92G1QBgWFJZVUWWiNiLuvY43hnPB9xE0H5DR3c sBIVovSy4bC2ho1X0M5lXDqlo6xc/4aoC9RAcPpXm40QOh1E7KfHK/yPZqwYMknc0mqwBntZPDDiy QAInK0Dg==; From: "J.P." In-Reply-To: (Alan Mackenzie's message of "Mon, 28 Oct 2024 18:10:43 +0000") References: <87ikz0xrew.fsf@neverwas.me> <871q5moycr.fsf@neverwas.me> <877cf3nily.fsf@neverwas.me> Date: Mon, 28 Oct 2024 11:20:01 -0700 Message-ID: <87ttcw144u.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alan Mackenzie writes: > Stefan Monnier amended pcase earlier on this year better to handle "big" > structures, and I think you deleted the ert test which triggered the > bug anyway. Right, I did indeed. > > The circumstances which triggered this bug don't seem to have occurred > in the last few months. That's great to hear. > So it seems it is now time to close this bug. Would you have anything > against me closing it as "won't fix"? Not at all. Makes sense to me. Cheers. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 15:04:24 2024 Received: (at control) by debbugs.gnu.org; 28 Oct 2024 19:04:24 +0000 Received: from localhost ([127.0.0.1]:54731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5V2N-0007Ps-SG for submit@debbugs.gnu.org; Mon, 28 Oct 2024 15:04:24 -0400 Received: from mail.muc.de ([193.149.48.3]:40392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5V2L-0007Pb-E6 for control@debbugs.gnu.org; Mon, 28 Oct 2024 15:04:22 -0400 Received: (qmail 97164 invoked by uid 3782); 28 Oct 2024 20:03:37 +0100 Received: from muc.de (p4fe15284.dip0.t-ipconnect.de [79.225.82.132]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 28 Oct 2024 20:03:37 +0100 Received: (qmail 14906 invoked by uid 1000); 28 Oct 2024 19:03:36 -0000 Date: Mon, 28 Oct 2024 19:03:36 +0000 To: control@debbugs.gnu.org Subject: Re: bug#71178: Acknowledgement (Batch ert wrongly aborts a test run, and wrongly fails to say why.) Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Submission-Agent: TMDA/1.3.x (Ph3nix) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 71178 + wontfix close 71178 quit The trigger for this bug was a Lisp structure generated by pcase which was over PRINT_CIRCLE (200) elements deep. The error handler attempted to print a backtrace, which in turn attempted to print the Lisp structure. This led to a recursive exception. The ert test which triggered the bug has been removed. pcase has been amended to produce less deeply nested Lisp structures. So it seems appropriate to close this bug as won't fix, given that it's not currently causing problems, and nobody's working on it. It could be reopened if the same problem were to crop up again. -- Alan Mackenzie (Nuremberg, Germany).