GNU bug report logs - #71155
Update vcmi to 1.5.1

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Vagrant Cascadian <vagrant <at> debian.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71155: closed (Update vcmi to 1.5.1)
Date: Sat, 25 May 2024 20:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 25 May 2024 13:22:45 -0700
with message-id <874jalproq.fsf <at> wireframe>
and subject line Re: Update vcmi to 1.5.1
has caused the debbugs.gnu.org bug report #71155,
regarding Update vcmi to 1.5.1
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71155: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71155
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Cc: iyzsong <at> envs.net, liliana.prikler <at> gmail.com, adam.faiz <at> disroot.org
Subject: Update vcmi to 1.5.1
Date: Thu, 23 May 2024 15:41:21 -0700

[Message part 3 (text/plain, inline)]

Updated vcmi. Needed to disable a feature that requires an embedded copy
of innoextract via git submodules. Would require significant reworking
to use the guix-shipped innoextract.

Have not actually play-tested yet, but will get to that...

live well,
  vagrant

[0001-gnu-vcmi-Update-to-1.5.1.patch (text/x-diff, inline)]

From b202245d60130728b861df08a79e2450cd778ad3 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Thu, 23 May 2024 14:23:47 -0700
Subject: [PATCH] gnu: vcmi: Update to 1.5.1.

* gnu/packages/games.scm (vcmi): Update to 1.5.1.
[#:configure-flags]: Disable use of embedded innoextract.
---
 gnu/packages/games.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 03a36a8a6d..73d1ffc008 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -11467,7 +11467,7 @@ (define-public fheroes2
 (define-public vcmi
   (package
     (name "vcmi")
-    (version "1.4.5")
+    (version "1.5.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -11476,11 +11476,11 @@ (define-public vcmi
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1z4vy3drj6dra8rb243pyryr61jnlw3l7yxsxwl9rddv8cdk69lz"))
+                "1s3a23p9k081ccbkhvifx2rhg6rv82fkrsbjh6allmmsa1lhq6fd"))
               (patches (search-patches "vcmi-disable-privacy-breach.patch"))))
     (build-system cmake-build-system)
     (arguments
-     (list #:configure-flags #~(list "-DFORCE_BUNDLED_FL=OFF")
+     (list #:configure-flags #~(list "-DFORCE_BUNDLED_FL=OFF" "-DENABLE_INNOEXTRACT=OFF")
            ;; Test suites do not seem well supported upstream and are disabled by default.
            ;; Pass -DENABLE_TEST to configure to enable.
            #:tests? #f))

base-commit: 9901416233867233192b63fde7f616751127b189
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

[Message part 6 (message/rfc822, inline)]

From: Vagrant Cascadian <vagrant <at> debian.org>
To: 宋文武 <iyzsong <at> envs.net>
Cc: 71155-done <at> debbugs.gnu.org, liliana.prikler <at> gmail.com,
 adam.faiz <at> disroot.org
Subject: Re: Update vcmi to 1.5.1
Date: Sat, 25 May 2024 13:22:45 -0700

[Message part 7 (text/plain, inline)]

On 2024-05-24, 宋文武 wrote:
> Vagrant Cascadian <vagrant <at> debian.org> writes:
>
>> Updated vcmi. Needed to disable a feature that requires an embedded copy
>> of innoextract via git submodules. Would require significant reworking
>> to use the guix-shipped innoextract.
>
> Look good to me, please push, thank you!

Thanks for the review!

Pushed as 94c8cec99969fe9f65777637fde1f05e1c576a3f.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.