GNU bug report logs - #71146
[PATCH] gnu: kallisto: Update to 0.50.1

Previous Next

Package: guix-patches;

Reported by: guix <at> mawumag.com

Date: Thu, 23 May 2024 13:38:02 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 71146 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix <at> mawumag.com
Cc: 71146 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: kallisto: Update to 0.50.1
Date: Sat, 01 Jun 2024 21:13:10 +0200
Ricardo Wurmus <rekado <at> elephly.net> writes:

>> I had to modify the 'do-not-use-bundled-htslib snippet to make one
>> regex more selective---in this new version it the previous regex was
>> mistakenly modifying parts of CMakeLists.txt other than the intended
>> one.
>
> It looks like this might not be working as intended.  I used:
>
>     guix gc -R $(./pre-inst-env guix build kallisto)
>
> and it shows me that the newly built kallisto does not link with our
> htslib.  Perhaps it used the static library?

Turns out it's not actually using htslib at all, because USE_BAM is not
set.  It uses a bundled copy of bifrost instead.  If we want to build
kallisto with bifrost only then we should remove htslib from the inputs,
package bifrost (https://github.com/pmelsted/bifrost) and unbundle it
from kallisto, linking with the shared library.

Does this sound like a good plan or should we use htslib instead?

-- 
Ricardo




This bug report was last modified 200 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.