From unknown Fri Jun 20 05:26:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71123 <71123@debbugs.gnu.org> To: bug#71123 <71123@debbugs.gnu.org> Subject: Status: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Reply-To: bug#71123 <71123@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:26:29 +0000 retitle 71123 [PATCH] Rename `subr-native-elisp` to `native-comp-function` reassign 71123 emacs submitter 71123 Stefan Monnier severity 71123 normal tag 71123 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 13:50:48 2024 Received: (at submit) by debbugs.gnu.org; 22 May 2024 17:50:48 +0000 Received: from localhost ([127.0.0.1]:57298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9q6x-0005h8-LY for submit@debbugs.gnu.org; Wed, 22 May 2024 13:50:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:50650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9q6t-0005h2-Dd for submit@debbugs.gnu.org; Wed, 22 May 2024 13:50:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9q6m-00032e-EB for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 13:50:37 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9q6h-00068j-Uf for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 13:50:36 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F2BF5444718 for ; Wed, 22 May 2024 13:50:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716400223; bh=qyuxB7zCcLfZQH272DSrnFBFRxFOlSb/DgrJ2DxxCFA=; h=From:To:Subject:Date:From; b=lrzXDl+fO+HXXMWi4/rmF1/cB80dbgaAXWMCDnj4s2IPXScnPGyv53e8wzSK9XvD3 PvAPbHDNBXaM3yk5JEcVGJ2Iw6iQxQ5NDF0e7lmcwnT4wcKbFZGp8TQq4oo/6jPqVw pHjSkSObftshOYJhp0mATP8WEBA8pMqx/rFCmcPcvj9WahXB6JYT7IcuchWSZEYL0J /gmVbg8b5ngSFxl4Pw7pTm6mkp3EyQN/5xwbsqtIizMTyziQXZiK/yJcwgnlJQTA5T SldsVOuZGiblfMMd9pxuSxceB0qOHRTmRKxAvIija1Z/qRXCZylBfl8O2e+jDSsvhH 2dZeIe/OcnsbQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id CF4AF44471A for ; Wed, 22 May 2024 13:50:23 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C1CCC120230 for ; Wed, 22 May 2024 13:50:23 -0400 (EDT) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Message-ID: X-Debbugs-Cc: monnier@iro.umontreal.ca Date: Wed, 22 May 2024 13:50:17 -0400 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.109 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch I can't remember where someone requested a nicer name than `subr-native-elisp`, but here's a patch which aims to do that. AFAICT we do not need to preserve the *type* `subr-native-elisp` because it was never exposed to ELisp before Emacs-30 anyway. So the only backward compatibility needed is the `subr-native-elisp-p` function. I chose `native-comp-function` as the new name based on a few `grep`s through our C code which suggested that `native-comp-` is the most "popular" prefix in there from code related to native compilation. I don't have a strong preference, so if there's a consensus around another name, I'll happily change the patch accordingly. Stefan In GNU Emacs 30.0.50 (build 2, i686-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-06 built on lechazo Repository revision: b0d12d2b65c94af306c8f116a3dfb0040e2feef3 Repository branch: work Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Debian GNU/Linux trixie/sid Configured using: 'configure -C --enable-checking --enable-check-lisp-object-type --with-modules --with-cairo --with-tiff=ifavailable 'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign' --without-native-compilation PKG_CONFIG_PATH=/home/monnier/lib/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Rename-subr-native-elisp-to-native-comp-function.patch >From a0df6f4eabf0f64267b6d31905982e620f581a3f Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Wed, 22 May 2024 13:45:39 -0400 Subject: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Now that this type name is displayed in *Help*, it is more important to use a name that is less weird for the unsuspecting user. * lisp/emacs-lisp/cl-preloaded.el (cl-functionp): Adjust to new name of native function's type. (subr-native-elisp-p): Redefine as an obsolete alias. (native-comp-function): Rename from `subr-native-elisp` * src/data.c (Fcl_type_of): Return `Qnative_comp_function` i.s.o `Qsubr_native_elisp`. (Fnative_comp_function_p): Rename from `Fsubr_native_elisp_p`. (syms_of_data): Adjust accordingly. * src/doc.c (Fsubr_documentation): Use new `Fnative_comp_function_p` name. --- lisp/emacs-lisp/cl-preloaded.el | 5 +++-- src/data.c | 12 ++++++------ src/doc.c | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el index fa745396b02..4b1bd2a9aff 100644 --- a/lisp/emacs-lisp/cl-preloaded.el +++ b/lisp/emacs-lisp/cl-preloaded.el @@ -355,7 +355,7 @@ cl-functionp This is like `functionp' except that it returns nil for all lists and symbols, regardless if `funcall' would accept to call them." (memq (cl-type-of object) - '(primitive-function subr-native-elisp module-function + '(primitive-function native-comp-function module-function interpreted-function byte-code-function))) (cl--define-built-in-type t nil "Abstract supertype of everything.") @@ -465,7 +465,8 @@ interpreted-function "Type of functions that have not been compiled.") (cl--define-built-in-type special-form (subr) "Type of the core syntactic elements of the Emacs Lisp language.") -(cl--define-built-in-type subr-native-elisp (subr compiled-function) +(define-obsolete-function-alias 'subr-native-elisp-p #'native-comp-function-p "30.1") +(cl--define-built-in-type native-comp-function (subr compiled-function) "Type of functions that have been compiled by the native compiler.") (cl--define-built-in-type primitive-function (subr compiled-function) "Type of functions hand written in C.") diff --git a/src/data.c b/src/data.c index 30d8eab7359..2ff5050580d 100644 --- a/src/data.c +++ b/src/data.c @@ -244,7 +244,7 @@ DEFUN ("cl-type-of", Fcl_type_of, Scl_type_of, 1, 1, 0, case PVEC_WINDOW: return Qwindow; case PVEC_SUBR: return XSUBR (object)->max_args == UNEVALLED ? Qspecial_form - : SUBR_NATIVE_COMPILEDP (object) ? Qsubr_native_elisp + : SUBR_NATIVE_COMPILEDP (object) ? Qnative_comp_function : Qprimitive_function; case PVEC_CLOSURE: return CONSP (AREF (object, CLOSURE_CODE)) @@ -1060,9 +1060,8 @@ DEFUN ("subr-name", Fsubr_name, Ssubr_name, 1, 1, 0, return build_string (name); } -DEFUN ("subr-native-elisp-p", Fsubr_native_elisp_p, Ssubr_native_elisp_p, 1, 1, - 0, doc: /* Return t if the object is native compiled lisp -function, nil otherwise. */) +DEFUN ("native-comp-function-p", Fnative_comp_function_p, Snative_comp_function_p, 1, 1, + 0, doc: /* Return t if the object is native compiled Lisp function, nil otherwise. */) (Lisp_Object object) { return SUBR_NATIVE_COMPILEDP (object) ? Qt : Qnil; @@ -4151,7 +4150,8 @@ #define PUT_ERROR(sym, tail, msg) \ DEFSYM (Qsubr, "subr"); DEFSYM (Qspecial_form, "special-form"); DEFSYM (Qprimitive_function, "primitive-function"); - DEFSYM (Qsubr_native_elisp, "subr-native-elisp"); + DEFSYM (Qsubr_native_elisp, "subr-native-elisp"); /* Deprecated name. */ + DEFSYM (Qnative_comp_function, "native-comp-function"); DEFSYM (Qbyte_code_function, "byte-code-function"); DEFSYM (Qinterpreted_function, "interpreted-function"); DEFSYM (Qbuffer, "buffer"); @@ -4286,7 +4286,7 @@ #define PUT_ERROR(sym, tail, msg) \ defsubr (&Sbyteorder); defsubr (&Ssubr_arity); defsubr (&Ssubr_name); - defsubr (&Ssubr_native_elisp_p); + defsubr (&Snative_comp_function_p); defsubr (&Ssubr_native_lambda_list); defsubr (&Ssubr_type); #ifdef HAVE_NATIVE_COMP diff --git a/src/doc.c b/src/doc.c index 36633a920c6..9cd8b60f118 100644 --- a/src/doc.c +++ b/src/doc.c @@ -431,7 +431,7 @@ DEFUN ("internal-subr-documentation", Fsubr_documentation, Ssubr_documentation, (Lisp_Object function) { #ifdef HAVE_NATIVE_COMP - if (!NILP (Fsubr_native_elisp_p (function))) + if (!NILP (Fnative_comp_function_p (function))) return native_function_doc (function); else #endif -- 2.43.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 14:47:33 2024 Received: (at 71123) by debbugs.gnu.org; 22 May 2024 18:47:33 +0000 Received: from localhost ([127.0.0.1]:57646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9qzr-0000av-V4 for submit@debbugs.gnu.org; Wed, 22 May 2024 14:47:33 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9qzp-0000af-FQ for 71123@debbugs.gnu.org; Wed, 22 May 2024 14:47:30 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E210B100043; Wed, 22 May 2024 14:47:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716403634; bh=yQ42JfyK5iKeXrS67hCq8TAtJVc3Ywx5eNJqUTMyA9k=; h=From:To:Subject:In-Reply-To:References:Date:From; b=NTTvai07adHamTEYXnpK2HalADHSpgLAdC9EtHoQgKkVPqMsKB97wMtUbNo+XYpG5 WLr+XBgPLKvDfJsE+Fbyh28Yd1HBPolXTfnawPnj0hRiKYybTYQULvZV5e9yKfhK/a qxfvyQX8aiZPG5zrmSqLKc7D2bsaJhkC/hLY+jY6GuUJKHbdsh1nUVxebn3s944oTT +frgwBJu5VUG/UefhJ3B1gnFOVjE7BlW5KUvu66biMiI8w5ZleHSxh7awIkmWM/hXz UtgGJ4IBqit99K+dOfWpWtxNZaCFJPmr3f7n0qUB8tCBurEqpWy4VOAju3fuFtZZfp FZCEpC0xLQC9Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CA00E100035; Wed, 22 May 2024 14:47:14 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B7AD8120495; Wed, 22 May 2024 14:47:14 -0400 (EDT) From: Stefan Monnier To: 71123@debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Stefan Monnier's message of "Wed, 22 May 2024 13:50:17 -0400") Message-ID: References: Date: Wed, 22 May 2024 14:47:13 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.155 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain And of course, I forgot to include `etc/NEWS`. Here's an updated patch, together with the natural subsequent patch to fix the compiler warnings due to old calls to the new obsolete function. Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Rename-subr-native-elisp-to-native-comp-function.patch >From 512c9392cac0e9682e5f3306aa4355a996541d7b Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Wed, 22 May 2024 13:45:39 -0400 Subject: [PATCH 1/2] Rename `subr-native-elisp` to `native-comp-function` Now that this type name is displayed in *Help*, it is more important to use a name that is less weird for the unsuspecting user. * lisp/emacs-lisp/cl-preloaded.el (cl-functionp): Adjust to new name of native function's type. (subr-native-elisp-p): Redefine as an obsolete alias. (native-comp-function): Rename from `subr-native-elisp` * src/data.c (Fcl_type_of): Return `Qnative_comp_function` i.s.o `Qsubr_native_elisp`. (Fnative_comp_function_p): Rename from `Fsubr_native_elisp_p`. (syms_of_data): Adjust accordingly. * src/doc.c (Fsubr_documentation): Use new `Fnative_comp_function_p` name. --- etc/NEWS | 4 ++++ lisp/emacs-lisp/cl-preloaded.el | 5 +++-- src/data.c | 12 ++++++------ src/doc.c | 2 +- 4 files changed, 14 insertions(+), 9 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index d72ef5b5bef..c3e2b70bbc1 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1880,6 +1880,10 @@ documentation and examples. * Incompatible Lisp Changes in Emacs 30.1 +--- +** 'subr-native-elisp-p' is renamed to 'native-comp-function-p'. +The previous name still exists but is marked as obsolete. + +++ ** Evaluating a 'lambda' returns an object of type 'interpreted-function'. Instead of representing interpreted functions as lists that start with diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el index fa745396b02..4b1bd2a9aff 100644 --- a/lisp/emacs-lisp/cl-preloaded.el +++ b/lisp/emacs-lisp/cl-preloaded.el @@ -355,7 +355,7 @@ cl-functionp This is like `functionp' except that it returns nil for all lists and symbols, regardless if `funcall' would accept to call them." (memq (cl-type-of object) - '(primitive-function subr-native-elisp module-function + '(primitive-function native-comp-function module-function interpreted-function byte-code-function))) (cl--define-built-in-type t nil "Abstract supertype of everything.") @@ -465,7 +465,8 @@ interpreted-function "Type of functions that have not been compiled.") (cl--define-built-in-type special-form (subr) "Type of the core syntactic elements of the Emacs Lisp language.") -(cl--define-built-in-type subr-native-elisp (subr compiled-function) +(define-obsolete-function-alias 'subr-native-elisp-p #'native-comp-function-p "30.1") +(cl--define-built-in-type native-comp-function (subr compiled-function) "Type of functions that have been compiled by the native compiler.") (cl--define-built-in-type primitive-function (subr compiled-function) "Type of functions hand written in C.") diff --git a/src/data.c b/src/data.c index 30d8eab7359..2ff5050580d 100644 --- a/src/data.c +++ b/src/data.c @@ -244,7 +244,7 @@ DEFUN ("cl-type-of", Fcl_type_of, Scl_type_of, 1, 1, 0, case PVEC_WINDOW: return Qwindow; case PVEC_SUBR: return XSUBR (object)->max_args == UNEVALLED ? Qspecial_form - : SUBR_NATIVE_COMPILEDP (object) ? Qsubr_native_elisp + : SUBR_NATIVE_COMPILEDP (object) ? Qnative_comp_function : Qprimitive_function; case PVEC_CLOSURE: return CONSP (AREF (object, CLOSURE_CODE)) @@ -1060,9 +1060,8 @@ DEFUN ("subr-name", Fsubr_name, Ssubr_name, 1, 1, 0, return build_string (name); } -DEFUN ("subr-native-elisp-p", Fsubr_native_elisp_p, Ssubr_native_elisp_p, 1, 1, - 0, doc: /* Return t if the object is native compiled lisp -function, nil otherwise. */) +DEFUN ("native-comp-function-p", Fnative_comp_function_p, Snative_comp_function_p, 1, 1, + 0, doc: /* Return t if the object is native compiled Lisp function, nil otherwise. */) (Lisp_Object object) { return SUBR_NATIVE_COMPILEDP (object) ? Qt : Qnil; @@ -4151,7 +4150,8 @@ #define PUT_ERROR(sym, tail, msg) \ DEFSYM (Qsubr, "subr"); DEFSYM (Qspecial_form, "special-form"); DEFSYM (Qprimitive_function, "primitive-function"); - DEFSYM (Qsubr_native_elisp, "subr-native-elisp"); + DEFSYM (Qsubr_native_elisp, "subr-native-elisp"); /* Deprecated name. */ + DEFSYM (Qnative_comp_function, "native-comp-function"); DEFSYM (Qbyte_code_function, "byte-code-function"); DEFSYM (Qinterpreted_function, "interpreted-function"); DEFSYM (Qbuffer, "buffer"); @@ -4286,7 +4286,7 @@ #define PUT_ERROR(sym, tail, msg) \ defsubr (&Sbyteorder); defsubr (&Ssubr_arity); defsubr (&Ssubr_name); - defsubr (&Ssubr_native_elisp_p); + defsubr (&Snative_comp_function_p); defsubr (&Ssubr_native_lambda_list); defsubr (&Ssubr_type); #ifdef HAVE_NATIVE_COMP diff --git a/src/doc.c b/src/doc.c index 36633a920c6..9cd8b60f118 100644 --- a/src/doc.c +++ b/src/doc.c @@ -431,7 +431,7 @@ DEFUN ("internal-subr-documentation", Fsubr_documentation, Ssubr_documentation, (Lisp_Object function) { #ifdef HAVE_NATIVE_COMP - if (!NILP (Fsubr_native_elisp_p (function))) + if (!NILP (Fnative_comp_function_p (function))) return native_function_doc (function); else #endif -- 2.43.0 --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0002-Redirect-calls-to-subr-native-elisp-p-to-native-comp.patch Content-Transfer-Encoding: quoted-printable >From 2965f85459dfbafcd02c47177d6b1ee1a5aeb2d8 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Wed, 22 May 2024 14:45:35 -0400 Subject: [PATCH 2/2] Redirect calls to `subr-native-elisp-p` to `native-comp-function-p` * test/src/comp-tests.el (comp-tests-bootstrap, lambda-return) (lambda-return2, free-fun, free-fun2, free-fun-silly-name, speed--1) (compile-forms, comp-test-defsubst, primitive-redefine-compile-44221) (48029-1, 61917-1, tco, fw-prop-1, pure): * test/lisp/help-fns-tests.el (help-fns-test-lisp-defun): * lisp/subr.el (subr-primitive-p, primitive-function-p, symbol-file): * lisp/help-fns.el (find-lisp-object-file-name): * lisp/emacs-lisp/disass.el (disassemble-internal): * lisp/emacs-lisp/comp.el (comp--call-optim-form-call): * lisp/emacs-lisp/comp-run.el (comp-warn-primitives): * lisp/emacs-lisp/comp-common.el (comp-function-type-spec): * lisp/emacs-lisp/byte-opt.el (side-effect-free-fns): * lisp/emacs-lisp/bytecomp.el (): Rename `subr-native-elisp-p` to `native-comp-function-p`. --- lisp/emacs-lisp/byte-opt.el | 5 +++-- lisp/emacs-lisp/bytecomp.el | 2 +- lisp/emacs-lisp/comp-common.el | 2 +- lisp/emacs-lisp/comp-run.el | 2 +- lisp/emacs-lisp/comp.el | 2 +- lisp/emacs-lisp/disass.el | 4 ++-- lisp/help-fns.el | 2 +- lisp/subr.el | 8 +++---- test/lisp/help-fns-tests.el | 2 +- test/src/comp-tests.el | 40 +++++++++++++++++----------------- 10 files changed, 35 insertions(+), 34 deletions(-) diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el index 4095726d276..c060c8d676b 100644 --- a/lisp/emacs-lisp/byte-opt.el +++ b/lisp/emacs-lisp/byte-opt.el @@ -1876,9 +1876,10 @@ byte-optimize-set byteorder car-safe cdr-safe char-or-string-p char-table-p condition-variable-p consp eq floatp indirect-function integer-or-marker-p integerp keywordp listp markerp - module-function-p multibyte-string-p mutexp natnump nlistp null + module-function-p multibyte-string-p mutexp native-comp-function-p + natnump nlistp null number-or-marker-p numberp recordp remove-pos-from-symbol - sequencep stringp subr-native-elisp-p subrp symbol-with-pos-p sym= bolp + sequencep stringp subrp symbol-with-pos-p symbolp threadp type-of user-ptrp vector-or-char-table-p vectorp wholenump ;; editfns.c bobp bolp buffer-size buffer-string current-message emacs-pid diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 12b45f9f5b8..03cfbe6f4c9 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -6028,7 +6028,7 @@ byte-compile-report-ops (let ((byte-optimize nil) ; do it fast (byte-compile-warnings nil)) (mapc (lambda (x) - (unless (subr-native-elisp-p x) + (unless (native-comp-function-p x) (or noninteractive (message "compiling %s..." x)) (byte-compile x) (or noninteractive (message "compiling %s...done" x)))) diff --git a/lisp/emacs-lisp/comp-common.el b/lisp/emacs-lisp/comp-common.el index 355988838c7..ce6296953bf 100644 --- a/lisp/emacs-lisp/comp-common.el +++ b/lisp/emacs-lisp/comp-common.el @@ -518,7 +518,7 @@ comp-function-type-spec (if-let ((delc-type (function-get function 'function-type))) ;; Declared Lisp function (setf type-spec delc-type) - (when (subr-native-elisp-p f) + (when (native-comp-function-p f) ;; Native compiled inferred (setf kind 'inferred type-spec (subr-type f)))))) diff --git a/lisp/emacs-lisp/comp-run.el b/lisp/emacs-lisp/comp-run.el index 5cc61579030..f159c5b1911 100644 --- a/lisp/emacs-lisp/comp-run.el +++ b/lisp/emacs-lisp/comp-run.el @@ -341,7 +341,7 @@ comp-run-async-workers (clrhash comp-deferred-pending-h))) =20 (defconst comp-warn-primitives - '(null memq gethash and subrp not subr-native-elisp-p + '(null memq gethash and subrp not native-comp-function-p comp--install-trampoline concat if symbolp symbol-name make-string length aset aref length> mapcar expand-file-name file-name-as-directory file-exists-p native-elisp-load) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 4c76f95a0e9..32d4442ca1b 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -2847,7 +2847,7 @@ comp--call-optim-form-call (subrp (subrp f)) (comp-func-callee (comp--func-in-unit callee))) (cond - ((and subrp (not (subr-native-elisp-p f))) + ((and subrp (not (native-comp-function-p f))) ;; Trampoline removal. (let* ((callee (intern (subr-name f))) ; Fix aliased names. (maxarg (cdr (subr-arity f))) diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el index 91427166137..07072f2a2be 100644 --- a/lisp/emacs-lisp/disass.el +++ b/lisp/emacs-lisp/disass.el @@ -91,8 +91,8 @@ disassemble-internal args) (setq obj (autoload-do-load obj name)) (if (subrp obj) - (if (and (fboundp 'subr-native-elisp-p) - (subr-native-elisp-p obj)) + (if (and (fboundp 'native-comp-function-p) + (native-comp-function-p obj)) (progn (require 'comp) (let ((eln (native-comp-unit-file (subr-native-comp-unit obj= )))) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 182b22549b5..af27d101ac8 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -475,7 +475,7 @@ find-lisp-object-file-name (cond ((and (not file-name) (subrp type) - (not (subr-native-elisp-p type))) + (not (native-comp-function-p type))) ;; A built-in function. The form is from `describe-function-1'. (if (or (get-buffer " *DOC*") (and also-c-source diff --git a/lisp/subr.el b/lisp/subr.el index d6481fdf73e..d171ac7adac 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -316,14 +316,14 @@ subr-primitive-p Such objects can be functions or special forms." (declare (side-effect-free error-free)) (and (subrp object) - (not (subr-native-elisp-p object)))) + (not (native-comp-function-p object)))) =20 (defsubst primitive-function-p (object) "Return t if OBJECT is a built-in primitive function. This excludes special forms, since they are not functions." (declare (side-effect-free error-free)) (and (subrp object) - (not (or (subr-native-elisp-p object) + (not (or (native-comp-function-p object) (eq (cdr (subr-arity object)) 'unevalled))))) =20 (defsubst xor (cond1 cond2) @@ -3022,7 +3022,7 @@ define-symbol-prop =20 (defvar comp-native-version-dir) (defvar native-comp-eln-load-path) -(declare-function subr-native-elisp-p "data.c") +(declare-function native-comp-function-p "data.c") (declare-function native-comp-unit-file "data.c") (declare-function subr-native-comp-unit "data.c") (declare-function comp-el-to-eln-rel-filename "comp.c") @@ -3071,7 +3071,7 @@ symbol-file (symbolp symbol) (native-comp-available-p) ;; If it's a defun, we have a shortcut. - (subr-native-elisp-p (symbol-function symbol))) + (native-comp-function-p (symbol-function symbol))) ;; native-comp-unit-file returns unnormalized file names. (expand-file-name (native-comp-unit-file (subr-native-comp-unit (symbol-function symbol)))) diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el index 82350a4bc71..7393a2624fe 100644 --- a/test/lisp/help-fns-tests.el +++ b/test/lisp/help-fns-tests.el @@ -67,7 +67,7 @@ help-fns-test-lisp-defun (result (help-fns-tests--describe-function 'last))) (should (string-match regexp result)) (should (member (match-string 1 result) - '("subr-native-elisp" "byte-code-function"))))) + '("native-comp-function" "byte-code-function"))))) =20 (ert-deftest help-fns-test-lisp-defsubst () (let ((regexp "a byte-code-function in .+subr\\.el") diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el index 5deff03fd84..dffb7097a3e 100644 --- a/test/src/comp-tests.el +++ b/test/src/comp-tests.el @@ -85,13 +85,13 @@ comp-tests-bootstrap (copy-file comp-src comp2-src t) (let ((load-no-native t)) (load (concat comp-src "c") nil nil t t)) - (should-not (subr-native-elisp-p (symbol-function 'native-compile)= )) + (should-not (native-comp-function-p (symbol-function 'native-compi= le))) (message "Compiling stage1...") (let* ((t0 (current-time)) (comp1-eln (native-compile comp1-src))) (message "Done in %d secs" (float-time (time-since t0))) (load comp1-eln nil nil t t) - (should (subr-native-elisp-p (symbol-function 'native-compile))) + (should (native-comp-function-p (symbol-function 'native-compile= ))) (message "Compiling stage2...") (let ((t0 (current-time)) (comp2-eln (native-compile comp2-src))) @@ -325,15 +325,15 @@ buffer =20 (comp-deftest lambda-return () (let ((f (comp-tests-lambda-return-f))) - (should (subr-native-elisp-p f)) + (should (native-comp-function-p f)) (should (=3D (funcall f 3) 4)))) =20 (comp-deftest lambda-return2 () "Check a nested lambda function gets native compiled." (let ((f (comp-tests-lambda-return-f2))) - (should (subr-native-elisp-p f)) + (should (native-comp-function-p f)) (let ((f2 (funcall f))) - (should (subr-native-elisp-p f2)) + (should (native-comp-function-p f2)) (should (=3D (funcall f2 3) 4))))) =20 (comp-deftest recursive () @@ -391,7 +391,7 @@ free-fun t) (native-compile #'comp-tests-free-fun-f) =20 - (should (subr-native-elisp-p (symbol-function 'comp-tests-free-fun-f))) + (should (native-comp-function-p (symbol-function 'comp-tests-free-fun-f)= )) (should (=3D (comp-tests-free-fun-f) 3)) (should (string=3D (documentation #'comp-tests-free-fun-f) "Some doc.")) @@ -412,8 +412,8 @@ free-fun2 =20 (let* ((f (symbol-function 'comp-tests-free-fun-f2)) (f2 (funcall f))) - (should (subr-native-elisp-p f)) - (should (subr-native-elisp-p f2)) + (should (native-comp-function-p f)) + (should (native-comp-function-p f2)) (should (string=3D (documentation f2) "Some doc.")) (should (commandp f2)) (should (equal (interactive-form f2) '(interactive nil))) @@ -425,7 +425,7 @@ free-fun-silly-name "Check we are able to compile a single function." (eval '(defun comp-tests/free\fun-f ()) t) (native-compile #'comp-tests/free\fun-f) - (should (subr-native-elisp-p (symbol-function 'comp-tests/free\fun-f)))) + (should (native-comp-function-p (symbol-function 'comp-tests/free\fun-f)= ))) =20 (comp-deftest bug-40187 () "Check function name shadowing. @@ -436,7 +436,7 @@ bug-40187 (comp-deftest speed--1 () "Check that at speed -1 we do not native compile." (should (=3D (comp-test-speed--1-f) 3)) - (should-not (subr-native-elisp-p (symbol-function 'comp-test-speed--1-f)= ))) + (should-not (native-comp-function-p (symbol-function 'comp-test-speed--1= -f)))) =20 (comp-deftest bug-42360 () "." @@ -497,22 +497,22 @@ compile-forms (should-error (native-compile '(+ 1 foo))) (let ((lexical-binding t) (f (native-compile '(lambda (x) (1+ x))))) - (should (subr-native-elisp-p f)) + (should (native-comp-function-p f)) (should (=3D (funcall f 2) 3))) (let* ((lexical-binding nil) (f (native-compile '(lambda (x) (1+ x))))) - (should (subr-native-elisp-p f)) + (should (native-comp-function-p f)) (should (=3D (funcall f 2) 3)))) =20 (comp-deftest comp-test-defsubst () ;; Bug#42664, Bug#43280, Bug#44209. - (should-not (subr-native-elisp-p (symbol-function 'comp-test-defsubst-f)= ))) + (should-not (native-comp-function-p (symbol-function 'comp-test-defsubst= -f)))) =20 (comp-deftest primitive-redefine-compile-44221 () "Test the compiler still works while primitives are redefined (bug#44221= )." (cl-letf (((symbol-function 'delete-region) (lambda (_ _)))) - (should (subr-native-elisp-p + (should (native-comp-function-p (native-compile '(lambda () (delete-region (point-min) (point-max)))))))) @@ -564,7 +564,7 @@ comp-test-47868-1 =20 (comp-deftest 48029-1 () "" - (should (subr-native-elisp-p + (should (native-comp-function-p (symbol-function 'comp-test-48029-nonascii-=C5=BE=C5=BE=C5=BE-f= )))) =20 (comp-deftest 61917-1 () @@ -578,7 +578,7 @@ 61917-1 (setf x (native-compile '(lambda () (delete-region 1 2)))) - (should (subr-native-elisp-p x)) + (should (native-comp-function-p x)) (funcall x) (advice-remove #'delete-region f) (should (equal comp-test-primitive-redefine-args '(1 2)))))) @@ -874,7 +874,7 @@ tco (comp-tests-tco-f (+ a b) a (- count 1)))) t) (native-compile #'comp-tests-tco-f) - (should (subr-native-elisp-p (symbol-function 'comp-tests-tco-f))) + (should (native-comp-function-p (symbol-function 'comp-tests-tco-f))) (should (=3D (comp-tests-tco-f 1 0 10) 55)))) =20 (defun comp-tests-fw-prop-checker-1 (_) @@ -901,7 +901,7 @@ fw-prop-1 (length c))) ; <=3D has to optimize t) (native-compile #'comp-tests-fw-prop-1-f) - (should (subr-native-elisp-p (symbol-function 'comp-tests-fw-prop-1-f)= )) + (should (native-comp-function-p (symbol-function 'comp-tests-fw-prop-1= -f))) (should (=3D (comp-tests-fw-prop-1-f) 6)))) =20 (defun comp-tests--type-lists-equal (l1 l2) @@ -1556,10 +1556,10 @@ pure (declare-function comp-tests-pure-caller-f nil) (declare-function comp-tests-pure-fibn-entry-f nil) =20 - (should (subr-native-elisp-p (symbol-function 'comp-tests-pure-caller-= f))) + (should (native-comp-function-p (symbol-function 'comp-tests-pure-call= er-f))) (should (=3D (comp-tests-pure-caller-f) 4)) =20 - (should (subr-native-elisp-p (symbol-function 'comp-tests-pure-fibn-en= try-f))) + (should (native-comp-function-p (symbol-function 'comp-tests-pure-fibn= -entry-f))) (should (=3D (comp-tests-pure-fibn-entry-f) 6765)))) =20 (defvar comp-tests-cond-rw-checked-function nil --=20 2.43.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 03:17:48 2024 Received: (at 71123) by debbugs.gnu.org; 24 May 2024 07:17:48 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAPBT-0004og-Ob for submit@debbugs.gnu.org; Fri, 24 May 2024 03:17:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAPBP-0004oY-1Q for 71123@debbugs.gnu.org; Fri, 24 May 2024 03:17:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAPBC-0006Pp-GE; Fri, 24 May 2024 03:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=56KStXk0W02Mc0D07XZ3jiFmuUoqqnjf+P6zADb1X9Q=; b=CounAfVeKgEQ05mRSnRt eZJUCRzlxfQBxU1Sern0zPr4pWReu29Qyc/cXE6YkUFIKgz4DsCoySpmX4OWQrtRIgun10dlJ9I0d m7fUd9j8tMRUPrrZV4LMtDCLGjGjRQHgWeWvLvIpJihGZ6n6KgGop/Ul7pIymDtBlDONdR5G/Q2tq TYrfmRVd6xuCUbcKnDYyrQLhe9qg78o5x2GyFymEvnX+TNQzjoQxJOkzLL3Ka5Gj000s3FLWRxtvR w0cJa7k9zobIv9057fh4T14KyQGFlS8sgM90Vkew/R7YH1NPSACotE8CkakXKB0c3B+9VJ4Oa4O+v hSMI6/nIwA8azw==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sAPBC-0004fj-7l; Fri, 24 May 2024 03:17:30 -0400 From: Andrea Corallo To: 71123@debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Stefan Monnier via's message of "Wed, 22 May 2024 13:50:17 -0400") References: Date: Fri, 24 May 2024 03:17:30 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Tags: patch > > I can't remember where someone requested a nicer name than > `subr-native-elisp`, but here's a patch which aims to do that. > > AFAICT we do not need to preserve the *type* `subr-native-elisp` because > it was never exposed to ELisp before Emacs-30 anyway. So the only > backward compatibility needed is the `subr-native-elisp-p` function. > > I chose `native-comp-function` as the new name based on a few > `grep`s through our C code which suggested that `native-comp-` is the > most "popular" prefix in there from code related to native compilation. > > I don't have a strong preference, so if there's a consensus around > another name, I'll happily change the patch accordingly. Hi Stefan, I don't have a strong opinion about renaming this, at the time I called it subr- something as in my mind it was really a subr from an ABI stand point of view. So yeah my implementor view was probably biased technically. For this reason I'm not opposed to this change but I'd like to hear Eli's opinion. On the patch itself I've three comments: - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? - The patch introduces a number of warnings in: help-fns.el, subr.el, bytecomp.el, comp.el, comp-common.el. - It's also introducing a fail in lisp/help-fns-tests.log Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 03:37:41 2024 Received: (at 71123) by debbugs.gnu.org; 24 May 2024 07:37:41 +0000 Received: from localhost ([127.0.0.1]:35533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAPUj-00050U-1S for submit@debbugs.gnu.org; Fri, 24 May 2024 03:37:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAPUh-00050O-PB for 71123@debbugs.gnu.org; Fri, 24 May 2024 03:37:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAPUV-0002Cl-Ei; Fri, 24 May 2024 03:37:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mt5E9ev7F4MAam0ZQMvu46gxxdifZI2cbvFJkhG8vMc=; b=fgHpdGT/0sGp pCjf1EQ4z1V4v3Hpw2FH0KJcWSxvNcZU8w07xVe4gqB2ZKISJ4Lt4mSGNf86gLLeTl22jyKnpu6m2 8+gFwzqzJkWqgR3CAR9QEL3RHC17LBbS2gZs6bBk4Wmvbb3QIDkgXKnNzQDJT+a8F8NwVitbnGs0o GT/dxZPqgGnCVjDzFM0C+bJcGM/pLLVFo0e4VldmH7+Zt1NIRO0AafWi8aJ0CNtODnMtxGXhEXWLM tBmJB4P476HeXDchfcU1Z2jXwexkFSDJd1WMhnzov9tMMHPVRY7lHc7ELijHd7gDkoeFaBJSw3/Ou LX0STIspRtNPhT6lj4IewQ==; Date: Fri, 24 May 2024 10:37:24 +0300 Message-Id: <86r0dr3bkb.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Fri, 24 May 2024 03:17:30 -0400) Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Stefan Monnier > From: Andrea Corallo > Date: Fri, 24 May 2024 03:17:30 -0400 > > Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > Tags: patch > > > > I can't remember where someone requested a nicer name than > > `subr-native-elisp`, but here's a patch which aims to do that. > > > > AFAICT we do not need to preserve the *type* `subr-native-elisp` because > > it was never exposed to ELisp before Emacs-30 anyway. So the only > > backward compatibility needed is the `subr-native-elisp-p` function. > > > > I chose `native-comp-function` as the new name based on a few > > `grep`s through our C code which suggested that `native-comp-` is the > > most "popular" prefix in there from code related to native compilation. > > > > I don't have a strong preference, so if there's a consensus around > > another name, I'll happily change the patch accordingly. > > Hi Stefan, > > I don't have a strong opinion about renaming this, at the time I called > it subr- something as in my mind it was really a subr from an ABI stand > point of view. So yeah my implementor view was probably biased > technically. > > For this reason I'm not opposed to this change but I'd like to hear > Eli's opinion. I don't like renaming in general (it increases the mess we have, and makes it harder to remember things). But in this case I don't object, since this particular term is used only very rarely (provided that all the adverse consequences you mention are fixed, of course). From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 09:07:41 2024 Received: (at 71123) by debbugs.gnu.org; 24 May 2024 13:07:41 +0000 Received: from localhost ([127.0.0.1]:37097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAUe4-0007pz-P6 for submit@debbugs.gnu.org; Fri, 24 May 2024 09:07:40 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAUe3-0007pt-G8 for 71123@debbugs.gnu.org; Fri, 24 May 2024 09:07:39 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8EF8C4423F2; Fri, 24 May 2024 09:07:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716556045; bh=C8hCqFI9Tgl/wM65dt0LZpq7Kd9JVIEppmQ+2LJcIoA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QWFYDIhT9kCHQKAj0txHZav2PXY88aupsIuqWkjZRO5X0NXoalmx9n7JOjMzPOW6r +zDfwmrDuq/9oxcqDi+5ZrRQF2eQoaGSiJTF+DlZ4UnwXIwxEOreFjSErGTcKE4D10 5rKN4oTpMka7oD2FM+/IOi7ZVt1JKHTJq73vOJ0luNX6CEgbDSCX5TcL7a7YjAWlKZ Mvs77maWsKwXtKg661L0wHs2/57fjv7BCTK0WnM7RP9if9YQagVe/rFQaMlLEZRMDd jGd8vy5WPR3X2C9tEce82kMW+SnrW1bQIr1zrk4uC/cyjyBu1Bz9eLSaJkl14+nYXw EAlbz5ytGnxqw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 44FCC4423DD; Fri, 24 May 2024 09:07:25 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 35C291204F5; Fri, 24 May 2024 09:07:25 -0400 (EDT) From: Stefan Monnier To: Andrea Corallo Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Andrea Corallo's message of "Fri, 24 May 2024 03:17:30 -0400") Message-ID: References: Date: Fri, 24 May 2024 09:07:23 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > On the patch itself I've three comments: > > - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and > SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? No opinion on this. Eli? > - The patch introduces a number of warnings in: help-fns.el, subr.el, > bytecomp.el, comp.el, comp-common.el. > - It's also introducing a fail in lisp/help-fns-tests.log AFAIK these were fixed by the second patch. Do you still see them after installing the two patches? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 10:47:12 2024 Received: (at 71123) by debbugs.gnu.org; 24 May 2024 14:47:12 +0000 Received: from localhost ([127.0.0.1]:37523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAWCO-0000UM-E9 for submit@debbugs.gnu.org; Fri, 24 May 2024 10:47:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAWCM-0000UC-GX for 71123@debbugs.gnu.org; Fri, 24 May 2024 10:47:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAWCA-0006oM-7D; Fri, 24 May 2024 10:46:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SYbVEpG/Y+Rd4yfNkgDTjnyp8cu3TMEynUfD43XZijw=; b=FtH7WdlVodce u8YppQlqCDzgDaXMg+ObE/S9C9HyRgeX4i6nADfPEhkDAlevCjX17YWHvri1+zJZqlY6ZDi7MXnEv vrOzJFjgpQalj25S2Ua/dRF9sdlgZPxujCHMIwvVedKomSMoO0Uak1//qq9kSD5kl6xPsfzP+HiSQ vdGoNwZmbCtRikhDGTJhKdasuANFAihLjb4/GFaWd4hfJtxm5kRDdNnQO2icMsx9ys72C4YF4jCgn PfQNcZtWEt7gfvVpBGHIftovV5RbhV7wK/9sfFYmqg+2EusKMMZ3eyz4Qk6ixeuyf6mVtHJHShDDJ optZEHNKGEpnPTcSGMtbDw==; Date: Fri, 24 May 2024 17:46:53 +0300 Message-Id: <8634q72roi.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org, acorallo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 71123@debbugs.gnu.org > Date: Fri, 24 May 2024 09:07:23 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > On the patch itself I've three comments: > > > > - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and > > SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? > > No opinion on this. Eli? I think it will help if the names are similar, yes. From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 03:16:59 2024 Received: (at 71123) by debbugs.gnu.org; 25 May 2024 07:16:59 +0000 Received: from localhost ([127.0.0.1]:41665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAleF-0006Vx-Fv for submit@debbugs.gnu.org; Sat, 25 May 2024 03:16:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAle9-0006Vr-TM for 71123@debbugs.gnu.org; Sat, 25 May 2024 03:16:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAldw-0000Yo-1q; Sat, 25 May 2024 03:16:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=SiJRHt5vdJax4MXrfLIoO0aJvbcTvPpwgiIAYNpdLSw=; b=TT4pB/ASnk/e/oE4q507 j8CseVTBc8l1W8+u3C6ZVhurGF6GuV5cw4O7Is4jwaiBCUnJT0rVDM9XLYSv1JBO2u1hYqKWMhjpQ h3LDVVnE2PKQD24QNytmbDc31tph6GwELUD/D9JslxQupRB2o0xGHxzE1gYye7quzP8ao+5+2ZKJT Ut0AdvHHy4/1vuqS5zd0t3zZiAxoyQa8es14hcQ6l+dEzZ9kKSuDDi8Q7M/KAiRHsl+J21kVeitcq oBJSflhzoCxrNitJm7sYtCJUCPj20i40Hg3Z2V3V3HJdMQN25N3SinAMr4Ag5RiamPwky6S/nLS+W a90hJu3uicv5gg==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sAldv-0007xa-R4; Sat, 25 May 2024 03:16:39 -0400 From: Andrea Corallo To: Stefan Monnier Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Stefan Monnier's message of "Fri, 24 May 2024 09:07:23 -0400") References: Date: Sat, 25 May 2024 03:16:38 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> On the patch itself I've three comments: >> >> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and >> SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? > > No opinion on this. Eli? Sorry I realize I formulated the phrase a bit unclear, my opinion FWIW is that we should rename those. >> - The patch introduces a number of warnings in: help-fns.el, subr.el, >> bytecomp.el, comp.el, comp-common.el. >> - It's also introducing a fail in lisp/help-fns-tests.log > > AFAIK these were fixed by the second patch. > Do you still see them after installing the two patches? I've installed the second version of your patch, isn't this a replacement for the first? Andrea From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 15:36:22 2024 Received: (at 71123) by debbugs.gnu.org; 28 May 2024 19:36:22 +0000 Received: from localhost ([127.0.0.1]:54070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC2cQ-0001d9-3z for submit@debbugs.gnu.org; Tue, 28 May 2024 15:36:22 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC2cO-0001cs-Kf for 71123@debbugs.gnu.org; Tue, 28 May 2024 15:36:20 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 83400100048; Tue, 28 May 2024 15:36:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716924960; bh=IwycAp5+WY8ckym5U7LHrM1h39YF9zsUjRuwCTJrq9Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OSfaK1XVW6d+nuHSQcaDrfRE/zbUCAEQVSNqiZl5Y0pCOnCF6nfYrJLoySNxgQwcI 311EKv1wdA2W2CFwC0zq67e0faEbxJ5Y9q/20NSMAFl2YZqk/Y5F8Orsp53BuzawT/ S91jmFlrwDh1CHWBosUj20y+g7Zxmxm8yz/PBygJGtT/wRus5KiPPpwwN3S2Ti5Sdi I1JiUr7Ov69q0BD20Rl1JZpwIDteedmJZNDo2nMokuRKj/SQRbR4qKyxleX2rpCqYQ Eck8Ez5ogaOQDG6QpNAcEhq0yfzeBJ0KiQEI8/7VvuXBilnwvinDMQXnWGURwSsvcp SdIB00LFR0gqA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 04E64100035; Tue, 28 May 2024 15:36:00 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EE15D120517; Tue, 28 May 2024 15:35:59 -0400 (EDT) From: Stefan Monnier To: Andrea Corallo Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Andrea Corallo's message of "Sat, 25 May 2024 03:16:38 -0400") Message-ID: References: Date: Tue, 28 May 2024 15:35:53 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.171 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've installed the second version of your patch, isn't this a > replacement for the first? The second email had 2 patches: a newer version of the original patch plus a second patch (which is the one that should presumably fix the warnings and test failures). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 15:59:07 2024 Received: (at 71123) by debbugs.gnu.org; 28 May 2024 19:59:07 +0000 Received: from localhost ([127.0.0.1]:54919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC2yQ-0002P3-KY for submit@debbugs.gnu.org; Tue, 28 May 2024 15:59:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC2yO-0002OO-Il for 71123@debbugs.gnu.org; Tue, 28 May 2024 15:59:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sC2y9-0007Vs-6e; Tue, 28 May 2024 15:58:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=b8h9x+Im2KKSKiTj5jcsBlbPUiW+NJw1rfXzrD9WqCc=; b=OV5qa+9dqaPY8gR7Ehse y5T2mYhtYmddOusdUcpLG3lv+ZuX5CXTsTk5l/xka8Br21zIuaiPeXamqljPodCp9n7UzOB4FlNq5 ft/PyO+htReW8rCIsitJJkXAm+uJCe/xk5trBxpM6mgSXWNyT3ez5u2em0j77ynFqp3Q+W4xs/n9e ZreahJIeWjxolitb5mpD08gDyOYQ/Rk367kiLkBHyDF51js2PNiy4jdgc6qaAYUqPnhDyfDgo0H1b uQi3lgCYIPXKk1Sf+abDS9JJYqJTs6qdbgexYMBylYwxvotftspl0ncjXglumSx9DSBcTW3fY85ed Mm4ukxqeWJoffg==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1sC2y8-0007Ow-Vt; Tue, 28 May 2024 15:58:49 -0400 From: Andrea Corallo To: Stefan Monnier Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Stefan Monnier's message of "Tue, 28 May 2024 15:35:53 -0400") References: Date: Tue, 28 May 2024 15:58:48 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123 Cc: 71123@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> I've installed the second version of your patch, isn't this a >> replacement for the first? > > The second email had 2 patches: a newer version of the original patch > plus a second patch (which is the one that should presumably fix the > warnings and test failures). Ouch I missed that sorry! Yes I confirm I see no warnings nor failures. Okay by me with 'SUBR_NATIVE_COMPILEDP' and 'SUBR_NATIVE_COMPILED_DYNP' renamed. Thanks Andrea From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 20:54:16 2024 Received: (at 71123-done) by debbugs.gnu.org; 29 May 2024 00:54:16 +0000 Received: from localhost ([127.0.0.1]:37401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC7a3-0004rP-9H for submit@debbugs.gnu.org; Tue, 28 May 2024 20:54:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:29588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC7a2-0004r9-7k for 71123-done@debbugs.gnu.org; Tue, 28 May 2024 20:54:14 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 07E0780169; Tue, 28 May 2024 20:53:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716944037; bh=YVfZb/k0rgrSZx8Qlp7rOOyaCuz3f8kfHerOVkqKiA0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NFDzVOBLwpKUPOq4I5NKa/60k5YlGTamUf96XHNnpelrxh1gyoML+qEDgzRRp1RLN MfXWJC6oBwf3vCnykqGcoSmSdyDTw1jXpNnGH+I2Voa8U9jTqt0e2H2J9XNnDU31Vb Hu88dgQjChupUr9HMedVzwcKsN0z2V9kdrKnTOitnclaize3pY16f+Fvaun/9QA6Vj /KGh1emkmhsSVXVACnc6JCI0zlBndKlpIZdqoFB0SV4mq+2f6tXBwMDIjkudqJrkaF PGln4p3OiHP2O8lVP7jS/Dx5M+bpSK3MhQMIZtn9TGxTdqV9RQWJgpdxnJXbFpsw44 YV37XKMo2w9Dg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7B81A802DD; Tue, 28 May 2024 20:53:57 -0400 (EDT) Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 48C4E1201E0; Tue, 28 May 2024 20:53:57 -0400 (EDT) From: Stefan Monnier To: Andrea Corallo Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` In-Reply-To: (Andrea Corallo's message of "Tue, 28 May 2024 15:58:48 -0400") Message-ID: References: Date: Tue, 28 May 2024 20:53:56 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.130 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71123-done Cc: 71123-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pushed to `master`, closing, thanks, Stefan From unknown Fri Jun 20 05:26:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Jun 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator