GNU bug report logs - #71115
[PATCH] Fix usage of cons cells in grep-find-ignored-files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Spencer Baugh <sbaugh <at> janestreet.com>
Subject: bug#71115: closed (Re: bug#71115: [PATCH] Fix usage of cons cells
 in grep-find-ignored-files)
Date: Fri, 24 May 2024 20:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71115: [PATCH] Fix usage of cons cells in grep-find-ignored-files

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71115 <at> debbugs.gnu.org.

-- 
71115: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71115
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 71115-done <at> debbugs.gnu.org
Subject: Re: bug#71115: [PATCH] Fix usage of cons cells in
 grep-find-ignored-files
Date: Fri, 24 May 2024 23:05:50 +0300

On 23/05/2024 18:04, Spencer Baugh wrote:
>> There is just one problem that project.el is supposed to be usable in
>> Emacs 26+.
>>
>> I suppose that a little fboundp check will get us around the problem.
> Fixed:

Thanks, pushed to master as commit c812c935486.

(Sans the little (debug) Easter egg ;-)

[Message part 3 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: dmitry <at> gutov.dev
Subject: [PATCH] Fix usage of cons cells in grep-find-ignored-files
Date: Wed, 22 May 2024 08:28:53 -0400

[Message part 4 (text/plain, inline)]

Tags: patch


grep-find-ignored-files is documented to also include cons
cells, not just globs, but there were two places outside grep.el
where we were using it as if it was only a string list.

To fix this, add a helper function named grep-find-ignored-files
which handles grep-find-ignored-files properly and returns the
list of globs, and use it everywhere.

* lisp/dired-aux.el (dired-do-find-regexp): Use
grep-find-ignored-files function.
* lisp/progmodes/grep.el (grep--filter-list-by-dir)
(grep-find-ignored-files): Add.
(rgrep-find-ignored-directories): Use grep--filter-list-by-dir.
(lgrep, rgrep-default-command): Use grep-find-ignored-files
function.
* lisp/progmodes/project.el (project-ignores): Use
grep-find-ignored-files function.

In GNU Emacs 29.2.50 (build 11, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-05-15 built on
 igm-qws-u22796a
Repository revision: 734740051bd377d24899d08d00ec8e1bb8e00e00
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.9 (Green Obsidian)

Configured using:
 'configure -C --with-x-toolkit=lucid --with-gif=ifavailable'

[0001-Fix-usage-of-cons-cells-in-grep-find-ignored-files.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.