From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 05:40:16 2024 Received: (at submit) by debbugs.gnu.org; 22 May 2024 09:40:16 +0000 Received: from localhost ([127.0.0.1]:54660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9iSG-0000M8-Gb for submit@debbugs.gnu.org; Wed, 22 May 2024 05:40:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:34872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9iSD-0000M2-5o for submit@debbugs.gnu.org; Wed, 22 May 2024 05:40:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9iQ0-0006dD-O5 for guix-patches@gnu.org; Wed, 22 May 2024 05:37:56 -0400 Received: from layka.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9iPy-0007IF-K1 for guix-patches@gnu.org; Wed, 22 May 2024 05:37:56 -0400 X-Virus-Scanned: SPAM Filter at disroot.org From: Sughosha DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1716370670; bh=DWDaA1PQfAVzkHq/qB4nBH9HYn2aM4W9/YRc3RZnHig=; h=From:To:Cc:Subject:Date; b=VKl3J8JPWdESZD6LSTZVbJTtMLASI8UjgJogxNNav27vwQJwVal0MKvjkCdELmXym lSAEsgf3q2qELlXJmYeLwQKYr5hmb5LA9PKX0ZN48uga5cjwDvA2zQ3oV6cPUNjbyl L7C6dxvI5gQi2JBZ4M19of4nbmqb9adMMVcTaWMmV0BjpdssiPS3pRB+O9i71aiKmL Ihra74ZR2f3A4JARVL2o7uX5bxhsdoSXTqn+1K3D4dS8WCORZxzP62MpKV2tgz6ktT XQmzrQALD2este7vQ2XUzj73anxrUZzzdRQCcvihCoRxiXnVQExdtu3dqxg0OvRpPs X19u9cuTWWdaw== To: guix-patches@gnu.org Subject: [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Date: Wed, 22 May 2024 15:06:19 +0530 Message-ID: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=sughosha@disroot.org; helo=layka.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This fixes not finding vulkan-loader. * gnu/packages/vulkan.scm (vulkan-tools)[arguments]<#:phases>: Wrap-binaries with LD_LIBRARY_PATH. Change-Id: I9aaf1cf04f70f1da976fa84d2189ca2c01b9520f --- gnu/packages/vulkan.scm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm index 4c53a19aba..dcf97e98dd 100644 --- a/gnu/packages/vulkan.scm +++ b/gnu/packages/vulkan.scm @@ -368,7 +368,16 @@ (define-public vulkan-tools (replace 'check (lambda* (#:key tests? #:allow-other-keys) (when tests? - (invoke "./tests/vulkan_tools_tests"))))))) + (invoke "./tests/vulkan_tools_tests")))) + (add-after 'install 'wrap-binaries + (lambda* (#:key outputs #:allow-other-keys) + (for-each + (lambda (file) + (wrap-program file + `("LD_LIBRARY_PATH" ":" = + (,(getenv "LIBRARY_PATH"))))) + (find-files (string-append (assoc-ref outputs "out") + "/bin")))))))) (home-page "https://github.com/KhronosGroup/Vulkan-Tools") (synopsis "Tools and utilities for Vulkan") base-commit: e9b25a6c6c626a560d28a1f732e6e5d362d584a4 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 26 14:51:22 2024 Received: (at 71109) by debbugs.gnu.org; 26 May 2024 18:51:22 +0000 Received: from localhost ([127.0.0.1]:42576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBIxm-00036t-24 for submit@debbugs.gnu.org; Sun, 26 May 2024 14:51:22 -0400 Received: from mail-40133.protonmail.ch ([185.70.40.133]:64203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBIxj-00036b-Pb for 71109@debbugs.gnu.org; Sun, 26 May 2024 14:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1716749465; x=1717008665; bh=aXgRV4kj4ae0VJtlStaTvxGWkG0mkeAFdFkT8+EU4so=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=taIgILVrv7qaiHcfngL5Pdv+RFcrlYh5cv64iKaLP7HXwfkla8uHtG6NKYbjSvgCV bZYh0O4FJ9bdnevbkyomW048fjyvGAVcA2II2VG5o6r2xrBwAn5oC+DJUwe3yF0bzh S9JiXekxYVHMrKF/yfN3oJMqvV62p5ITGGUc6Zej+ohGkI949tDI1TvcNfZM0ccvqs nRJwPQUfsAandDBGXBppeYhK78aBWML2mS6vi9SXVLSC6j9gJ6TlAlJc3IUXtadqC9 MBR+c1OFCiY0DOTe8ZSm8y9tN/atVfMqzbHLy1eHZgaNQ+OqyHai1p1Q8H9iqR37IY f56iv8ASWD/Ow== Date: Sun, 26 May 2024 18:51:01 +0000 To: "71109@debbugs.gnu.org" <71109@debbugs.gnu.org> From: Kaelyn Subject: Re: [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Message-ID: <0sbkYdBDyA3AoA6l8fAUcxreG-bXFqu9fbRWAgwmboKLPENMF9TZlwA1ksjsl0tJ-odegouxVvGTZ2rgMh6o0U77FuvvOqB0TZA_F-u1K48=@protonmail.com> Feedback-ID: 34709329:user:proton X-Pm-Message-ID: 2e898ddd474c6d6da0c80e69a32ef00c25500775 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71109 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, This patch looks good to me, and I've confirmed it fixes the issue with vul= kaninfo not running. I am curious though as to what caused vulkaninfo to need LD_LIBRARY_PATH, a= s before the the vulkan updates a couple of months ago (at least as of giti= sh 4d79a9c from early April), vulkaninfo worked fine without needing LD_LIB= RARY_PATH set. The new need does have me a bit concerned that other vulkan = apps which used to work may need a similar workaround to keep functioning a= s expected. Cheers, Kaelyn From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 06:39:15 2024 Received: (at 71109) by debbugs.gnu.org; 31 May 2024 10:39:15 +0000 Received: from localhost ([127.0.0.1]:53303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCzfH-0008AM-CU for submit@debbugs.gnu.org; Fri, 31 May 2024 06:39:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCzfE-0008A5-Hp for 71109@debbugs.gnu.org; Fri, 31 May 2024 06:39:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCzex-0003q9-Kj; Fri, 31 May 2024 06:38:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8KZ1a5LLthhoM3KAMa9VmRaydyiITEnEluRQibsB3Hw=; b=pMHMIzeV8AgJFRfSkmRo Kil3qKLoHhznvSkxClDOXwX533+97z/vRbpLdolCZEGvuHIzs/XkhTu/6+6y+iL6kCi68w5wQyQdG PlR5BsHQiVrxyYwTUT1HhQfcLr+/SDHvA+sM3yz8WQXaf3tCbWnV4kSpLYyWu1xech0cEJhkLk3wX fJ8hhJEh+C/ixWZWhHMPYvPNqh/Q1QhH6dKPV4Mh4F2+ge8fZ54wOoQKhcEKeGGd/8EaD048jNC1g zMjbxFEC/8ySg+bud+n5sx5LRaRwQLUx0jAif5e2XIZgDY+umMdGlyGS1Y2aJ6b+2Ed6ZG1i2GVKx D1FfX6NDkKriNw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sughosha Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. In-Reply-To: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> (sughosha@disroot.org's message of "Wed, 22 May 2024 15:06:19 +0530") References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> Date: Fri, 31 May 2024 12:38:53 +0200 Message-ID: <87y17qtgea.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71109 Cc: 71109@debbugs.gnu.org, Kaelyn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Sughosha skribis: > This fixes not finding vulkan-loader. Could you show how to test it? > + (wrap-program file > + `("LD_LIBRARY_PATH" ":" =3D > + (,(getenv "LIBRARY_PATH"))))) This is probably a bit too broad because LIBRARY_PATH includes build-time-only dependencies (python, gawk, binutils, bzip2, etc.). Could we explicitly list what needs to be there instead? Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so user= s can still override LD_LIBRARY_PATH. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 12:48:07 2024 Received: (at 71109) by debbugs.gnu.org; 31 May 2024 16:48:07 +0000 Received: from localhost ([127.0.0.1]:55266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD5QE-0001Lq-M1 for submit@debbugs.gnu.org; Fri, 31 May 2024 12:48:06 -0400 Received: from mail-40134.protonmail.ch ([185.70.40.134]:29075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD5QB-0001L9-UP for 71109@debbugs.gnu.org; Fri, 31 May 2024 12:48:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1717174066; x=1717433266; bh=oWyJ9rnqBpa0R6aIAMfxYW0FTom92DXi52OZtTYzeGM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=N277y1HNjO6FPJpwOKA+G9kEenbll5GxY6OShZHCMHRn5B3J8x1PPH8EL5CsBb2ck 3fq83NNceqgLc+v7vl/bphaRNd6WJQvYVRGLKGryiV3Eg9N+fmyadHHpIea2pS+o9u rQQfZViyyZY7TubzZeTsxLfOq8V1WTuEbqtfMQzo1+GlY8Eb02gI2x9Sg+/BRpMZOZ V6+Edj68Y2FLCEVyQtsWdkrCMSSva3y3tctLkmc9F/z0Qfji6znS9w1jL8gptQ3Gzk h6bnEHbfUL7lWhuXfx80mpfhWmd/4LfUmGfcFQo3/lekVNv0NQrdHHBCiGfk0NgCKh nZmOa/QsQECuw== Date: Fri, 31 May 2024 16:47:41 +0000 To: =?utf-8?Q?Ludovic_Court=C3=A8s?= From: Kaelyn Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Message-ID: In-Reply-To: <87y17qtgea.fsf@gnu.org> References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <87y17qtgea.fsf@gnu.org> Feedback-ID: 34709329:user:proton X-Pm-Message-ID: cfce034aad0adae3c0cdd33467ec4f2fdf32a4d3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71109 Cc: 71109@debbugs.gnu.org, Sughosha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Friday, May 31st, 2024 at 3:38 AM, Ludovic Court=C3=A8s w= rote: >=20 >=20 > Hi, >=20 > Sughosha sughosha@disroot.org skribis: >=20 > > This fixes not finding vulkan-loader. >=20 >=20 > Could you show how to test it? At least for me, the problem shows up simply with vulkan-tools installed (o= r using "guix shell vulkan-tools") using a guix commit after the latest (1.= 3.280) vulkan updates. Simply running "vulkaninfo" results in the error: ERROR at /tmp/guix-build-vulkan-tools-1.3.280.0.drv-0/source/vulkaninfo/./v= ulkaninfo.h:412: Failed to initialize: Vulkan loader is not installed, not = found, or failed to load. >=20 > > + (wrap-program file > > + `("LD_LIBRARY_PATH" ":" =3D > > + (,(getenv "LIBRARY_PATH"))))) >=20 >=20 > This is probably a bit too broad because LIBRARY_PATH includes > build-time-only dependencies (python, gawk, binutils, bzip2, etc.). >=20 > Could we explicitly list what needs to be there instead? A bit of local testing just now suggests setting LD_LIBRARY_PATH to the vul= kan-loader package's lib dir should be enough to resolve the error. Cheers, Kaelyn > Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so us= ers can still override > LD_LIBRARY_PATH. >=20 > Thanks, > Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri May 31 13:55:14 2024 Received: (at 71109) by debbugs.gnu.org; 31 May 2024 17:55:14 +0000 Received: from localhost ([127.0.0.1]:55304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD6TC-0003Cm-7H for submit@debbugs.gnu.org; Fri, 31 May 2024 13:55:14 -0400 Received: from layka.disroot.org ([178.21.23.139]:35886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD6T7-0003CZ-JD for 71109@debbugs.gnu.org; Fri, 31 May 2024 13:55:12 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 6F9884185A; Fri, 31 May 2024 19:54:56 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tqUQ-LzBC-fW; Fri, 31 May 2024 19:54:55 +0200 (CEST) From: Sughosha DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1717178095; bh=Ju79pTOzNYBZJ0+mu88idBXntZ5V6I4WvQQOzMeCR0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eFRGfN71MMSdUsV58T823hcZmGVew4G2jUXL4lLq3FRfj3rnkgTMOaHZAuvbY7eqc 9mqOzGI8YjOkS9+xanQvOLNQlMzVB+jhn2HLVQ4OMCR4qwneDwfWxQsEqEJ/EKMX1J ZPgLcAo/nfCaBKCJA7V/Yam36+W5+Xmi6NgL/GvLdNLD6WvECitmkbp/Un7Qklb8jb FMXL5U93BuX2E5fmDp38dAbE3oTSIjm8gS41zjI7rwLxgW1Rnb1LCbA6B8mspLB51g i5P6414OQzz1eapa7ljdpbQVAYwKy+PPxixlfkJbtd2wbJzPDn4JLx+uC0KeLf/zap 3Zq/A0ORa1Nbw== To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Date: Fri, 31 May 2024 20:51:44 +0530 Message-ID: <3564606.iIbC2pHGDl@localhost.localdomain> In-Reply-To: <87y17qtgea.fsf@gnu.org> References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <87y17qtgea.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71109 Cc: 71109@debbugs.gnu.org, Kaelyn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Friday, May 31, 2024 4:08:53 PM IST Ludovic Court=C3=A8s wrote: > Hi, >=20 > Sughosha skribis: > > This fixes not finding vulkan-loader. >=20 > Could you show how to test it? >=20 > > + (wrap-program file > > + `("LD_LIBRARY_PATH" ":" =3D > > + (,(getenv "LIBRARY_PATH"))))) >=20 > This is probably a bit too broad because LIBRARY_PATH includes > build-time-only dependencies (python, gawk, binutils, bzip2, etc.). >=20 > Could we explicitly list what needs to be there instead? >=20 > Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so us= ers can still override > LD_LIBRARY_PATH. >=20 > Thanks, > Ludo=E2=80=99. Hi, Thanks for your review! > Could you show how to test it? Currently if I just run `vulkaninfo`, this error appears: ``` ERROR at /tmp/guix-build-vulkan-tools-1.3.280.0.drv-0/source/vulkaninfo/./ vulkaninfo.h:412: Failed to initialize: Vulkan loader is not installed, not= =20 found, or failed to load. ``` I don't know if something should be patched before building itself. But if I run: `LD_LIBRARY_PATH=3D$(guix build vulkan-loader)/lib vulkaninfo= `,=20 the program will be executed without any error. > This is probably a bit too broad because LIBRARY_PATH includes > build-time-only dependencies (python, gawk, binutils, bzip2, etc.). If I wrap only with vulkan-loader's library path also, it works. But would = it=20 be a "right" way of wrapping a program. > Also maybe change =E2=80=98=3D=E2=80=99 to =E2=80=98suffix=E2=80=99 so us= ers can still override Yes, you are right. I will change it. =2D-=20 Sughosha From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 01 21:19:30 2024 Received: (at 71109) by debbugs.gnu.org; 2 Jun 2024 01:19:31 +0000 Received: from localhost ([127.0.0.1]:57577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZsg-0006c0-GN for submit@debbugs.gnu.org; Sat, 01 Jun 2024 21:19:30 -0400 Received: from mail.nborghese.com ([207.148.28.48]:53472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDZse-0006bq-3E for 71109@debbugs.gnu.org; Sat, 01 Jun 2024 21:19:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=062122; bh=dXOpxWblXd7l6 H498gCJG3n9clCgnzJ7GXxc4uCiCHw=; h=to:from:subject:date; d=nborghese.com; b=ZCVGZGNGQUx0WY0bkExW2zBJ6twViybATAug3tudg1RKBHZiA0h OYWl/Olntnjj0ksWpOMaa/iz4S31ZJQ8qQYSMkU0vgDk2q5K/mO/HHDtuwrDBnLuJIj6JC EKbQmRBxRK20rbYNVFklMBLZQRCZR6ursD6pq9867OHnLvwwJo= Received: by nborghese.com (OpenSMTPD) with ESMTPSA id 99d3bbf3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 2 Jun 2024 01:19:03 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------p9iOlUQyVPl1slIxVgqu6LPc" Message-ID: <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> Date: Sun, 2 Jun 2024 01:19:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Content-Language: en-US From: nathan To: sughosha@disroot.org, 71109@debbugs.gnu.org X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71109 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------p9iOlUQyVPl1slIxVgqu6LPc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit commit e156996c478a8e5d040ccf199437bcdbdbab63ed in vulkan-tools makes it use volk to load vulkan instead of a bunch of custom code in the repo. volk uses dlopen("libvulkan.so.1"). i dont remember volk ever working, so this just propagated the bug to another program. attached is a patch to hard-code the libvulkan.so path into volk. vulkan-headers also has dlopen for libvulkan.so. i dont know which programs use it, but next time we have to rebuild everything we may as well patch it. i attached a patch that shows how to do it. --------------p9iOlUQyVPl1slIxVgqu6LPc Content-Type: text/x-patch; charset=UTF-8; name="0001-example-of-how-to-patch-patch-of-vulkan-loader-into-.patch" Content-Disposition: attachment; filename*0="0001-example-of-how-to-patch-patch-of-vulkan-loader-into-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4MTFkNzU2NzA5OGUwMDcxMWVlNGM5YzgwYWZiZTU0NGViZTFjMDhlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8ODExZDc1NjcwOThlMDA3MTFlZTRjOWM4 MGFmYmU1NDRlYmUxYzA4ZS4xNzE3MjkwOTM0LmdpdC5uYXRoYW5fbWFpbEBuYm9yZ2hlc2Uu Y29tPgpGcm9tOiBuYXRoYW4gPG5hdGhhbl9tYWlsQG5ib3JnaGVzZS5jb20+CkRhdGU6IFNh dCwgMSBKdW4gMjAyNCAyMToxNDoxMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGV4YW1wbGUg b2YgaG93IHRvIHBhdGNoIHBhdGNoIG9mIHZ1bGthbi1sb2FkZXIgaW50bwogdnVsa2FuLWhl YWRlcnMKCkNoYW5nZS1JZDogSWM2NzRhNGQ5NjVkODA0OWUzODhkNzUxMzcxMTFlZDAyNTNj YTNiMTgKLS0tCiBnbnUvcGFja2FnZXMvdnVsa2FuLnNjbSB8IDI0ICsrKysrKysrKysrKysr KysrKysrKystLQogMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3Z1bGthbi5zY20gYi9nbnUvcGFj a2FnZXMvdnVsa2FuLnNjbQppbmRleCA0YzUzYTE5YWJhLi4yZmMyZmVlZWJhIDEwMDY0NAot LS0gYS9nbnUvcGFja2FnZXMvdnVsa2FuLnNjbQorKysgYi9nbnUvcGFja2FnZXMvdnVsa2Fu LnNjbQpAQCAtMjM4LDcgKzIzOCw4IEBAIChkZWZpbmUtcHVibGljIGdsc2xhbmcKICAgICAg ICAgICAgICAgICAgICA7OyBpbmNsdWRlL1NQSVJWL3tiaXR1dGlscyxoZXhfZmxvYXR9Lmgg YXJlIEFwYWNoZSAyLjAuCiAgICAgICAgICAgICAgICAgICAgbGljZW5zZTphc2wyLjApKSkp CiAKLShkZWZpbmUtcHVibGljIHZ1bGthbi1oZWFkZXJzCis7OyB2dWxrYW4taGVhZGVycywg YnV0IHdpdGhvdXQgdGhlIHBhdGggdG8gdnVsa2FuLWxvYWRlciBwYXRjaGVkIGluLgorKGRl ZmluZSB2dWxrYW4taGVhZGVycy9uby1sb2FkZXIKICAgKHBhY2thZ2UKICAgICAobmFtZSAi dnVsa2FuLWhlYWRlcnMiKQogICAgICh2ZXJzaW9uICIxLjMuMjgwLjAiKQpAQCAtMjU1LDYg KzI1Niw3IEBAIChkZWZpbmUtcHVibGljIHZ1bGthbi1oZWFkZXJzCiAgICAgKGJ1aWxkLXN5 c3RlbSBjbWFrZS1idWlsZC1zeXN0ZW0pCiAgICAgKGFyZ3VtZW50cwogICAgICBgKCM6dGVz dHM/ICNmKSkgICAgICAgICAgICAgICAgICAgIDsgTm8gdGVzdHMuCisgICAgKHByb3BlcnRp ZXMgJygoaGlkZGVuPyAuICN0KSkpCiAgICAgKGhvbWUtcGFnZQogICAgICAiaHR0cHM6Ly9n aXRodWIuY29tL0tocm9ub3NHcm91cC9WdWxrYW4tSGVhZGVycyIpCiAgICAgKHN5bm9wc2lz ICJWdWxrYW4gSGVhZGVyIGZpbGVzIGFuZCBBUEkgcmVnaXN0cnkiKQpAQCAtMjYyLDYgKzI2 NCwyNCBAQCAoZGVmaW5lLXB1YmxpYyB2dWxrYW4taGVhZGVycwogICAgICAiVnVsa2FuLUhl YWRlcnMgY29udGFpbnMgaGVhZGVyIGZpbGVzIGFuZCBBUEkgcmVnaXN0cnkgZm9yIFZ1bGth bi4iKQogICAgIChsaWNlbnNlIChsaXN0IGxpY2Vuc2U6YXNsMi4wKSkpKSA7TElDRU5TRS50 eHQKIAorKGRlZmluZS1wdWJsaWMgdnVsa2FuLWhlYWRlcnMKKyAgKHBhY2thZ2UKKyAgICAo aW5oZXJpdCB2dWxrYW4taGVhZGVycy9uby1sb2FkZXIpCisgICAgKGFyZ3VtZW50cworICAg ICAoc3Vic3RpdHV0ZS1rZXl3b3JkLWFyZ3VtZW50cyAocGFja2FnZS1hcmd1bWVudHMgdnVs a2FuLWhlYWRlcnMvbm8tbG9hZGVyKQorICAgICAgICgoIzpwaGFzZXMgcGhhc2VzICN+JXN0 YW5kYXJkLXBoYXNlcykKKyAgICAgICAgI34obW9kaWZ5LXBoYXNlcyAjJHBoYXNlcworICAg ICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICdwYXRjaC1sb2FkZXItcGF0aAorICAgICAg ICAgICAgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAg ICAgICAgICAgICAgICAoc3Vic3RpdHV0ZSogImluY2x1ZGUvdnVsa2FuL3Z1bGthbi5ocHAi CisgICAgICAgICAgICAgICAgICAoKCJkbG9wZW5cXCggXCJsaWJ2dWxrYW4uc28iKQorICAg ICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJkbG9wZW4oXCIiIChhc3NvYy1yZWYg aW5wdXRzICJ2dWxrYW4tbG9hZGVyIikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiL2xpYi9saWJ2dWxrYW4uc28iKSkpKSkpKSkpCisgICAgKGlucHV0cworICAgICAo bW9kaWZ5LWlucHV0cyAocGFja2FnZS1pbnB1dHMgdnVsa2FuLWhlYWRlcnMvbm8tbG9hZGVy KQorICAgICAgIChwcmVwZW5kIHZ1bGthbi1sb2FkZXIpKSkKKyAgICAocHJvcGVydGllcyAn KCkpKSkKKwogKGRlZmluZS1wdWJsaWMgdnVsa2FuLWxvYWRlcgogICAocGFja2FnZQogICAg IChuYW1lICJ2dWxrYW4tbG9hZGVyIikKQEAgLTMxOCw3ICszMzgsNyBAQCAoZGVmaW5lLXB1 YmxpYyB2dWxrYW4tbG9hZGVyCiAgICAgICAgICAgIHB5dGhvbgogICAgICAgICAgICB3YXls YW5kKSkKICAgICAoaW5wdXRzCi0gICAgIChsaXN0IHZ1bGthbi1oZWFkZXJzIGxpYnhyYW5k cikpCisgICAgIChsaXN0IHZ1bGthbi1oZWFkZXJzL25vLWxvYWRlciBsaWJ4cmFuZHIpKQog ICAgIChuYXRpdmUtc2VhcmNoLXBhdGhzCiAgICAgIChsaXN0IChzZWFyY2gtcGF0aC1zcGVj aWZpY2F0aW9uCiAgICAgICAgICAgICAodmFyaWFibGUgIlhER19EQVRBX0RJUlMiKQoKYmFz ZS1jb21taXQ6IGZhNzkwNmQ2NDg4MWVlMTJlMGM0MTgxMzZiNDRjNzM3NjZlM2QxNjkKLS0g CjIuNDUuMQoK --------------p9iOlUQyVPl1slIxVgqu6LPc Content-Type: text/x-patch; charset=UTF-8; name="0001-gnu-volk-Hard-code-path-of-vulkan-loader-for-dynamic.patch" Content-Disposition: attachment; filename*0="0001-gnu-volk-Hard-code-path-of-vulkan-loader-for-dynamic.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlZTQ1ODE2OTBiNjQ4NmE2NWJmMGU0ZmFlZDNmMmM4OGNhYzcwZDllIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlEOiA8ZWU0NTgxNjkwYjY0ODZhNjViZjBlNGZh ZWQzZjJjODhjYWM3MGQ5ZS4xNzE3Mjg2MzEwLmdpdC5uYXRoYW5fbWFpbEBuYm9yZ2hlc2Uu Y29tPgpGcm9tOiBuYXRoYW4gPG5hdGhhbl9tYWlsQG5ib3JnaGVzZS5jb20+CkRhdGU6IFNh dCwgMSBKdW4gMjAyNCAxOTo1NToyNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGdudTogdm9s azogSGFyZC1jb2RlIHBhdGggb2YgdnVsa2FuLWxvYWRlciBmb3IgZHluYW1pYwogbG9hZGlu ZwoKKiBnbnUvcGFja2FnZXMvdnVsa2FuLnNjbSAodm9sayk6Clthcmd1bWVudHNdOiB1c2Ug Z2V4cC4KPCM6cGhhc2VzPjogcGF0Y2ggZGxvcGVuIHdpdGggbGlidnVsa2FuLnNvLiBmaXhl cyB2dWxrYW4tdG9vbHMgYW5kIHBvdGVudGlhbGx5Cm90aGVyIHByb2dyYW1zIHRvby4KW2lu cHV0XTogYWRkIHZ1bGthbi1sb2FkZXIKCkNoYW5nZS1JZDogSTVlZjBlYjEzZDM1ZTUxN2I4 OTQ3ZmFkZGFjZTY0MTg4MmE3NzViODAKLS0tCiBnbnUvcGFja2FnZXMvdnVsa2FuLnNjbSB8 IDE1ICsrKysrKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3Z1bGthbi5zY20g Yi9nbnUvcGFja2FnZXMvdnVsa2FuLnNjbQppbmRleCA0YzUzYTE5YWJhLi4yMTVhNTkyMjY2 IDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvdnVsa2FuLnNjbQorKysgYi9nbnUvcGFja2Fn ZXMvdnVsa2FuLnNjbQpAQCAtNTY4LDkgKzU2OCwxOCBAQCAoZGVmaW5lLXB1YmxpYyB2b2xr CiAgICAgICAgICAgICAgICAgIjB4NGpoYzhuOWM0azhzdm1tY2F4eHM2MTN4YnNhdjd3YW05 NGdhY2RkbG03Mzhjd3AxM3YiKSkpKQogICAgIChidWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQt c3lzdGVtKQogICAgIChhcmd1bWVudHMKLSAgICAgJygjOnRlc3RzPyAjZiAgICAgICAgICAg ICAgICAgICAgICA7bm8gdGVzdAotICAgICAgICM6Y29uZmlndXJlLWZsYWdzICcoIi1EVk9M S19JTlNUQUxMPU9OIiAiLURWT0xLX1BVTExfSU5fVlVMS0FOPU9OIikpKQotICAgIChpbnB1 dHMgKGxpc3QgdnVsa2FuLWhlYWRlcnMpKQorICAgICAobGlzdAorICAgICAgIzp0ZXN0cz8g I2YgICAgICAgICAgICAgICAgICAgICAgO25vIHRlc3QKKyAgICAgICM6Y29uZmlndXJlLWZs YWdzICN+KGxpc3QgIi1EVk9MS19JTlNUQUxMPU9OIiAiLURWT0xLX1BVTExfSU5fVlVMS0FO PU9OIikKKyAgICAgICM6cGhhc2VzCisgICAgICAjfihtb2RpZnktcGhhc2VzICVzdGFuZGFy ZC1waGFzZXMKKyAgICAgICAgICAoYWRkLWFmdGVyICd1bnBhY2sgJ3BhdGNoLWxvYWRlci1w YXRoCisgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzICM6YWxsb3ctb3RoZXIt a2V5cykKKyAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJ2b2xrLmMiCisgICAgICAgICAg ICAgICAgKCgiZGxvcGVuXFwoXCJsaWJ2dWxrYW4uc28iKQorICAgICAgICAgICAgICAgICAo c3RyaW5nLWFwcGVuZCAiZGxvcGVuKFwiIiAoYXNzb2MtcmVmIGlucHV0cyAidnVsa2FuLWxv YWRlciIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvbGliL2xpYnZ1bGth bi5zbyIpKSkpKSkpKQorICAgIChpbnB1dHMgKGxpc3QgdnVsa2FuLWhlYWRlcnMgdnVsa2Fu LWxvYWRlcikpCiAgICAgKHN5bm9wc2lzICJNZXRhIGxvYWRlciBmb3IgVnVsa2FuIEFQSSIp CiAgICAgKGRlc2NyaXB0aW9uCiAgICAgICJWb2xrIGlzIGEgbWV0YS1sb2FkZXIgZm9yIFZ1 bGthbi4gIEl0IGFsbG93cyB5b3UgdG8gZHluYW1pY2FsbHkgbG9hZAoKYmFzZS1jb21taXQ6 IGZhNzkwNmQ2NDg4MWVlMTJlMGM0MTgxMzZiNDRjNzM3NjZlM2QxNjkKLS0gCjIuNDUuMQoK --------------p9iOlUQyVPl1slIxVgqu6LPc-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 17:30:05 2024 Received: (at 71109-done) by debbugs.gnu.org; 11 Jun 2024 21:30:05 +0000 Received: from localhost ([127.0.0.1]:36927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH948-0007fc-Q6 for submit@debbugs.gnu.org; Tue, 11 Jun 2024 17:30:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH946-0007ef-73 for 71109-done@debbugs.gnu.org; Tue, 11 Jun 2024 17:30:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH91v-0002XW-JG; Tue, 11 Jun 2024 17:27:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=4zzO+IiN5Kct69oNZwPbbvFndBSuua/zGoSc2sofAmo=; b=GKoMsW+IPwlvJVQDO+B7 dTQX7BRkWot9dNJ983t/aS1t3+mayguWLteBQXrMDTsDkfO+BwUb8ds0BaCeb1h1sDZ8HwFBGAWs5 /kqD95Eku0R/Ti0Yuppa331IOc9Sph5BYb+eZhPTYZbmHHkSkpTe6sHsN2pAm7oLD2kKDRV/tbjfj 4rBhKC/MTD8fUsGKvebUKbkJI+9TrLfJWP/AOP22t8D/Y5uvuOk4CoeFpEyAt1i5fQpjnl+wfiHTR sjxq0PvsGuDKZqVBNsSlcmkWu6rmtsirrdsWp4Irr+gQIQMg1n78947aw93XhtDyxuZS0QVFE2hs+ 3kzuflVN6t3lGg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: nathan Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. In-Reply-To: <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> (nathan's message of "Sun, 2 Jun 2024 01:19:14 +0000") References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> Date: Tue, 11 Jun 2024 23:27:43 +0200 Message-ID: <87tthzkw4w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71109-done Cc: 71109-done@debbugs.gnu.org, sughosha@disroot.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi nathan and all, nathan skribis: > From 811d7567098e00711ee4c9c80afbe544ebe1c08e Mon Sep 17 00:00:00 2001 > Message-ID: <811d7567098e00711ee4c9c80afbe544ebe1c08e.1717290934.git.nath= an_mail@nborghese.com> > From: nathan > Date: Sat, 1 Jun 2024 21:14:13 -0400 > Subject: [PATCH] example of how to patch patch of vulkan-loader into > vulkan-headers > > Change-Id: Ic674a4d965d8049e388d75137111ed0253ca3b18 [...] > From ee4581690b6486a65bf0e4faed3f2c88cac70d9e Mon Sep 17 00:00:00 2001 > Message-ID: > From: nathan > Date: Sat, 1 Jun 2024 19:55:24 -0400 > Subject: [PATCH] gnu: volk: Hard-code path of vulkan-loader for dynamic > loading > > * gnu/packages/vulkan.scm (volk): > [arguments]: use gexp. > <#:phases>: patch dlopen with libvulkan.so. fixes vulkan-tools and potent= ially > other programs too. > [input]: add vulkan-loader > > Change-Id: I5ef0eb13d35e517b8947faddace641882a775b80 These two patches make sense to me. I applied them with minor tweaks: using =E2=80=98search-input-file=E2=80=99= rather than =E2=80=98assoc-ref=E2=80=99 in build phases, and commit log modifications t= o match our conventions. Thank you! Ludo=E2=80=99. From unknown Sun Jun 15 08:39:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Tue, 11 Jun 2024 21:59:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 17:58:41 2024 Received: (at control) by debbugs.gnu.org; 11 Jun 2024 21:58:41 +0000 Received: from localhost ([127.0.0.1]:36968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH9Vp-0002o5-6b for submit@debbugs.gnu.org; Tue, 11 Jun 2024 17:58:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH9Vn-0002np-4e for control@debbugs.gnu.org; Tue, 11 Jun 2024 17:58:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH9Vh-0001TF-Rc for control@debbugs.gnu.org; Tue, 11 Jun 2024 17:58:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:From:To:Date:in-reply-to: references; bh=pLR7CDvDP4tA6jEqEPefa3U/tB3gsBEo5V3hjXAgw3s=; b=YZg/0bGsPjTOM/ E7UdHxWBBysarsGW+lC8honMtnUrg1WPI2u/EsMoKpXLcKhwjTG+RDCUb/BTxsNNULzX68c2KRKKi p2MeQBx1Q/jRUJMDofiRYfb4HIojuyld0ub0aA1A/qjp0USoBvSpoioJ8bCWpzUG93OjtWf+iJr4d SswmNEyERXz/81FX+2jiD99fZcnc9XTKumvGAyiEOe6hwvq4JKr0PdiGcfG3HdsXFKxLhsGhlvbFb dv7sQNeCcKrRddU3FbADTjg8VENxeIS8yITOAsMwBlBFaKpGJ8/GCX+BKlHCJ8bXoC1ipwHKbMZ/x PNwg/sdeqGVgcDP7nOpQ==; Date: Tue, 11 Jun 2024 23:58:30 +0200 Message-Id: <87h6dzkupl.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #71109 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) reopen 71109 tags 71109 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 11 18:02:24 2024 Received: (at 71109) by debbugs.gnu.org; 11 Jun 2024 22:02:24 +0000 Received: from localhost ([127.0.0.1]:36978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH9ZQ-0005jN-1V for submit@debbugs.gnu.org; Tue, 11 Jun 2024 18:02:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sH9ZN-0005j9-7y for 71109@debbugs.gnu.org; Tue, 11 Jun 2024 18:02:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH9ZJ-0002NR-1l; Tue, 11 Jun 2024 18:02:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=D/7XW8EUJWDi8/oc48b9Zd9UO/QlIb1AeohZr4MxZW0=; b=d9gbV6L8WXYUU04ZJ4F+ NkRRUKMM+z0ZJJlfFumjmi+Qrg6qeLHdp+O4IjybgKdNw2s0mOxE+Fwg7MtBwiaVYqYdGl1C+WVr3 dpa4v8sMoq+qp6YVqoYowcZAADuaYV30+fiVuYIWmp/KvmrIXJj3WpoJpiLc1zpqw5p+9C9ZAFHeP VpHt2VQlQjsPAlMLZBnk75KA+E3naJcVviAnMLPovLmR6Pn8Oup82myqQ9zF20bpD2Wi6XZdSpv2T k2ykiHGgRE9+NKYYkFWtEi45DUnletqAa4xR/F9gQ+8xr5DmGNmMvK9myyk5IWpSuB5JW3qHZ+R1h pYrViomjSO7UKw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: nathan Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. In-Reply-To: <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> (nathan's message of "Sun, 2 Jun 2024 01:19:14 +0000") References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> Date: Wed, 12 Jun 2024 00:02:14 +0200 Message-ID: <87bk47kujd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71109 Cc: John Kehayias , 71109@debbugs.gnu.org, sughosha@disroot.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I spoke a bit too fast: given that many packages depend on =E2=80=98vulkan-headers=E2=80=99, this should be applied on a branch. Attached as the updated patches. John, could you apply them on the =E2=80=98mesa-updates=E2=80=99 branch? (= I realized there=E2=80=99s no formal =E2=80=98mesa=E2=80=99 team contrary to what I th= ought; perhaps there should be one?). Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-vulkan-headers-Hard-code-libvulkan.so-file-name.patch Content-Transfer-Encoding: quoted-printable >From 577a58ac4d23e7fa749fddb3007a3ad14c40f38d Mon Sep 17 00:00:00 2001 Message-ID: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.ludo@g= nu.org> From: nathan Date: Sat, 1 Jun 2024 21:14:13 -0400 Subject: [PATCH 1/2] gnu: vulkan-headers: Hard-code libvulkan.so file name. MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/vulkan.scm (vulkan-headers): Rename to=E2=80=A6 (vulkan-headers/no-loader): =E2=80=A6 this. (vulkan-headers): New variable. (vulkan-loader): Depend on =E2=80=98vulkan-headers/no-loader=E2=80=99. Change-Id: Ic674a4d965d8049e388d75137111ed0253ca3b18 Co-authored-by: Ludovic Court=C3=A8s --- gnu/packages/vulkan.scm | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm index 25542c1e064..5ff47be92e2 100644 --- a/gnu/packages/vulkan.scm +++ b/gnu/packages/vulkan.scm @@ -246,7 +246,8 @@ (define-public glslang ;; include/SPIRV/{bitutils,hex_float}.h are Apache 2.0. license:asl2.0)))) =20 -(define-public vulkan-headers +;; vulkan-headers, but without the path to vulkan-loader patched in. +(define-public vulkan-headers/no-loader (package (name "vulkan-headers") (version "1.3.280.0") @@ -263,6 +264,7 @@ (define-public vulkan-headers (build-system cmake-build-system) (arguments `(#:tests? #f)) ; No tests. + (properties '((hidden? . #t))) (home-page "https://github.com/KhronosGroup/Vulkan-Headers") (synopsis "Vulkan Header files and API registry") @@ -270,6 +272,25 @@ (define-public vulkan-headers "Vulkan-Headers contains header files and API registry for Vulkan.") (license (list license:asl2.0)))) ;LICENSE.txt =20 +(define-public vulkan-headers + (package + (inherit vulkan-headers/no-loader) + (arguments + (substitute-keyword-arguments (package-arguments vulkan-headers/no-lo= ader) + ((#:phases phases #~%standard-phases) + #~(modify-phases #$phases + (add-after 'unpack 'patch-libvulkan-file-name + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "include/vulkan/vulkan.hpp" + (("dlopen\\( \"libvulkan.so") + (string-append "dlopen(\"" + (search-input-file + inputs "/lib/libvulkan.so")))))))))) + (inputs + (modify-inputs (package-inputs vulkan-headers/no-loader) + (prepend vulkan-loader))) + (properties '()))) + (define-public vulkan-loader (package (name "vulkan-loader") @@ -326,7 +347,7 @@ (define-public vulkan-loader python wayland)) (inputs - (list vulkan-headers libxrandr)) + (list vulkan-headers/no-loader libxrandr)) (native-search-paths (list (search-path-specification (variable "XDG_DATA_DIRS") base-commit: 7daf9328921f9f7d4fe4839d8e16091bd9f06072 --=20 2.45.1 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0002-gnu-volk-Hard-code-path-of-vulkan-loader-for-dynamic.patch Content-Transfer-Encoding: quoted-printable >From 2cb9899209d1807cd18e9ed68a634faca48c6d89 Mon Sep 17 00:00:00 2001 Message-ID: <2cb9899209d1807cd18e9ed68a634faca48c6d89.1718143100.git.ludo@g= nu.org> In-Reply-To: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.ludo@= gnu.org> References: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.ludo@g= nu.org> From: nathan Date: Sat, 1 Jun 2024 19:55:24 -0400 Subject: [PATCH 2/2] gnu: volk: Hard-code path of vulkan-loader for dynamic loading MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Until now, we=E2=80=99d get: $ guix shell vulkan-tools -- vulkaninfo ERROR at /tmp/guix-build-vulkan-tools-1.3.280.0.drv-0/source/vulkaninfo/.= /vulkaninfo.h:412: Failed to initialize: Vulkan loader is not installed, no= t found, or failed to load. This patch fixes it and potentially for other programs as well. * gnu/packages/vulkan.scm (volk)[arguments]: use gexp. <#:phases>: Patch dlopen with libvulkan.so. [input]: Add vulkan-loader. Change-Id: I5ef0eb13d35e517b8947faddace641882a775b80 Co-authored-by: Ludovic Court=C3=A8s --- gnu/packages/vulkan.scm | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm index 5ff47be92e2..5d322f3ddb9 100644 --- a/gnu/packages/vulkan.scm +++ b/gnu/packages/vulkan.scm @@ -597,9 +597,19 @@ (define-public volk "0x4jhc8n9c4k8svmmcaxxs613xbsav7wam94gacddlm738cwp13v")))) (build-system cmake-build-system) (arguments - '(#:tests? #f ;no test - #:configure-flags '("-DVOLK_INSTALL=3DON" "-DVOLK_PULL_IN_VULKAN=3D= ON"))) - (inputs (list vulkan-headers)) + (list + #:tests? #f ;no test + #:configure-flags #~(list "-DVOLK_INSTALL=3DON" "-DVOLK_PULL_IN_VULK= AN=3DON") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'patch-loader-path + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "volk.c" + (("dlopen\\(\"libvulkan.so") + (string-append "dlopen(\"" + (search-input-file + inputs "/lib/libvulkan.so"))))))))) + (inputs (list vulkan-headers vulkan-loader)) (synopsis "Meta loader for Vulkan API") (description "Volk is a meta-loader for Vulkan. It allows you to dynamically load --=20 2.45.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 21:32:16 2024 Received: (at 71109-done) by debbugs.gnu.org; 7 Sep 2024 01:32:16 +0000 Received: from localhost ([127.0.0.1]:54468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smkJD-0006Jy-MQ for submit@debbugs.gnu.org; Fri, 06 Sep 2024 21:32:16 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:47911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smkJB-0006Jj-9x for 71109-done@debbugs.gnu.org; Fri, 06 Sep 2024 21:32:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1725672726; x=1725931926; bh=+u/vBDYmps9/3St8u+LPl7yXxwL/qMWVEVNJvDTsbvc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=cye2uS7RzLvcqUW8h19BPQSdyGrkf0FRxrmxCzoO6rMgs4V0495JtCnwOuvr8fKZB 8nlH6sBDf2jEg6eXlBFHKvw+B9/1H75qRmILR4DwJclnxb616DQLMvDyU/NUDddn+x Q9zHYXvST5hk98nzquGXhQqNjCi8cdt50oeWb3y5M03CKQkRNMThxNjgZz1kJg6PMi nZPoe4ozWT8tmBt1OMZPQQJ55yA54P7fMxupCgD4cCMgMgtoQN0EpiX+Pj+K5UVT6Q jBxiAtAllAwuCRGCA+5G6aDJ/PBeibmJXLv3lZykkf2jzrus/jiodiwdpNoDuuHIq8 J01HIfF2swhCA== Date: Sat, 07 Sep 2024 01:32:04 +0000 To: =?utf-8?Q?Ludovic_Court=C3=A8s?= From: John Kehayias Subject: Re: [bug#71109] [PATCH] gnu: vulkan-tools: Wrap binaries with LD_LIBRARY_PATH. Message-ID: <878qw4l04v.fsf@protonmail.com> In-Reply-To: <87bk47kujd.fsf@gnu.org> References: <0f2a806ee6259147a098e8d672d03ed768fde5fa.1716370579.git.sughosha@disroot.org> <66f9f6e2-434b-08e7-b5d5-c9d1cfd99b50@nborghese.com> <87bk47kujd.fsf@gnu.org> Feedback-ID: 7805494:user:proton X-Pm-Message-ID: c21a9982251b1d1d084aa0d95dd9a44d43cd4474 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 71109-done Cc: nathan , 71109-done@debbugs.gnu.org, sughosha@disroot.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, On Wed, Jun 12, 2024 at 12:02 AM, Ludovic Court=C3=A8s wrote: > Hi, > > I spoke a bit too fast: given that many packages depend on > =E2=80=98vulkan-headers=E2=80=99, this should be applied on a branch. > > Attached as the updated patches. > > John, could you apply them on the =E2=80=98mesa-updates=E2=80=99 branch? = (I realized > there=E2=80=99s no formal =E2=80=98mesa=E2=80=99 team contrary to what I = thought; perhaps there > should be one?). > > Thanks, > Ludo=E2=80=99. > My apologies for a being a bit slow here! I've included these patches on mesa-updates (building now) and the full set of patches is tracked here: https://issues.guix.gnu.org/73071 I have used vulkan on that branch without issues so far. And yes, I keep forgetting to make a formal team. I suppose it shouldn't be a "mesa" team but a bit broader (graphics?). I will close this as it is live on mesa-updates and hopefully merged into master before long. (Otherwise I'm afraid it will be forgotten open and it can be tested with the other updates, but please correct me if this should remain open.) Thanks everyone for your work here! John >>>From 577a58ac4d23e7fa749fddb3007a3ad14c40f38d Mon Sep 17 00:00:00 2001 > Message-ID: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.ludo= @gnu.org> > From: nathan > Date: Sat, 1 Jun 2024 21:14:13 -0400 > Subject: [PATCH 1/2] gnu: vulkan-headers: Hard-code libvulkan.so file nam= e. > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > * gnu/packages/vulkan.scm (vulkan-headers): Rename to=E2=80=A6 > (vulkan-headers/no-loader): =E2=80=A6 this. > (vulkan-headers): New variable. > (vulkan-loader): Depend on =E2=80=98vulkan-headers/no-loader=E2=80=99. > > Change-Id: Ic674a4d965d8049e388d75137111ed0253ca3b18 > Co-authored-by: Ludovic Court=C3=A8s > --- > gnu/packages/vulkan.scm | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm > index 25542c1e064..5ff47be92e2 100644 > --- a/gnu/packages/vulkan.scm > +++ b/gnu/packages/vulkan.scm > @@ -246,7 +246,8 @@ (define-public glslang > ;; include/SPIRV/{bitutils,hex_float}.h are Apache 2.= 0. > license:asl2.0)))) > > -(define-public vulkan-headers > +;; vulkan-headers, but without the path to vulkan-loader patched in. > +(define-public vulkan-headers/no-loader > (package > (name "vulkan-headers") > (version "1.3.280.0") > @@ -263,6 +264,7 @@ (define-public vulkan-headers > (build-system cmake-build-system) > (arguments > `(#:tests? #f)) ; No tests. > + (properties '((hidden? . #t))) > (home-page > "https://github.com/KhronosGroup/Vulkan-Headers") > (synopsis "Vulkan Header files and API registry") > @@ -270,6 +272,25 @@ (define-public vulkan-headers > "Vulkan-Headers contains header files and API registry for Vulkan."= ) > (license (list license:asl2.0)))) ;LICENSE.txt > > +(define-public vulkan-headers > + (package > + (inherit vulkan-headers/no-loader) > + (arguments > + (substitute-keyword-arguments (package-arguments vulkan-headers/no-= loader) > + ((#:phases phases #~%standard-phases) > + #~(modify-phases #$phases > + (add-after 'unpack 'patch-libvulkan-file-name > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "include/vulkan/vulkan.hpp" > + (("dlopen\\( \"libvulkan.so") > + (string-append "dlopen(\"" > + (search-input-file > + inputs "/lib/libvulkan.so")))))))))) > + (inputs > + (modify-inputs (package-inputs vulkan-headers/no-loader) > + (prepend vulkan-loader))) > + (properties '()))) > + > (define-public vulkan-loader > (package > (name "vulkan-loader") > @@ -326,7 +347,7 @@ (define-public vulkan-loader > python > wayland)) > (inputs > - (list vulkan-headers libxrandr)) > + (list vulkan-headers/no-loader libxrandr)) > (native-search-paths > (list (search-path-specification > (variable "XDG_DATA_DIRS") > > base-commit: 7daf9328921f9f7d4fe4839d8e16091bd9f06072 > -- > 2.45.1 > >>>From 2cb9899209d1807cd18e9ed68a634faca48c6d89 Mon Sep 17 00:00:00 2001 > Message-ID: <2cb9899209d1807cd18e9ed68a634faca48c6d89.1718143100.git.ludo= @gnu.org> > In-Reply-To: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.lud= o@gnu.org> > References: <577a58ac4d23e7fa749fddb3007a3ad14c40f38d.1718143100.git.ludo= @gnu.org> > From: nathan > Date: Sat, 1 Jun 2024 19:55:24 -0400 > Subject: [PATCH 2/2] gnu: volk: Hard-code path of vulkan-loader for dynam= ic > loading > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > > Until now, we=E2=80=99d get: > > $ guix shell vulkan-tools -- vulkaninfo > ERROR at /tmp/guix-build-vulkan-tools-1.3.280.0.drv-0/source/vulkaninfo= /./vulkaninfo.h:412: Failed to initialize: Vulkan loader is not installed, = not found, or failed to load. > > This patch fixes it and potentially for other programs as well. > > * gnu/packages/vulkan.scm (volk)[arguments]: use gexp. > <#:phases>: Patch dlopen with libvulkan.so. > [input]: Add vulkan-loader. > > Change-Id: I5ef0eb13d35e517b8947faddace641882a775b80 > Co-authored-by: Ludovic Court=C3=A8s > --- > gnu/packages/vulkan.scm | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm > index 5ff47be92e2..5d322f3ddb9 100644 > --- a/gnu/packages/vulkan.scm > +++ b/gnu/packages/vulkan.scm > @@ -597,9 +597,19 @@ (define-public volk > "0x4jhc8n9c4k8svmmcaxxs613xbsav7wam94gacddlm738cwp13v"))= )) > (build-system cmake-build-system) > (arguments > - '(#:tests? #f ;no test > - #:configure-flags '("-DVOLK_INSTALL=3DON" "-DVOLK_PULL_IN_VULKAN= =3DON"))) > - (inputs (list vulkan-headers)) > + (list > + #:tests? #f ;no test > + #:configure-flags #~(list "-DVOLK_INSTALL=3DON" "-DVOLK_PULL_IN_VU= LKAN=3DON") > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-loader-path > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "volk.c" > + (("dlopen\\(\"libvulkan.so") > + (string-append "dlopen(\"" > + (search-input-file > + inputs "/lib/libvulkan.so"))))))))) > + (inputs (list vulkan-headers vulkan-loader)) > (synopsis "Meta loader for Vulkan API") > (description > "Volk is a meta-loader for Vulkan. It allows you to dynamically lo= ad From unknown Sun Jun 15 08:39:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Oct 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator