GNU bug report logs - #71107
29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71107: closed (29.3; eshell-hist/Incorrect history handling
 with eshell-hist-ignoredups 'erase)
Date: Sat, 25 May 2024 02:38:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 24 May 2024 19:35:48 -0700
with message-id <14ed1c61-5569-41bf-d02a-40479df20634 <at> gmail.com>
and subject line Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase
has caused the debbugs.gnu.org bug report #71107,
regarding 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71107: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71107
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Robin Campbell Joy <emacs <at> robinjoy.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.3;
 eshell-hist/Incorrect history handling with eshell-hist-ignoredups
 'erase
Date: Wed, 22 May 2024 10:21:12 +0200

[Message part 3 (text/plain, inline)]

Severity: minor
Tags: patch

In case of eshell-hist-ingoredups set to 'erase, history handling isn't
working correctly.

1) If the input ring is empty, no elements are added to the ring.
2) If elements are on the ring, but the element added to the ring is not
yet in the ring, the last element is deleted.
3) When switching to 'erase with multiple duplicates in the ring, only
the last equal element is removed.

emacs -Q
(require 'eshell)
(setq eshell-hist-ignoredups 'erase)
(eshell)
$ echo foo
foo
M-p -> Empty input ring

[Message part 4 (text/html, inline)]

[eshell-hist-ignoredups.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Robin Campbell Joy <emacs <at> robinjoy.net>
Cc: eli <at> gnu.org, 71107-done <at> debbugs.gnu.org
Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with
 eshell-hist-ignoredups 'erase
Date: Fri, 24 May 2024 19:35:48 -0700

On 5/24/2024 5:29 AM, Robin Campbell Joy wrote:
> Sure, hope this will do.

Thanks, that looks good to me. I've merged your patch to the master 
branch as 984fb346fdf. Closing this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.