GNU bug report logs - #71107
29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase

Previous Next

Full log

View this message in rfc822 format

From: Robin Campbell Joy <emacs <at> robinjoy.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 71107 <at> debbugs.gnu.org, eli <at> gnu.org
Subject: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase
Date: Fri, 24 May 2024 14:29:59 +0200

[Message part 1 (text/plain, inline)]

On Fri, 24 May 2024 at 01:33, Jim Porter <jporterbugs <at> gmail.com> wrote:

> On 5/22/2024 11:22 PM, Robin Campbell Joy wrote:
> > Thanks, not sure why I didn't find this when looking for an existing
> > bug, should have checked master first though.
> >
> > Attached the rebased patch. Thanks for fixing this.
>
> Thanks for the updated patch. From a visual inspection, this all looks
> good to me.
>
> Just two small things and then I think this is good to merge:
>
> 1) Could you add a commit message in the usual style (you can look at
> the other Emacs commits to get an idea of what these look like), and
> then generate the patch file with `git format-patch master`? This'll
> make it easier for me to apply the patch without having to write up a
> commit message myself.
>

Sure, hope this will do.

[Message part 2 (text/html, inline)]

[0001-Erase-existing-duplicates-in-eshell-history-ring.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.