GNU bug report logs - #71107
29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase

Previous Next

Full log

Message #11 received at 71107 <at> debbugs.gnu.org (full text, mbox):

From: Robin Campbell Joy <emacs <at> robinjoy.net>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 71107 <at> debbugs.gnu.org
Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with
 eshell-hist-ignoredups 'erase
Date: Thu, 23 May 2024 08:22:37 +0200

[Message part 1 (text/plain, inline)]

On Thu, 23 May 2024 at 06:35, Jim Porter <jporterbugs <at> gmail.com> wrote:

> I believe this should already be fixed by commit 7b0f24ab1f9 from
> bug#63360.
>
> However, I didn't bother to account for the case where there may be
> multiple entries to remove (I just added a FIXME note since it seemed
> like a low priority). If removing multiple duplicates is important to
> you, would you be willing to rebase your patch on top of the master
> branch? Thanks either way.
>

Thanks, not sure why I didn't find this when looking for an existing bug,
should have checked master first though.

Attached the rebased patch. Thanks for fixing this.

[Message part 2 (text/html, inline)]

[eshell-hist-ignoredups.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.