From unknown Sun Aug 17 09:11:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71107 <71107@debbugs.gnu.org> To: bug#71107 <71107@debbugs.gnu.org> Subject: Status: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Reply-To: bug#71107 <71107@debbugs.gnu.org> Date: Sun, 17 Aug 2025 16:11:50 +0000 retitle 71107 29.3; eshell-hist/Incorrect history handling with eshell-hist= -ignoredups 'erase reassign 71107 emacs submitter 71107 Robin Campbell Joy severity 71107 minor tag 71107 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 04:21:41 2024 Received: (at submit) by debbugs.gnu.org; 22 May 2024 08:21:41 +0000 Received: from localhost ([127.0.0.1]:54326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9hED-0007wF-35 for submit@debbugs.gnu.org; Wed, 22 May 2024 04:21:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9hE9-0007w9-QH for submit@debbugs.gnu.org; Wed, 22 May 2024 04:21:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9hE3-0001VW-Lr for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 04:21:31 -0400 Received: from mail-pf1-f170.google.com ([209.85.210.170]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9hE0-0002vS-40 for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 04:21:31 -0400 Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-6f4dcc3eeb3so839795b3a.0 for ; Wed, 22 May 2024 01:21:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716366085; x=1716970885; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=HQxGmPCmYJCSF78rJs85xAmE9ROoWoxwJLocqiTYloE=; b=eXLsUkNqEOCLuEl2LwwiDhnhayzwCMi2baZkBqZQCqVrDuYEeZhPJBKGB3zjl75SyB xGhPjovPhWUa4R4MkWUQ5m3R9XF+fjCHg9uNycwXq0duCYdQjz7cK+sF6ZxoFn8WPCKX Lmk/zLjmW7QGPfJgh2iO/MzDB7OQ4q00TiDSTuIZe9n3f18+slbYB8jZJaLtB+USsCpw Av6ty6mnUMk2MkgFMY6bGyjHYTp12eyQOWWMvVtBc6z1+MHkNlyaV3RkBtGfl4bqOsIS CDLRXEDsc1dqx/HKafm4xfrRBwuRBy1P8kSF9H4R0rBmY1FZCYIZOJtjxMPsBZxO56M9 mNWg== X-Gm-Message-State: AOJu0Ywm/izZMM/y6l3YPfpEi/+08Y5buiOYXLbfD/c6DaGBGYhuGhL8 TNZWSfU7zDiE1eIMhMCIcNcstd/cPpGGUVmzxkqYqYUxuMCQJOI/57pXjv+5Cqc+S9hMYABub1R M2Fo2XzYykS+fmgRS+uyKWETVcyJ0419+qML3dbPrylMQzMkLUhw= X-Google-Smtp-Source: AGHT+IFmmfh86FBoBq+eu31IG3eaGTXTUpU27AX6teKed1LUPvBJJA56fJgU1znqeurMcxfZMdkb6hFLsZCYuM9vqkM= X-Received: by 2002:a05:6a20:9490:b0:1b0:14a0:c875 with SMTP id adf61e73a8af0-1b1f8829ed3mr1170778637.1.1716366084669; Wed, 22 May 2024 01:21:24 -0700 (PDT) MIME-Version: 1.0 From: Robin Campbell Joy Date: Wed, 22 May 2024 10:21:12 +0200 Message-ID: Subject: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000c899f20619069ea5" Received-SPF: none client-ip=209.85.210.170; envelope-from=rcj@robinjoy.net; helo=mail-pf1-f170.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --000000000000c899f20619069ea5 Content-Type: multipart/alternative; boundary="000000000000c899f10619069ea3" --000000000000c899f10619069ea3 Content-Type: text/plain; charset="UTF-8" Severity: minor Tags: patch In case of eshell-hist-ingoredups set to 'erase, history handling isn't working correctly. 1) If the input ring is empty, no elements are added to the ring. 2) If elements are on the ring, but the element added to the ring is not yet in the ring, the last element is deleted. 3) When switching to 'erase with multiple duplicates in the ring, only the last equal element is removed. emacs -Q (require 'eshell) (setq eshell-hist-ignoredups 'erase) (eshell) $ echo foo foo M-p -> Empty input ring --000000000000c899f10619069ea3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Severity: minor
Tags: patch

In case of eshell-hi= st-ingoredups set to 'erase, history handling isn't
working corr= ectly.

1) If the input ring is empty, no elements are added to the r= ing.
2) If elements are on the ring, but the element added to the ring i= s not
yet in the ring, the last element is deleted.
3) When switching= to 'erase with multiple duplicates in the ring, only
the last equal= element is removed.

emacs -Q
(require 'eshell)
(setq eshe= ll-hist-ignoredups 'erase)
(eshell)
$ echo foo
foo
M-p ->= ; Empty input ring
--000000000000c899f10619069ea3-- --000000000000c899f20619069ea5 Content-Type: application/octet-stream; name="eshell-hist-ignoredups.patch" Content-Disposition: attachment; filename="eshell-hist-ignoredups.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwhk03zw0 ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0 LmVsCmluZGV4IDQwODFmMmE3Zjg1Li5lNzY2NWRlM2FiNyAxMDA2NDQKLS0tIGEvbGlzcC9lc2hl bGwvZW0taGlzdC5lbAorKysgYi9saXNwL2VzaGVsbC9lbS1oaXN0LmVsCkBAIC0zODUsMTAgKzM4 NSwxMiBAQCBlc2hlbGwtYWRkLWlucHV0LXRvLWhpc3RvcnkKICAgICAgICAgICAgICAoaWYgKGVx IGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMgJ2VyYXNlKQogICAgICAgICAgICAgICAgICA7OyBSZW1v dmUgYW55IG9sZCBvY2N1cnJlbmNlcyBvZiB0aGUgaW5wdXQsIGFuZCBwdXQKICAgICAgICAgICAg ICAgICAgOzsgdGhlIG5ldyBvbmUgYXQgdGhlIGVuZC4KLSAgICAgICAgICAgICAgICAgKHVubGVz cyAocmluZy1lbXB0eS1wIGVzaGVsbC1oaXN0b3J5LXJpbmcpCi0gICAgICAgICAgICAgICAgICAg KHJpbmctcmVtb3ZlIGVzaGVsbC1oaXN0b3J5LXJpbmcKLQkgICAgICAgICAgICAgICAgICAgICAg ICAocmluZy1tZW1iZXIgZXNoZWxsLWhpc3RvcnktcmluZyBpbnB1dCkpCi0gICAgICAgICAgICAg ICAgICAgdCkKKyAgICAgICAgICAgICAgICAgKG9yICh1bmxlc3MgKHJpbmctZW1wdHktcCBlc2hl bGwtaGlzdG9yeS1yaW5nKQorICAgICAgICAgICAgICAgICAgICAgICAobGV0IChpbmRleCkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAod2hpbGUgKHNldHEgaW5kZXggKHJpbmctbWVtYmVyIGVz aGVsbC1oaXN0b3J5LXJpbmcgaW5wdXQpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJp bmctcmVtb3ZlIGVzaGVsbC1oaXN0b3J5LXJpbmcgaW5kZXgpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgdCkKKyAgICAgICAgICAgICAgICAgICAgIHQpCiAgICAgICAgICAgICAgICA7OyBBbHdh eXMgYWRkLi4uCiAgICAgICAgICAgICAgICAob3IgKG51bGwgZXNoZWxsLWhpc3QtaWdub3JlZHVw cykKICAgICAgICAgICAgICAgICAgICA7OyAuLi4gb3IgYWRkIGlmIGl0J3Mgbm90IGFscmVhZHkg cHJlc2VudCBhdCB0aGUKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZW0taGlzdC10ZXN0 cy5lbCBiL3Rlc3QvbGlzcC9lc2hlbGwvZW0taGlzdC10ZXN0cy5lbAppbmRleCBkMzI1ZTNhNjQw Mi4uMDRkN2IxYTA2NzAgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwvZW0taGlzdC10ZXN0 cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVzdHMuZWwKQEAgLTMzLDYgKzMz LDUxIEBAIGVzaGVsbC13cml0ZS1yZWFkb25seS1oaXN0b3J5CiAgICAgICAgICAgICAgICAgICAg KHByb3BlcnRpemUgImVjaG8gYmFyIiAncmVhZC1vbmx5IHQpKQogICAgICAgKGVzaGVsbC13cml0 ZS1oaXN0b3J5IGhpc3RmaWxlKSkpKQogCisoZXJ0LWRlZnRlc3QgZXNoZWxsLWFkZC1oaXN0b3J5 LWVsZW1lbnQtdG8tZW1wdHktcmluZy13aXRoLWVyYXNlLWR1cHMgKCkKKyAgIlRlc3QgdGhhdCB3 ZSBhZGQgYSBuZXcgaGlzdG9yeSBpdGVtIHRvIGFuIGVtcHR5IGhpc3RvcnkgcmluZyB3aXRoIGBl c2hlbGwtaGlzdC1pZ25vcmVkdXBzJyBzZXQgdG8gJ2VyYXNlLiIKKyAgKGVydC13aXRoLXRlc3Qt YnVmZmVyICg6bmFtZSAiZXNoZWxsLWhpc3QtdGVzdCIpCisgICAgKGxldCAoKGVzaGVsbC1oaXN0 b3J5LXJpbmcgKG1ha2UtcmluZyAyKSkKKyAgICAgICAgICAoZXNoZWxsLWhpc3QtaWdub3JlZHVw cyAnZXJhc2UpKQorICAgICAgKGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeSAiZWNobyBmb28i KQorICAgICAgKHNob3VsZCAoPSAocmluZy1sZW5ndGggZXNoZWxsLWhpc3RvcnktcmluZykgMSkp CisgICAgICAoc2hvdWxkICg9IChyaW5nLW1lbWJlciBlc2hlbGwtaGlzdG9yeS1yaW5nICJlY2hv IGZvbyIpIDApKSkpKQorCisoZXJ0LWRlZnRlc3QgZXNoZWxsLWFkZC1oaXN0b3J5LWVsZW1lbnQt dG8tbm9uLWVtcHR5LXJpbmctd2l0aC1lcmFzZS1kdXBzLWVyYXNlcy1kdXBsaWNhdGUgKCkKKyAg IlRlc3QgdGhhdCB3aGVuIHdlIGFkZCBhbiBleGlzdGluZyBoaXN0b3J5IGl0ZW0gdG8gYSBub24g ZW1wdHkgaGlzdG9yeSByaW5nIHdpdGggYGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMnIHNldCB0byAn ZXJhc2UgdGhlIGV4aXN0aW5nIGVsZW1lbnQgaXMgZXJhc2VkLiIKKyAgKGVydC13aXRoLXRlc3Qt YnVmZmVyICg6bmFtZSAiZXNoZWxsLWhpc3QtdGVzdCIpCisgICAgKGxldCAoKGVzaGVsbC1oaXN0 b3J5LXJpbmcgKG1ha2UtcmluZyAyKSkKKyAgICAgICAgICAoZXNoZWxsLWhpc3QtaWdub3JlZHVw cyAnZXJhc2UpKQorICAgICAgKGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeSAiZWNobyBmb28i KQorICAgICAgKGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeSAiZWNobyBmb28iKQorICAgICAg KHNob3VsZCAoPSAocmluZy1sZW5ndGggZXNoZWxsLWhpc3RvcnktcmluZykgMSkpCisgICAgICAo c2hvdWxkICg9IChyaW5nLW1lbWJlciBlc2hlbGwtaGlzdG9yeS1yaW5nICJscyIpIDApKSkpKQor CisoZXJ0LWRlZnRlc3QgZXNoZWxsLWFkZC1oaXN0b3J5LWVsZW1lbnQtdG8tbm9uLWVtcHR5LXJp bmctd2l0aC1lcmFzZS1kdXBzLWVyYXNlcy1kdXBsaWNhdGVzICgpCisgICJUZXN0IHRoYXQgd2hl biB3ZSBhZGQgYW4gZXhpc3RpbmcgaGlzdG9yeSBpdGVtIHRvIGEgbm9uIGVtcHR5IGhpc3Rvcnkg cmluZyB3aXRoIGBlc2hlbGwtaGlzdC1pZ25vcmVkdXBzJyBzZXQgdG8gJ2VyYXNlIHRoZSBleGlz dGluZyBlbGVtZW50cyBhcmUgZXJhc2VkLiIKKyAgKGVydC13aXRoLXRlc3QtYnVmZmVyICg6bmFt ZSAiZXNoZWxsLWhpc3QtdGVzdCIpCisgICAgKGxldCAoKGVzaGVsbC1oaXN0b3J5LXJpbmcgKG1h a2UtcmluZyA1KSkKKyAgICAgICAgICAoZXNoZWxsLWhpc3QtaWdub3JlZHVwcyBuaWwpKQorICAg ICAgKGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeSAiZWNobyBmb28iKQorICAgICAgKGVzaGVs bC1hZGQtaW5wdXQtdG8taGlzdG9yeSAiZWNobyBiYXIiKQorICAgICAgKGVzaGVsbC1hZGQtaW5w dXQtdG8taGlzdG9yeSAiZWNobyBmb28iKQorICAgICAgKHNob3VsZCAoPSAocmluZy1sZW5ndGgg ZXNoZWxsLWhpc3RvcnktcmluZykgMykpCisgICAgICAoc2V0cSBlc2hlbGwtaGlzdC1pZ25vcmVk dXBzICdlcmFzZSkKKyAgICAgIChlc2hlbGwtYWRkLWlucHV0LXRvLWhpc3RvcnkgImVjaG8gZm9v IikKKyAgICAgIChzaG91bGQgKD0gKHJpbmctbGVuZ3RoIGVzaGVsbC1oaXN0b3J5LXJpbmcpIDIp KQorICAgICAgKHNob3VsZCAoPSAocmluZy1tZW1iZXIgZXNoZWxsLWhpc3RvcnktcmluZyAiZWNo byBmb28iKSAwKSkKKyAgICAgIChzaG91bGQgKD0gKHJpbmctbWVtYmVyIGVzaGVsbC1oaXN0b3J5 LXJpbmcgImVjaG8gYmFyIikgMSkpKSkpKQorCisoZXJ0LWRlZnRlc3QgZXNoZWxsLWFkZC1oaXN0 b3J5LWVsZW1lbnQtdG8tbm9uLWVtcHR5LXJpbmctd2l0aC1lcmFzZS1kdXBzLWtlZXBzLW5vbi1k dXBsaWNhdGVzICgpCisgICJUZXN0IHRoYXQgd2hlbiB3ZSBhZGQgYSBuZXcgIGhpc3RvcnkgaXRl bSB0byBhIG5vbiBlbXB0eSBoaXN0b3J5IHJpbmcgd2l0aCBgZXNoZWxsLWhpc3QtaWdub3JlZHVw cycgc2V0IHRvICdlcmFzZSB0aGUgZXhpc3RpbmcgZWxlbWVudHMgYXJlIG5vdCBlcmFzZWQuIgor ICAoZXJ0LXdpdGgtdGVzdC1idWZmZXIgKDpuYW1lICJlc2hlbGwtaGlzdC10ZXN0IikKKyAgICAo bGV0ICgoZXNoZWxsLWhpc3RvcnktcmluZyAobWFrZS1yaW5nIDIpKQorICAgICAgICAgIChlc2hl bGwtaGlzdC1pZ25vcmVkdXBzICdlcmFzZSkpCisgICAgICAoZXNoZWxsLWFkZC1pbnB1dC10by1o aXN0b3J5ICJlY2hvIGZvbyIpCisgICAgICAoZXNoZWxsLWFkZC1pbnB1dC10by1oaXN0b3J5ICJl Y2hvIGJhciIpCisgICAgICAoc2hvdWxkICg9IChyaW5nLWxlbmd0aCBlc2hlbGwtaGlzdG9yeS1y aW5nKSAyKSkKKyAgICAgIChzaG91bGQgKD0gKHJpbmctbWVtYmVyIGVzaGVsbC1oaXN0b3J5LXJp bmcgImVjaG8gZm9vIikgMSkpCisgICAgICAoc2hvdWxkICg9IChyaW5nLW1lbWJlciBlc2hlbGwt aGlzdG9yeS1yaW5nICJlY2hvIGJhciIpIDApKSkpKQorCiAocHJvdmlkZSAnZW0taGlzdC10ZXN0 KQogCiA7OzsgZW0taGlzdC10ZXN0cy5lbCBlbmRzIGhlcmUK --000000000000c899f20619069ea5-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 00:36:46 2024 Received: (at 71107) by debbugs.gnu.org; 23 May 2024 04:36:46 +0000 Received: from localhost ([127.0.0.1]:58334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA0C5-0005uh-Mg for submit@debbugs.gnu.org; Thu, 23 May 2024 00:36:46 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:56737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA0C2-0005ub-CJ for 71107@debbugs.gnu.org; Thu, 23 May 2024 00:36:44 -0400 Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1f335e8d493so839405ad.1 for <71107@debbugs.gnu.org>; Wed, 22 May 2024 21:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716438930; x=1717043730; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=put3T+B3EkAi1XuxElWcBwCQOBbXIYjJ8R+r2luWggQ=; b=dXmqDcvgmLLqQE5M8LKcoaMUvo3el/GuvzdpgeRIpTkMG+xgGhsmWvrzupnvXteYPl r3H3CkWdJNvf3UW+3DCXqBXL7ZjgZR16frEz1J2me5nx5yDlDsbrXexmZfvnj7u/YpBc 9YN5zzekYsnjKFMrwY8jNwzDUlfpJajj/M7zLZpelLqUJiqbfQDxIkjah91FKAxCQQ5L Z7rQC3x8UkqMg8Qps/2I4BWADyVZPFFVtg64kizDKPwb/BeoGVFFNB1Pu6CwedpLNRm1 fIIAdZKtzzrcD1Bc11Y4rnZiiIMe9ckpz+WV77nrwX6k8asTqKiJvcbjothmsPY0Rkkk I8Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716438930; x=1717043730; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=put3T+B3EkAi1XuxElWcBwCQOBbXIYjJ8R+r2luWggQ=; b=YL9NTXHWTNM/no1C/d04pACe4eKPydcYdjE20NwUhwOHpiWeurqjH6RegWnAlQ2H2a G/3GGzsMhLB2WQUgOMDHxEIMLNNhcBVQYLmrqd5hZ5NL6phL7x4MbFFQiLXjac4+5SXE 91MRnRQKbJ0p08e7bRn17UZt/ED9+WBlu5/QjOJ5P4QZeV5geIZHQEoGVF5sqt+t3mAq 323WkfVjtEcuP+ZYA+7y2gr+NFPQcxvfq1n7OrPdbnGQHcZ/i50MKnYX8SMREJ6kiwi4 +Jyx8DxvwwjB1+OrDKSUl34MBtEaQdqQmsuPzbs2AHB7fmF4c9U9SNZux2d33pUnIuZs erAQ== X-Forwarded-Encrypted: i=1; AJvYcCWw9zpoi7Tcvk/1im9aDATQkwd4QLS8HzUrJ/8ZFet3VKP+SFIHJmTo0xfYHQ1A4vekzXCsxeakdYQD44rLToKYpt73vHk= X-Gm-Message-State: AOJu0YxZScWjnmgZ5jiIxU9IcwJoUR1y7NbpFvF0ELKwR7ipax7bzNP4 u8PcfJpwtiPmUSS+TQbaZw/T8okY+YdAicJSdBrUlALy0DAiL7Lw X-Google-Smtp-Source: AGHT+IEukjkxz21sdAhZFyibSYp1WX+8nnGP8qCvR8SN9bgFImYAoc6jIYeY2iAk3JyS27DDfmhpVA== X-Received: by 2002:a17:902:e748:b0:1f3:1ca6:8a49 with SMTP id d9443c01a7336-1f31ca68aacmr45206095ad.65.1716438930014; Wed, 22 May 2024 21:35:30 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f3469384e6sm689305ad.283.2024.05.22.21.35.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 21:35:29 -0700 (PDT) Message-ID: Date: Wed, 22 May 2024 21:35:29 -0700 MIME-Version: 1.0 Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Content-Language: en-US To: Robin Campbell Joy , 71107@debbugs.gnu.org References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/22/2024 1:21 AM, Robin Campbell Joy wrote: > Severity: minor > Tags: patch > > In case of eshell-hist-ingoredups set to 'erase, history handling isn't > working correctly. I believe this should already be fixed by commit 7b0f24ab1f9 from bug#63360. However, I didn't bother to account for the case where there may be multiple entries to remove (I just added a FIXME note since it seemed like a low priority). If removing multiple duplicates is important to you, would you be willing to rebase your patch on top of the master branch? Thanks either way. From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 02:23:05 2024 Received: (at 71107) by debbugs.gnu.org; 23 May 2024 06:23:06 +0000 Received: from localhost ([127.0.0.1]:58487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA1qz-0007BV-Iv for submit@debbugs.gnu.org; Thu, 23 May 2024 02:23:05 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:44534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA1qv-0007B8-DS for 71107@debbugs.gnu.org; Thu, 23 May 2024 02:23:04 -0400 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f32448e8fbso10900215ad.1 for <71107@debbugs.gnu.org>; Wed, 22 May 2024 23:22:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716445369; x=1717050169; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xrUj6GsiNES4pC8w6X24eBIChPQ7xqaiaZiqlEI9tBM=; b=Nz2ZmNN8I9NPTl/13iAPAgtRY/3iDQiGCbn3uSpKtAUiCu8edp6LybS60HHRRt/egr XD3kzOV7rsd1kXE+FjSRTyFl0rxvhyG78d8T5AseAGhwvjq7a6n01E4a3vM8pGelAqCw HIbKOsw+afMET2YcPq2z11F6fEC5yo8qRhimhDWvoyNNGvf7NBi9hLpAyr7qALG7RMzS Fjjd6dvReyL50h4qidfAY+mYOwMIJscfjMDndAfQDssQTFIG9QWfKBoP6FIRW9YqtrnI kVg+5vyPowKjEyy3TW5w3fudMCDPMFhUA4yxRRcdj4eBkhhZE9lTDh+SuMM90c1MjXCj TV7A== X-Gm-Message-State: AOJu0YwbtnKDPm7h0dPNeUZBaomnLn/UElTDM87RVAzZXovqJyLoVpBV UzHuD6zzeS6uBx6qyIk9qlqvuegv3asmy4aDdtJEnWoC4l12N3BxjxtPna0bqTqsxvoQBM4IovB tpvLGLSqs4CKRbdhy2WtpQZQyhG8+VnCwN2YU1jqv1D0LiIRq X-Google-Smtp-Source: AGHT+IGUdlqw8LwZp5Ewu2Fj1LH88QNBSAa8yPbSQRrelvlAx0VqvZKDodv/ncPzXpV1r4UUjivWH5L+e7s65Q41I4c= X-Received: by 2002:a17:902:64d7:b0:1f3:2204:c4e5 with SMTP id d9443c01a7336-1f32204c607mr37922435ad.17.1716445369327; Wed, 22 May 2024 23:22:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robin Campbell Joy Date: Thu, 23 May 2024 08:22:37 +0200 Message-ID: Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase To: Jim Porter Content-Type: multipart/mixed; boundary="0000000000008414cc0619191486" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107 Cc: 71107@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008414cc0619191486 Content-Type: multipart/alternative; boundary="0000000000008414cb0619191484" --0000000000008414cb0619191484 Content-Type: text/plain; charset="UTF-8" On Thu, 23 May 2024 at 06:35, Jim Porter wrote: > I believe this should already be fixed by commit 7b0f24ab1f9 from > bug#63360. > > However, I didn't bother to account for the case where there may be > multiple entries to remove (I just added a FIXME note since it seemed > like a low priority). If removing multiple duplicates is important to > you, would you be willing to rebase your patch on top of the master > branch? Thanks either way. > Thanks, not sure why I didn't find this when looking for an existing bug, should have checked master first though. Attached the rebased patch. Thanks for fixing this. --0000000000008414cb0619191484 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, 23 May 2024 at 06:35, Jim Porter = <jporterbugs@gmail.com> = wrote:
I believe this should already be fixed by commit 7b0f24ab1f9 from bug#63360= .

However, I didn't bother to account for the case where there may be multiple entries to remove (I just added a FIXME note since it seemed
like a low priority). If removing multiple duplicates is important to
you, would you be willing to rebase your patch on top of the master
branch? Thanks either way.

Thanks, not = sure why I didn't find this when looking for an existing bug, should ha= ve checked master first though.

Attached the rebas= ed patch. Thanks for fixing this.=C2=A0
--0000000000008414cb0619191484-- --0000000000008414cc0619191486 Content-Type: application/octet-stream; name="eshell-hist-ignoredups.patch" Content-Disposition: attachment; filename="eshell-hist-ignoredups.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwiv7rw70 ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwgYi9saXNwL2VzaGVsbC9lbS1oaXN0 LmVsCmluZGV4IDIxMDI5ZWFlMWJjLi5iMTcxYTI4NTBmZiAxMDA2NDQKLS0tIGEvbGlzcC9lc2hl bGwvZW0taGlzdC5lbAorKysgYi9saXNwL2VzaGVsbC9lbS1oaXN0LmVsCkBAIC0zOTgsMTEgKzM5 OCw5IEBAIGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9yeQogICAgICAgICAgICAgIChwY2FzZSBl c2hlbGwtaGlzdC1pZ25vcmVkdXBzCiAgICAgICAgICAgICAgICAoJ25pbCB0KSAgICAgICAgICAg ICAgICAgOyBBbHdheXMgYWRkIHRvIGhpc3RvcnkKICAgICAgICAgICAgICAgICgnZXJhc2UgICAg ICAgICAgICAgICAgICA7IEFkZCwgcmVtb3ZpbmcgYW55IG9sZCBvY2N1cnJlbmNlcwotICAgICAg ICAgICAgICAgICh3aGVuLWxldCAoKG9sZC1pbmRleCAocmluZy1tZW1iZXIgZXNoZWxsLWhpc3Rv cnktcmluZyBpbnB1dCkpKQotICAgICAgICAgICAgICAgICAgOzsgUmVtb3ZlIHRoZSBvbGQgb2Nj dXJyZW5jZSBvZiB0aGlzIGlucHV0IHNvIHdlIGNhbgotICAgICAgICAgICAgICAgICAgOzsgYWRk IGl0IHRvIHRoZSBlbmQuICBGSVhNRTogU2hvdWxkIHdlIHRyeSB0bwotICAgICAgICAgICAgICAg ICAgOzsgcmVtb3ZlIG11bHRpcGxlIG9sZCBvY2N1cnJlbmNlcywgZS5nLiBpZiB0aGUgdXNlcgot ICAgICAgICAgICAgICAgICAgOzsgcmVjZW50bHkgY2hhbmdlZCB0byB1c2luZyBgZXJhc2UnPwor ICAgICAgICAgICAgICAgICh3aGlsZS1sZXQgKChvbGQtaW5kZXggKHJpbmctbWVtYmVyIGVzaGVs bC1oaXN0b3J5LXJpbmcgaW5wdXQpKSkKKyAgICAgICAgICAgICAgICAgIDs7IFJlbW92ZSB0aGUg b2xkIG9jY3VycmVuY2VzIG9mIHRoaXMgaW5wdXQgc28gd2UgY2FuCisgICAgICAgICAgICAgICAg ICA7OyBhZGQgaXQgdG8gdGhlIGVuZC4KICAgICAgICAgICAgICAgICAgIChyaW5nLXJlbW92ZSBl c2hlbGwtaGlzdG9yeS1yaW5nIG9sZC1pbmRleCkpCiAgICAgICAgICAgICAgICAgdCkKICAgICAg ICAgICAgICAgIChfICAgICAgICAgICAgICAgICAgICAgICA7IEFkZCBpZiBub3QgYWxyZWFkeSB0 aGUgbGF0ZXN0IGVudHJ5CmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVz dHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVzdHMuZWwKaW5kZXggYTRlMWUwMWIx MjQuLjQwZTZmOTA0NzhkIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVz dHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1oaXN0LXRlc3RzLmVsCkBAIC0xNjMsNiAr MTYzLDIzIEBAIGVtLWhpc3QtdGVzdC9hZGQtdG8taGlzdG9yeS9lcmFzZS1kdXBzCiAgICAgIChz aG91bGQgKGVxdWFsIChyaW5nLWVsZW1lbnRzIGVzaGVsbC1oaXN0b3J5LXJpbmcpCiAgICAgICAg ICAgICAgICAgICAgICcoImVjaG8gaGkiICJlY2hvIGJ5ZSIpKSkpKSkKIAorKGVydC1kZWZ0ZXN0 IGVtLWhpc3QtdGVzdC9hZGQtdG8taGlzdG9yeS9lcmFzZS1leGlzdGluZy1kdXBzICgpCisgICJU ZXN0IGFkZGluZyB0byBoaXN0b3J5LCBlcmFzaW5nIGFueSBvbGQgZHVwcyBhZnRlciBzd2l0Y2hp bmcgdG8gJ2VyYXNlLiIKKyAgKGxldCAoKGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMgbmlsKSkKKyAg ICAod2l0aC10ZW1wLWVzaGVsbAorICAgICAoZXNoZWxsLWluc2VydC1jb21tYW5kICJlY2hvIGhp IikKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29tbWFuZCAiZWNobyBieWUiKQorICAgICAoZXNoZWxs LWluc2VydC1jb21tYW5kICJlY2hvIGJ5ZSIpCisgICAgIChlc2hlbGwtaW5zZXJ0LWNvbW1hbmQg ImVjaG8gaGkiKQorICAgICAoZXNoZWxsLWluc2VydC1jb21tYW5kICJlY2hvIGJ5ZSIpCisgICAg IChzZXRxIGVzaGVsbC1oaXN0LWlnbm9yZWR1cHMgJ2VyYXNlKQorICAgICAoZXNoZWxsLWluc2Vy dC1jb21tYW5kICJlY2hvIGhpIikKKyAgICAgKHNob3VsZCAoZXF1YWwgKHJpbmctZWxlbWVudHMg ZXNoZWxsLWhpc3RvcnktcmluZykKKyAgICAgICAgICAgICAgICAgICAgJygiZWNobyBoaSIgImVj aG8gYnllIiAiZWNobyBieWUiICJlY2hvIGJ5ZSIpKSkKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29t bWFuZCAiZWNobyBieWUiKQorICAgICAoc2hvdWxkIChlcXVhbCAocmluZy1lbGVtZW50cyBlc2hl bGwtaGlzdG9yeS1yaW5nKQorICAgICAgICAgICAgICAgICAgICAnKCJlY2hvIGJ5ZSIgImVjaG8g aGkiKSkpKSkpCisKIChwcm92aWRlICdlbS1oaXN0LXRlc3QpCiAKIDs7OyBlbS1oaXN0LXRlc3Rz LmVsIGVuZHMgaGVyZQo= --0000000000008414cc0619191486-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 19:35:12 2024 Received: (at 71107) by debbugs.gnu.org; 23 May 2024 23:35:12 +0000 Received: from localhost ([127.0.0.1]:33359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAHxn-0000OJ-T6 for submit@debbugs.gnu.org; Thu, 23 May 2024 19:35:12 -0400 Received: from mail-pl1-f170.google.com ([209.85.214.170]:50672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAHxh-0000Nj-Oz for 71107@debbugs.gnu.org; Thu, 23 May 2024 19:35:09 -0400 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1f44b513017so1904145ad.1 for <71107@debbugs.gnu.org>; Thu, 23 May 2024 16:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716507233; x=1717112033; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=yCsyrSHNQWsFr3n5s2v8vS0ID77/pnICv3PV3gtIj6E=; b=TNJeCAO4HEK9Bs/9LJ10pV9rWwNaG/TTGdy1/n7UCrKFWrkR4oX7ux4FBVOluGIkst DNecUXhJCGUe29WPrPluVG03h/IksUFWOuXCV8l5gpT3Te7DwRNAe8r9bh3Rsmjgu8fF aUJiMKxxAqR3U+VnpmgEsHQZAsAFQvcdna32IRL8vUdlWrBdfMVUKl16i8z15x6JI/wz 9Lji0ZW3PmaFh8jquvNoUnFVqLndt3tELjRXPntERozqOOBSWqAfTfZYTFjYM2ScE2D8 tvEyW96CkMxCVn20tX1TwoK+nGdKQ8OqAu5ZxYcacpLu4qWJHEM6SpyYbTEyDVMsb5Cr K3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716507233; x=1717112033; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yCsyrSHNQWsFr3n5s2v8vS0ID77/pnICv3PV3gtIj6E=; b=erQXWQCryIQsF+nuIG5DFhGZTpbi8/VNSuf6w3bFAM0mvK9bhEm6LQfpUkHWvKOwdW qWL/jfwEr7Akdg1MIi5RvD/fjKG8wK0Vo+XyHdw5oFTRt9MUakyxa6noWEs7SIc4IlnW F4BJ9H90ZqqZ2Fu/mb1H3VZFzDhy8xD+O3qNmmqIUSnDTNssNOP/eLDz+TVyB2GJKKL+ GZyEFp42bKnilFo3+xHB/PiFUUy84+hywr2tEMMkE71MoprUwtTT+zyinmiLjbQIXEtB 8d2UTq72zN6KC8DJxcezmigjXg/UMniNhUMKEG0kKb076/lsNh7Obs4JA+z8i3N3TAYg ELNg== X-Gm-Message-State: AOJu0YwLOkvHpbTYbqMHl61+jqE+yrcdNF42kITa6ErIrB49wiyie7iH FLUifQ6jTQWcwc2iz7QQWZjvf+52QkaiIdrcwePlLcqIifwVuZe6 X-Google-Smtp-Source: AGHT+IFAk363lkzqmmR+kizSq07CtA1XTu4BJdhUgCmRlSpA67o29Non1R8InKjV6IB8ANqpkbD+pA== X-Received: by 2002:a17:903:18a:b0:1e4:3df0:38a5 with SMTP id d9443c01a7336-1f4498e13f2mr8115265ad.65.1716507233126; Thu, 23 May 2024 16:33:53 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f44c7bb389sm1357035ad.92.2024.05.23.16.33.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 16:33:52 -0700 (PDT) Message-ID: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> Date: Thu, 23 May 2024 16:33:51 -0700 MIME-Version: 1.0 Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Content-Language: en-US To: Robin Campbell Joy References: From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107 Cc: 71107@debbugs.gnu.org, eli@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/22/2024 11:22 PM, Robin Campbell Joy wrote: > Thanks, not sure why I didn't find this when looking for an existing > bug, should have checked master first though. > > Attached the rebased patch. Thanks for fixing this. Thanks for the updated patch. From a visual inspection, this all looks good to me. Just two small things and then I think this is good to merge: 1) Could you add a commit message in the usual style (you can look at the other Emacs commits to get an idea of what these look like), and then generate the patch file with `git format-patch master`? This'll make it easier for me to apply the patch without having to write up a commit message myself. 2) Have you filled out copyright assignment paperwork with the FSF? While the code changes are below the maximum (15 lines) for no paperwork, the tests push it over. (I'm not 100% sure if we count test code for the copyright stuff.) I don't think I can check the paperwork status for people myself, but hopefully Eli (CCed) can help if needed. From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 01:58:31 2024 Received: (at 71107) by debbugs.gnu.org; 24 May 2024 05:58:31 +0000 Received: from localhost ([127.0.0.1]:35074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sANwk-00046Y-L0 for submit@debbugs.gnu.org; Fri, 24 May 2024 01:58:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sANwg-00046S-6t for 71107@debbugs.gnu.org; Fri, 24 May 2024 01:58:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sANuN-0005QQ-TN; Fri, 24 May 2024 01:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GOstXLEVC/ZdTDKfE/L1+2y/M79iHRP5OnE8IROSCX4=; b=hue3ArIsxHYJ fYVRK0Dt8mYDEZVeoOnyKuEuwJBscZRbRP2ZPca32cO2yTzYihvYZ3PPP8dMpVOZXAHCakmmUihSY g+8e/IdpgJ+wWuwPmXv3epaP3WznnMKYdwby/pLHgV1xwuxCTczMSGhMgDvVNn61B33EIpVjCRCEe lAVeQ1U7PXeyOsPd6bI80T6wKfYaKwqN/lFQX9hW10njq57B0rp7al9CbF60TJDmzAoMR1Iyc1EQj 0U+bJa+zdtFCxvPG2xPPYmhlPV3E1eSbCKhHesa+GKyB6s5cY+wyl89AejBqeA/7fmwxzxCwDcKF2 FZ3wMZldBAiAaxwCsbL97w==; Date: Fri, 24 May 2024 08:55:47 +0300 Message-Id: <86y17z3g9o.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> (message from Jim Porter on Thu, 23 May 2024 16:33:51 -0700) Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase References: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71107 Cc: emacs@robinjoy.net, 71107@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 71107@debbugs.gnu.org, eli@gnu.org > Date: Thu, 23 May 2024 16:33:51 -0700 > From: Jim Porter > > 2) Have you filled out copyright assignment paperwork with the FSF? > While the code changes are below the maximum (15 lines) for no > paperwork, the tests push it over. (I'm not 100% sure if we count test > code for the copyright stuff.) I don't think I can check the paperwork > status for people myself, but hopefully Eli (CCed) can help if needed. Robin's assignment is on file, so we can accept this and other contributions without limitations. From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 08:30:27 2024 Received: (at 71107) by debbugs.gnu.org; 24 May 2024 12:30:27 +0000 Received: from localhost ([127.0.0.1]:36897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAU43-0004iF-52 for submit@debbugs.gnu.org; Fri, 24 May 2024 08:30:27 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:56679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAU40-0004i9-NW for 71107@debbugs.gnu.org; Fri, 24 May 2024 08:30:25 -0400 Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f335e8d493so6167275ad.1 for <71107@debbugs.gnu.org>; Fri, 24 May 2024 05:30:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716553812; x=1717158612; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ps75nQIRgJskESp/CeEC38P1n46W50bsL/PvHpj4dCo=; b=SbmuG7ml65A/7kZ5tbX66DpvR9fX3YRIhWljiYW8VtNTa72LWEdcp2qnGwqIoAsGvD YoZ4z6AHu5/XRn/f1bAFBlUnUfdnBu4//WJxgQu99z8W0Sb/4gWW5Wzr+iPQxPNhBvS+ gKPuH+sCgFLzrrGQQAHzkNDxXhij8QMH5ZljkkgWA/bwNfLOuwgtBKzf2dUFV1wB0Hjq DQVkVQs5hQzG9vZO3XM3uP6WUBPe4pgjIAZj78C/ROAvdERADOcSAPbSH/9Wy0dgzV0R uysf8mKoTwNvDQO5MqjpyauyofVXeaemdX2WTm2z1u06vHIwSCBNwTimzihkdVj28YRo WXUA== X-Gm-Message-State: AOJu0YywT+BCYHtgYc/w8BsbXvFfnHORfDraMSJh85Ik8DH4tbAlrVu0 OXDMgssjeBIxjPwMirNRNQtaDDAwz+wlFbbqSARIsZZaWKaBBTe2MAtIQxK7A/hZOTfW308Va/I T1Vu+mxodqMzY1gCPiiiUVtjd078DH84bA5T0+Q== X-Google-Smtp-Source: AGHT+IGZqDuEDmHnUuPPqIMy4ECy66OkeYLWqE4naiEum9LSAkytmTN5yA9WH9Dy6pXL1e5yz/L4Ya13ce1pEtdTTEE= X-Received: by 2002:a17:90a:fb8b:b0:2bd:d6c3:9e39 with SMTP id 98e67ed59e1d1-2bf5ee17dc4mr1992589a91.16.1716553811669; Fri, 24 May 2024 05:30:11 -0700 (PDT) MIME-Version: 1.0 References: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> In-Reply-To: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> From: Robin Campbell Joy Date: Fri, 24 May 2024 14:29:59 +0200 Message-ID: Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase To: Jim Porter Content-Type: multipart/mixed; boundary="0000000000002ef246061932545c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107 Cc: 71107@debbugs.gnu.org, eli@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002ef246061932545c Content-Type: multipart/alternative; boundary="0000000000002ef245061932545a" --0000000000002ef245061932545a Content-Type: text/plain; charset="UTF-8" On Fri, 24 May 2024 at 01:33, Jim Porter wrote: > On 5/22/2024 11:22 PM, Robin Campbell Joy wrote: > > Thanks, not sure why I didn't find this when looking for an existing > > bug, should have checked master first though. > > > > Attached the rebased patch. Thanks for fixing this. > > Thanks for the updated patch. From a visual inspection, this all looks > good to me. > > Just two small things and then I think this is good to merge: > > 1) Could you add a commit message in the usual style (you can look at > the other Emacs commits to get an idea of what these look like), and > then generate the patch file with `git format-patch master`? This'll > make it easier for me to apply the patch without having to write up a > commit message myself. > Sure, hope this will do. --0000000000002ef245061932545a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, 24 May 2024 at 01:33, Jim Porter = <jporterbugs@gmail.com> = wrote:
On 5/22/2024 11= :22 PM, Robin Campbell Joy wrote:
> Thanks, not sure why I didn't find this when looking for an existi= ng
> bug, should have checked master first though.
>
> Attached the rebased patch. Thanks for fixing this.

Thanks for the updated patch. From a visual inspection, this all looks
good to me.

Just two small things and then I think this is good to merge:

1) Could you add a commit message in the usual style (you can look at
the other Emacs commits to get an idea of what these look like), and
then generate the patch file with `git format-patch master`? This'll make it easier for me to apply the patch without having to write up a
commit message myself.

Sure, hope this = will do.=C2=A0
--0000000000002ef245061932545a-- --0000000000002ef246061932545c Content-Type: application/octet-stream; name="0001-Erase-existing-duplicates-in-eshell-history-ring.patch" Content-Disposition: attachment; filename="0001-Erase-existing-duplicates-in-eshell-history-ring.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwknssad0 RnJvbSA1MDgwYWQyYzFjNzA2YzQxMTBlZTNhNTc0MjJmMWJjZjk5OGNmYmJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JpbiBKb3kgPGVtYWNzQHJvYmluam95Lm5ldD4KRGF0ZTog RnJpLCAyNCBNYXkgMjAyNCAxNDoyNjozOSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEVyYXNlIGV4 aXN0aW5nIGR1cGxpY2F0ZXMgaW4gZXNoZWxsLWhpc3RvcnktcmluZwoKRXJhc2UgYWxsIGV4aXN0 aW5nIGR1cGxpY2F0ZXMgaW5zdGVhZCBvZiBqdXN0IHRoZSBsYXN0IGR1cGxpY2F0ZSBlbnRyeQp3 aGVuIGBlc2hlbGwtaGlzdC1pZ25vcmVkdXBzYCBpcyBzZXQgdG8gJ2VyYXNlLiBNdWx0aXBsZSBk dXBsaWNhdGVzIGNhbgpleGlzdCBpbiBjYXNlIGBlc2hlbGwtaGlzdC1pZ25vcmVkdXBzYCB3YXMg c2V0IHRvIHNvbWV0aGluZyBlbHNlIHRoYW4KJ2VyYXNlIGluIHRoZSBwYXN0IG9yIGlmIHRoZSBo aXN0b3J5IGZpbGUgY29udGFpbnMgZHVwbGljYXRlcy4KCiogbGlzcC9lc2hlbGwvZW0taGlzdC5l bCAoZXNoZWxsLWFkZC1pbnB1dC10by1oaXN0b3J5KTogUmVtb3ZlIGFsbApkdXBsaWNhdGVzIGZy b20gaGlzdG9yeSByaW5nLgoKKiB0ZXN0L2xpc3AvZXNoZWxsL2VtLWhpc3QtdGVzdHMuZWwgKGVy YXNlLWV4aXN0aW5nLWR1cHMpOiBOZXcgdGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lbS1oaXN0LmVs ICAgICAgICAgICAgfCAgOCArKystLS0tLQogdGVzdC9saXNwL2VzaGVsbC9lbS1oaXN0LXRlc3Rz LmVsIHwgMTcgKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1oaXN0LmVs IGIvbGlzcC9lc2hlbGwvZW0taGlzdC5lbAppbmRleCAyMTAyOWVhZTFiYy4uYjE3MWEyODUwZmYg MTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0t aGlzdC5lbApAQCAtMzk4LDExICszOTgsOSBAQCBlc2hlbGwtYWRkLWlucHV0LXRvLWhpc3RvcnkK ICAgICAgICAgICAgICAocGNhc2UgZXNoZWxsLWhpc3QtaWdub3JlZHVwcwogICAgICAgICAgICAg ICAgKCduaWwgdCkgICAgICAgICAgICAgICAgIDsgQWx3YXlzIGFkZCB0byBoaXN0b3J5CiAgICAg ICAgICAgICAgICAoJ2VyYXNlICAgICAgICAgICAgICAgICAgOyBBZGQsIHJlbW92aW5nIGFueSBv bGQgb2NjdXJyZW5jZXMKLSAgICAgICAgICAgICAgICAod2hlbi1sZXQgKChvbGQtaW5kZXggKHJp bmctbWVtYmVyIGVzaGVsbC1oaXN0b3J5LXJpbmcgaW5wdXQpKSkKLSAgICAgICAgICAgICAgICAg IDs7IFJlbW92ZSB0aGUgb2xkIG9jY3VycmVuY2Ugb2YgdGhpcyBpbnB1dCBzbyB3ZSBjYW4KLSAg ICAgICAgICAgICAgICAgIDs7IGFkZCBpdCB0byB0aGUgZW5kLiAgRklYTUU6IFNob3VsZCB3ZSB0 cnkgdG8KLSAgICAgICAgICAgICAgICAgIDs7IHJlbW92ZSBtdWx0aXBsZSBvbGQgb2NjdXJyZW5j ZXMsIGUuZy4gaWYgdGhlIHVzZXIKLSAgICAgICAgICAgICAgICAgIDs7IHJlY2VudGx5IGNoYW5n ZWQgdG8gdXNpbmcgYGVyYXNlJz8KKyAgICAgICAgICAgICAgICAod2hpbGUtbGV0ICgob2xkLWlu ZGV4IChyaW5nLW1lbWJlciBlc2hlbGwtaGlzdG9yeS1yaW5nIGlucHV0KSkpCisgICAgICAgICAg ICAgICAgICA7OyBSZW1vdmUgdGhlIG9sZCBvY2N1cnJlbmNlcyBvZiB0aGlzIGlucHV0IHNvIHdl IGNhbgorICAgICAgICAgICAgICAgICAgOzsgYWRkIGl0IHRvIHRoZSBlbmQuCiAgICAgICAgICAg ICAgICAgICAocmluZy1yZW1vdmUgZXNoZWxsLWhpc3RvcnktcmluZyBvbGQtaW5kZXgpKQogICAg ICAgICAgICAgICAgIHQpCiAgICAgICAgICAgICAgICAoXyAgICAgICAgICAgICAgICAgICAgICAg OyBBZGQgaWYgbm90IGFscmVhZHkgdGhlIGxhdGVzdCBlbnRyeQpkaWZmIC0tZ2l0IGEvdGVzdC9s aXNwL2VzaGVsbC9lbS1oaXN0LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9lbS1oaXN0LXRl c3RzLmVsCmluZGV4IGE0ZTFlMDFiMTI0Li40MGU2ZjkwNDc4ZCAxMDA2NDQKLS0tIGEvdGVzdC9s aXNwL2VzaGVsbC9lbS1oaXN0LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lc2hlbGwvZW0taGlz dC10ZXN0cy5lbApAQCAtMTYzLDYgKzE2MywyMyBAQCBlbS1oaXN0LXRlc3QvYWRkLXRvLWhpc3Rv cnkvZXJhc2UtZHVwcwogICAgICAoc2hvdWxkIChlcXVhbCAocmluZy1lbGVtZW50cyBlc2hlbGwt aGlzdG9yeS1yaW5nKQogICAgICAgICAgICAgICAgICAgICAnKCJlY2hvIGhpIiAiZWNobyBieWUi KSkpKSkpCiAKKyhlcnQtZGVmdGVzdCBlbS1oaXN0LXRlc3QvYWRkLXRvLWhpc3RvcnkvZXJhc2Ut ZXhpc3RpbmctZHVwcyAoKQorICAiVGVzdCBhZGRpbmcgdG8gaGlzdG9yeSwgZXJhc2luZyBhbnkg b2xkIGR1cHMgYWZ0ZXIgc3dpdGNoaW5nIHRvICdlcmFzZS4iCisgIChsZXQgKChlc2hlbGwtaGlz dC1pZ25vcmVkdXBzIG5pbCkpCisgICAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgICAgKGVzaGVsbC1p bnNlcnQtY29tbWFuZCAiZWNobyBoaSIpCisgICAgIChlc2hlbGwtaW5zZXJ0LWNvbW1hbmQgImVj aG8gYnllIikKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29tbWFuZCAiZWNobyBieWUiKQorICAgICAo ZXNoZWxsLWluc2VydC1jb21tYW5kICJlY2hvIGhpIikKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29t bWFuZCAiZWNobyBieWUiKQorICAgICAoc2V0cSBlc2hlbGwtaGlzdC1pZ25vcmVkdXBzICdlcmFz ZSkKKyAgICAgKGVzaGVsbC1pbnNlcnQtY29tbWFuZCAiZWNobyBoaSIpCisgICAgIChzaG91bGQg KGVxdWFsIChyaW5nLWVsZW1lbnRzIGVzaGVsbC1oaXN0b3J5LXJpbmcpCisgICAgICAgICAgICAg ICAgICAgICcoImVjaG8gaGkiICJlY2hvIGJ5ZSIgImVjaG8gYnllIiAiZWNobyBieWUiKSkpCisg ICAgIChlc2hlbGwtaW5zZXJ0LWNvbW1hbmQgImVjaG8gYnllIikKKyAgICAgKHNob3VsZCAoZXF1 YWwgKHJpbmctZWxlbWVudHMgZXNoZWxsLWhpc3RvcnktcmluZykKKyAgICAgICAgICAgICAgICAg ICAgJygiZWNobyBieWUiICJlY2hvIGhpIikpKSkpKQorCiAocHJvdmlkZSAnZW0taGlzdC10ZXN0 KQogCiA7OzsgZW0taGlzdC10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuNDUuMQoK --0000000000002ef246061932545c-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 22:37:03 2024 Received: (at 71107-done) by debbugs.gnu.org; 25 May 2024 02:37:03 +0000 Received: from localhost ([127.0.0.1]:40465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhHL-0000yc-IH for submit@debbugs.gnu.org; Fri, 24 May 2024 22:37:03 -0400 Received: from mail-il1-f173.google.com ([209.85.166.173]:59879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhHJ-0000y6-Um for 71107-done@debbugs.gnu.org; Fri, 24 May 2024 22:37:02 -0400 Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3737ee27cc9so5107325ab.3 for <71107-done@debbugs.gnu.org>; Fri, 24 May 2024 19:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716604549; x=1717209349; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=uNxZKSI0H/2W57uyldO0o0smqR7KfKcL6qRLtXnGnAc=; b=k6CXDBUrHCi5gnLnFagI4iweFzBjtxggSWVvD2Ie8UCjPsmwZN1sZp6D+XsxMvFqh6 zvwR8vrBdtlVIEOQ1PymJn2Cjs5402tZqEanj/WUf5jshFbPsPq3Iwpmfxpt0bvnYZdV RyIkdyRBimbbyP4GUZH5T07Slt4haiQJaIGqs2/SvrQ4VU68IMV1QUq9kYh/FEsf+VBL hRT9Ri884MNv8KRSn2FW+tJ+0ZIWTBSbRzqQrgHilBTVv6k4ac34IS/PW9h3nbIUdioL FgQA4LKF6KmFHe70Trxv4VlBFufoFdEzUnKd+wCHBQEqdku30PjM9sAWszGnkyQmVLmz YMKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716604549; x=1717209349; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uNxZKSI0H/2W57uyldO0o0smqR7KfKcL6qRLtXnGnAc=; b=pJeXp29qJuaiNF4Zqbd9nIShe07SvX7kSNPubC8Nkx2SbR29cVY7acmEGnZF1U2cqZ qDA/ngZYIJGsd7p5lyYL/vRyYNoZmwcpyEIzvQkayEsJW+718C1uufLCBQ3Fm+zFrGgx rhnHKAypsXzdCjZW9VVujkMUTTwfngA9LL6JI9UeSt8lVPYBXY2gNngGkZlnEHR3OJ9v 3poyCAVd+x6kTE/WEq14E4ckXWSo72ga8MzsQSodmavJ9c3wBeYP+oKXzhtuvDHdh44A xEcRo7yVdg1PPfnEyOLdrzk2sftgZhF8HY+6bTgIvJFUv12nYsKgHSONt/kWcXLcYgzO fesA== X-Gm-Message-State: AOJu0Yw7XVKHGnhQ9Silc3rGwEujblCob7CTyxZioo0crJ0y3J0Tp0Ii ucxTA10YKdIpN+SPQ5EFu+n+udJBhjDl4/QDWNFEHKcbfcbeHGLB X-Google-Smtp-Source: AGHT+IFlih5jsLH0hHC+hbN8d9hIo3uv+HaIE4pdmlhAFwGmfLsPAIjdNyn78m2KkTBJQwRLbdFS5A== X-Received: by 2002:a05:6e02:12cd:b0:36d:b4bf:9b51 with SMTP id e9e14a558f8ab-3737b333769mr51277655ab.29.1716604548944; Fri, 24 May 2024 19:35:48 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-68226a133d0sm1832449a12.62.2024.05.24.19.35.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 19:35:48 -0700 (PDT) Message-ID: <14ed1c61-5569-41bf-d02a-40479df20634@gmail.com> Date: Fri, 24 May 2024 19:35:48 -0700 MIME-Version: 1.0 Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Content-Language: en-US To: Robin Campbell Joy References: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107-done Cc: eli@gnu.org, 71107-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/24/2024 5:29 AM, Robin Campbell Joy wrote: > Sure, hope this will do. Thanks, that looks good to me. I've merged your patch to the master branch as 984fb346fdf. Closing this bug now. From debbugs-submit-bounces@debbugs.gnu.org Fri May 24 22:39:32 2024 Received: (at 71107) by debbugs.gnu.org; 25 May 2024 02:39:32 +0000 Received: from localhost ([127.0.0.1]:40484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhJk-00010C-1j for submit@debbugs.gnu.org; Fri, 24 May 2024 22:39:32 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:47415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAhJi-000106-1M for 71107@debbugs.gnu.org; Fri, 24 May 2024 22:39:30 -0400 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6fcbd812b33so323028b3a.3 for <71107@debbugs.gnu.org>; Fri, 24 May 2024 19:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716604697; x=1717209497; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=LEiF0SP0skYDEAPTIBSFMk2yo7QPK5c+Zb2tS242H1U=; b=cBpxL3iLLmWcrYKnKHeNbpaYWJdUrsvm45a6ANDzYFV/F9xr7+7VdjywGGYFretHtL M4LggGmCUPmlYbkZweVBLQ+od/zzeLfiC1kbYsDncPCaixIrH4ghHHUvM1aMhjGj+ySH 04S8MH8YCUek9cIbplvMCx4r/MNRrdciWXuHPMy4E81PJkzfppU6s47AI58Dp4oMzqa2 ALkfZCTAjXSI43hirS3iZI1dYevfSZkPIxz9ErTcmhn/6m+j+3sabnYWqic4V2T+plJr iTXa/F6hn40yYzSEsc71U6LIJS/p1iqSq7G4PxxEx89yJfha+DRlOMy/RvYOfnn8+NTj LkHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716604697; x=1717209497; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LEiF0SP0skYDEAPTIBSFMk2yo7QPK5c+Zb2tS242H1U=; b=nlQqMzwNnzUBnO62LElt8KtQ3JvgKGhOWcSVnIiA9ktYEKmNrjI5ev1pCi5tGSBKdY anv2pSTvduJfF0xAAqMMhxkC9SUr0FwDmbZoQ1UPBPTDkuUqHci6X0NwMpaL/Vsg17E6 wFrrAJWoFZVf9lTb46EFhgKTNT6Q4XE6yj0J3IWYecp/f2NgqQRQqFA94Q8UTpEpZfM6 maJKlGolm+GitMj4rx8729vtuyO608gcRlD2dP9PyGukkDzZEmBeYt0td3tOifA+oFYm NxA7Z66PYJWWkG3GCRTabGv0dt9sZU8eKq5sj7+7pbiOJR8/utF8G2gsM0gi1EhC+COI 6TEQ== X-Forwarded-Encrypted: i=1; AJvYcCVMTrmroiT4YzGh3fO8RPWaiw24wkInZB6j6ZOYmDvYdrRe+CIVj7uIy9w+azCspz4bv5TEKOWDC0foIq89LobhzMYrJ/g= X-Gm-Message-State: AOJu0YwtZvloyCDrgJCo6uMLLkKNHTFPZ7jDbBDDGab7ypKoE1ANWqpW dKEoWSQVH0OYBp3n3BXA9Gy3CBoLeyl/5+/u/XTUl3rkO6vuBWqOJwcTFA== X-Google-Smtp-Source: AGHT+IF6Q7jx+/xWMnIi+BShSt4MDuUTGeFPoYTZsm9iLId0rDnNJPxo3jZbTanlYI5Gv16DHSA4sw== X-Received: by 2002:a05:6a00:3311:b0:6f0:28a4:a871 with SMTP id d2e1a72fcca58-6f8f3921119mr4066121b3a.19.1716604696831; Fri, 24 May 2024 19:38:16 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-682229da8a3sm1863523a12.48.2024.05.24.19.38.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 May 2024 19:38:16 -0700 (PDT) Message-ID: Date: Fri, 24 May 2024 19:38:16 -0700 MIME-Version: 1.0 Subject: Re: bug#71107: 29.3; eshell-hist/Incorrect history handling with eshell-hist-ignoredups 'erase Content-Language: en-US To: Eli Zaretskii References: <634c838e-9a20-816f-d786-d01ccf75b5e1@gmail.com> <86y17z3g9o.fsf@gnu.org> From: Jim Porter In-Reply-To: <86y17z3g9o.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71107 Cc: emacs@robinjoy.net, 71107@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5/23/2024 10:55 PM, Eli Zaretskii wrote: > Robin's assignment is on file, so we can accept this and other > contributions without limitations. Thanks for checking. From unknown Sun Aug 17 09:11:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Jun 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator