From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 12:30:44 2010 Received: (at submit) by debbugs.gnu.org; 26 Sep 2010 16:30:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ozu7g-00059p-2v for submit@debbugs.gnu.org; Sun, 26 Sep 2010 12:30:44 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ozu7e-00059k-Dv for submit@debbugs.gnu.org; Sun, 26 Sep 2010 12:30:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzuAJ-0004s3-6z for submit@debbugs.gnu.org; Sun, 26 Sep 2010 12:33:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:55396) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzuAJ-0004rx-4L for submit@debbugs.gnu.org; Sun, 26 Sep 2010 12:33:27 -0400 Received: from [140.186.70.92] (port=36039 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzuAI-0000qh-2h for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 12:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzuAG-0004rC-Pu for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 12:33:25 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:59402 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1OzuAG-0004qt-Cd for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 12:33:24 -0400 Received: (qmail invoked by alias); 26 Sep 2010 16:33:21 -0000 Received: from i59F5762A.versanet.de (EHLO escher.home) [89.245.118.42] by mail.gmx.net (mp039) with SMTP; 26 Sep 2010 18:33:21 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19UlRlnpPBU9WGq+i/qCe25harQLuXH1Ksy/m8fs+ xwCXt6IwIzZDQw Received: by escher.home (Postfix, from userid 1000) id 42EBE10426; Sun, 26 Sep 2010 18:33:18 +0200 (CEST) From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 24.0.50; appt-check FIXME does -- please install Date: Sun, 26 Sep 2010 18:33:18 +0200 Message-ID: <877hi8v50x.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) On Tue, 14 Sep 2010 04:06:07 -0400 Glenn Morris wrote in bug#6999: > Leo wrote: > >> The only remaining issue is the main diary file buffer pops up when >> saving in included files. > > I know; see the FIXME comment in appt-check. [which is: ;; FIXME why not using diary-list-entries with ;; non-nil LIST-ONLY? ] > It is only displayed if it was being visited beforehand. > It is because (diary) turns on "selective" display and we need to turn > it off again. This whole thing is a mess. I patched my appt-check as per the FIXME and AFAICT it DTRT, at least when using the default fancy display: the diary is not displayed on saving an included file, yet `C-u M-x appt-check' does show new appointments from the included file. With simple display, the new appointments are not displayed, but neither are they displayed with (diary) as in the current code. So there seems to (still) be a problem for appt-check with simply display regardless of the FIXME. But since that works (AFAICT) with fancy display, I strongly favor committing the fix. In GNU Emacs 24.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.18.6) of 2010-09-23 on escher Windowing system distributor `The X.Org Foundation', version 11.0.10605000 configured using `configure '--with-imagemagick' '--without-toolkit-scroll-bars'' From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 13:49:12 2010 Received: (at 7110) by debbugs.gnu.org; 27 Sep 2010 17:49:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0HpA-0000Cr-5N for submit@debbugs.gnu.org; Mon, 27 Sep 2010 13:49:12 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Hp8-0000Cm-BX for 7110@debbugs.gnu.org; Mon, 27 Sep 2010 13:49:10 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0Hrq-00051N-Sj; Mon, 27 Sep 2010 13:51:58 -0400 To: Stephen Berman Subject: Re: bug#7110: 24.0.50; appt-check FIXME does -- please install References: <877hi8v50x.fsf@escher.home> From: Glenn Morris X-Spook: IMF Marxist electronic surveillance explosion White Water X-Ran: >"O!W[ANRo,O#DdzSGyok${qt:;pqt=ZmsJ90EmZxe]Ql(8zdlSFCn$t?22M+)6Gq+;)=n X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 27 Sep 2010 13:51:58 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7110 Cc: 7110@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Stephen Berman wrote: >>> The only remaining issue is the main diary file buffer pops up when >>> saving in included files. >> >> I know; see the FIXME comment in appt-check. > > [which is: > ;; FIXME why not using diary-list-entries with > ;; non-nil LIST-ONLY? > ] Actually I fixed that issue, which is why that bug was closed. The comment you quote does not relate to any bugs as far as I am aware, it is just cosmetic. > I patched my appt-check as per the FIXME and AFAICT it DTRT, at least > when using the default fancy display: the diary is not displayed on > saving an included file, yet `C-u M-x appt-check' does show new > appointments from the included file. But this is already fixed (in r100043), which is why I closed that bug. > With simple display, the new appointments are not displayed, but > neither are they displayed with (diary) as in the current code. Include files do not work with simply diary display. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 17:56:45 2010 Received: (at 7110) by debbugs.gnu.org; 27 Sep 2010 21:56:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0Lgi-0001uh-Vc for submit@debbugs.gnu.org; Mon, 27 Sep 2010 17:56:45 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1P0Lgg-0001uc-2w for 7110@debbugs.gnu.org; Mon, 27 Sep 2010 17:56:43 -0400 Received: (qmail invoked by alias); 27 Sep 2010 21:59:30 -0000 Received: from i59F57E96.versanet.de (EHLO escher.home) [89.245.126.150] by mail.gmx.net (mp029) with SMTP; 27 Sep 2010 23:59:30 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18jTWJqCZgjxbk4ldGJBzUs7IkcJ6xoby4IlDax2W 5Wo2gstqjZ4KBO Received: by escher.home (Postfix, from userid 1000) id C4E101041F; Mon, 27 Sep 2010 23:59:27 +0200 (CEST) From: Stephen Berman To: Glenn Morris Subject: Re: bug#7110: 24.0.50; appt-check FIXME does -- please install References: <877hi8v50x.fsf@escher.home> Date: Mon, 27 Sep 2010 23:59:27 +0200 In-Reply-To: (Glenn Morris's message of "Mon, 27 Sep 2010 13:51:58 -0400") Message-ID: <8739suc0g0.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7110 Cc: 7110@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Mon, 27 Sep 2010 13:51:58 -0400 Glenn Morris wrote: > Stephen Berman wrote: > >>>> The only remaining issue is the main diary file buffer pops up when >>>> saving in included files. >>> >>> I know; see the FIXME comment in appt-check. >> >> [which is: >> ;; FIXME why not using diary-list-entries with >> ;; non-nil LIST-ONLY? >> ] > > Actually I fixed that issue, which is why that bug was closed. I thought that bug was mainly about appt-check not taking included files into account, the diary buffer popping up being "[t]he only remaining issue". > The comment you quote does not relate to any bugs as far as I am > aware, it is just cosmetic. By cosmetic do you mean the diary buffer popping up? If so, I do regard that as a bug, hence reported it as such, and since calling diary-list-entries instead of diary in appt-check does (also) fix this problem, I just wanted to encourage you to install it -- not having realized that you had provided a different fix in the Emacs 23 branch. (If the cosmetic effect of diary-list-entries is not the diary buffer popping up, then what is it? I don't see any other difference.) >> I patched my appt-check as per the FIXME and AFAICT it DTRT, at least >> when using the default fancy display: the diary is not displayed on >> saving an included file, yet `C-u M-x appt-check' does show new >> appointments from the included file. > > But this is already fixed (in r100043), which is why I closed that bug. Mea culpa for not updating before filing the report (I actually had updated from the trunk the same day your fix was merged -- but earlier). I don't have time to update now and confirm it (though I believe you that it works); I should be able to tomorrow and then I'll close this bug, if you haven't already done so. >> With simple display, the new appointments are not displayed, but >> neither are they displayed with (diary) as in the current code. > > Include files do not work with simply diary display. Oh, right, I forgot (I've been using fancy display for a long time). Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 21:45:11 2010 Received: (at 7110) by debbugs.gnu.org; 28 Sep 2010 01:45:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0PFm-0003Oc-VR for submit@debbugs.gnu.org; Mon, 27 Sep 2010 21:45:11 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0PFk-0003OV-47 for 7110@debbugs.gnu.org; Mon, 27 Sep 2010 21:45:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0PIS-0000MP-TF; Mon, 27 Sep 2010 21:47:56 -0400 To: Stephen Berman Subject: Re: bug#7110: 24.0.50; appt-check FIXME does -- please install References: <877hi8v50x.fsf@escher.home> <8739suc0g0.fsf@escher.home> From: Glenn Morris X-Spook: cypherpunk brigand Security Council passwd EuroFed JFK X-Ran: v8JX9.l_ENswk49.eXk_YUF"[bgGg2;1d1zU_z@oLL/iOu;jqPmC1R;Mu{mza)y{oZR+<6 X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 27 Sep 2010 21:47:56 -0400 In-Reply-To: <8739suc0g0.fsf@escher.home> (Stephen Berman's message of "Mon\, 27 Sep 2010 23\:59\:27 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7110 Cc: 7110@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Stephen Berman wrote: > By cosmetic do you mean the diary buffer popping up? No, by "cosmetic" I was trying to find a way to say the current code is inelegant/inefficient. It makes things invisible, then makes them visible again, when it could just not bother. The end result in terms of behaviour is the same, AFAICS. So it's not a bug, just crufty code. > If so, I do regard that as a bug It should be fixed, try it out when you get a chance. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 23:00:52 2010 Received: (at 7110) by debbugs.gnu.org; 28 Sep 2010 03:00:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0QR2-0003t0-I4 for submit@debbugs.gnu.org; Mon, 27 Sep 2010 23:00:52 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0QQz-0003sv-VZ for 7110@debbugs.gnu.org; Mon, 27 Sep 2010 23:00:50 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1P0QTj-000390-91; Mon, 27 Sep 2010 23:03:39 -0400 To: Stephen Berman Subject: Re: bug#7110: 24.0.50; appt-check FIXME does -- please install References: <877hi8v50x.fsf@escher.home> <8739suc0g0.fsf@escher.home> From: Glenn Morris X-Spook: BCCI offensive information warfare 9705 Samford Road X-Ran: {w?X%}:p4i%;OG`0P|vvE\>"wQ(qRA1pXQCL>GW/4LKqX2cJolD{C?kJ.;6W?WlA|qG$2d X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 27 Sep 2010 23:03:39 -0400 In-Reply-To: (Glenn Morris's message of "Mon\, 27 Sep 2010 21\:47\:56 -0400") Message-ID: <9peicey3g4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7110 Cc: 7110@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Bah, installed it anyway. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 28 04:39:18 2010 Received: (at 7110-done) by debbugs.gnu.org; 28 Sep 2010 08:39:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0ViY-00066b-La for submit@debbugs.gnu.org; Tue, 28 Sep 2010 04:39:18 -0400 Received: from mailout-de.gmx.net ([213.165.64.23] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1P0ViU-00066U-UT for 7110-done@debbugs.gnu.org; Tue, 28 Sep 2010 04:39:16 -0400 Received: (qmail invoked by alias); 28 Sep 2010 08:42:03 -0000 Received: from i59F550DD.versanet.de (EHLO escher.home) [89.245.80.221] by mail.gmx.net (mp037) with SMTP; 28 Sep 2010 10:42:03 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/b7PgBNm7bPJCAyQUxsO8EeOl6xoGBkE0ZB2ab2/ inVdfy1rP8u3Dp Received: by escher.home (Postfix, from userid 1000) id 156F71041F; Tue, 28 Sep 2010 10:42:00 +0200 (CEST) From: Stephen Berman To: 7110-done@debbugs.gnu.org Subject: Re: bug#7110: 24.0.50; appt-check FIXME does -- please install References: <877hi8v50x.fsf@escher.home> <8739suc0g0.fsf@escher.home> <9peicey3g4.fsf@fencepost.gnu.org> Date: Tue, 28 Sep 2010 10:41:59 +0200 In-Reply-To: <9peicey3g4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 27 Sep 2010 23:03:39 -0400") Message-ID: <87sk0u8dk8.fsf@escher.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7110-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Mon, 27 Sep 2010 23:03:39 -0400 Glenn Morris wrote: > Bah, installed it anyway. Thanks; fix confirmed; bug closed. Steve Berman From unknown Sat Aug 16 10:45:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 26 Oct 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator