GNU bug report logs - #71094
[PATCH] Prefer to run find and grep in parallel in rgrep

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71094: closed ([PATCH] Prefer to run find and grep in
 parallel in rgrep)
Date: Wed, 03 Jul 2024 13:46:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 03 Jul 2024 09:42:52 -0400
with message-id <yp1r0cak2w3.fsf <at> fencepost.gnu.org>
and subject line Re: bug#71094: [PATCH] Prefer to run find and grep in parallel in rgrep
has caused the debbugs.gnu.org bug report #71094,
regarding [PATCH] Prefer to run find and grep in parallel in rgrep
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71094: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71094
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Glenn Morris <rgm <at> gnu.org>, dmitry <at> gutov.dev
Subject: [PATCH] Prefer to run find and grep in parallel in rgrep
Date: Tue, 21 May 2024 10:35:07 -0400

[Message part 3 (text/plain, inline)]

Tags: patch


grep.el prefers to run "find" and "xargs grep" in a pipeline,
which means that "find" can continue searching the filesystem
while "xargs grep" searches files.  If find and xargs don't
support the flags required for this behavior, grep.el will fall
back to using the -exec flags to "find", which meant "find" will
wait for each "grep" process to complete before continuing to
search the filesystem tree.  This behavior is controlled by
grep-find-use-xargs; `gnu' produces the pipeline and `exec' is
the slower fallback.

In f3ca7378c1336b3ff98ecb5a99a98c7b2eceece9, the `exec-plus'
option was added for grep-find-use-xargs, which improves on
`exec' by running one "grep" process to search multiple files,
which `gnu' (by using xargs) already did.  However, the change
erroneously added the `exec-plus' case before the `gnu' case in
the autodetection code in grep-compute-defaults, so `exec-plus'
would be used even if `gnu' was supported.

This change just swaps the two cases, so the faster `gnu' option
is once again used in preference to `exec-plus'.  In my
benchmarking on a large repository, this provides a ~40%
speedup.


In GNU Emacs 29.2.50 (build 11, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-05-15 built on
 igm-qws-u22796a
Repository revision: 734740051bd377d24899d08d00ec8e1bb8e00e00
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.9 (Green Obsidian)

Configured using:
 'configure -C --with-x-toolkit=lucid --with-gif=ifavailable'

[0001-Prefer-to-run-find-and-grep-in-parallel-in-rgrep.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Andrea Corallo <acorallo <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: rgm <at> gnu.org, Eli Zaretskii <eliz <at> gnu.org>, 71094-done <at> debbugs.gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>, dmitry <at> gutov.dev
Subject: Re: bug#71094: [PATCH] Prefer to run find and grep in parallel in
 rgrep
Date: Wed, 03 Jul 2024 09:42:52 -0400

Spencer Baugh <sbaugh <at> janestreet.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>> Spencer Baugh <sbaugh <at> janestreet.com> writes:
>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>>> From: Spencer Baugh <sbaugh <at> janestreet.com>
>>>>> Cc: rgm <at> gnu.org,  71094 <at> debbugs.gnu.org,  dmitry <at> gutov.dev
>>>>> Date: Thu, 30 May 2024 08:29:04 -0400
>>>>>
>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>>>
>>>>> > Thanks, LGTM.
>>>>>
>>>>> So is this OK to install now?
>>>>
>>>> As far as I'm concerned, yes.  I don't know if the other participants
>>>> of this discussion are okay with this or they still have some
>>>> comments.
>>>
>>> Since no-one else has made any comments, could this be installed now?
>>
>> Yes, please go ahead, and thanks.
>
> I don't actually have commit access (AFAIK?) so someone else will need
> to push it :)

Should be done, please double check.

Closing meanwhile.

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.