GNU bug report logs - #71089
[PATCH] import/elpa: Add proper file-name to origin.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71089 in the body.
You can then email your comments to 71089 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] import/elpa: Add proper file-name to origin.
Date: Tue, 21 May 2024 08:46:52 +0200

This avoids the lint "the source file name should contain the package
name" with generated packages.

Change-Id: I61c81203d9f3cdd035e2b64a4c7a8d86d1f3dd50
---
 guix/import/elpa.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
index d1855b36986..46b6dc98a20 100644
--- a/guix/import/elpa.scm
+++ b/guix/import/elpa.scm
@@ -250,6 +250,7 @@ (define ref
        (uri (git-reference
              (url ,url)
              (commit ,commit)))
+       (file-name (git-file-name name version))
        (sha256
         (base32
          ,(bytevector->nix-base32-string
-- 
2.41.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <zhengjunjie <at> iscas.ac.cn>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>
Cc: 71089-done <at> debbugs.gnu.org, Nicolas Graves <ngraves <at> ngraves.fr>
Subject: Re: [bug#71089] [PATCH] import/elpa: Add proper file-name to origin.
Date: Wed, 22 May 2024 15:51:06 +0800

[Message part 1 (text/plain, inline)]

Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org> writes:

> This avoids the lint "the source file name should contain the package
> name" with generated packages.
>
> Change-Id: I61c81203d9f3cdd035e2b64a4c7a8d86d1f3dd50
> ---
>  guix/import/elpa.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/guix/import/elpa.scm b/guix/import/elpa.scm
> index d1855b36986..46b6dc98a20 100644
> --- a/guix/import/elpa.scm
> +++ b/guix/import/elpa.scm
> @@ -250,6 +250,7 @@ (define ref
>         (uri (git-reference
>               (url ,url)
>               (commit ,commit)))
> +       (file-name (git-file-name name version))
>         (sha256
>          (base32
>           ,(bytevector->nix-base32-string

push, see https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6bcecb6898d0e205a705f3cfb4a3140f45dd7034

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.