From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 May 2024 20:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 71083@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17162369214309 (code B ref -1); Mon, 20 May 2024 20:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 May 2024 20:28:41 +0000 Received: from localhost ([127.0.0.1]:44600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s99cf-00017R-0Z for submit@debbugs.gnu.org; Mon, 20 May 2024 16:28:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s99cb-00017J-F5 for submit@debbugs.gnu.org; Mon, 20 May 2024 16:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s99cW-0004Me-2R for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 16:28:32 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s99cU-0008DY-Bi for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 16:28:31 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-352129e3c8eso2678145f8f.2 for ; Mon, 20 May 2024 13:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716236909; x=1716841709; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rc5gnJvBlIAQBX76/taF/5BV2r7mT6x2jCbX975Qhrc=; b=nRV1raiYdWiDkeVK71T/6ZFY8zxbej1wyz2ghBQDKxe3BQV7Dt1HT54E3f/b0lFhf3 eMbwklwmKZWBa4v6Df2i5vgu5RPGGwcNbWoilLP6n7+QC19QqmBFfX6245YioxZTm/hK 2Ve1FY7wSXVT3iHYfi77wJvaVTLJxRsQ6bi1q8OpoqGgJpxAeVi2rzs4K0GxeW4wCSTx 7HEV6TNP9ejd8u6kMjbIvGZXE5V88f/VpckFTiYiVG2BlPLnw5Rsq9+/wZ/bhx2gTC6I +oFBKzfItwnD1QgUuixeTZ/DhnixQDnshzqYImyrM2L2LauIbL6OQ2a5rkjGSqvcDJcb 8P2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716236909; x=1716841709; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rc5gnJvBlIAQBX76/taF/5BV2r7mT6x2jCbX975Qhrc=; b=sWzQ6NavdU5IKKGfk14JW4vAZmZoP7yla6PW5WqcHJcOLVgnb1FRv4NKTdFVemgmfW 5sRFcqosGaW93bW9jNsMufq0ROXRdeOovLznCI06qx7TgI6MeioP7FAaMbokRLunioK+ cYVAwHJ3OJBTM1AewRLn0PGDDQhwfr6Kowf0XXz1h6QpDF2yUKnTYEZPfYjHu2TgtbJ0 rkdvdOPn3ee6KIlhWQ55MGC4p+9HpT5O8tANNt9PyTdCCC667qEIA9+ITfEheGmifs6N 8cZR1Vn5DPWWk0if0bTm1ft5kaXGpyQpoJiMEYfbx2uX0e3WODPzegjgZCkbvjwaEDWy IH2A== X-Gm-Message-State: AOJu0YyOiY6iOrdRqw+V5mM7Z68kC/aCI3k0oQLufX2iAqgvxgafu7kZ 0dDimdzPP6PTTIJHSlwP3Htig28RABpqOK8YU3NWmDIdi7OB6YcH9v9SXta4CG3P2XETxq5qfu3 cH2Klxu8ix+OWdW+uxPh5SuQEkORJnZlu X-Google-Smtp-Source: AGHT+IEGbyx6023zpzjGvOuQfI7deJYXYJT+BvBs0+0FL4omgpZI4Mss5ysTYJ5/zC2hrerSDfU4TEKLulR7cNkg2Hw= X-Received: by 2002:a05:600c:4fcd:b0:41f:e56c:ef81 with SMTP id 5b1f17b1804b1-41fea93186bmr203868565e9.1.1716236908492; Mon, 20 May 2024 13:28:28 -0700 (PDT) MIME-Version: 1.0 From: Lin Sun Date: Mon, 20 May 2024 20:28:17 +0000 Message-ID: Content-Type: multipart/mixed; boundary="0000000000004854c20618e88b34" Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=sunlin7.mail@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000004854c20618e88b34 Content-Type: text/plain; charset="UTF-8" Hi, This patch tries to make `python-shell-send-block' more convenient. I had added the function `python-shell-send-block' twenty days ago in bug#70609, it will send code block with header by default, and a prefix "C-u" to call the function will send block without header. And I received some feedback that sending a block without a header should be a more used one. Many python blocks begin with "if condition", and users may want to send the block without its condition header to try different condition branches. So this patch will make sending block without header to be the default behavior, and a prefix "C-u" will make the function to send block with header. Please help review this minor change. Thanks --0000000000004854c20618e88b34 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Disposition: attachment; filename="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwfezfev0 RnJvbSA3ZWVmYmYzZTRkZTkyNWMyMTFlNDgzYTgwOWQwZjhkOTRlOGQxN2YwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBN b24sIDIwIE1heSAyMDI0IDA2OjU1OjMxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gOyBFbmhhbmNl IHRoZSAicHl0aG9uLXNoZWxsLXNlbmQtYmxvY2siIGZvciBjb252ZW5pZW5jZQoKKiBsaXNwL3By b2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrKToKICBUaGUgInB5dGhv bi1zaGVsbC1zZW5kLWJsb2NrIiB3aWxsIHNlbmQgYmxvY2sgd2l0aG91dCBoZWFkZXIgZGVmYXVs dGx5LgoqIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbDogVXBkYXRlIHRlc3QgY2FzZS4KLS0tCiBs aXNwL3Byb2dtb2Rlcy9weXRob24uZWwgICAgICAgICAgICB8IDQgKystLQogdGVzdC9saXNwL3By b2dtb2Rlcy9weXRob24tdGVzdHMuZWwgfCA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3B5 dGhvbi5lbCBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbAppbmRleCA3ZjI4ZjU4MzU0My4uOWVj MTk4ZGE3OWEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9weXRob24uZWwKQEAgLTQxNDksMTQgKzQxNDksMTQgQEAgaW50ZXJhY3RpdmVs eS4iCiAgICJTZW5kIHRoZSBibG9jayBhdCBwb2ludCB0byBpbmZlcmlvciBQeXRob24gcHJvY2Vz cy4KIFRoZSBibG9jayBpcyBkZWxpbWl0ZWQgYnkgYHB5dGhvbi1uYXYtYmVnaW5uaW5nLW9mLWJs b2NrJyBhbmQKIGBweXRob24tbmF2LWVuZC1vZi1ibG9jaycuICBJZiBvcHRpb25hbCBhcmd1bWVu dCBBUkcgaXMgbm9uLW5pbAotKGludGVyYWN0aXZlbHksIHRoZSBwcmVmaXggYXJndW1lbnQpLCBz ZW5kIHRoZSBibG9jayBib2R5IHdpdGhvdXQKKyhpbnRlcmFjdGl2ZWx5LCB0aGUgcHJlZml4IGFy Z3VtZW50KSwgc2VuZCB0aGUgYmxvY2sgYm9keSB3aXRoCiBpdHMgaGVhZGVyLiAgSWYgb3B0aW9u YWwgYXJndW1lbnQgTVNHIGlzIG5vbi1uaWwsIGZvcmNlIGRpc3BsYXkKIG9mIGEgdXNlci1mcmll bmRseSBtZXNzYWdlIGlmIHRoZXJlJ3Mgbm8gcHJvY2VzcyBydW5uaW5nOyB0aGlzCiBhbHdheXMg aGFwcGVucyBpbnRlcmFjdGl2ZWx5LiIKICAgKGludGVyYWN0aXZlIChsaXN0IGN1cnJlbnQtcHJl Zml4LWFyZyB0KSkKICAgKGxldCAoKGJlZyAoc2F2ZS1leGN1cnNpb24KICAgICAgICAgICAgICAg ICh3aGVuIChweXRob24tbmF2LWJlZ2lubmluZy1vZi1ibG9jaykKLSAgICAgICAgICAgICAgICAg KGlmIChudWxsIGFyZykKKyAgICAgICAgICAgICAgICAgKGlmIGFyZwogICAgICAgICAgICAgICAg ICAgICAgKGJlZ2lubmluZy1vZi1saW5lKQogICAgICAgICAgICAgICAgICAgIChweXRob24tbmF2 LWVuZC1vZi1zdGF0ZW1lbnQpCiAgICAgICAgICAgICAgICAgICAgKGJlZ2lubmluZy1vZi1saW5l IDIpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsIGIv dGVzdC9saXNwL3Byb2dtb2Rlcy9weXRob24tdGVzdHMuZWwKaW5kZXggZjUwNzk3OTUzYzMuLjgw MzAwOGRiOGEzIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5l bAorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5lbApAQCAtNzQ3Niw3ICs3 NDc2LDcgQEAgcHJpbnQoJ2N1cnJlbnQgMycpIgogICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CiAgICAgKHNob3VsZC1lcnJvciAocHl0aG9uLXNoZWxsLXNlbmQtYmxvY2spIDp0eXBlICd1c2Vy LWVycm9yKQogICAgIChmb3J3YXJkLWxpbmUpCi0gICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2Nr KQorICAgIChweXRob24tc2hlbGwtc2VuZC1ibG9jayB0KSA7OyBzZW5kIGJsb2NrIHdpdGggaGVh ZGVyCiAgICAgKHB5dGhvbi10ZXN0cy1zaGVsbC13YWl0LWZvci1wcm9tcHQpCiAgICAgKHB5dGhv bi1zaGVsbC13aXRoLXNoZWxsLWJ1ZmZlcgogICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkK QEAgLTc0ODUsNyArNzQ4NSw3IEBAIHByaW50KCdjdXJyZW50IDMnKSIKICAgICAgIChzaG91bGQg KHJlLXNlYXJjaC1mb3J3YXJkICJjdXJyZW50IDIiIG5pbCB0KSkKICAgICAgIChzaG91bGQtbm90 IChyZS1zZWFyY2gtZm9yd2FyZCAiY3VycmVudCAzIiBuaWwgdCkpKQogICAgIChmb3J3YXJkLWxp bmUpCi0gICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrIHQpIDs7IHNlbmQgYmxvY2sgYm9keSBv bmx5CisgICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrKSA7OyBzZW5kIGJsb2NrIGJvZHkgb25s eQogICAgIChweXRob24tdGVzdHMtc2hlbGwtd2FpdC1mb3ItcHJvbXB0KQogICAgIChweXRob24t c2hlbGwtd2l0aC1zaGVsbC1idWZmZXIKICAgICAgIDs7IHNob3VsZCBvbmx5IDEgbGluZSBvdXRw dXQgZnJvbSB0aGUgYmxvY2sgYm9keQotLSAKMi4yMC41Cgo= --0000000000004854c20618e88b34-- From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 08:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lin Sun , kobarity Cc: 71083@debbugs.gnu.org Received: via spool by 71083-submit@debbugs.gnu.org id=B71083.171662424627357 (code B ref 71083); Sat, 25 May 2024 08:05:02 +0000 Received: (at 71083) by debbugs.gnu.org; 25 May 2024 08:04:06 +0000 Received: from localhost ([127.0.0.1]:41963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAmNq-00077B-4C for submit@debbugs.gnu.org; Sat, 25 May 2024 04:04:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAmNo-00076o-Hx for 71083@debbugs.gnu.org; Sat, 25 May 2024 04:04:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAmNb-0002ZJ-Iu; Sat, 25 May 2024 04:03:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z27EHwe5WmsroyT0mq41T0AaRx2SfoHg6vz3FzQhrqs=; b=D379af+ug9Uf ly9MntoKfqWZ5279AeQK0W3NNjQoyurD2U13W2ytfwyfuq+3cqYBqixn3K7TYgRH/JXKcsVf5GHNw aZkBrvsMyoldJplCQzpy5AunvLEFqmMo3NnoVkPENUJc/czS3wduh6PzxN7vm+it1yULwwlkyjPxf Okj7PBANQXoYxEoSustxibXKs5BkEB2o5NEcPaMWALncgx2mFEaHEdSGTCKH1bSCsN1BlqEtyOjf7 /CQdPzQd8On/DHBtj6/07z/JGrIoDW+1vILGHU9C+GaEyPzIv4B48wWizeIacwGixogeNrJK46ugK 49LO+nAHShtYXVu/qijB9w==; Date: Sat, 25 May 2024 11:03:49 +0300 Message-Id: <86sey6z5ay.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Lin Sun on Mon, 20 May 2024 20:28:17 +0000) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Any comments on the proposed patch? > From: Lin Sun > Date: Mon, 20 May 2024 20:28:17 +0000 > > This patch tries to make `python-shell-send-block' more convenient. > > I had added the function `python-shell-send-block' twenty days ago in > bug#70609, it will send code block with header by default, and a > prefix "C-u" to call the function will send block without header. > > And I received some feedback that sending a block without a header > should be a more used one. > > Many python blocks begin with "if condition", and users may want to > send the block without its condition header to try different condition > branches. > > So this patch will make sending block without header to be the default > behavior, and a prefix "C-u" will make the function to send block with > header. > > Please help review this minor change. Thanks > > > From 7eefbf3e4de925c211e483a809d0f8d94e8d17f0 Mon Sep 17 00:00:00 2001 > From: Lin Sun > Date: Mon, 20 May 2024 06:55:31 +0000 > Subject: [PATCH] ; Enhance the "python-shell-send-block" for convenience > > * lisp/progmodes/python.el (python-shell-send-block): > The "python-shell-send-block" will send block without header defaultly. > * lisp/progmodes/python.el: Update test case. > --- > lisp/progmodes/python.el | 4 ++-- > test/lisp/progmodes/python-tests.el | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index 7f28f583543..9ec198da79a 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -4149,14 +4149,14 @@ interactively." > "Send the block at point to inferior Python process. > The block is delimited by `python-nav-beginning-of-block' and > `python-nav-end-of-block'. If optional argument ARG is non-nil > -(interactively, the prefix argument), send the block body without > +(interactively, the prefix argument), send the block body with > its header. If optional argument MSG is non-nil, force display > of a user-friendly message if there's no process running; this > always happens interactively." > (interactive (list current-prefix-arg t)) > (let ((beg (save-excursion > (when (python-nav-beginning-of-block) > - (if (null arg) > + (if arg > (beginning-of-line) > (python-nav-end-of-statement) > (beginning-of-line 2))) > diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el > index f50797953c3..803008db8a3 100644 > --- a/test/lisp/progmodes/python-tests.el > +++ b/test/lisp/progmodes/python-tests.el > @@ -7476,7 +7476,7 @@ print('current 3')" > (goto-char (point-min)) > (should-error (python-shell-send-block) :type 'user-error) > (forward-line) > - (python-shell-send-block) > + (python-shell-send-block t) ;; send block with header > (python-tests-shell-wait-for-prompt) > (python-shell-with-shell-buffer > (goto-char (point-min)) > @@ -7485,7 +7485,7 @@ print('current 3')" > (should (re-search-forward "current 2" nil t)) > (should-not (re-search-forward "current 3" nil t))) > (forward-line) > - (python-shell-send-block t) ;; send block body only > + (python-shell-send-block) ;; send block body only > (python-tests-shell-wait-for-prompt) > (python-shell-with-shell-buffer > ;; should only 1 line output from the block body > -- > 2.20.5 > From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71083@debbugs.gnu.org, Lin Sun Received: via spool by 71083-submit@debbugs.gnu.org id=B71083.171662705128837 (code B ref 71083); Sat, 25 May 2024 08:51:02 +0000 Received: (at 71083) by debbugs.gnu.org; 25 May 2024 08:50:51 +0000 Received: from localhost ([127.0.0.1]:42156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAn75-0007V3-DA for submit@debbugs.gnu.org; Sat, 25 May 2024 04:50:51 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:51505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAn72-0007Ux-Jy for 71083@debbugs.gnu.org; Sat, 25 May 2024 04:50:49 -0400 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f333e7a669so28418265ad.3 for <71083@debbugs.gnu.org>; Sat, 25 May 2024 01:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716626975; x=1717231775; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=hQuRknTJtidK3gb5vWK3h1gNUBftLfKn9E81kBFHO+g=; b=OV9lPxXb/JgFDytcJ1DEspepJeIRpHE4MfzZQXtpLoD79SNIqJyQZ/H2vJC0dUPu3f wkVPhb4Ldg4Jat2/i6Spj6ToJMLb4RCQxjNhdDQt510yPKvS7jyTWSrPO+HMT8+2iAYX 5NQQomORReYhZQCOxNOgJUXEITqYyTym4ajRB2L6Y6uswsAXNTpGKRmKbVLuMiDiuSFM xYW3mFnjkea28HUBrMqKZlruXTDXVzcxKfMfu+pIeDGVY5g+TV0hOHljfr3D0COGU/we 8rFW3bEYukB7KLdO4tIh79x97uSuiKjNkdoFm+6oCGNStvPvjiGmcARLBmyCquDqpsWB T47g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716626975; x=1717231775; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hQuRknTJtidK3gb5vWK3h1gNUBftLfKn9E81kBFHO+g=; b=LD9e7acNSzLtwdVzdX3OWbm2LX1XW5kkbr2nNyf6CApN9FmnxJNBNdY+uOp5ih+YPG h6KJFJjX1SW9CLprRgc2ZUc6zQgVVtHkBeLb8uunOAuUBsXWIOvV4xfpIt4B9ppRef0m Xxi1KI8UWJu1qRDO/pyBa2+6og+xRRP/7y8iFzEPLZm25bl6kfkXA9M3SO8WYPPNboAQ 6tdVjgROclSaMcZ08u2U/Tf3tEd3kjc2GQ7/ModoHY5mIKNRLZOhSh6ENZDnEMSzl/A1 XFTt9HOYp4aWT4ZLcjyXcsM9ofSg0E12BBbyB4CnPZO11wX2ChAT0rYLVxU+IJZaHiB7 rHbg== X-Forwarded-Encrypted: i=1; AJvYcCWSXswzmh6f0Sy+DqKe3XksDs7H0ehwixeX0SMg7Jk1p5i9tgH+ras9n53g1JR+eTcJJVmJu7EzggBCfCo8czV5mU5irFE= X-Gm-Message-State: AOJu0YxIfSV8J032chybu/0pNw0HY6ZYD15GUdWZJIojvZ5t5RM6W6/P QP6Q3DuEKWZP/V7o5RP1Y5S/IxhZJUPEwswGVn8pIaV2EyC7YPhJ X-Google-Smtp-Source: AGHT+IG3WBvyc2Itj5igjK1slWmu+RMvIDejjLJol0Azsb94mNDno0FMBHy1kcUBibHyxpeV777ItQ== X-Received: by 2002:a17:902:d2cd:b0:1f4:5685:b146 with SMTP id d9443c01a7336-1f45685b4c7mr41191965ad.37.1716626975161; Sat, 25 May 2024 01:49:35 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c96fd7esm26113705ad.157.2024.05.25.01.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 01:49:34 -0700 (PDT) Date: Sat, 25 May 2024 17:49:30 +0900 Message-ID: From: kobarity In-Reply-To: <86sey6z5ay.fsf@gnu.org> References: <86sey6z5ay.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii wrote: > Any comments on the proposed patch? > > > From: Lin Sun > > Date: Mon, 20 May 2024 20:28:17 +0000 > > > > This patch tries to make `python-shell-send-block' more convenient. > > > > I had added the function `python-shell-send-block' twenty days ago in > > bug#70609, it will send code block with header by default, and a > > prefix "C-u" to call the function will send block without header. > > > > And I received some feedback that sending a block without a header > > should be a more used one. > > > > Many python blocks begin with "if condition", and users may want to > > send the block without its condition header to try different condition > > branches. > > > > So this patch will make sending block without header to be the default > > behavior, and a prefix "C-u" will make the function to send block with > > header. > > > > Please help review this minor change. Thanks > > > > > > From 7eefbf3e4de925c211e483a809d0f8d94e8d17f0 Mon Sep 17 00:00:00 2001 > > From: Lin Sun > > Date: Mon, 20 May 2024 06:55:31 +0000 > > Subject: [PATCH] ; Enhance the "python-shell-send-block" for convenience > > > > * lisp/progmodes/python.el (python-shell-send-block): > > The "python-shell-send-block" will send block without header defaultly. > > * lisp/progmodes/python.el: Update test case. > > --- > > lisp/progmodes/python.el | 4 ++-- > > test/lisp/progmodes/python-tests.el | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > index 7f28f583543..9ec198da79a 100644 > > --- a/lisp/progmodes/python.el > > +++ b/lisp/progmodes/python.el > > @@ -4149,14 +4149,14 @@ interactively." > > "Send the block at point to inferior Python process. > > The block is delimited by `python-nav-beginning-of-block' and > > `python-nav-end-of-block'. If optional argument ARG is non-nil > > -(interactively, the prefix argument), send the block body without > > +(interactively, the prefix argument), send the block body with > > its header. If optional argument MSG is non-nil, force display > > of a user-friendly message if there's no process running; this > > always happens interactively." > > (interactive (list current-prefix-arg t)) > > (let ((beg (save-excursion > > (when (python-nav-beginning-of-block) > > - (if (null arg) > > + (if arg > > (beginning-of-line) > > (python-nav-end-of-statement) > > (beginning-of-line 2))) > > diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el > > index f50797953c3..803008db8a3 100644 > > --- a/test/lisp/progmodes/python-tests.el > > +++ b/test/lisp/progmodes/python-tests.el > > @@ -7476,7 +7476,7 @@ print('current 3')" > > (goto-char (point-min)) > > (should-error (python-shell-send-block) :type 'user-error) > > (forward-line) > > - (python-shell-send-block) > > + (python-shell-send-block t) ;; send block with header > > (python-tests-shell-wait-for-prompt) > > (python-shell-with-shell-buffer > > (goto-char (point-min)) > > @@ -7485,7 +7485,7 @@ print('current 3')" > > (should (re-search-forward "current 2" nil t)) > > (should-not (re-search-forward "current 3" nil t))) > > (forward-line) > > - (python-shell-send-block t) ;; send block body only > > + (python-shell-send-block) ;; send block body only > > (python-tests-shell-wait-for-prompt) > > (python-shell-with-shell-buffer > > ;; should only 1 line output from the block body > > -- > > 2.20.5 > > As for the default behavior of `python-shell-send-block' I am fine with either. "send block without header defaultly." in the commit message would be better for "send block without header by default." I noticed two Flymake diagnostics regarding `python-shell-send-block'. - Open parenthesis in column 0 should be escaped - Error messages should *not* end with a period It would be nice to resolve them. From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: kobarity Cc: 71083@debbugs.gnu.org, Eli Zaretskii Received: via spool by 71083-submit@debbugs.gnu.org id=B71083.171665275917873 (code B ref 71083); Sat, 25 May 2024 16:00:02 +0000 Received: (at 71083) by debbugs.gnu.org; 25 May 2024 15:59:19 +0000 Received: from localhost ([127.0.0.1]:44196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAtni-0004eD-Lw for submit@debbugs.gnu.org; Sat, 25 May 2024 11:59:19 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:60917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAtng-0004e5-NZ for 71083@debbugs.gnu.org; Sat, 25 May 2024 11:59:17 -0400 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52327368e59so10873394e87.1 for <71083@debbugs.gnu.org>; Sat, 25 May 2024 08:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716652683; x=1717257483; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iPDDYp0aFckto21AanlIkFyRkloku3hKNP4W1FpaTms=; b=R9c1innugpatsB3OxjQWXWAXj8F3YhY7g5yFqWifia0xlO0qpN0q7/uxx0HucqPuJm cBqWuNQ+6KqHKpxEmQ+iEVrQ5SRbVQbSiBzqrbwsicUbWV3qrUc+1bmLSaWz6AMhL6sA V1MtVzBdDXmUyy0Ue5n/u7RjHHplZQU1zetzaqp4Rte1f9O9D1Oj0h5WGGYvNOxB8xI4 QTgOo98ZUqn+2BYhAcOzAsJs+gV3gNclJxNNk9gxdNV8Q6Mmk9v/OfB85R1ywelKTkqW GsPP/mLdhN/isU2XC3dObDGqEHaSmLwLEY+oflQEkD+EHPeC3MGF6h2krZRfmPzuqh6s x6GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716652683; x=1717257483; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iPDDYp0aFckto21AanlIkFyRkloku3hKNP4W1FpaTms=; b=auTvmOqdJl47Ej2EOzk4zqSwAaGDrtf5BBjM+PHN3nCrUwuuYtDCva4u7Q8DEGLJLu PA2Ew9y/9+JzxfBCVr2F9rICMN32EWDF/0E3nHIW9zcjKFgcs3QtiK7YpE3ieKETJmt+ 8MMtr6UYhaqq2rh5kLLYv1dWLktKBX/of+udtZMg141F1+8OOiuSeodqOehUt+poUEFE aFFEetp/3/VPt+M2DUOjMRNnkQkyJ6d5wMyFKabYLtZ/BjT/ORAQJ4ntNkC8bQi84zZD oliqoEwLXz1+qi8PPBzv/fhoJMPUO6yCTPSFpKzQGEmMVBplDHH7H0rLeBxXVnpU/SQ1 aNhA== X-Forwarded-Encrypted: i=1; AJvYcCVe6s/5mHmjufmvM8hNZLi3+Ek8roFNFnsM9R2dEBzlDFDZSrMWMp/iOw+qjHgVZucfzU+2Q1fjIguRKfVWAxV2Bstubw4= X-Gm-Message-State: AOJu0Yy88MK7A8vF5BGlPI31L7n2j7AxLA3T7sfcesqu5qk4uUpOOXts 4SURq/XnxeXZCk7+HsG/ek/gQuZ3zpgbbLDKBtML/UwgAw6sdgwrXjQ5ahZIZI4nJSBBPJvbFH7 h96kk/Lv5h5d29VCdHrkHTRx9YQY= X-Google-Smtp-Source: AGHT+IHjwEuSc4Qnv/it0TtOsU4tq43MzkPzwaGGKyApvqLn3CcglsiVpfZDxs0v157h2qz8KOMu5qsze1kw8CbEvCE= X-Received: by 2002:ac2:558b:0:b0:522:35c6:d343 with SMTP id 2adb3069b0e04-529646de49emr2874761e87.16.1716652682685; Sat, 25 May 2024 08:58:02 -0700 (PDT) MIME-Version: 1.0 References: <86sey6z5ay.fsf@gnu.org> In-Reply-To: From: Lin Sun Date: Sat, 25 May 2024 15:57:51 +0000 Message-ID: Content-Type: multipart/mixed; boundary="0000000000005b6da80619495924" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005b6da80619495924 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 25, 2024 at 8:49=E2=80=AFAM kobarity wrote= : > Eli Zaretskii wrote: > > Any comments on the proposed patch? > > > > > From: Lin Sun > > > Date: Mon, 20 May 2024 20:28:17 +0000 > > > > > > This patch tries to make `python-shell-send-block' more convenient. > > > > > > I had added the function `python-shell-send-block' twenty days ago i= n > > > bug#70609, it will send code block with header by default, and a > > > prefix "C-u" to call the function will send block without header. > > > > > > And I received some feedback that sending a block without a header > > > should be a more used one. > > > > > > Many python blocks begin with "if condition", and users may want to > > > send the block without its condition header to try different conditio= n > > > branches. > > > > > > So this patch will make sending block without header to be the defaul= t > > > behavior, and a prefix "C-u" will make the function to send block wit= h > > > header. > > > > > > Please help review this minor change. Thanks > > > > > > > > > From 7eefbf3e4de925c211e483a809d0f8d94e8d17f0 Mon Sep 17 00:00:00 200= 1 > > > From: Lin Sun > > > Date: Mon, 20 May 2024 06:55:31 +0000 > > > Subject: [PATCH] ; Enhance the "python-shell-send-block" for convenie= nce > > > > > > * lisp/progmodes/python.el (python-shell-send-block): > > > The "python-shell-send-block" will send block without header defaul= tly. > > > * lisp/progmodes/python.el: Update test case. > > > --- > > > lisp/progmodes/python.el | 4 ++-- > > > test/lisp/progmodes/python-tests.el | 4 ++-- > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > > index 7f28f583543..9ec198da79a 100644 > > > --- a/lisp/progmodes/python.el > > > +++ b/lisp/progmodes/python.el > > > @@ -4149,14 +4149,14 @@ interactively." > > > "Send the block at point to inferior Python process. > > > The block is delimited by `python-nav-beginning-of-block' and > > > `python-nav-end-of-block'. If optional argument ARG is non-nil > > > -(interactively, the prefix argument), send the block body without > > > +(interactively, the prefix argument), send the block body with > > > its header. If optional argument MSG is non-nil, force display > > > of a user-friendly message if there's no process running; this > > > always happens interactively." > > > (interactive (list current-prefix-arg t)) > > > (let ((beg (save-excursion > > > (when (python-nav-beginning-of-block) > > > - (if (null arg) > > > + (if arg > > > (beginning-of-line) > > > (python-nav-end-of-statement) > > > (beginning-of-line 2))) > > > diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmode= s/python-tests.el > > > index f50797953c3..803008db8a3 100644 > > > --- a/test/lisp/progmodes/python-tests.el > > > +++ b/test/lisp/progmodes/python-tests.el > > > @@ -7476,7 +7476,7 @@ print('current 3')" > > > (goto-char (point-min)) > > > (should-error (python-shell-send-block) :type 'user-error) > > > (forward-line) > > > - (python-shell-send-block) > > > + (python-shell-send-block t) ;; send block with header > > > (python-tests-shell-wait-for-prompt) > > > (python-shell-with-shell-buffer > > > (goto-char (point-min)) > > > @@ -7485,7 +7485,7 @@ print('current 3')" > > > (should (re-search-forward "current 2" nil t)) > > > (should-not (re-search-forward "current 3" nil t))) > > > (forward-line) > > > - (python-shell-send-block t) ;; send block body only > > > + (python-shell-send-block) ;; send block body only > > > (python-tests-shell-wait-for-prompt) > > > (python-shell-with-shell-buffer > > > ;; should only 1 line output from the block body > > > -- > > > 2.20.5 > > > > > As for the default behavior of `python-shell-send-block' I am fine > with either. > > "send block without header defaultly." in the commit message would be > better for "send block without header by default." > > I noticed two Flymake diagnostics regarding `python-shell-send-block'. > > - Open parenthesis in column 0 should be escaped > - Error messages should *not* end with a period > > It would be nice to resolve them. Hi kobarity, Thank you for the comment, you're right. I had fixed the flymake diagnostics and the commit message. Please help review again. Thanks. --0000000000005b6da80619495924 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Disposition: attachment; filename="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwmao0940 RnJvbSBjMTYwYTc0ZjAxNTM1ZTUzZGQyOTNjMDkyNDc3MWM1YjI2N2U0OTA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBN b24sIDIwIE1heSAyMDI0IDA2OjU1OjMxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gOyBFbmhhbmNl IHRoZSAicHl0aG9uLXNoZWxsLXNlbmQtYmxvY2siIGZvciBjb252ZW5pZW5jZQoKKiBsaXNwL3By b2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrKToKICBUaGUgInB5dGhv bi1zaGVsbC1zZW5kLWJsb2NrIiB3aWxsIHNlbmQgYmxvY2sgd2l0aG91dCBoZWFkZXIgYnkgZGVm YXVsdC4KKiBsaXNwL3Byb2dtb2Rlcy9weXRob24uZWw6IFVwZGF0ZSB0aGUgdGVzdCBjYXNlLgot LS0KIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbCAgICAgICAgICAgIHwgNiArKystLS0KIHRlc3Qv bGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsIHwgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQs IDUgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dt b2Rlcy9weXRob24uZWwgYi9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKaW5kZXggN2YyOGY1ODM1 NDMuLmFmN2M0MTIyYmEwIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKKysr IGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVsCkBAIC00MTQ5LDE0ICs0MTQ5LDE0IEBAIGludGVy YWN0aXZlbHkuIgogICAiU2VuZCB0aGUgYmxvY2sgYXQgcG9pbnQgdG8gaW5mZXJpb3IgUHl0aG9u IHByb2Nlc3MuCiBUaGUgYmxvY2sgaXMgZGVsaW1pdGVkIGJ5IGBweXRob24tbmF2LWJlZ2lubmlu Zy1vZi1ibG9jaycgYW5kCiBgcHl0aG9uLW5hdi1lbmQtb2YtYmxvY2snLiAgSWYgb3B0aW9uYWwg YXJndW1lbnQgQVJHIGlzIG5vbi1uaWwKLShpbnRlcmFjdGl2ZWx5LCB0aGUgcHJlZml4IGFyZ3Vt ZW50KSwgc2VuZCB0aGUgYmxvY2sgYm9keSB3aXRob3V0CitcKGludGVyYWN0aXZlbHksIHRoZSBw cmVmaXggYXJndW1lbnQpLCBzZW5kIHRoZSBibG9jayBib2R5IHdpdGgKIGl0cyBoZWFkZXIuICBJ ZiBvcHRpb25hbCBhcmd1bWVudCBNU0cgaXMgbm9uLW5pbCwgZm9yY2UgZGlzcGxheQogb2YgYSB1 c2VyLWZyaWVuZGx5IG1lc3NhZ2UgaWYgdGhlcmUncyBubyBwcm9jZXNzIHJ1bm5pbmc7IHRoaXMK IGFsd2F5cyBoYXBwZW5zIGludGVyYWN0aXZlbHkuIgogICAoaW50ZXJhY3RpdmUgKGxpc3QgY3Vy cmVudC1wcmVmaXgtYXJnIHQpKQogICAobGV0ICgoYmVnIChzYXZlLWV4Y3Vyc2lvbgogICAgICAg ICAgICAgICAgKHdoZW4gKHB5dGhvbi1uYXYtYmVnaW5uaW5nLW9mLWJsb2NrKQotICAgICAgICAg ICAgICAgICAoaWYgKG51bGwgYXJnKQorICAgICAgICAgICAgICAgICAoaWYgYXJnCiAgICAgICAg ICAgICAgICAgICAgICAoYmVnaW5uaW5nLW9mLWxpbmUpCiAgICAgICAgICAgICAgICAgICAgKHB5 dGhvbi1uYXYtZW5kLW9mLXN0YXRlbWVudCkKICAgICAgICAgICAgICAgICAgICAoYmVnaW5uaW5n LW9mLWxpbmUgMikpKQpAQCAtNDE2NSw3ICs0MTY1LDcgQEAgYWx3YXlzIGhhcHBlbnMgaW50ZXJh Y3RpdmVseS4iCiAgICAgICAgIChweXRob24taW5kZW50LWd1ZXNzLWluZGVudC1vZmZzZXQtdmVy Ym9zZSBuaWwpKQogICAgIChpZiAoYW5kIGJlZyBlbmQpCiAgICAgICAgIChweXRob24tc2hlbGwt c2VuZC1yZWdpb24gYmVnIGVuZCBuaWwgbXNnIHQpCi0gICAgICAodXNlci1lcnJvciAiQ2FuJ3Qg Z2V0IGNvZGUgYmxvY2sgZnJvbSBjdXJyZW50IHBvc2l0aW9uLiIpKSkpCisgICAgICAodXNlci1l cnJvciAiQ2FuJ3QgZ2V0IGNvZGUgYmxvY2sgZnJvbSBjdXJyZW50IHBvc2l0aW9uIikpKSkKIAog KGRlZnVuIHB5dGhvbi1zaGVsbC1zZW5kLWJ1ZmZlciAoJm9wdGlvbmFsIHNlbmQtbWFpbiBtc2cp CiAgICJTZW5kIHRoZSBlbnRpcmUgYnVmZmVyIHRvIGluZmVyaW9yIFB5dGhvbiBwcm9jZXNzLgpk aWZmIC0tZ2l0IGEvdGVzdC9saXNwL3Byb2dtb2Rlcy9weXRob24tdGVzdHMuZWwgYi90ZXN0L2xp c3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5lbAppbmRleCBmNTA3OTc5NTNjMy4uODAzMDA4ZGI4 YTMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsCkBAIC03NDc2LDcgKzc0NzYsNyBA QCBwcmludCgnY3VycmVudCAzJykiCiAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKICAgICAo c2hvdWxkLWVycm9yIChweXRob24tc2hlbGwtc2VuZC1ibG9jaykgOnR5cGUgJ3VzZXItZXJyb3Ip CiAgICAgKGZvcndhcmQtbGluZSkKLSAgICAocHl0aG9uLXNoZWxsLXNlbmQtYmxvY2spCisgICAg KHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrIHQpIDs7IHNlbmQgYmxvY2sgd2l0aCBoZWFkZXIKICAg ICAocHl0aG9uLXRlc3RzLXNoZWxsLXdhaXQtZm9yLXByb21wdCkKICAgICAocHl0aG9uLXNoZWxs LXdpdGgtc2hlbGwtYnVmZmVyCiAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQpAQCAtNzQ4 NSw3ICs3NDg1LDcgQEAgcHJpbnQoJ2N1cnJlbnQgMycpIgogICAgICAgKHNob3VsZCAocmUtc2Vh cmNoLWZvcndhcmQgImN1cnJlbnQgMiIgbmlsIHQpKQogICAgICAgKHNob3VsZC1ub3QgKHJlLXNl YXJjaC1mb3J3YXJkICJjdXJyZW50IDMiIG5pbCB0KSkpCiAgICAgKGZvcndhcmQtbGluZSkKLSAg ICAocHl0aG9uLXNoZWxsLXNlbmQtYmxvY2sgdCkgOzsgc2VuZCBibG9jayBib2R5IG9ubHkKKyAg ICAocHl0aG9uLXNoZWxsLXNlbmQtYmxvY2spIDs7IHNlbmQgYmxvY2sgYm9keSBvbmx5CiAgICAg KHB5dGhvbi10ZXN0cy1zaGVsbC13YWl0LWZvci1wcm9tcHQpCiAgICAgKHB5dGhvbi1zaGVsbC13 aXRoLXNoZWxsLWJ1ZmZlcgogICAgICAgOzsgc2hvdWxkIG9ubHkgMSBsaW5lIG91dHB1dCBmcm9t IHRoZSBibG9jayBib2R5Ci0tIAoyLjIwLjUKCg== --0000000000005b6da80619495924-- From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 00:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lin Sun Cc: 71083@debbugs.gnu.org, Eli Zaretskii Received: via spool by 71083-submit@debbugs.gnu.org id=B71083.1716683830373 (code B ref 71083); Sun, 26 May 2024 00:38:01 +0000 Received: (at 71083) by debbugs.gnu.org; 26 May 2024 00:37:10 +0000 Received: from localhost ([127.0.0.1]:45460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB1sr-00005Q-9j for submit@debbugs.gnu.org; Sat, 25 May 2024 20:37:09 -0400 Received: from mail-pj1-f42.google.com ([209.85.216.42]:59731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB1so-0008LI-Aw for 71083@debbugs.gnu.org; Sat, 25 May 2024 20:37:07 -0400 Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2bf5797973fso1953401a91.3 for <71083@debbugs.gnu.org>; Sat, 25 May 2024 17:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716683752; x=1717288552; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=esEBI2ea10KAdICRg5hA77a32DuqJ30p2aY3lzmPCY0=; b=J6kjnJ0tSoZyrmtmCDVbqx57jjudpXZ/KcdNtEuA7KtfvyzxxaGRziyrYPd0l+N2rK nlHR9tZd03xiJ3S+mtZE0GIt6r6CYIIsxoAfVYu5UEAMjI3JJpvbNbTPVnTQKjGDrHD+ 9pb/TqsoKSfxMDFcKyupDEEbPlfj7HTP2S8LSTbGoHug6w/ocwTISD/4lzo2ovELwdEu ZGkVnZr8e8oDXty3UqoO52fmrNO8P43RNTrH87nwN1/e4wOdMHp4IByhp5YLACk4ZHw5 xvM8b/8vO9fgOUgSDHMBgK6XSfEptfitH6VyO0cyxh5B9ymj8e6MtQwY8WivfEXkbzjC wG5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716683752; x=1717288552; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=esEBI2ea10KAdICRg5hA77a32DuqJ30p2aY3lzmPCY0=; b=NpJpi0Dppun7ZS9kgnvh/glNJ0aq3JvuKizgcwU5w/sDciegXltk1i7eCltOz0rGW4 m4RasAXizZ7gG8ykFENFA7HeYNDcIdz35vK9LzDjnloQZgUulcd3vPlMafGAPdwm1fI8 sRT4XZdqdJz8dYfMhg8BVUdXbLnhiKtGk5eoS4u+kRqzT+KKWLVZqvLKGCen9xvzsuFV dAwTr/Z4SZI4XPfSa/wrom6j/koKTKX+eet4lUqPCoUtasqRAKPQp2cjE4LBsyb+jZLX wqN0soT6cZzqw4kyRhXmuKlI7UA1jHdZ7CisFyLGGZ9QyQdgwjV39YWExwKDu57jyuux APiw== X-Forwarded-Encrypted: i=1; AJvYcCXpPTSDODirTeX/M05tBmQl6PP/Kq50yKFdI+GNAAC4LYZDaHr1/w5hrR5mIED/2D02PTqgJkKbcyk162SuM5eTpNQtZIE= X-Gm-Message-State: AOJu0Yz4kkT1HciSWxhEzHmzkQgjhtMA7Qxrxv8iye/t2s1Zl0c0cl64 hJrYOW096N29VsVsWNyNnJ7KBbrzt0S677lK4JKZEKj+ztBvo5s+ X-Google-Smtp-Source: AGHT+IGG1FtjcG2yBo4pzv4oFOYh9qAS8WFbT9bicWuFl/WvMFFJPEhxkCemjrw1P0/D0igKH6OSwA== X-Received: by 2002:a17:903:120c:b0:1f2:f63b:4795 with SMTP id d9443c01a7336-1f4486c65e6mr80142075ad.14.1716683752239; Sat, 25 May 2024 17:35:52 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2bdd9f4bdcbsm5252388a91.36.2024.05.25.17.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 17:35:51 -0700 (PDT) Date: Sun, 26 May 2024 09:35:49 +0900 Message-ID: From: kobarity In-Reply-To: References: <86sey6z5ay.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lin Sun wrote: > On Sat, May 25, 2024 at 8:49=E2=80=AFAM kobarity wro= te: > > Eli Zaretskii wrote: > > > Any comments on the proposed patch? > > > > > > > From: Lin Sun > > > > Date: Mon, 20 May 2024 20:28:17 +0000 > > > > > > > > This patch tries to make `python-shell-send-block' more convenient. > > > > > > > > I had added the function `python-shell-send-block' twenty days ago= in > > > > bug#70609, it will send code block with header by default, and a > > > > prefix "C-u" to call the function will send block without header. > > > > > > > > And I received some feedback that sending a block without a header > > > > should be a more used one. > > > > > > > > Many python blocks begin with "if condition", and users may want to > > > > send the block without its condition header to try different condit= ion > > > > branches. > > > > > > > > So this patch will make sending block without header to be the defa= ult > > > > behavior, and a prefix "C-u" will make the function to send block w= ith > > > > header. > > > > > > > > Please help review this minor change. Thanks > > > > > > > > > > > > From 7eefbf3e4de925c211e483a809d0f8d94e8d17f0 Mon Sep 17 00:00:00 2= 001 > > > > From: Lin Sun > > > > Date: Mon, 20 May 2024 06:55:31 +0000 > > > > Subject: [PATCH] ; Enhance the "python-shell-send-block" for conven= ience > > > > > > > > * lisp/progmodes/python.el (python-shell-send-block): > > > > The "python-shell-send-block" will send block without header defa= ultly. > > > > * lisp/progmodes/python.el: Update test case. > > > > --- > > > > lisp/progmodes/python.el | 4 ++-- > > > > test/lisp/progmodes/python-tests.el | 4 ++-- > > > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > > > index 7f28f583543..9ec198da79a 100644 > > > > --- a/lisp/progmodes/python.el > > > > +++ b/lisp/progmodes/python.el > > > > @@ -4149,14 +4149,14 @@ interactively." > > > > "Send the block at point to inferior Python process. > > > > The block is delimited by `python-nav-beginning-of-block' and > > > > `python-nav-end-of-block'. If optional argument ARG is non-nil > > > > -(interactively, the prefix argument), send the block body without > > > > +(interactively, the prefix argument), send the block body with > > > > its header. If optional argument MSG is non-nil, force display > > > > of a user-friendly message if there's no process running; this > > > > always happens interactively." > > > > (interactive (list current-prefix-arg t)) > > > > (let ((beg (save-excursion > > > > (when (python-nav-beginning-of-block) > > > > - (if (null arg) > > > > + (if arg > > > > (beginning-of-line) > > > > (python-nav-end-of-statement) > > > > (beginning-of-line 2))) > > > > diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmo= des/python-tests.el > > > > index f50797953c3..803008db8a3 100644 > > > > --- a/test/lisp/progmodes/python-tests.el > > > > +++ b/test/lisp/progmodes/python-tests.el > > > > @@ -7476,7 +7476,7 @@ print('current 3')" > > > > (goto-char (point-min)) > > > > (should-error (python-shell-send-block) :type 'user-error) > > > > (forward-line) > > > > - (python-shell-send-block) > > > > + (python-shell-send-block t) ;; send block with header > > > > (python-tests-shell-wait-for-prompt) > > > > (python-shell-with-shell-buffer > > > > (goto-char (point-min)) > > > > @@ -7485,7 +7485,7 @@ print('current 3')" > > > > (should (re-search-forward "current 2" nil t)) > > > > (should-not (re-search-forward "current 3" nil t))) > > > > (forward-line) > > > > - (python-shell-send-block t) ;; send block body only > > > > + (python-shell-send-block) ;; send block body only > > > > (python-tests-shell-wait-for-prompt) > > > > (python-shell-with-shell-buffer > > > > ;; should only 1 line output from the block body > > > > -- > > > > 2.20.5 > > > > > > > > As for the default behavior of `python-shell-send-block' I am fine > > with either. > > > > "send block without header defaultly." in the commit message would be > > better for "send block without header by default." > > > > I noticed two Flymake diagnostics regarding `python-shell-send-block'. > > > > - Open parenthesis in column 0 should be escaped > > - Error messages should *not* end with a period > > > > It would be nice to resolve them. > Hi kobarity, >=20 > Thank you for the comment, you're right. I had fixed the flymake > diagnostics and the commit message. >=20 > Please help review again. Thanks. Thanks, it looks good to me. From unknown Sat Aug 16 13:41:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Lin Sun Subject: bug#71083: closed (Re: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience) Message-ID: References: <86zfsdvutb.fsf@gnu.org> X-Gnu-PR-Message: they-closed 71083 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 71083@debbugs.gnu.org Date: Sun, 26 May 2024 08:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1716712322-31742-1" This is a multi-part message in MIME format... ------------=_1716712322-31742-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 71083@debbugs.gnu.org. --=20 71083: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D71083 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1716712322-31742-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 71083-done) by debbugs.gnu.org; 26 May 2024 08:31:33 +0000 Received: from localhost ([127.0.0.1]:38318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB9Hx-0008FI-8f for submit@debbugs.gnu.org; Sun, 26 May 2024 04:31:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB9Hv-0008F6-LF for 71083-done@debbugs.gnu.org; Sun, 26 May 2024 04:31:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sB9Hg-0004DG-8h; Sun, 26 May 2024 04:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AqmHV0vb4w+y7e77cVaotgte8MmJp71kLslQ70IWj8A=; b=XNuV/84wzs92 PUrAqQEkoUs63fkhlJsAZQbL5dlyP1DfXlc1IGFJg7xQw55e2+zjQ+qzta4isL8R0UckqhYDL9Jhc nwOy6IZ4KcrJz46aM78929UPmvKj+S6ybn6FxCTnRys4lAQ4CW0qGRSPycdgEHF/fgAufCxSuVo9Z PGsiyocGpY590dUkYPQ4+CKsig2QAUY803lcC+1+pjcPVzE6lRRnRLG4U8voRhxkbznxA3hoKv2aV XEF1Omj3flScK0JqLkqf/jsNb6dG4Lo3NJSxxV3ZdjKaikuYlpZ16frBaH1wAEmCux3yLe51gdAYj l3YgjeRMxoZxeXHGHJ5ZKQ==; Date: Sun, 26 May 2024 11:30:56 +0300 Message-Id: <86zfsdvutb.fsf@gnu.org> From: Eli Zaretskii To: Lin Sun In-Reply-To: (message from Lin Sun on Sat, 25 May 2024 15:57:51 +0000) Subject: Re: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience References: <86sey6z5ay.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71083-done Cc: 71083-done@debbugs.gnu.org, kobarity@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lin Sun > Date: Sat, 25 May 2024 15:57:51 +0000 > Cc: Eli Zaretskii , 71083@debbugs.gnu.org > > Thank you for the comment, you're right. I had fixed the flymake > diagnostics and the commit message. > > Please help review again. Thanks. Thanks, installed, and closing the bug. Please in the future try to follow our conventions for commit log messages more closely: . quote symbols 'like this' . wrap lines at column 63 . ensure correct file names . mention test names in patches in test/ files . mention the bug number, if known You can see how I reformatted your commit log message this time, to understand better the above conventions. ------------=_1716712322-31742-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 20 May 2024 20:28:41 +0000 Received: from localhost ([127.0.0.1]:44600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s99cf-00017R-0Z for submit@debbugs.gnu.org; Mon, 20 May 2024 16:28:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:53716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s99cb-00017J-F5 for submit@debbugs.gnu.org; Mon, 20 May 2024 16:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s99cW-0004Me-2R for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 16:28:32 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s99cU-0008DY-Bi for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 16:28:31 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-352129e3c8eso2678145f8f.2 for ; Mon, 20 May 2024 13:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716236909; x=1716841709; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rc5gnJvBlIAQBX76/taF/5BV2r7mT6x2jCbX975Qhrc=; b=nRV1raiYdWiDkeVK71T/6ZFY8zxbej1wyz2ghBQDKxe3BQV7Dt1HT54E3f/b0lFhf3 eMbwklwmKZWBa4v6Df2i5vgu5RPGGwcNbWoilLP6n7+QC19QqmBFfX6245YioxZTm/hK 2Ve1FY7wSXVT3iHYfi77wJvaVTLJxRsQ6bi1q8OpoqGgJpxAeVi2rzs4K0GxeW4wCSTx 7HEV6TNP9ejd8u6kMjbIvGZXE5V88f/VpckFTiYiVG2BlPLnw5Rsq9+/wZ/bhx2gTC6I +oFBKzfItwnD1QgUuixeTZ/DhnixQDnshzqYImyrM2L2LauIbL6OQ2a5rkjGSqvcDJcb 8P2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716236909; x=1716841709; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rc5gnJvBlIAQBX76/taF/5BV2r7mT6x2jCbX975Qhrc=; b=sWzQ6NavdU5IKKGfk14JW4vAZmZoP7yla6PW5WqcHJcOLVgnb1FRv4NKTdFVemgmfW 5sRFcqosGaW93bW9jNsMufq0ROXRdeOovLznCI06qx7TgI6MeioP7FAaMbokRLunioK+ cYVAwHJ3OJBTM1AewRLn0PGDDQhwfr6Kowf0XXz1h6QpDF2yUKnTYEZPfYjHu2TgtbJ0 rkdvdOPn3ee6KIlhWQ55MGC4p+9HpT5O8tANNt9PyTdCCC667qEIA9+ITfEheGmifs6N 8cZR1Vn5DPWWk0if0bTm1ft5kaXGpyQpoJiMEYfbx2uX0e3WODPzegjgZCkbvjwaEDWy IH2A== X-Gm-Message-State: AOJu0YyOiY6iOrdRqw+V5mM7Z68kC/aCI3k0oQLufX2iAqgvxgafu7kZ 0dDimdzPP6PTTIJHSlwP3Htig28RABpqOK8YU3NWmDIdi7OB6YcH9v9SXta4CG3P2XETxq5qfu3 cH2Klxu8ix+OWdW+uxPh5SuQEkORJnZlu X-Google-Smtp-Source: AGHT+IEGbyx6023zpzjGvOuQfI7deJYXYJT+BvBs0+0FL4omgpZI4Mss5ysTYJ5/zC2hrerSDfU4TEKLulR7cNkg2Hw= X-Received: by 2002:a05:600c:4fcd:b0:41f:e56c:ef81 with SMTP id 5b1f17b1804b1-41fea93186bmr203868565e9.1.1716236908492; Mon, 20 May 2024 13:28:28 -0700 (PDT) MIME-Version: 1.0 From: Lin Sun Date: Mon, 20 May 2024 20:28:17 +0000 Message-ID: Subject: [PATCH] ; Enhance the "python-shell-send-block" for convenience To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000004854c20618e88b34" Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=sunlin7.mail@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000004854c20618e88b34 Content-Type: text/plain; charset="UTF-8" Hi, This patch tries to make `python-shell-send-block' more convenient. I had added the function `python-shell-send-block' twenty days ago in bug#70609, it will send code block with header by default, and a prefix "C-u" to call the function will send block without header. And I received some feedback that sending a block without a header should be a more used one. Many python blocks begin with "if condition", and users may want to send the block without its condition header to try different condition branches. So this patch will make sending block without header to be the default behavior, and a prefix "C-u" will make the function to send block with header. Please help review this minor change. Thanks --0000000000004854c20618e88b34 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Disposition: attachment; filename="0001-Enhance-the-python-shell-send-block-for-convenience.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lwfezfev0 RnJvbSA3ZWVmYmYzZTRkZTkyNWMyMTFlNDgzYTgwOWQwZjhkOTRlOGQxN2YwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBN b24sIDIwIE1heSAyMDI0IDA2OjU1OjMxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gOyBFbmhhbmNl IHRoZSAicHl0aG9uLXNoZWxsLXNlbmQtYmxvY2siIGZvciBjb252ZW5pZW5jZQoKKiBsaXNwL3By b2dtb2Rlcy9weXRob24uZWwgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrKToKICBUaGUgInB5dGhv bi1zaGVsbC1zZW5kLWJsb2NrIiB3aWxsIHNlbmQgYmxvY2sgd2l0aG91dCBoZWFkZXIgZGVmYXVs dGx5LgoqIGxpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbDogVXBkYXRlIHRlc3QgY2FzZS4KLS0tCiBs aXNwL3Byb2dtb2Rlcy9weXRob24uZWwgICAgICAgICAgICB8IDQgKystLQogdGVzdC9saXNwL3By b2dtb2Rlcy9weXRob24tdGVzdHMuZWwgfCA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgNCBpbnNl cnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3B5 dGhvbi5lbCBiL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbAppbmRleCA3ZjI4ZjU4MzU0My4uOWVj MTk4ZGE3OWEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3B5dGhvbi5lbAorKysgYi9saXNw L3Byb2dtb2Rlcy9weXRob24uZWwKQEAgLTQxNDksMTQgKzQxNDksMTQgQEAgaW50ZXJhY3RpdmVs eS4iCiAgICJTZW5kIHRoZSBibG9jayBhdCBwb2ludCB0byBpbmZlcmlvciBQeXRob24gcHJvY2Vz cy4KIFRoZSBibG9jayBpcyBkZWxpbWl0ZWQgYnkgYHB5dGhvbi1uYXYtYmVnaW5uaW5nLW9mLWJs b2NrJyBhbmQKIGBweXRob24tbmF2LWVuZC1vZi1ibG9jaycuICBJZiBvcHRpb25hbCBhcmd1bWVu dCBBUkcgaXMgbm9uLW5pbAotKGludGVyYWN0aXZlbHksIHRoZSBwcmVmaXggYXJndW1lbnQpLCBz ZW5kIHRoZSBibG9jayBib2R5IHdpdGhvdXQKKyhpbnRlcmFjdGl2ZWx5LCB0aGUgcHJlZml4IGFy Z3VtZW50KSwgc2VuZCB0aGUgYmxvY2sgYm9keSB3aXRoCiBpdHMgaGVhZGVyLiAgSWYgb3B0aW9u YWwgYXJndW1lbnQgTVNHIGlzIG5vbi1uaWwsIGZvcmNlIGRpc3BsYXkKIG9mIGEgdXNlci1mcmll bmRseSBtZXNzYWdlIGlmIHRoZXJlJ3Mgbm8gcHJvY2VzcyBydW5uaW5nOyB0aGlzCiBhbHdheXMg aGFwcGVucyBpbnRlcmFjdGl2ZWx5LiIKICAgKGludGVyYWN0aXZlIChsaXN0IGN1cnJlbnQtcHJl Zml4LWFyZyB0KSkKICAgKGxldCAoKGJlZyAoc2F2ZS1leGN1cnNpb24KICAgICAgICAgICAgICAg ICh3aGVuIChweXRob24tbmF2LWJlZ2lubmluZy1vZi1ibG9jaykKLSAgICAgICAgICAgICAgICAg KGlmIChudWxsIGFyZykKKyAgICAgICAgICAgICAgICAgKGlmIGFyZwogICAgICAgICAgICAgICAg ICAgICAgKGJlZ2lubmluZy1vZi1saW5lKQogICAgICAgICAgICAgICAgICAgIChweXRob24tbmF2 LWVuZC1vZi1zdGF0ZW1lbnQpCiAgICAgICAgICAgICAgICAgICAgKGJlZ2lubmluZy1vZi1saW5l IDIpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLXRlc3RzLmVsIGIv dGVzdC9saXNwL3Byb2dtb2Rlcy9weXRob24tdGVzdHMuZWwKaW5kZXggZjUwNzk3OTUzYzMuLjgw MzAwOGRiOGEzIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5l bAorKysgYi90ZXN0L2xpc3AvcHJvZ21vZGVzL3B5dGhvbi10ZXN0cy5lbApAQCAtNzQ3Niw3ICs3 NDc2LDcgQEAgcHJpbnQoJ2N1cnJlbnQgMycpIgogICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CiAgICAgKHNob3VsZC1lcnJvciAocHl0aG9uLXNoZWxsLXNlbmQtYmxvY2spIDp0eXBlICd1c2Vy LWVycm9yKQogICAgIChmb3J3YXJkLWxpbmUpCi0gICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2Nr KQorICAgIChweXRob24tc2hlbGwtc2VuZC1ibG9jayB0KSA7OyBzZW5kIGJsb2NrIHdpdGggaGVh ZGVyCiAgICAgKHB5dGhvbi10ZXN0cy1zaGVsbC13YWl0LWZvci1wcm9tcHQpCiAgICAgKHB5dGhv bi1zaGVsbC13aXRoLXNoZWxsLWJ1ZmZlcgogICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkK QEAgLTc0ODUsNyArNzQ4NSw3IEBAIHByaW50KCdjdXJyZW50IDMnKSIKICAgICAgIChzaG91bGQg KHJlLXNlYXJjaC1mb3J3YXJkICJjdXJyZW50IDIiIG5pbCB0KSkKICAgICAgIChzaG91bGQtbm90 IChyZS1zZWFyY2gtZm9yd2FyZCAiY3VycmVudCAzIiBuaWwgdCkpKQogICAgIChmb3J3YXJkLWxp bmUpCi0gICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrIHQpIDs7IHNlbmQgYmxvY2sgYm9keSBv bmx5CisgICAgKHB5dGhvbi1zaGVsbC1zZW5kLWJsb2NrKSA7OyBzZW5kIGJsb2NrIGJvZHkgb25s eQogICAgIChweXRob24tdGVzdHMtc2hlbGwtd2FpdC1mb3ItcHJvbXB0KQogICAgIChweXRob24t c2hlbGwtd2l0aC1zaGVsbC1idWZmZXIKICAgICAgIDs7IHNob3VsZCBvbmx5IDEgbGluZSBvdXRw dXQgZnJvbSB0aGUgYmxvY2sgYm9keQotLSAKMi4yMC41Cgo= --0000000000004854c20618e88b34-- ------------=_1716712322-31742-1-- From unknown Sat Aug 16 13:41:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#71083: [PATCH] ; Enhance the "python-shell-send-block" for convenience Resent-From: Lin Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71083 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 71083-done@debbugs.gnu.org, kobarity@gmail.com Received: via spool by 71083-done@debbugs.gnu.org id=D71083.171674897611089 (code D ref 71083); Sun, 26 May 2024 18:43:01 +0000 Received: (at 71083-done) by debbugs.gnu.org; 26 May 2024 18:42:56 +0000 Received: from localhost ([127.0.0.1]:42552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBIpb-0002sn-SD for submit@debbugs.gnu.org; Sun, 26 May 2024 14:42:56 -0400 Received: from mail-lj1-f182.google.com ([209.85.208.182]:58727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBIpZ-0002sZ-NT for 71083-done@debbugs.gnu.org; Sun, 26 May 2024 14:42:54 -0400 Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2e9684e0288so17847661fa.1 for <71083-done@debbugs.gnu.org>; Sun, 26 May 2024 11:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716748899; x=1717353699; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+p+IM3kijaUo226BNqYA/vTyZ6KdSmJCZuxyx2Re19U=; b=I6oGKsdLZtphGShEp5WMHkrAxQ6OBuXua+vvkvparAeVbi30/9km/Dk0DGLqCmRpp5 DMdp3vIqClCU4TwZxra2noBg5JjEoOLGYioZuu1hrpWPRXq/pZ9qRHsb3zq8vgp2khEb scgdNVwoDCPjHEnwaS1Q0u8Hf0IhTxEWP/YGh6JKukxrUWAMYQb40AcC/gZU0OgxScix Yc6mznBX66480imdrI6PS1j/MxCOfVd4KORhLVtyaSR7rEHHQiZ9x2okQT1EWNTmkq15 guaYgJfL2DDEF5Ih4la+IAAsAeGgxxTfdrk62QWq5sxEu6tPul1d6TsrugQ2VNyvF5Jj dfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716748899; x=1717353699; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+p+IM3kijaUo226BNqYA/vTyZ6KdSmJCZuxyx2Re19U=; b=ciGYoSfb8Fj5l6okIyWnzg1CNS63CEXnENNn9WylC1UAP2wlQgPBNwZ/HmHcuE9DwI 9y+WHmbIvCLQSTeTArGSen8T20M4RlOJZ+uWkYS6Cr4hNF80fDdeKoNsI6YDGAx4Q41i AuzuYydizVe4CxcgiJLUD2L4Eg2ln5K9Jh3ea6YvMdNfS5oXFYiAUoz6V6jHIDpxAlgz vCZNx+OsuNmQS8TOz6lVqoWPQfqKs2uv8BocA6ylc2E1bO4YbfanoO2Z/BjVorfbPn1u IQ6AXjZNDBHQY4eEKQDuRR1g5T3ii2i8VsRellAqJjU9LThkjYdaUohwd1yB4y84dnFo cNxQ== X-Forwarded-Encrypted: i=1; AJvYcCXoTJpBJ6CyyARdNYz07QLzwzCikr88hNCVacizxNIxJIAATt6sJcRcF5lmNNoycwRXz8+sKZktLpurhsRWugzOYnxwpHDqYIyFLQ== X-Gm-Message-State: AOJu0YzQ34ASF54GrzjU4wfA/FdBPlgIl4ffWGOjow+xgxHoMo89OZhS jE3xKYQiOP4sljTlOCHlboGur9QNspCsFR55K2h3Be+/WJaEe0MpBBS07AbESC4UQpaxi04skrQ fHCPPMAZEDKK7go64f4x+eLABido= X-Google-Smtp-Source: AGHT+IEGKtI8wuOmqotw2DFene5N8c9S9FUcNzA/MQeos0+cXdL6oSbi5PUxEi52dvfwtd0SrJr/qGMzz0Gnh2ci28M= X-Received: by 2002:a2e:a165:0:b0:2e6:f7f7:772b with SMTP id 38308e7fff4ca-2e95b256484mr65858731fa.37.1716748899048; Sun, 26 May 2024 11:41:39 -0700 (PDT) MIME-Version: 1.0 References: <86sey6z5ay.fsf@gnu.org> <86zfsdvutb.fsf@gnu.org> In-Reply-To: <86zfsdvutb.fsf@gnu.org> From: Lin Sun Date: Sun, 26 May 2024 18:41:28 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, May 26, 2024 at 8:31=E2=80=AFAM Eli Zaretskii wrote: > > > From: Lin Sun > > Date: Sat, 25 May 2024 15:57:51 +0000 > > Cc: Eli Zaretskii , 71083@debbugs.gnu.org > > > > Thank you for the comment, you're right. I had fixed the flymake > > diagnostics and the commit message. > > > > Please help review again. Thanks. > > Thanks, installed, and closing the bug. > > Please in the future try to follow our conventions for commit log > messages more closely: > > . quote symbols 'like this' > . wrap lines at column 63 > . ensure correct file names > . mention test names in patches in test/ files > . mention the bug number, if known > > You can see how I reformatted your commit log message this time, to > understand better the above conventions. Thank you for your comments, and I checked your listed points and the commit message, also readed the CONTRIBUTE document, will follow the points. Appreciate !