GNU bug report logs - #71070
30.0.50; c++-ts-mode namespace wrong fontification.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71070: closed (30.0.50; c++-ts-mode namespace wrong
 fontification.)
Date: Fri, 21 Jun 2024 01:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 20 Jun 2024 18:53:47 -0700
with message-id <FE0E634E-2557-4DF5-BE1E-DF4360A86A65 <at> gmail.com>
and subject line Re: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification.
has caused the debbugs.gnu.org bug report #71070,
regarding 30.0.50; c++-ts-mode namespace wrong fontification.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71070: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71070
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ergus <spacibba <at> aol.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; c++-ts-mode namespace wrong fontification.
Date: Sun, 19 May 2024 20:14:19 +0200

Following up the conversation in the develops mailing list I will report
this issue still happening:

In c++-ts-mode, the namespaces are not fontified like in c++-mode

(i.e in std::string the `std` used to have font-lock-constant-face while
`string` used to have font-lock-type-face).

It seems like tresitter identifies them properly like
(namespace_identifier) and (type_identifier), but the fontification rule
is wrong.

There was an attempt to fix it in c6a5aae3da17459be7550c but the issue
is still there.

Best,
Ergus

[Message part 3 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Ergus <spacibba <at> aol.com>,
 71070-done <at> debbugs.gnu.org
Subject: Re: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification.
Date: Thu, 20 Jun 2024 18:53:47 -0700

> On Jun 19, 2024, at 4:52 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Tue, 18 Jun 2024 23:27:47 -0700
>> Cc: Dmitry Gutov <dmitry <at> gutov.dev>,
>> Ergus <spacibba <at> aol.com>,
>> 71070 <at> debbugs.gnu.org
>> 
>> 
>> 
>>> On Jun 15, 2024, at 1:34 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> 
>>> Ping!  Can we please make some progress here?
>> 
>> As for the original reported bug, I’ve fixed that (now c++-ts-mode fontifies namespaces in constant face). Perhaps namespaces could be fontified in type face instead. I don’t have any opinion on that. My take is that we could add a namespace/module face and make it inherit from either type or constant.
> 
> So you are basically saying that this bug should be closed, and if
> there are more requests, they should open a new bug report?

Yes, this bug is resolved. Closing the report.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.