GNU bug report logs - #71064
[PATCH 0/7] Nsncd: Introduce package + nscd service update

Previous Next

Full log

Message #32 received at 71064 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: picnoir <at> alternativebit.fr
Cc: 71064 <at> debbugs.gnu.org
Subject: Re: [bug#71064] [PATCH 7/7] gnu: services: nscd: add Nsncd optional
 support.
Date: Sun, 02 Jun 2024 20:55:54 +0200

Hi,

picnoir <at> alternativebit.fr skribis:

> From: Picnoir <picnoir <at> alternativebit.fr>
>
> * gnu/services/base.scm (services: nscd: add Nsncd optional support): Add a
> new nscd-use-nscd? field in the Nscd configuration record. When set to #t, the
> nscd service will use Nsncd in place of the Glibc's Nscd. I'm not 100% sure
> adding this to the existing Nscd service is a good idea, it's however the most
> convenient option for now. Or is it? :)

Well, there needs to be a flag somehow.  :-)

Nitpick: could you describe the changes at a syntactic level in the
commit log?  I know our conventions aren’t common today, so whoever
commits it can eventually tweak it on your behalf if needed.

> +  (use-nsncd?  nscd-use-nsncd?                     ;boolean
> +               (default #t))

I’m tempted to make it:

  (implementation nscd-implementation (default 'glibc))

And thus 'nsncd would be the other supported value.

Do you think that makes sense?

Anyhow, could you adjust doc/guix.texi to mention the new field?

Apart from that, the patch looks good to me.  Could you send an updated
version?

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.