From unknown Fri Aug 15 12:51:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#71022 <71022@debbugs.gnu.org> To: bug#71022 <71022@debbugs.gnu.org> Subject: Status: [PATCH] configure.ac: Set default value for the 'prefix' variable. Reply-To: bug#71022 <71022@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:51:02 +0000 retitle 71022 [PATCH] configure.ac: Set default value for the 'prefix' vari= able. reassign 71022 guix-patches submitter 71022 Maxim Cournoyer severity 71022 normal tag 71022 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri May 17 19:55:35 2024 Received: (at submit) by debbugs.gnu.org; 17 May 2024 23:55:35 +0000 Received: from localhost ([127.0.0.1]:57947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s87QF-0003mU-CJ for submit@debbugs.gnu.org; Fri, 17 May 2024 19:55:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:45196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s87QC-0003mO-A2 for submit@debbugs.gnu.org; Fri, 17 May 2024 19:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s87O2-0004DJ-TO for guix-patches@gnu.org; Fri, 17 May 2024 19:53:18 -0400 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s87O0-000893-QH; Fri, 17 May 2024 19:53:18 -0400 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-62036051972so7978907b3.1; Fri, 17 May 2024 16:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715989993; x=1716594793; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Uaq2gwSO2xGxuaRVUpI2osQam0rhtAlAigodtEs01/4=; b=aj7iRlwQHXOfxAYxxLiT7JH33Hji+B6+Ntc0jMZZ4KYzbZBB9LGuVvsZX/uMn5LeYR 834E5Ws/9NHvuK21BsxxZwKoVSN/sy57ED1nQ3C6t+mfGrlL2KH49Ti2V+eAKsdKcleu Ey7xPBWIprKfYGBdl6X6dTfLfb5AnEGKcS3BDrXDbz4r4jeK9YkBt1o0tpTV9ea3jqry aAYr/OppYtahv1WVwuUckx7hTNr8En1UAr1e4X/qwdhMhD5CjycT+S80V13XBf5RX19W dEAi0UN0RC/ZkScw9N7kL6k+vvQY3Q/9aeFRspjK49fbuE1nocbyO9EZC+n4E/B5geBn PDZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715989993; x=1716594793; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Uaq2gwSO2xGxuaRVUpI2osQam0rhtAlAigodtEs01/4=; b=A7TC7FtgatLYsfiCIjUcDYHk1x8L3ZdgNmB9TDtLFuzoUmgx8PP5a7fICaQIipEuAO Eq7p8SMwdppMJaKPL/oDfs2K5OvZBe2NtNuS2WsCJWfoh6rAmmRbw5LZc/istQcHWztl yeo1djqWBw7eGlegXgA3iVA58GnMaTFe7vYSpgMOUQfLymK0UPzvOpf3SKRo3eZQhNuU zfQrWsQPJKRyTqS+W+pgmkzzbyMX6jrGMcRaiF85h3tf20AV6FvSUJKPLU3iyQz/6I8M iz8t8ajeSuruz0bctZQz1yYcwIEX4OQRAYlFIvkANM6t/rzAqdHwgHRH4r/pHN7EWj2n kdYA== X-Forwarded-Encrypted: i=1; AJvYcCWEbqbOcMyspNuyfRTJypM8+IzRVBfqIURoWKaJD87edpAXVw9bAXlh4OTQAUYWTAb+abof8egqjz6RPaMaUQg= X-Gm-Message-State: AOJu0YzfwBAwdlVjoKhM0ulievoNe208apQn7QviwaRar/BSCEOb4ABe Ho3mLYlGXM1ePoSlEKK+XbhM0Rbzyyw5Z14MKAfdnze1oIvprIkACZFU4MxX X-Google-Smtp-Source: AGHT+IFZkux2PKjVBZsjNvV/vJWkVk30JTk1kEI3KrCUFGHxpjhELcr/7h/pktSfxuyUoieG5XTKRw== X-Received: by 2002:a0d:e605:0:b0:627:788e:94c7 with SMTP id 00721157ae682-627788e96fbmr69281697b3.6.1715989992676; Fri, 17 May 2024 16:53:12 -0700 (PDT) Received: from localhost.localdomain (dsl-155-127.b2b2c.ca. [66.158.155.127]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43df54b590csm116150041cf.13.2024.05.17.16.53.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 16:53:12 -0700 (PDT) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH] configure.ac: Set default value for the 'prefix' variable. Date: Fri, 17 May 2024 19:52:33 -0400 Message-ID: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1135; envelope-from=maxim.cournoyer@gmail.com; helo=mail-yw1-x1135.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Guix standard configuration uses a localstatedir of /var and a sysconfdir of /etc. To ease things for everyone, make the default values match that standard expected configuration. See , Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Richard Sent , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) The Guix standard configuration uses a localstatedir of /var and a sysconfdir of /etc. To ease things for everyone, make the default values match that standard expected configuration. See for a related discussion. * configure.ac: Default $prefix to '' unless already set. * doc/contributing.texi (Building from Git): Streamline doc. * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 --- configure.ac | 4 ++++ doc/contributing.texi | 15 +-------------- doc/guix-cookbook.texi | 2 +- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/configure.ac b/configure.ac index 8c3a06da37..f831416650 100644 --- a/configure.ac +++ b/configure.ac @@ -73,6 +73,10 @@ AC_ARG_ENABLE([daemon], [guix_build_daemon="$enableval"], [guix_build_daemon="yes"]) +dnl Set some sane default directory variables for use with the Guix. This +dnl also causes localstatedir to be /var and sysconfdir to be /etc. +test "$prefix" = NONE && prefix= + # Prepare a version of $localstatedir & co. that does not contain references # to shell variables. guix_prefix="`eval echo $prefix | sed -e"s|NONE|/usr/local|g"`" diff --git a/doc/contributing.texi b/doc/contributing.texi index 66f4e86d0a..539b4dd0d3 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -235,7 +235,7 @@ Building from Git Then, run: @example -./configure --localstatedir=/var --sysconfdir=/etc +./configure @end example @noindent @@ -246,19 +246,6 @@ Building from Git important to pass the right @code{localstatedir} and @code{sysconfdir} values, which get recorded in the @code{(guix config)} Guile module. -When configuring Guix on a system that already has a Guix installation, -be sure to specify the same state directory as the existing installation -using the @option{--localstatedir} option of the @command{configure} -script (@pxref{Directory Variables, @code{localstatedir},, standards, -GNU Coding Standards}). Usually, this @var{localstatedir} option is set -to the value @file{/var}. The @command{configure} script protects -against unintended misconfiguration of @var{localstatedir} so you do not -inadvertently corrupt your store (@pxref{The Store}). The configuration -directory should also be configured by setting the @option{--sysconfdir} -option to the @file{/etc} value, which is the location used by Guix to -store for example the access control list of authorized machines and the -definition of offload machines. - Finally, you can build Guix and, if you feel so inclined, run the tests (@pxref{Running the Test Suite}): diff --git a/doc/guix-cookbook.texi b/doc/guix-cookbook.texi index 3bc63cba7a..cbd088632a 100644 --- a/doc/guix-cookbook.texi +++ b/doc/guix-cookbook.texi @@ -5076,7 +5076,7 @@ Guix environment via direnv # Predefine configure flags. configure() @{ - ./configure --localstatedir=/var --prefix= + ./configure @} export_function configure base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 06:42:27 2024 Received: (at submit) by debbugs.gnu.org; 19 May 2024 10:42:27 +0000 Received: from localhost ([127.0.0.1]:35940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8dzm-0003ys-Mf for submit@debbugs.gnu.org; Sun, 19 May 2024 06:42:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:56110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8dzl-0003ym-3x for submit@debbugs.gnu.org; Sun, 19 May 2024 06:42:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8dzg-0006jr-SN for guix-patches@gnu.org; Sun, 19 May 2024 06:42:20 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8dze-0007Ix-8y; Sun, 19 May 2024 06:42:20 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1716115331; cv=none; d=zohomail.com; s=zohoarc; b=oJB/k1MHAPzbARd9QAa9VNCpO5+OpbkZuFK3rbmT1RhSbtMm30HqOUOiJiR9CtmYPJlT+wZtyZLLz7BE0dTSfrrTXc/8YTuUphqNSbltadL1uzggRcA95pkfl5em37b3uxEK5pbqBVAW4hpKVdh0E6pqQsRRAKbU8yQYfI1Pf08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716115331; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=0zug476CqosrN+2qAGb+zoiGy+amoN2kQtPHfeeVqDI=; b=MLJFrD+ii1CpEjEdp2yd514jqnIPHdidqsNM7BQHk2y3eMpj8Em//vOmymqSKj0VGYbNK8R+pvwNzLCMTRGhGZnUZgo8fXD19SFyVDkf4Cxr1M6HbzHdQU3GUc6I9F0Ub7EVDpEtZjKzOgpLZc5LgT0enTyLabjdbciMIyqEH08= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1716115331; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=0zug476CqosrN+2qAGb+zoiGy+amoN2kQtPHfeeVqDI=; b=JXIU80EOEj/xgKPkPmbXf+JQt5NP/x+nsk1C5XOTrKIoeDResZ1mGgadZLMdiG4L ySxDtY+WpBNMksYP90p7EnsvtdLMLH2nHVhOu6ityhW1tSDhUURR5+iV9TsmQr9gSWH pReZ0onKLXx9idWmoafO1/N6Aq3QT1Uo/bPXFr+o= Received: by mx.zohomail.com with SMTPS id 1716115329496962.3010355461726; Sun, 19 May 2024 03:42:09 -0700 (PDT) From: Ricardo Wurmus To: Maxim Cournoyer Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Sun, 19 May 2024 12:42:04 +0200 Message-ID: <87h6eunkw3.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.188.51; envelope-from=rekado@elephly.net; helo=sender4-of-o51.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Andreas Enge , Attila Lendvai , Richard Sent , guix-patches@gnu.org, Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Maxim Cournoyer writes: > -When configuring Guix on a system that already has a Guix installation, > -be sure to specify the same state directory as the existing installation > -using the @option{--localstatedir} option of the @command{configure} > -script (@pxref{Directory Variables, @code{localstatedir},, standards, > -GNU Coding Standards}). Usually, this @var{localstatedir} option is set > -to the value @file{/var}. The @command{configure} script protects > -against unintended misconfiguration of @var{localstatedir} so you do not > -inadvertently corrupt your store (@pxref{The Store}). The configuration > -directory should also be configured by setting the @option{--sysconfdir} > -option to the @file{/etc} value, which is the location used by Guix to > -store for example the access control list of authorized machines and the > -definition of offload machines. This information is still useful, isn't it? It's important for people who intend to modify these locations, such as system administrators who might want to install things elsewhere. Perhaps this could be rewritten to explain why this would be a bad idea. -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 10:16:28 2024 Received: (at 71022) by debbugs.gnu.org; 19 May 2024 14:16:28 +0000 Received: from localhost ([127.0.0.1]:36379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8hKt-0001Y8-U7 for submit@debbugs.gnu.org; Sun, 19 May 2024 10:16:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8hKt-0001Y2-31 for 71022@debbugs.gnu.org; Sun, 19 May 2024 10:16:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8hKg-0005vg-3i; Sun, 19 May 2024 10:16:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=LzXnz2IjXo6EyXSnVaCRGrBfP9rY27Z0GT/hJe6IsDQ=; b=Dy9OYS+K414sv3/CBXct Fwpdo00mX1Ip9Pc8QJLx7k7YR76TU6zlQ1Ai+eIaUuCSNULobuPRZk48nFQkw9rD25R6c6k2VGlux qlZ9Pa+tB8iwWUqInp/7FuNT4Pc/UyFGbYaEtpHunN6dJ/2Cap5M4J0IPBZD/nRxqUbefHeq4bvB8 fFVvfMM29uo/wjLi0D7aS8DxcjLiipqsUd5BBNhW/fUGJjrYmgZgm/UhpL98jE3llvv25mNh/LN0L ppM3RFQ0zukJvAktImBtfQzrLbQawqNbPLXkxhohyJxUwIbyDaj+NIdY2oknw2LmweJxTecuvNDO9 RNdkkVMITFEbzw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 1 Prairial an 232 de la =?utf-8?Q?R=C3=A9vol?= =?utf-8?Q?ution=2C?= jour de la Luzerne X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 19 May 2024 16:16:10 +0200 Message-ID: <87ttit3n11.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71022 Cc: Simon Tournier , Vagrant Cascadian , Richard Sent , 71022@debbugs.gnu.org, Efraim Flashner , Florian Pelz , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Matthew Trzcinski , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi Maxim, Maxim Cournoyer skribis: > The Guix standard configuration uses a localstatedir of /var and a syscon= fdir > of /etc. To ease things for everyone, make the default values match that > standard expected configuration. See > for= a > related discussion. > > * configure.ac: Default $prefix to '' unless already set. > * doc/contributing.texi (Building from Git): Streamline doc. > * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. > > Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 [...] > +dnl Set some sane default directory variables for use with the Guix. Th= is > +dnl also causes localstatedir to be /var and sysconfdir to be /etc. > +test "$prefix" =3D NONE && prefix=3D Shouldn=E2=80=99t it read =E2=80=9Cprefix=3D/=E2=80=9D? Might be good to check whether this breaks =E2=80=9Cmake distcheck=E2=80=9D= , so I suppose it should be fine. Apart from that it LGTM. Thanks for this patch! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 20:16:48 2024 Received: (at submit) by debbugs.gnu.org; 22 May 2024 00:16:48 +0000 Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Zey-0008K3-14 for submit@debbugs.gnu.org; Tue, 21 May 2024 20:16:48 -0400 Received: from lists.gnu.org ([209.51.188.17]:54322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Zew-0008Jx-2z for submit@debbugs.gnu.org; Tue, 21 May 2024 20:16:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9Zem-0002SZ-2W for guix-patches@gnu.org; Tue, 21 May 2024 20:16:38 -0400 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9Zek-0007lf-Fx; Tue, 21 May 2024 20:16:35 -0400 Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-792e4c2a002so55548885a.0; Tue, 21 May 2024 17:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716336991; x=1716941791; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=; b=h8uQa3yWBsXWNN7Zjc41c2GVu+XlhCwRBT4bu7n+uNgVezaWUlJrgRYQ5MEoN4g5hM aolYCVa7DCMjgvDjbJtM5drbGAvLZZTGkS6+rdOgnO0MipdZr+fIwYd+XLXLa0n6G43D 03KFe7lkXY/1mwqzUJRLm3YzL34DBFL5LUt7rnGbibgQh7YmVuCvBPY7nSSeHYOwSwjJ 5/ZqtFxfSMuCr8nRbzxFm64HvmSRptPlEJ7+qJ9xC6iDm6QTwtumrYDVkHG28BAy9Ijk i+20fAltqMl5jQDylTiZGn01R8xNXJ6ftFgDD/6vnsQhoHq6Y352HHXNy7vyn5udhhpp yz0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716336991; x=1716941791; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wqGtuEYnO2wBZXhocr4chnr/1qI/HebSLvOvcX6Zd4Q=; b=kfMu2yFgSXBf40SR2dPRf2AA8++ybf0LWUZ6Ovah0ws/rmuWjWvvZzDDVWqrXfUgNs LAu2ZCZczzbK8Aq9+BeMPOVrgnDGsHDFAPR88kZB1X0UZCuXOG+x9lwLF+5AeCCPpDL1 CdnoCHgi/Bheq3Y8BzlkbkqlhpZeJ6NNsoTCZUip7MAXDD7DKmrBFSWEY6wFxMaepwpE dhRCEClMApAVppkqkEYgp1f7/chYw4EPGTT7I8yFdnS/JnsFuOiQLeiHUwl7xAKLUJe/ rGlKtxoU3DgfxlxFMyei1a/EthyB46MWImVd817zoWkmiMWO4f4IOaHI9S3Whp2S90P4 xL1Q== X-Forwarded-Encrypted: i=1; AJvYcCWjgU0PY+eYmA5xXxZdgZDHlx6o6xoKSz1OSkk0HVG5arparregpOP8naLfB02f4XlIx85LVT0bpIY2VjHcsX5q42wYYk9WktVkPmh88g== X-Gm-Message-State: AOJu0Yw9GdaAjFHeK39TRV1fxbWoPwCIfntuMLkiQGtkshjrSQN8qO8X zosCPxp8zU5xpNLxhpgV10cMoARe8ZIyP7F8+HBKdknbf/FDzJkI X-Google-Smtp-Source: AGHT+IEWBoo8aKQ+rhH3wECek+er/5s3+pgrDtnmm/i6RTQEI2dsnRcEdQUdqHyCbbcfWAsQO+YxXQ== X-Received: by 2002:a05:620a:4ce:b0:792:989e:7c5b with SMTP id af79cd13be357-794994b3f82mr46181585a.60.1716336991148; Tue, 21 May 2024 17:16:31 -0700 (PDT) Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234]) by smtp.gmail.com with ESMTPSA id af79cd13be357-792bf2972cdsm1325371785a.54.2024.05.21.17.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 17:16:30 -0700 (PDT) From: Maxim Cournoyer To: Ricardo Wurmus Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <87h6eunkw3.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 19 May 2024 12:42:04 +0200") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> <87h6eunkw3.fsf@elephly.net> Date: Tue, 21 May 2024 20:16:28 -0400 Message-ID: <87r0du4s6b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Andreas Enge , Attila Lendvai , Richard Sent , guix-patches@gnu.org, Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Ricardo, Ricardo Wurmus writes: > Maxim Cournoyer writes: > >> -When configuring Guix on a system that already has a Guix installation, >> -be sure to specify the same state directory as the existing installation >> -using the @option{--localstatedir} option of the @command{configure} >> -script (@pxref{Directory Variables, @code{localstatedir},, standards, >> -GNU Coding Standards}). Usually, this @var{localstatedir} option is set >> -to the value @file{/var}. The @command{configure} script protects >> -against unintended misconfiguration of @var{localstatedir} so you do not >> -inadvertently corrupt your store (@pxref{The Store}). The configuration >> -directory should also be configured by setting the @option{--sysconfdir} >> -option to the @file{/etc} value, which is the location used by Guix to >> -store for example the access control list of authorized machines and the >> -definition of offload machines. > > This information is still useful, isn't it? It's important for people > who intend to modify these locations, such as system administrators who > might want to install things elsewhere. Perhaps this could be rewritten > to explain why this would be a bad idea. It's useful, but it's duplicated with the warning you'd get from the GUIX_CHECK_LOCALSTATEDIR m4/guix.m4 macro: --8<---------------cut here---------------start------------->8--- dnl GUIX_CHECK_LOCALSTATEDIR dnl dnl Check that the LOCALSTATEDIR value is consistent with that of the existing dnl Guix installation, if any. Error out or warn if they do not match. AC_DEFUN([GUIX_CHECK_LOCALSTATEDIR], [ AC_REQUIRE([GUIX_CURRENT_LOCALSTATEDIR]) if test "x$guix_cv_current_localstatedir" != "xnone"; then if test "$guix_cv_current_localstatedir" != "$guix_localstatedir"; then case "$localstatedir" in NONE|\${prefix}*) # User kept the default value---i.e., did not pass '--localstatedir'. AC_MSG_ERROR([chosen localstatedir '$guix_localstatedir' does not match \ that of the existing installation '$guix_cv_current_localstatedir' Installing may corrupt $storedir! Use './configure --localstatedir=$guix_cv_current_localstatedir'.]) ;; *) # User passed an explicit '--localstatedir'. Assume they know what # they're doing. AC_MSG_WARN([chosen localstatedir '$guix_localstatedir' does not match \ that of the existing installation '$guix_cv_current_localstatedir']) AC_MSG_WARN([installing may corrupt $storedir!]) ;; esac fi fi]) --8<---------------cut here---------------end--------------->8--- So it seems judicious to remove it, especially since with this change the default `./configure` would no longer require the user to think about '--localstatedir' and friends (unless their system was an odd snowflake, in which case the macro would do its job to warn them). Does that clarify the intent? -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue May 21 20:24:19 2024 Received: (at submit) by debbugs.gnu.org; 22 May 2024 00:24:19 +0000 Received: from localhost ([127.0.0.1]:52060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9ZmE-0008PX-NA for submit@debbugs.gnu.org; Tue, 21 May 2024 20:24:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9Zm9-0008PR-IN for submit@debbugs.gnu.org; Tue, 21 May 2024 20:24:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9Zm2-00053X-Rk for guix-patches@gnu.org; Tue, 21 May 2024 20:24:06 -0400 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9Zm1-0001As-1o; Tue, 21 May 2024 20:24:06 -0400 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-62036051972so47370127b3.1; Tue, 21 May 2024 17:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716337442; x=1716942242; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=0jcIdBee1R2rZTljm33wefbwO8181SGEyosUpIEfbdI=; b=PhG+31BsV+UdeiPptZYNxxSPSw4PH2/fqTDx079eUIajKCz/xgzBH4SEGnAnzwOh/J Lhaqz1Nh9WHpx8WCXzQcIpnuTRVDC5xykMab0j+E5cT3r6REpjz9DBo1/3sFiFVrCa9s +ggL8uEm3IonOH5OD+8xfJWbbDPUIkM8Flf1ogDHFKjLzLquetthAa1LmvMGj1TGAnXZ EOguGHP2mJP1ef046i0+qT0kx20wdKtfEGRFpErX+5Mrb2TkcnM1jAUi4cdSpAwza+Dj hc1YdhPeMSCthCWMsfHjhjzDa129uLVcxvMAB2FJkwLzTiqiWqwJS2vA6L/z01Y080YF ulOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716337442; x=1716942242; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0jcIdBee1R2rZTljm33wefbwO8181SGEyosUpIEfbdI=; b=EsqcHHgGs9hsYvg9H8sgycY9YENnb6jccyaThNxvS+mMXitC2blJqVlmhzo7h1UOf4 xRwsT4y9sD/Ve3+MBrtYyzEX7Y+VScYyY3e3GUPNRNzRqQto8b5xKKlwEXiaa7ttWP3U yYMQM6IOJRS6GYvhXYqSje5B2VIA0LjpsLR9v8WAUPQKEGYWbWknmisAwJiuvjWhcbiS kbl+bu2owbUqN/jDi5jX9XiqJ0dHzoEdnXkkUy8mGP5aWIutg7W0QhpYCm18yfIhWkug tHiL2Pf2cNX5LFbTEbPi7R69QYsBNxS2FZ2BkMOJlLoA9z1Yj/2F2K5QdYXRHE/aGlFy FRig== X-Forwarded-Encrypted: i=1; AJvYcCU6saXX7BMzY1Xxxt8zVKbgNGljV/wR3WhmH77pAHNxVwUmthvOQeDJQ5MjJnlS41wRyvosbMu3PWQ2ncbdPp8= X-Gm-Message-State: AOJu0Ywbd4tDCTWhZv5el/DNMPxlS1p865c4vVa8FU4E5nTduvqMdKnL ab8QGCJ2r+nPW+EYOeke9+bkbkaRXUjHXYLHnqswCDiTnYOmll63 X-Google-Smtp-Source: AGHT+IF5+EuxM+kjYMoESdlU6MbKOmusdnchNNN4mONSAmjyFpdYdZ6SPJdk/DamIDdrRmkri3oTnQ== X-Received: by 2002:a81:4c53:0:b0:618:79f5:8d32 with SMTP id 00721157ae682-627e4896f89mr6045417b3.48.1716337442202; Tue, 21 May 2024 17:24:02 -0700 (PDT) Received: from hurd (dsl-205-233-124-234.b2b2c.ca. [205.233.124.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6ab8231dc95sm999186d6.69.2024.05.21.17.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 17:24:01 -0700 (PDT) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: Re: [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Fri, 17 May 2024 19:52:33 -0400") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> Date: Tue, 21 May 2024 20:24:00 -0400 Message-ID: <87jzjm4rtr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1131; envelope-from=maxim.cournoyer@gmail.com; helo=mail-yw1-x1131.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Richard Sent , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Maxim Cournoyer writes: > The Guix standard configuration uses a localstatedir of /var and a sysconfdir > of /etc. To ease things for everyone, make the default values match that > standard expected configuration. See > for a > related discussion. > > * configure.ac: Default $prefix to '' unless already set. > * doc/contributing.texi (Building from Git): Streamline doc. > * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. > > Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 While authoring the above, I got thinking about *why* we can't default to the default GNU /usr/local prefix, since Guix *should* handle this correctly, via paths registered in the (guix config). I guess the only reason is that /var is the hard-coded $localstatedir value we chose for any Guix package and can't meaningfully be changed (without rewritting the graft), so if it must exists anyway, we might as well use it for Guix itself by default. In other words, I believe this change does the right thing (the other idea I was musing with defaulting '--prefix=' or '--localstatedir' to the value of any installed guix, unless the user had provided one explicitly). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 08:31:18 2024 Received: (at 71022) by debbugs.gnu.org; 22 May 2024 12:31:18 +0000 Received: from localhost ([127.0.0.1]:55665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9l7m-0002C0-BV for submit@debbugs.gnu.org; Wed, 22 May 2024 08:31:18 -0400 Received: from mail-yw1-f171.google.com ([209.85.128.171]:52429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9l7j-0002Bs-SQ for 71022@debbugs.gnu.org; Wed, 22 May 2024 08:31:16 -0400 Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-627788ce780so8237477b3.0 for <71022@debbugs.gnu.org>; Wed, 22 May 2024 05:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716381004; x=1716985804; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=afMCZI8oM3k56/P27G4uBR138cXIpozQ5cf05ckaybo=; b=j4Pn+Z3iG1ltITPQ6kTgtKsGHsviKuOB9qxxyb9ewcnKkaXBFYfvdya6I9tNBLrjOl dh0w2AGwVuSWM8LzrMO4Q+SY9/G1ziZJpPYe+q8BHvjUBo3vaa0IIiMZ6PKbFN4XmDaB LKF5NN9S5Iuk8Qu+Fbu3VQXO2Wg9yGZ57wtdwpi00lV7QJjfmKCDwQGgUUSpfadU4LdZ obp31fBuTB0Gm855Ieb5gLWQrmvt3+IKd+V6wHsjT905HyHg93ZrWGh+Ro5Y0shaoksp LPGP7ibK23OZ8GZ9Gl2vtYqzgpGgost3Av6bCw1PX3joj9PfvyC6vPO5AY7Gbtnol/jr YQyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716381004; x=1716985804; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=afMCZI8oM3k56/P27G4uBR138cXIpozQ5cf05ckaybo=; b=hR3y6aObuVu9Bh/y/sPaiBMGXX+ny/ilFQ53QVVphyyckWCjnDMl3J+4SnjGr5vvaW DVoUGeReKh5jjMsUn+Pl+siyhmGlk/UnPQ6JlWBQK+0Mi+jURx2YdU7ZpOiI/2fSsr1p BKrc3daR2BmEzpVtnKlY27O1ObFEB75czd/wqS9tYm/r9+/rX4KEAlcduHtw8BJB8QcL Cf7HVHz/yLS5KID4Oyv/LWnslogcUnWDuwDtghUI8Ml2aPKp0KRFU8U7P3QUlv2ZKAQc Kr4wareX/Yc07GQJvWt99Ohi4hgXfuom5w+rcj/Gn15l3HDz1/JqsQPvDbrl+g+irGc2 QAfg== X-Gm-Message-State: AOJu0Yx5wShwssCUJWbjrH+KFqrA0UzqzegGhNH1TvG27kRRiXV/NFP+ 1Iz6IvHRFRlgwqJi0QhLZgrH2qONRQDtNmyPrLmAufPvIUU+fSIi X-Google-Smtp-Source: AGHT+IHer5QeQDZINeUSSgjSVE96txYTISQNx9ImegfOWawG2Wad1MemLwjL6YgUV3PUK4SsXbsV1w== X-Received: by 2002:a05:6902:2191:b0:de6:4ff:3167 with SMTP id 3f1490d57ef6-df4e0dfa469mr2250587276.57.1716381003981; Wed, 22 May 2024 05:30:03 -0700 (PDT) Received: from hurd (dsl-148-133.b2b2c.ca. [66.158.148.133]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43e1c32e8basm125267081cf.36.2024.05.22.05.30.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 05:30:03 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <87ttit3n11.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 19 May 2024 16:16:10 +0200") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> <87ttit3n11.fsf@gnu.org> Date: Wed, 22 May 2024 08:30:01 -0400 Message-ID: <87frua3u7q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ludovic, Ludovic Courtès writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> The Guix standard configuration uses a localstatedir of /var and a sysconfdir >> of /etc. To ease things for everyone, make the default values match tha [...] Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.0 MANY_TO_CC Sent to 10+ recipients -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.171 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.171 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 71022 Cc: Simon Tournier , Vagrant Cascadian , Richard Sent , 71022@debbugs.gnu.org, Efraim Flashner , Florian Pelz , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Matthew Trzcinski , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Ludovic, Ludovic Courtès writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> The Guix standard configuration uses a localstatedir of /var and a sysconfdir >> of /etc. To ease things for everyone, make the default values match tha [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.171 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.171 listed in list.dnswl.org] 3.0 MANY_TO_CC Sent to 10+ recipients 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (maxim.cournoyer[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> The Guix standard configuration uses a localstatedir of /var and a sysco= nfdir >> of /etc. To ease things for everyone, make the default values match that >> standard expected configuration. See >> fo= r a >> related discussion. >> >> * configure.ac: Default $prefix to '' unless already set. >> * doc/contributing.texi (Building from Git): Streamline doc. >> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. >> >> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 > > [...] > >> +dnl Set some sane default directory variables for use with the Guix. T= his >> +dnl also causes localstatedir to be /var and sysconfdir to be /etc. >> +test "$prefix" =3D NONE && prefix=3D > > Shouldn=E2=80=99t it read =E2=80=9Cprefix=3D/=E2=80=9D? This is what I went for originally, but it would cause this error: --8<---------------cut here---------------start------------->8--- configure: error: chosen localstatedir '//var' does not match that of the e= xisting installation '/var' Installing may corrupt /gnu/store! Use './configure --localstatedir=3D/var'. --8<---------------cut here---------------end--------------->8--- So it seems Autoconf's generated configure script expects --prefix to *not* contain a trailing '/', which is the case for --prefix=3D/. > Might be good to check whether this breaks =E2=80=9Cmake distcheck=E2=80= =9D, so I > suppose it should be fine. Good suggestion; I just tested the target and the tarball was successfully generated. > Apart from that it LGTM. Thanks for this patch! Thanks for reviewing it! I'll send a v2, and wait for further comments, if any. --=20 Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed May 22 08:53:45 2024 Received: (at 71022) by debbugs.gnu.org; 22 May 2024 12:53:45 +0000 Received: from localhost ([127.0.0.1]:55778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9lTT-0002OB-4y for submit@debbugs.gnu.org; Wed, 22 May 2024 08:53:45 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:43143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9lTN-0002O5-Ks for 71022@debbugs.gnu.org; Wed, 22 May 2024 08:53:41 -0400 Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-43df23e034cso8179741cf.0 for <71022@debbugs.gnu.org>; Wed, 22 May 2024 05:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716382346; x=1716987146; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CZow95mWgFISkqByIXrjZNUAU2iZ/+5P205AsZ2ltX4=; b=V8sPVW1vHRxvPRlYFKAKXGQF38VhjqaWxxCJq1uxXlYzUF65BE7l7sLQiAeOVj9rES l43Fs90oUCyfgNJIZC4vRCV2/YkcyUZCCx9+6U+yKJfZFjmrgHBIoHG0v1e6RE63NVr3 DomY/yTVS/ek5DU3DrK+4i+kROWrefJ4EqMnK3CkVL1O+Jno218qWFdx1lqIwKkqneNO a9Chj1Nv/Hwst0BIhoTx1JJNbTCE0hH3oHRc7owWuYcT2Ex3mBdjxkVtdeFcAQ7Y9wCL QOeO58hfte7XnVYxXT2TcmqkCpRJ4GgcMRVZ3QTMz1YXI/Xb5V1DFp3GWSoJTx1dAP1q cfrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716382346; x=1716987146; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CZow95mWgFISkqByIXrjZNUAU2iZ/+5P205AsZ2ltX4=; b=VmhBKi4/Up2iyKSUz4e1gj5DR18llWB319n3a24L0g8tubsxtTdfooI0oQuTic+la5 hv8clMyUCKzKCqjPL5Oabl+A8f8XDageyApW0XBe/eYG26BQFl0TIM6f2h/cQ47GaaAD Gj/aqpQizOeiI/t+Hf//kRsM+mmJHbX5ing+EIX4C4iNzYqn1usp+eAAWpsX4AKmXFSZ ver5Yntq3KlNS9Fy9a0FOVoLt9W9DuZH0Pm/J0EvGzIq3l455jMeRe2jojKoW6szA94B J70zMrh5Qzap5BQeqGhauHFBBktqWgXoBDUmN80rt6U18MNWK3wA5MygbQyD4Z5iL4dc WB1w== X-Gm-Message-State: AOJu0YxHxCnBHzKu+9frNJxMg1mPxw54EZqe8+LbsMgJDtkO1sfKqwpX WTjd3fmSFtgEMC/Sbd+VNe01rz00NbtFzXt5v25pmmndNIHQ0HmrfLV3EoO8 X-Google-Smtp-Source: AGHT+IG7oV3fAsLpU0rf60+kiCVSIV/4l9AX2KyOuHLxgcDSx71FI95m5I3itLgHZ72ocAiDrAo1Ug== X-Received: by 2002:a05:622a:120d:b0:43a:bee9:ebc with SMTP id d75a77b69052e-43f9dddbe77mr35702611cf.19.1716382345703; Wed, 22 May 2024 05:52:25 -0700 (PDT) Received: from localhost.localdomain (dsl-148-133.b2b2c.ca. [66.158.148.133]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43dfa52e547sm164005411cf.10.2024.05.22.05.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 05:52:25 -0700 (PDT) From: Maxim Cournoyer To: 71022@debbugs.gnu.org Subject: [PATCH v2] configure.ac: Set default value for the 'prefix' variable. Date: Wed, 22 May 2024 08:51:57 -0400 Message-ID: <8e5c69aa6d108ce35c3124a969252227ce9ed178.1716382317.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Florian Pelz , Ludovic Courtès , Matthew Trzcinski , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Guix standard configuration uses a localstatedir of /var and a sysconfdir of /etc. To ease things for everyone, make the default values match that standard expected configuration. See , Simon Tournier , Vagrant Cascadian , ludo@gnu.org, Efraim Flashner , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Richard Sent , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The Guix standard configuration uses a localstatedir of /var and a sysconfdir of /etc. To ease things for everyone, make the default values match that standard expected configuration. See for a related discussion. * configure.ac: Default $prefix to '' unless already set. * doc/contributing.texi (Building from Git): Streamline doc. * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 --- Changes in v2: - combine comments and default directory variables manipulation configure.ac | 8 +++++--- doc/contributing.texi | 15 +-------------- doc/guix-cookbook.texi | 2 +- 3 files changed, 7 insertions(+), 18 deletions(-) diff --git a/configure.ac b/configure.ac index 8c3a06da37..c7b61d56a7 100644 --- a/configure.ac +++ b/configure.ac @@ -73,9 +73,11 @@ AC_ARG_ENABLE([daemon], [guix_build_daemon="$enableval"], [guix_build_daemon="yes"]) -# Prepare a version of $localstatedir & co. that does not contain references -# to shell variables. -guix_prefix="`eval echo $prefix | sed -e"s|NONE|/usr/local|g"`" +dnl Prepare a version of $localstatedir & co. that does not contain references +dnl to shell variables. Also set some sane default directory variables for +dnl use with the Guix. This also causes localstatedir to be /var and +dnl sysconfdir to be /etc. +test "$prefix" = NONE && prefix= guix_localstatedir="`eval echo $localstatedir | sed -e "s|NONE|$guix_prefix|g"`" guix_sysconfdir="`eval echo $sysconfdir | sed -e "s|NONE|$guix_prefix|g"`" guix_sbindir="`eval echo $sbindir | sed -e "s|NONE|$guix_prefix|g"`" diff --git a/doc/contributing.texi b/doc/contributing.texi index 66f4e86d0a..539b4dd0d3 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -235,7 +235,7 @@ Building from Git Then, run: @example -./configure --localstatedir=/var --sysconfdir=/etc +./configure @end example @noindent @@ -246,19 +246,6 @@ Building from Git important to pass the right @code{localstatedir} and @code{sysconfdir} values, which get recorded in the @code{(guix config)} Guile module. -When configuring Guix on a system that already has a Guix installation, -be sure to specify the same state directory as the existing installation -using the @option{--localstatedir} option of the @command{configure} -script (@pxref{Directory Variables, @code{localstatedir},, standards, -GNU Coding Standards}). Usually, this @var{localstatedir} option is set -to the value @file{/var}. The @command{configure} script protects -against unintended misconfiguration of @var{localstatedir} so you do not -inadvertently corrupt your store (@pxref{The Store}). The configuration -directory should also be configured by setting the @option{--sysconfdir} -option to the @file{/etc} value, which is the location used by Guix to -store for example the access control list of authorized machines and the -definition of offload machines. - Finally, you can build Guix and, if you feel so inclined, run the tests (@pxref{Running the Test Suite}): diff --git a/doc/guix-cookbook.texi b/doc/guix-cookbook.texi index 3bc63cba7a..cbd088632a 100644 --- a/doc/guix-cookbook.texi +++ b/doc/guix-cookbook.texi @@ -5076,7 +5076,7 @@ Guix environment via direnv # Predefine configure flags. configure() @{ - ./configure --localstatedir=/var --prefix= + ./configure @} export_function configure base-commit: 5a624adfd7b14c3717237d137bd0766c77f0f570 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 05:17:38 2024 Received: (at 71022) by debbugs.gnu.org; 23 May 2024 09:17:38 +0000 Received: from localhost ([127.0.0.1]:58769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA4Zu-0000Q6-BT for submit@debbugs.gnu.org; Thu, 23 May 2024 05:17:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA4Zs-0000Q0-E2 for 71022@debbugs.gnu.org; Thu, 23 May 2024 05:17:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA4Zc-0003dG-86; Thu, 23 May 2024 05:17:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=29m1bEUlj1HFloQ3h4qvSyW7YLCk3FxXKHc9Qq68C7A=; b=g4cgThiw5JRLIEIzEFip Fiyx4d6elzbyvA1MFrv0nIblpbnL3y4+QBF3OI3uf8TrVUhyhysUp3pRar4wKSBTAg4XmNcIoPnCp jJKIMGNKmns8Uop7hPWBPt+Mywa+E0P9ztJ3WxKD9tpPARKJO0o7RqCBHHAfbbOI4M0kGOn6B1uXn ZA7hNzsGc5oY11Muuth0+qYybZD/B7bJe0S+/+bY2xjm7/Irn9vfb/cuUBhrMrvh/feAXH4zOO0ZE 3wO+KaDidFQ1RRADKqeW/+vr+Ioz6xnVshkOjqwUwscKv4Ihb8HKQo8wij50tfdKXz9vlYayGJ2xn Nc/a9e5xIzWicw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#71022] [PATCH] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <87frua3u7q.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 22 May 2024 08:30:01 -0400") References: <9ac2df37867548ae5e15e4c262458d8fc63ba9a1.1715989953.git.maxim.cournoyer@gmail.com> <87ttit3n11.fsf@gnu.org> <87frua3u7q.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 Prairial an 232 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour du Canard X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 23 May 2024 11:17:17 +0200 Message-ID: <87cypcc2g2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 71022 Cc: Simon Tournier , Vagrant Cascadian , Richard Sent , 71022@debbugs.gnu.org, Efraim Flashner , Florian Pelz , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Matthew Trzcinski , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Maxim Cournoyer skribis: >> Shouldn=E2=80=99t it read =E2=80=9Cprefix=3D/=E2=80=9D? > > This is what I went for originally, but it would cause this error: > > configure: error: chosen localstatedir '//var' does not match that of the= existing installation '/var' > Installing may corrupt /gnu/store! > Use './configure --localstatedir=3D/var'. > > So it seems Autoconf's generated configure script expects --prefix to > *not* contain a trailing '/', which is the case for --prefix=3D/. Oh I see, makes sense. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu May 23 05:18:11 2024 Received: (at 71022) by debbugs.gnu.org; 23 May 2024 09:18:11 +0000 Received: from localhost ([127.0.0.1]:58774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA4aQ-0000Qi-Lh for submit@debbugs.gnu.org; Thu, 23 May 2024 05:18:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sA4aO-0000Qb-S0 for 71022@debbugs.gnu.org; Thu, 23 May 2024 05:18:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA4aC-0003m2-2c; Thu, 23 May 2024 05:17:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8J6SIfNiXBMI8hrsxMUI4SuAQAIrWeiq2ZTovJU39aM=; b=a5ZoTjnbXd9vPUL4yIUs rynIFFdA/ZnaeoKmiO/iJ3vk9wr9Z2MzerpaU3iuaV4ov+Y03H6GzmfGuzVKyRq8tgO5/HADAJZ1Q KTZBpk4/CRDEBxqAOrtI9AHQZQex+Brg79ijcEAck1CcI+/i1rTZEZkpowzR8jCH/zWg5w3B/bWC7 x1U8//iVwkbaKHS3y1XprjiulDsF2uZSFcozF4Y9lEM81Xmdj+7vO4KYffJd8qjV5EqrQyNnbOZPo 9NExEQe9N5d1JMVdPGWA46VOZL1Xg69kQsJYzJRe2xLPScZM82CS24Ubbl0XiL5U/LbRP+lRe4XCz GID/eHO0lA4s1Q==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH v2] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <8e5c69aa6d108ce35c3124a969252227ce9ed178.1716382317.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 22 May 2024 08:51:57 -0400") References: <8e5c69aa6d108ce35c3124a969252227ce9ed178.1716382317.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 5 Prairial an 232 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour du Canard X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 23 May 2024 11:17:48 +0200 Message-ID: <878r00c2f7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 71022 Cc: 71022@debbugs.gnu.org, Vagrant Cascadian , Richard Sent , Simon Tournier , Efraim Flashner , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Maxim Cournoyer skribis: > The Guix standard configuration uses a localstatedir of /var and a sysconfdir > of /etc. To ease things for everyone, make the default values match that > standard expected configuration. See > for a > related discussion. > > * configure.ac: Default $prefix to '' unless already set. > * doc/contributing.texi (Building from Git): Streamline doc. > * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. > > Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 LGTM! :-) From debbugs-submit-bounces@debbugs.gnu.org Sat May 25 23:39:35 2024 Received: (at 71022-done) by debbugs.gnu.org; 26 May 2024 03:39:36 +0000 Received: from localhost ([127.0.0.1]:38152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB4jP-0000sP-FX for submit@debbugs.gnu.org; Sat, 25 May 2024 23:39:35 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:56435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sB4jI-0000s4-65 for 71022-done@debbugs.gnu.org; Sat, 25 May 2024 23:39:33 -0400 Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-43fb387d9d0so10469481cf.0 for <71022-done@debbugs.gnu.org>; Sat, 25 May 2024 20:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716694694; x=1717299494; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h1EpFuz5hfwapMxdjZ3AwYTxXd0UB+wUeLrJzIv2Uys=; b=IVKrN7A2s6MyKHc6MZYT1jJNwhq687e/plUIOGkv8/s2jJ1zpJvGkaMynmmu6e3xkO GxblQWuMCfd2PTG6sdZ4UAZzJCSOLXLSAas5vhbA4w/CiEbHhyvDcMCDiDyr0CgqquRf ps9GURyW4JqW+GU2FAmcDUYkSPVjJ7bjSVhpftevLkSfdlUbRU60UFleOadlAMktmHZq ih/wbST44csHExtpCibII0oEa5FE6e/HHB8M5L6y+/KvBAMv1eRNiCUnEpd9jCUBaabK 1nAcviGvQ0XmHTIHkdS564akSLqLEKK8QjBWdQ45gLbaJxi2iOn+B9D6DvO/A6czSDCl 3YGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716694694; x=1717299494; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=h1EpFuz5hfwapMxdjZ3AwYTxXd0UB+wUeLrJzIv2Uys=; b=bukMXgPnsNFNpPMxBBT/6kzQnJQUEiQUFl70y081AIHq9h0IQKQqmHfTLGxHUohTC2 trHQD5Nhqh5xCqRKMjZQ+lfqs7Yjmdc3wZBOP/yxB0P2RDWjzyXUzknkfzLb38razfTX vSMax11V3i2jciA2tY8jjKC8Y5gOKfoPzfCvjkHP3uj+Fzg7D/Csnv4UkLzqRpGdVpCu UBaQ0oKKUGtIVSKKRb5pvEbWz6Zr3FYyno8uXp0Cj1SvCN8NAJpdMkGOwBfeidnU/whS GhH31YdIsqNAE89gWauQzcXBvUCOh+jPDji1R56jeH3nAAlpK/Kxk9oFWOmQezZwj+Bn t3SA== X-Gm-Message-State: AOJu0YzkQPO9Byv3Nt08NeiVV7jMq6fQyohQBGs1ZwdLHWfGB/TNY+Qd dMoA7g+HakBPOvcoEmF1A3Fth9xoXVmni0KOqFR2vQPMC6856fpG X-Google-Smtp-Source: AGHT+IGSgjUpapP4xAR/w1Jq44ACjDLLc7g85RsK/K1nn4EcTGEakS0shA/QvJO1Oh5JnyMe5Y7eMw== X-Received: by 2002:a05:622a:1213:b0:43c:5d37:5a94 with SMTP id d75a77b69052e-43fb0f019d9mr71312741cf.62.1716694694246; Sat, 25 May 2024 20:38:14 -0700 (PDT) Received: from hurd (dsl-10-130-164.b2b2c.ca. [72.10.130.164]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43fb18ae7e5sm21418181cf.74.2024.05.25.20.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 May 2024 20:38:13 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH v2] configure.ac: Set default value for the 'prefix' variable. In-Reply-To: <878r00c2f7.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 23 May 2024 11:17:48 +0200") References: <8e5c69aa6d108ce35c3124a969252227ce9ed178.1716382317.git.maxim.cournoyer@gmail.com> <878r00c2f7.fsf@gnu.org> Date: Sat, 25 May 2024 23:38:12 -0400 Message-ID: <877cfhi6or.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 71022-done Cc: 71022-done@debbugs.gnu.org, Simon Tournier , Vagrant Cascadian , Richard Sent , Efraim Flashner , Ricardo Wurmus , Andreas Enge , Attila Lendvai , Janneke Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> The Guix standard configuration uses a localstatedir of /var and a sysco= nfdir >> of /etc. To ease things for everyone, make the default values match that >> standard expected configuration. See >> fo= r a >> related discussion. >> >> * configure.ac: Default $prefix to '' unless already set. >> * doc/contributing.texi (Building from Git): Streamline doc. >> * doc/guix-cookbook.texi (Guix environment via direnv): Likewise. >> >> Change-Id: I23cd12b58a842d246fbc9fdc740311c573eb0212 > > LGTM! :-) I ran 'make distcheck', which initially failed with a --8<---------------cut here---------------start------------->8--- 'dot' error: Format: "pdf" not recognized. Use one of: canon cmap cmapx cma= px_np dot dot_json eps fig gd gd2 gif gv imap imap_np ismap jpe jpeg jpg json json0 mp pic plain plain-ext png pov ps ps2 svg svgz tk vdx vml vmlz vrml wbmp xdot xdot1.2 xdot1.4 xdot_json --8<---------------cut here---------------end--------------->8--- error. I needed to use the full graphviz, not 'graphviz-minimal' as used by the Guix package. I also had to add imagemagick for the 'convert' command. After that it proceeded normally; it failed finding many missing substitutes but otherwise 'make distcheck' went fine. Pushed, at last. Some related commits to the above will appear to guix-patches soon. --=20 Maxim From unknown Fri Aug 15 12:51:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Jun 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator