GNU bug report logs - #71012
30.0.50; tree-sitter crash

Previous Next

Full log

Message #74 received at 71012 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Basil L. Contovounesios" <basil <at> contovou.net>
Cc: casouri <at> gmail.com, eller.helmut <at> gmail.com, 71012 <at> debbugs.gnu.org
Subject: Re: bug#71012: 30.0.50; tree-sitter crash
Date: Thu, 25 Jul 2024 08:27:36 +0300

> From: "Basil L. Contovounesios" <basil <at> contovou.net>
> Cc: casouri <at> gmail.com,  71012 <at> debbugs.gnu.org,  eller.helmut <at> gmail.com
> Date: Thu, 25 Jul 2024 01:32:01 +0200
> 
> Eli Zaretskii [2024-07-24 19:31 +0300] wrote:
> 
> >> Cc: 71012 <at> debbugs.gnu.org, eller.helmut <at> gmail.com
> >> From: "Basil L. Contovounesios" <basil <at> contovou.net>
> >> Date: Wed, 24 Jul 2024 16:57:53 +0200
> >> 
> >> Ping: thoughts on whether this is an issue?
> >
> > Thoughts about what? what is deemed to be a problem in this case?
> 
> That each call to treesit-parse-string now allocates a new internal
> buffer which is not automatically GCed.
> 
> If this cannot be avoided, I think the docs should at least warn that
> it's the caller's responsibility to kill the return node's buffer when
> finished with it.

If the buffers aren't killed by the code, it's indeed an issue that
needs to be solved.  At the time I suggested that the node's buffer is
killed when the node is GC'ed or deleted -- have this not been done?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.