GNU bug report logs - #70997
[PATCH] gnu: python-scikit-image: Disable test_ellipse_parameter_stability.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70997: closed ([PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.)
Date: Sun, 26 May 2024 16:22:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 26 May 2024 17:20:43 +0100
with message-id <87msocfstg.fsf <at> cbaines.net>
and subject line Re: [bug#70997] [PATCH] gnu: python-scikit-image: Disable test_ellipse_parameter_stability.
has caused the debbugs.gnu.org bug report #70997,
regarding [PATCH] gnu: python-scikit-image: Disable test_ellipse_parameter_stability.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70997: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70997
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.
Date: Fri, 17 May 2024 09:00:52 +0100

As it's flaky, see https://github.com/scikit-image/scikit-image/issues/7061

* gnu/packages/python-science.scm (python-scikit-image)[arguments]: Add 'patch
phase.

Change-Id: Ic1fc301eb0fad5330c34780ce096c446c1076824
---
 gnu/packages/python-science.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index 861badad2e..d1a43b23ed 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -475,6 +475,13 @@ (define-public python-scikit-image
      (list
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch
+            (lambda _
+              ;; Disable flaky test
+              (substitute* "skimage/measure/tests/test_fit.py"
+                (("def test_ellipse_parameter_stability():")
+                 "@pytest.mark.xfail(reason=\"https://github.com/scikit-image/scikit-image/issues/7061\")
+def test_ellipse_parameter_stability():"))))
           (add-before 'build 'change-home-dir
             (lambda _
               ;; Change from /homeless-shelter to /tmp for write permission.

base-commit: 0846eaecd45783bf40e8dc67b0c16f71068524b7
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 70997-done <at> debbugs.gnu.org
Subject: Re: [bug#70997] [PATCH] gnu: python-scikit-image: Disable
 test_ellipse_parameter_stability.
Date: Sun, 26 May 2024 17:20:43 +0100

[Message part 4 (text/plain, inline)]

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> I think you may add the test to ignore list without substituting it.
>
> --8<---------------cut here---------------start------------->8---
> #:test-flags #~(list "-k" "test_ellipse_parameter_stability")
> --8<---------------cut here---------------end--------------->8---

Thanks for the suggestion, I think that actually selects the test to
run, but adding not to the start seems to skip the named test, so I've
pushed this as a4a45669c76f80d5126add818df22f42547bb4a2.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.