GNU bug report logs - #7099
mbsalign.c old c compiler complains about variables defined inside code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7099 in the body.
You can then email your comments to 7099 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Suhan Andrei <sandi_ro <at> yahoo.com>
To: bug-coreutils <at> gnu.org
Subject: mbsalign.c old c compiler complains about variables defined inside
	code
Date: Fri, 24 Sep 2010 13:15:08 -0700 (PDT)

[Message part 1 (text/plain, inline)]

Hi

Just wanted to let you know there are some errors when using old compiler 
(
gcc -v
Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs
gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)
)


Tere are 2 variables defined inside blocks of code that triggers old c compiler 
to spill errors.
I used code from coreutils-8.5.tar.gz 
I moved declaration at the start of code and all compiled ok.

Andrei.



      

[Message part 2 (text/html, inline)]

Message #8 received at 7099 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> CS.UCLA.EDU>
To: Suhan Andrei <sandi_ro <at> yahoo.com>
Cc: 7099 <at> debbugs.gnu.org
Subject: Re: bug#7099: mbsalign.c old c compiler complains about variables
	defined inside code
Date: Fri, 24 Sep 2010 14:35:23 -0700

On 09/24/10 13:15, Suhan Andrei wrote:
> gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)

That compiler was shipped with Red Hat Linux 6.0, if I
read the history correctly, and Red Hat stopped supporting
that version years ago.  Our general rule of thumb is that
we don't bother supporting software that the original supplier
no longer supports.

Is another, more up-to-date compiler available on that old
installation?  That might be the easiest way to get going.

Message #11 received at 7099 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Suhan Andrei <sandi_ro <at> yahoo.com>
Cc: 7099 <at> debbugs.gnu.org
Subject: Re: bug#7099: mbsalign.c old c compiler complains about variables
	defined inside code
Date: Fri, 24 Sep 2010 22:38:37 +0100

On 24/09/10 21:15, Suhan Andrei wrote:
> Hi
> 
> Just wanted to let you know there are some errors when using old compiler 
> (
> gcc -v
> Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs
> gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)
> )
> 
> 
> Tere are 2 variables defined inside blocks of code that triggers old c compiler 
> to spill errors.
> I used code from coreutils-8.5.tar.gz 
> I moved declaration at the start of code and all compiled ok.

Eep, I'll fix that up, as we want to keep stuff under gl/
C89 conformant, as it may be moved to gnulib at some stage.

$ LANG=C gcc -std=c89 -pedantic -Werror -c git/coreutils/gl/lib/mbsalign.c -o /dev/null -I git/coreutils/lib/
cc1: warnings being treated as errors
In file included from git/coreutils/gl/lib/mbsalign.c:21:
git/coreutils/gl/lib/mbsalign.h:24: error: comma at end of enumerator list
git/coreutils/gl/lib/mbsalign.c: In function 'mbsalign':
git/coreutils/gl/lib/mbsalign.c:241: error: ISO C90 forbids mixed declarations and code
git/coreutils/gl/lib/mbsalign.c: In function 'ambsalign':
git/coreutils/gl/lib/mbsalign.c:269: error: ISO C90 forbids mixed declarations and code

However I'm confused about how this was the only failure
given this info from README:

***********************
Pre-C99 build failure
-----------------------

There is a new, implicit build requirement:
To build the coreutils from source, you should have a C99-conforming
compiler, due to the use of declarations after non-declaration statements
in several files in src/.  There is code in configure to find and, if
possible, enable an appropriate compiler.  However, if configure doesn't
find a C99 compiler, it continues nonetheless, and your build will fail.
If that happens, simply[*] apply the included patch using the following
command, and then run make again:

  cd src && patch < c99-to-c89.diff

[*] however, as of coreutils-7.1, the "c99-to-c89.diff" file is no longer
maintained, so even if the patches still apply, the result will be an
incomplete conversion.  It's been 10 years.  Get a decent compiler! ;-)

cheers,
Pádraig.

Message #16 received at 7099-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Suhan Andrei <sandi_ro <at> yahoo.com>
Cc: 7099-done <at> debbugs.gnu.org
Subject: Re: bug#7099: mbsalign.c old c compiler complains about variables
	defined inside code
Date: Fri, 01 Oct 2010 14:32:42 +0100

[Message part 1 (text/plain, inline)]

On 24/09/10 22:38, Pádraig Brady wrote:
> On 24/09/10 21:15, Suhan Andrei wrote:
>> Hi
>>
>> Just wanted to let you know there are some errors when using old compiler 
>> (
>> gcc -v
>> Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/egcs-2.91.66/specs
>> gcc version egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)
>> )
>>
>>
>> Tere are 2 variables defined inside blocks of code that triggers old c compiler 
>> to spill errors.
>> I used code from coreutils-8.5.tar.gz 
>> I moved declaration at the start of code and all compiled ok.
> 
> Eep, I'll fix that up, as we want to keep stuff under gl/
> C89 conformant, as it may be moved to gnulib at some stage.

I'll push the attached soon.

cheers,
Pádraig.

[mbsalign-c89.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.