GNU bug report logs - #70966
30.0.50; eshell/diff produces track-changes errors

Previous Next

Full log

Message #11 received at 70966 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: John Wiegley <johnw <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Steven Allen <steven <at> stebalien.com>,
 70966 <at> debbugs.gnu.org
Subject: Re: bug#70966: 30.0.50; eshell/diff produces track-changes errors
Date: Thu, 16 May 2024 11:58:31 -0400

[Message part 1 (text/plain, inline)]

The patch below seems to fix this problem.

John, do you remember why you had those let-bindings (which originally
were let-binding `after-change-functions` to nil)?


        Stefan

[eshell.patch (text/x-diff, inline)]

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 78a448a41a5..8e993d47183 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -623,7 +623,8 @@ eshell-send-input
   ;; Note that the input string does not include its terminal newline.
   (let* ((proc-running-p (eshell-head-process))
          (send-to-process-p (and proc-running-p (not queue-p)))
-         (inhibit-modification-hooks t))
+         ;; (inhibit-modification-hooks t)
+         )
     (unless (and send-to-process-p
 		 (not (eq (process-status
 			   (eshell-head-process))
@@ -710,7 +711,8 @@ eshell-interactive-filter
   (unless buffer
     (setq buffer (current-buffer)))
   (when (and string (buffer-live-p buffer))
-    (let ((inhibit-modification-hooks t))
+    (let (;; (inhibit-modification-hooks t)
+          )
       (with-current-buffer buffer
         (let ((functions eshell-preoutput-filter-functions))
           (while (and functions string)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.