GNU bug report logs - #70936
[PATCH gnome-team 0/3] Fix some broken tests.

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Tue, 14 May 2024 12:30:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #26 received at 70936 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 70936 <at> debbugs.gnu.org, vivien <at> planete-kraus.eu
Subject: Re: [bug#70936] [PATCH gnome-team 3/3] gnu: qemu: Disable more tests.
Date: Tue, 14 May 2024 21:40:40 -0400

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Also disable
> qtest/ahci-test and qemu-iotests/copy-before-write.
> ---
>  gnu/packages/virtualization.scm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
> index 34cccd6550..5389af62f0 100644
> --- a/gnu/packages/virtualization.scm
> +++ b/gnu/packages/virtualization.scm
> @@ -305,7 +305,12 @@ (define-public qemu
>                (substitute* "tests/qtest/meson.build"
>                  ;; These tests fail to get the expected number of tests
>                  ;; on arm platforms.
> -                (("'arm-cpu-features',") ""))))
> +                (("'arm-cpu-features',") "")
> +                ;; XXX: Why does this (sometimes) fail?

Someone reported it already upstream:
<https://gitlab.com/qemu-project/qemu/-/issues/2121>.  Please add a
reference to it.

> +                (("\\['ahci-test'\\]") "[]"))
> +              ;; This test appears to be missing permissions.
> +              ;; Very sus 🤔

How can it be missing permissions if it is sometimes working?  Perhaps
more something racy where the file hasn't been created yet.  I'd
personally rather not see emojis or comments of dubious utility ("Very
suspect") in the source.  Perhaps add a short excerpt of the error for
the next curious person.

> +              (delete-file "tests/qemu-iotests/tests/copy-before-write")))
>            #$@(if (target-riscv64?)
>                   '((add-after 'unpack 'disable-some-tests
>                       (lambda _

Otherwise, LGTM!

-- 
Thanks,
Maxim
This bug report was last modified 335 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.