Subject: bug#70932: FAIL tests/guix-shell.sh

From: Christopher Baines <[email-masked]>
Date: Sat, 25 May 2024 12:53:11 +0100

Ludovic Courtès <[email-masked]> writes:

> Christopher Baines <[email-masked]> skribis:
>
>> ++ guile -c '(use-modules (guix utils))
>>   (display (%current-system))'
>> + this_system=x86_64-linux
>> ++ guile -c '(use-modules (guix utils))
>>   (display (if (string=? "riscv64-linux" (%current-system))
>> 	       "x86_64-linux"
>> 	       "riscv64-linux"))'
>> + other_system=riscv64-linux
>> + cat
>> + guix shell -D -f t-guix-shell-19847/some-package.scm -n
>> hint: Consider passing the `--check' option once to make sure your shell does not
>> clobber environment variables.
>>
>> + false
>
> This is in ‘tests/guix-shell.sh’ a test that checks that unsupported
> packages are rejected.  The ‘guix shell -D -f -t …’ command above is
> supposed to fail (non-zero exit code), but in your case it succeeded,
> hence the test failure.
>
> “make check TESTS=tests/guix-shell.sh” passes for me though with
> 9c3a8a380bcfebdb77af61532e7bfec523d7bde8.

I can just about see what's happening on this line now, I'm still not
sure why the exit status means the test fails.

I think I knew when I submitted the issue that the test was flaky as it
passed on the second attempt.