GNU bug report logs - #70906
[PATCH] Send HTTP headers with charset utf-8.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70906: closed ([PATCH] Send HTTP headers with charset utf-8.)
Date: Fri, 07 Jun 2024 22:44:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 07 Jun 2024 23:43:03 +0100
with message-id <87v82kfk7c.fsf <at> systemreboot.net>
and subject line Re: [PATCH] Send HTTP headers with charset utf-8.
has caused the debbugs.gnu.org bug report #70906,
regarding [PATCH] Send HTTP headers with charset utf-8.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70906: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70906
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: bug-mumi <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH] Send HTTP headers with charset utf-8.
Date: Sun, 12 May 2024 21:38:32 -0700

In most cases, providing HTTP headers with the charset is superior
to (and has precedence over) the declaration in an HTML <meta> tag:

    https://stackoverflow.com/a/26032993

A preview of this code is live at patchwise.org.
---
 mumi/web/render.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mumi/web/render.scm b/mumi/web/render.scm
index ad3ae0e..e867178 100644
--- a/mumi/web/render.scm
+++ b/mumi/web/render.scm
@@ -103,12 +103,12 @@
 
 (define* (render-html sxml #:key (extra-headers '()))
   (values (append extra-headers
-                  '((content-type . (text/html))))
+                  '((content-type . (text/html (charset . "utf-8")))))
           (lambda (port)
             (sxml->html sxml port))))
 
 (define (render-json json)
-  (values '((content-type . (application/json)))
+  (values '((content-type . (application/json (charset . "utf-8"))))
           (lambda (port)
             (scm->json json port))))
 

base-commit: 99416ed5c7d950eaf54d52023a2efd975bccac92
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 70906-done <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: Re: [PATCH] Send HTTP headers with charset utf-8.
Date: Fri, 07 Jun 2024 23:43:03 +0100

Applied, thanks!

I made the following modifications:
- The application/json MIME type does not require a charset. See
https://stackoverflow.com/questions/9254891/what-does-content-type-application-json-charset-utf-8-really-mean
So, I dropped that part.
- I removed the Content-Type meta tag from the HTML.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.