GNU bug report logs - #70902
[PATCH] Drop two invocations of 'apply'.

Previous Next

Package: mumi;

Reported by: Felix Lechner <felix.lechner <at> lease-up.com>

Date: Mon, 13 May 2024 04:31:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70902 in the body.
You can then email your comments to 70902 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-mumi <at> gnu.org:
bug#70902; Package mumi. (Mon, 13 May 2024 04:31:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Felix Lechner <felix.lechner <at> lease-up.com>:
New bug report received and forwarded. Copy sent to bug-mumi <at> gnu.org. (Mon, 13 May 2024 04:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: bug-mumi <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH] Drop two invocations of 'apply'.
Date: Sun, 12 May 2024 21:20:12 -0700
They stood out among other nearby calls to render-html, and do not
appear to be needed.
---
 mumi/web/download.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mumi/web/download.scm b/mumi/web/download.scm
index 5c12fca..d4eb09e 100644
--- a/mumi/web/download.scm
+++ b/mumi/web/download.scm
@@ -56,7 +56,7 @@ PATH."
      (html-response (email-headers entry)
                     (email-body entry)))
     (_
-     (apply render-html (unknown id)))))
+     (render-html (unknown id)))))
 
 (define (download-raw id msg-num)
   "Handle download of an attachment for bug ID, message number
@@ -77,4 +77,4 @@ PATH."
                 (content-disposition text/plain
                                      (filename . ,(format #f "~a-~a.mbox" id msg-num))))
               (list-ref emails msg-num))
-      (apply render-html (unknown id))))
+      (render-html (unknown id))))

base-commit: 99416ed5c7d950eaf54d52023a2efd975bccac92
-- 
2.41.0





Information forwarded to bug-mumi <at> gnu.org:
bug#70902; Package mumi. (Mon, 13 May 2024 04:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 70902 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 70902 <at> patchwise.org
Subject: Preview available
Date: Sun, 12 May 2024 21:46:37 -0700
A preview of this code is live at patchwise.org.




Reply sent to Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility. (Thu, 13 Feb 2025 22:20:02 GMT) Full text and rfc822 format available.

Notification sent to Felix Lechner <felix.lechner <at> lease-up.com>:
bug acknowledged by developer. (Thu, 13 Feb 2025 22:20:02 GMT) Full text and rfc822 format available.

Message #13 received at 70902-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 70902-done <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: Re: [PATCH] Drop two invocations of 'apply'.
Date: Thu, 13 Feb 2025 22:19:20 +0000
I discovered these independently and fixed them in
0c9ed892e99189f74582a75f91fb8ab25e9fe498. Sorry about the duplicated
work. Thanks for reporting!




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 14 Mar 2025 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 153 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.